cleverdatasets/dataset-uploader
cleverdatasets/dataset-uploader
0
0
Fork 0
Code Issues 17 Pull requests 6 Projects Releases Packages Wiki Activity Actions

mypy-and-pylint #2

Open
brent.edwards wants to merge 12 commits from mypy-and-pylint into 16-error-messages-and-logging
pull from: mypy-and-pylint
merge into: cleverdatasets:16-error-messages-and-logging
Conversation 2 Commits 12 Files changed 29 +2866 -1283
brent.edwards commented 2025-11-19 03:15:49 +00:00
Member
Copy link

Some work toward cleaning the scripts.

Some work toward cleaning the scripts.
brent.edwards changed target branch from master to 16-error-messages-and-logging 2025-11-21 02:36:38 +00:00
aditya approved these changes 2025-11-21 08:42:52 +00:00
brent.edwards reviewed 2025-11-22 02:39:09 +00:00
brent.edwards left a comment
Author
Member
Copy link

A few initial comments...

A few initial comments...
scripts/convert_rdf_to_hf_dataset_streaming.py Outdated
@ -90,3 +93,3 @@
# Handle compressed files
if file_path.suffix == ".gz":
file_obj = gzip.open(file_path, "rt", encoding="utf-8")
with gzip.open(file_path, "rt", encoding="utf-8") as file_obj:
brent.edwards commented 2025-11-22 02:15:54 +00:00
Author
Member
Copy link

Why was this added?

Why was this added?
aditya commented 2025-11-24 14:24:27 +00:00
Member
Copy link

Thanks for the feedback. The duplication came from fixing SIM115 (use a context manager), which required opening files with with. I've refactored to remove the duplication by extracting the shared logic into _process_ntriples_file() while keeping the context managers. This addresses both the Ruff error and the code duplication.

Thanks for the feedback. The duplication came from fixing SIM115 (use a context manager), which required opening files with with. I've refactored to remove the duplication by extracting the shared logic into _process_ntriples_file() while keeping the context managers. This addresses both the Ruff error and the code duplication.
scripts/convert_rdf_to_hf_dataset_streaming_parallel.py Outdated
@ -258,4 +267,0 @@
if current_batch:
yield current_batch
else:
brent.edwards commented 2025-11-22 02:17:52 +00:00
Author
Member
Copy link

This is the point where the comparer got confused...

This is the point where the comparer got confused...
aditya commented 2025-11-24 14:26:27 +00:00
Member
Copy link

This is part of the refactoring of the code, this part of the code is now moved into a helper function. The logic is unchanged.

This is part of the refactoring of the code, this part of the code is now moved into a helper function. The logic is unchanged.
scripts/convert_rdf_to_hf_dataset_streaming_parallel.py
@ -276,0 +280,4 @@
# Yield remaining lines
if current_batch:
yield current_batch
else:
brent.edwards commented 2025-11-22 02:20:43 +00:00
Author
Member
Copy link

Again, why was this added?

Again, why was this added?
aditya commented 2025-11-24 14:26:38 +00:00
Member
Copy link

This is part of the refactoring of the code, this part of the code is now moved into a helper function. The logic is unchanged.

This is part of the refactoring of the code, this part of the code is now moved into a helper function. The logic is unchanged.
scripts/convert_rdf_to_hf_dataset_streaming_parallel.py
@ -344,3 +403,2 @@
def stream_turtle_chunks(file_path: Path, chunk_size: int = 10000) -> Iterator[list[dict[str, str]]]:
"""Stream Turtle file in chunks using incremental parsing.
def _process_turtle_file(
brent.edwards commented 2025-11-22 02:38:43 +00:00
Author
Member
Copy link

Again, this is different. What changed?

Again, this is different. What changed?
aditya commented 2025-11-24 14:27:06 +00:00
Member
Copy link

The stream_turtle_chunks function was split into _process_turtle_file() helper to remove duplication when fixing SIM115.

The stream_turtle_chunks function was split into _process_turtle_file() helper to remove duplication when fixing SIM115.
This pull request has changes conflicting with the target branch.
  • scripts/convert_rdf_to_hf_dataset_streaming_parallel.py
  • scripts/upload_all_datasets.py
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin mypy-and-pylint:mypy-and-pylint
git switch mypy-and-pylint

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch 16-error-messages-and-logging
git merge --no-ff mypy-and-pylint
git switch mypy-and-pylint
git rebase 16-error-messages-and-logging
git switch 16-error-messages-and-logging
git merge --ff-only mypy-and-pylint
git switch mypy-and-pylint
git rebase 16-error-messages-and-logging
git switch 16-error-messages-and-logging
git merge --no-ff mypy-and-pylint
git switch 16-error-messages-and-logging
git merge --squash mypy-and-pylint
git switch 16-error-messages-and-logging
git merge --ff-only mypy-and-pylint
git switch 16-error-messages-and-logging
git merge mypy-and-pylint
git push origin 16-error-messages-and-logging
Sign in to join this conversation.
Reviewers
No reviewers
aditya
Labels
Clear labels
  
Blocked

A ticket in a blocked state and unable to complete until some other task is completed first.

  
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.

  
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.

  
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.

  
Needs feedback

There are questions in the ticket that can not be completed until the project owner provides clarity.

  
Points
1
1 man-hours worth of work for an expert with no learning curve.

  
Points
13
13 man-hours worth of work for an expert with no learning curve.

  
Points
2
2 man-hours worth of work for an expert with no learning curve.

  
Points
21
21 man-hours worth of work for an expert with no learning curve.

  
Points
3
3 man-hours worth of work for an expert with no learning curve.

  
Points
34
34 man-hours worth of work for an expert with no learning curve.

  
Points
5
5 man-hours worth of work for an expert with no learning curve.

  
Points
55
55 man-hours worth of work for an expert with no learning curve.

  
Points
8
8 man-hours worth of work for an expert with no learning curve.

  
Points
88
88 man-hours worth of work for an expert with no learning curve.

  
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Signed-off: Owner

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Scrum Master

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Tech Lead

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Spike

A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  
State
Duplicate
A ticket that represents the same content as an existing ticket.

  
State
In Progress
A ticket that is actively being developed.

  
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  
Type
Bug
Something that doesnt work as intended.

  
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  
Type
Documentation
An error or improvement needed in the documentation.

  
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  
Type
Feature
Some new functionality not present.

  
Type
Legendary
A type of Epic which will contain other Epics.

  
Type
Support
Someone needs help using the project.

  
Type
Task
A generic task that doesnt fit into the other type categories.

  
Type
Testing
Work exclusively focusing on fixing or expanding testing.

No labels
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Support
Type
Task
Type
Testing
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleverdatasets/dataset-uploader!2
No description provided.