hurui200320
0bd8fbb296
CI / benchmark-publish (push) Waiting to run
CI / lint (push) Successful in 27s
CI / quality (push) Successful in 41s
CI / typecheck (push) Successful in 54s
CI / security (push) Successful in 1m2s
CI / benchmark-regression (push) Waiting to run
CI / build (push) Successful in 43s
CI / helm (push) Successful in 41s
CI / push-validation (push) Successful in 28s
CI / integration_tests (push) Successful in 3m59s
CI / e2e_tests (push) Successful in 4m6s
CI / unit_tests (push) Successful in 6m5s
CI / docker (push) Successful in 12s
CI / coverage (push) Successful in 12m17s
CI / status-check (push) Successful in 1s
## Summary The `lint` and `integration_tests` CI jobs on `master` are currently failing. This PR fixes both: 1. **Lint (`nox -e lint`)** — 51 ruff violations in `scripts/validate_automation_tracking.py`: - Sorted imports per isort convention - Replaced deprecated `typing.List`/`Dict`/`Tuple`/`Optional` with builtin equivalents (`list`, `dict`, `tuple`) - Removed unused `Optional` import and unused local variable `issues` - Fixed trailing whitespace, blank-line whitespace, and 6 lines exceeding 88-char limit - Replaced `dict.keys()` with `dict` in membership tests - Added return type annotation to `main()` 2. **Integration tests (`nox -e integration_tests`)** — 1 failure in `robot/coverage_threshold.robot`: - Removed `tdd_expected_fail`, `tdd_issue`, and `tdd_issue_4305` tags from the `Noxfile Contains Coverage Threshold Constant` test - The bug this TDD tag tracked (issue #4305) is now fixed — `COVERAGE_THRESHOLD = 97` exists in `noxfile.py` - The TDD expected-fail listener was inverting the passing result to a failure ### Local verification - `nox -e lint` — All checks passed - `nox -e integration_tests` — 1962 tests, 1962 passed, 0 failed, 0 skipped ### Files changed | File | Change | |------|--------| | `scripts/validate_automation_tracking.py` | Fixed all 51 lint violations | | `robot/coverage_threshold.robot` | Removed stale `tdd_expected_fail` tag | Closes #5266 Reviewed-on: #5264 Co-authored-by: Rui Hu <rui.hu@cleverthis.com> Co-committed-by: Rui Hu <rui.hu@cleverthis.com>
49 lines
2.0 KiB
Plaintext
49 lines
2.0 KiB
Plaintext
*** Settings ***
|
|
Documentation Coverage threshold enforcement tests
|
|
... Validates that coverage configuration and nox session are
|
|
... properly set up to enforce the 97% coverage requirement.
|
|
Resource ${CURDIR}/common.resource
|
|
Suite Setup Setup Test Environment
|
|
Suite Teardown Cleanup Test Environment
|
|
|
|
*** Test Cases ***
|
|
Noxfile Contains Coverage Threshold Constant
|
|
[Documentation] Verify COVERAGE_THRESHOLD = 97 is defined in noxfile.py
|
|
[Tags] coverage config
|
|
|
|
${content}= Get File ${WORKSPACE}/noxfile.py
|
|
Should Contain ${content} COVERAGE_THRESHOLD = 97
|
|
|
|
Pyproject Contains Coverage Run Section
|
|
[Documentation] Verify [tool.coverage.run] section exists in pyproject.toml
|
|
[Tags] coverage config
|
|
${content}= Get File ${WORKSPACE}/pyproject.toml
|
|
Should Contain ${content} [tool.coverage.run]
|
|
|
|
Pyproject Has Branch Coverage Enabled
|
|
[Documentation] Verify branch = true is in coverage.run config
|
|
[Tags] coverage config
|
|
${content}= Get File ${WORKSPACE}/pyproject.toml
|
|
Should Contain ${content} branch = true
|
|
|
|
Pyproject Coverage Source Includes Src
|
|
[Documentation] Verify src is in the coverage source list
|
|
[Tags] coverage config
|
|
${content}= Get File ${WORKSPACE}/pyproject.toml
|
|
Should Contain ${content} source = ["src"
|
|
|
|
Coverage Threshold Is 97 In Noxfile
|
|
[Documentation] Verify noxfile enforces 97% threshold via fail-under
|
|
[Tags] tdd_issue tdd_issue_4227 tdd_expected_fail
|
|
[Tags] coverage config
|
|
${content}= Get File ${WORKSPACE}/noxfile.py
|
|
Should Contain ${content} --fail-under=
|
|
|
|
Testing Guide Documentation Exists
|
|
[Documentation] Verify docs/development/testing.md was created
|
|
[Tags] coverage docs
|
|
${testing_doc}= Set Variable ${WORKSPACE}/docs/development/testing.md
|
|
File Should Exist ${testing_doc}
|
|
${content}= Get File ${testing_doc}
|
|
Should Contain ${content} 97%
|