Files
cleveragents-core/scripts
hurui200320 0bd8fbb296
CI / benchmark-publish (push) Waiting to run
CI / lint (push) Successful in 27s
CI / quality (push) Successful in 41s
CI / typecheck (push) Successful in 54s
CI / security (push) Successful in 1m2s
CI / benchmark-regression (push) Waiting to run
CI / build (push) Successful in 43s
CI / helm (push) Successful in 41s
CI / push-validation (push) Successful in 28s
CI / integration_tests (push) Successful in 3m59s
CI / e2e_tests (push) Successful in 4m6s
CI / unit_tests (push) Successful in 6m5s
CI / docker (push) Successful in 12s
CI / coverage (push) Successful in 12m17s
CI / status-check (push) Successful in 1s
fix(ci): resolve lint errors and remove stale tdd_expected_fail tag (#5264)
## Summary

The `lint` and `integration_tests` CI jobs on `master` are currently failing. This PR fixes both:

1. **Lint (`nox -e lint`)** — 51 ruff violations in `scripts/validate_automation_tracking.py`:
   - Sorted imports per isort convention
   - Replaced deprecated `typing.List`/`Dict`/`Tuple`/`Optional` with builtin equivalents (`list`, `dict`, `tuple`)
   - Removed unused `Optional` import and unused local variable `issues`
   - Fixed trailing whitespace, blank-line whitespace, and 6 lines exceeding 88-char limit
   - Replaced `dict.keys()` with `dict` in membership tests
   - Added return type annotation to `main()`

2. **Integration tests (`nox -e integration_tests`)** — 1 failure in `robot/coverage_threshold.robot`:
   - Removed `tdd_expected_fail`, `tdd_issue`, and `tdd_issue_4305` tags from the `Noxfile Contains Coverage Threshold Constant` test
   - The bug this TDD tag tracked (issue #4305) is now fixed — `COVERAGE_THRESHOLD = 97` exists in `noxfile.py`
   - The TDD expected-fail listener was inverting the passing result to a failure

### Local verification

- `nox -e lint` — All checks passed
- `nox -e integration_tests` — 1962 tests, 1962 passed, 0 failed, 0 skipped

### Files changed

| File | Change |
|------|--------|
| `scripts/validate_automation_tracking.py` | Fixed all 51 lint violations |
| `robot/coverage_threshold.robot` | Removed stale `tdd_expected_fail` tag |

Closes #5266

Reviewed-on: #5264
Co-authored-by: Rui Hu <rui.hu@cleverthis.com>
Co-committed-by: Rui Hu <rui.hu@cleverthis.com>
2026-04-09 04:41:01 +00:00
..