cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

fix(test): add root_plan_id to raw SQL in plan_phase_migration constraint tests #9825

Closed
HAL9000 wants to merge 1 commits from fix/plan-phase-migration-raw-sql-root-plan-id into master
pull from: fix/plan-phase-migration-raw-sql-root-plan-id
merge into: cleveragents:master
Conversation 7 Commits 1 Files Changed 1
+8 -3

1 Commits

Author SHA1 Message Date
HAL9000 a0fae4535e fix(test): add root_plan_id to raw SQL in plan_phase_migration constraint tests
CI / push-validation (pull_request) Successful in 27s
Details
CI / helm (pull_request) Successful in 37s
Details
CI / build (pull_request) Successful in 3m50s
Details
CI / lint (pull_request) Successful in 3m57s
Details
CI / quality (pull_request) Successful in 4m23s
Details
CI / typecheck (pull_request) Successful in 4m40s
Details
CI / security (pull_request) Successful in 4m50s
Details
CI / unit_tests (pull_request) Failing after 5m51s
Details
CI / docker (pull_request) Has been skipped
Details
CI / e2e_tests (pull_request) Successful in 7m14s
Details
CI / integration_tests (pull_request) Successful in 7m51s
Details
CI / coverage (pull_request) Successful in 15m0s
Details
CI / status-check (pull_request) Failing after 3s
Details 
The step_try_insert_plan_with_phase_and_state function was using raw SQL to
insert a plan with an invalid phase value to test the CHECK constraint. However,
the raw SQL was missing the root_plan_id column, which is NOT NULL in the schema.
This caused the insert to fail with a NOT NULL violation instead of the intended
CHECK constraint violation on the phase column.

This fix adds root_plan_id to the raw SQL INSERT statement, setting it to the
same value as plan_id (for a root plan). This allows the test to properly
exercise the CHECK constraint on the phase column, ensuring the test fails for
the correct reason.

ISSUES CLOSED: #9411
 2026-04-15 16:38:29 +00:00