cleveragents/cleveragents-core
cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.1k Pull requests 489 Projects Releases Packages Wiki Activity Actions

[AUTO-DOCS-3] docs: Add v3.4.0 ACMS and v3.5.0 Autonomy Hardening documentation #9709

Closed
HAL9000 wants to merge 18 commits from auto-docs-3-v340-v350 into main
pull from: auto-docs-3-v340-v350
merge into: cleveragents:main
Conversation 2 Commits 18 Files changed 130 +7949 -875
HAL9000 commented 2026-04-15 03:49:13 +00:00
Owner
Copy link

Summary

This PR adds comprehensive documentation for the v3.4.0 (ACMS v1 + Context Scaling) and v3.5.0 (Autonomy Hardening) milestones, and extends CHANGELOG.md with the new version sections.

Changes

  • docs/context.md — New file: ACMS v1 documentation covering context policies, budget enforcement (max_file_size, max_total_size), CLI commands (agents context list/add/show/clear), hot/warm/cold storage tiers, context assembly pipeline, large project indexing (10,000+ files), and integration with plan execution
  • docs/autonomy.md — New file: Autonomy hardening documentation covering A2A protocol facade, event queue publish/subscribe, guard enforcement (denylist, budget caps, tool call limits), automation profiles and precedence (plan > action > global), hierarchical plan decomposition (4+ levels), parallel execution scaling (10+ concurrent subplans), and large-scale autonomous task execution
  • CHANGELOG.md — Extended with v3.4.0 and v3.5.0 unreleased sections (CRITICAL fix for broken API docs link)
  • mkdocs.yml — Updated navigation to include new Context Management (ACMS) and Autonomy Hardening pages

Related PRs

  • #9549 (v3.0.0 & v3.1.0 docs)
  • #9637 (v3.2.0 & v3.3.0 docs)

Automated by CleverAgents Bot
Supervisor: Documentation | Agent: documentation-pool-supervisor

Automated by CleverAgents Bot
Agent: pr-creator

## Summary This PR adds comprehensive documentation for the v3.4.0 (ACMS v1 + Context Scaling) and v3.5.0 (Autonomy Hardening) milestones, and extends CHANGELOG.md with the new version sections. ### Changes - **docs/context.md** — New file: ACMS v1 documentation covering context policies, budget enforcement (`max_file_size`, `max_total_size`), CLI commands (`agents context list/add/show/clear`), hot/warm/cold storage tiers, context assembly pipeline, large project indexing (10,000+ files), and integration with plan execution - **docs/autonomy.md** — New file: Autonomy hardening documentation covering A2A protocol facade, event queue publish/subscribe, guard enforcement (denylist, budget caps, tool call limits), automation profiles and precedence (plan > action > global), hierarchical plan decomposition (4+ levels), parallel execution scaling (10+ concurrent subplans), and large-scale autonomous task execution - **CHANGELOG.md** — Extended with v3.4.0 and v3.5.0 unreleased sections (CRITICAL fix for broken API docs link) - **mkdocs.yml** — Updated navigation to include new Context Management (ACMS) and Autonomy Hardening pages ### Related PRs - #9549 (v3.0.0 & v3.1.0 docs) - #9637 (v3.2.0 & v3.3.0 docs) --- **Automated by CleverAgents Bot** Supervisor: Documentation | Agent: documentation-pool-supervisor --- **Automated by CleverAgents Bot** Agent: pr-creator
Build: Made conflict resolution a more explicit part of the pr-merge agents
All checks were successful
CI / helm (push) Successful in 35s
Details
CI / push-validation (push) Successful in 19s
Details
CI / build (push) Successful in 3m57s
Details
CI / lint (push) Successful in 4m3s
Details
CI / quality (push) Successful in 4m34s
Details
CI / typecheck (push) Successful in 4m44s
Details
CI / security (push) Successful in 4m50s
Details
CI / e2e_tests (push) Successful in 7m3s
Details
CI / integration_tests (push) Successful in 10m13s
Details
CI / unit_tests (push) Successful in 11m21s
Details
CI / docker (push) Successful in 1m30s
Details
CI / coverage (push) Successful in 10m42s
Details
CI / status-check (push) Successful in 1s
Details
a71c142854
 
Ensure fail_fast cancels in-flight futures and reports them as CANCELLED.

Add Behave coverage that reproduces the concurrency regression.

ISSUES CLOSED: #7582
docs(changelog): add v3.3.0 changelog entry for #7582 fail_fast fix
All checks were successful
CI / lint (pull_request) Successful in 30s
Details
CI / typecheck (pull_request) Successful in 1m6s
Details
CI / security (pull_request) Successful in 1m7s
Details
CI / quality (pull_request) Successful in 42s
Details
CI / helm (pull_request) Successful in 27s
Details
CI / build (pull_request) Successful in 34s
Details
CI / push-validation (pull_request) Successful in 23s
Details
CI / e2e_tests (pull_request) Successful in 3m17s
Details
CI / integration_tests (pull_request) Successful in 4m13s
Details
CI / unit_tests (pull_request) Successful in 5m36s
Details
CI / docker (pull_request) Successful in 1m37s
Details
CI / coverage (pull_request) Successful in 11m50s
Details
CI / status-check (pull_request) Successful in 2s
Details
CI / lint (push) Successful in 36s
Details
CI / typecheck (push) Successful in 53s
Details
CI / quality (push) Successful in 30s
Details
CI / security (push) Successful in 1m16s
Details
CI / helm (push) Successful in 22s
Details
CI / push-validation (push) Successful in 15s
Details
CI / e2e_tests (push) Successful in 3m50s
Details
CI / build (push) Successful in 3m32s
Details
CI / integration_tests (push) Successful in 6m45s
Details
CI / unit_tests (push) Successful in 7m39s
Details
CI / docker (push) Successful in 1m19s
Details
CI / coverage (push) Successful in 14m59s
Details
CI / status-check (push) Successful in 1s
Details
c11b05b773
Build: Better protection against agents editing the main working directory
All checks were successful
CI / lint (push) Successful in 24s
Details
CI / typecheck (push) Successful in 54s
Details
CI / quality (push) Successful in 45s
Details
CI / security (push) Successful in 1m15s
Details
CI / build (push) Successful in 29s
Details
CI / push-validation (push) Successful in 30s
Details
CI / helm (push) Successful in 37s
Details
CI / e2e_tests (push) Successful in 3m39s
Details
CI / integration_tests (push) Successful in 4m28s
Details
CI / unit_tests (push) Successful in 5m22s
Details
CI / docker (push) Successful in 21s
Details
CI / coverage (push) Successful in 11m39s
Details
CI / status-check (push) Successful in 1s
Details
38bcd41338
 
LockService was implemented but never integrated into the plan execution
path, leaving execute_plan() and apply_plan() unprotected against
concurrent calls on the same plan_id (race condition, issue #7989).

Changes:
- container.py: add _build_lock_service() factory and register
  LockService as a Singleton provider; inject it into
  PlanLifecycleService via the DI container.
- plan_lifecycle_service.py: accept optional lock_service parameter in
  __init__; in execute_plan() and apply_plan() acquire a plan-level
  advisory lock before the critical section and release it in a finally
  block so the lock is always freed even when exceptions occur.

When lock_service is None (existing tests without DI wiring) the
behaviour is unchanged — locking is silently skipped for backward
compatibility.

Closes #7989
The original implementation used plan_id as the owner_id when acquiring
the advisory lock. Because LockService treats owner_id as the caller
identity and allows re-entrant acquisition for the same owner, concurrent
sessions attempting to lock the same plan would all present the same
owner_id and thus silently renew the lock instead of raising
LockConflictError.

This fix generates a unique UUID for each invocation as the owner_id,
ensuring that concurrent sessions present different owners and thus
trigger LockConflictError when attempting to acquire the same plan lock.
The lock is still acquired before the phase transition and released in
a finally block to ensure cleanup even on error.

ISSUES CLOSED: #8067
docs(contributors): add HAL 9000 concurrency-fix contribution detail
All checks were successful
CI / lint (pull_request) Successful in 39s
Details
CI / quality (pull_request) Successful in 41s
Details
CI / typecheck (pull_request) Successful in 57s
Details
CI / security (pull_request) Successful in 57s
Details
CI / build (pull_request) Successful in 45s
Details
CI / helm (pull_request) Successful in 45s
Details
CI / push-validation (pull_request) Successful in 20s
Details
CI / e2e_tests (pull_request) Successful in 4m5s
Details
CI / integration_tests (pull_request) Successful in 4m14s
Details
CI / unit_tests (pull_request) Successful in 5m30s
Details
CI / docker (pull_request) Successful in 1m33s
Details
CI / coverage (pull_request) Successful in 13m0s
Details
CI / status-check (pull_request) Successful in 1s
Details
CI / lint (push) Successful in 29s
Details
CI / quality (push) Successful in 48s
Details
CI / typecheck (push) Successful in 58s
Details
CI / security (push) Successful in 59s
Details
CI / build (push) Successful in 34s
Details
CI / push-validation (push) Successful in 29s
Details
CI / helm (push) Successful in 36s
Details
CI / e2e_tests (push) Successful in 3m22s
Details
CI / integration_tests (push) Successful in 5m46s
Details
CI / unit_tests (push) Successful in 8m50s
Details
CI / docker (push) Successful in 2m10s
Details
CI / coverage (push) Successful in 13m38s
Details
CI / status-check (push) Successful in 1s
Details
e757ca9db0 
Add a Details entry for HAL 9000 describing the plan lifecycle
concurrency race-condition fix (#7989) — wiring LockService into
execute_plan/apply_plan with unique per-invocation owner identities.

ISSUES CLOSED: #7989
Build: improve grooming worker permissions, milestone enforcement, and PR merge throughput
Some checks failed
CI / lint (push) Successful in 21s
Details
CI / quality (push) Successful in 43s
Details
CI / security (push) Successful in 51s
Details
CI / build (push) Successful in 28s
Details
CI / helm (push) Successful in 40s
Details
CI / push-validation (push) Successful in 27s
Details
CI / typecheck (push) Successful in 1m20s
Details
CI / e2e_tests (push) Successful in 3m25s
Details
CI / integration_tests (push) Successful in 3m59s
Details
CI / unit_tests (push) Successful in 5m13s
Details
CI / docker (push) Successful in 10s
Details
CI / coverage (push) Successful in 12m9s
Details
CI / status-check (push) Successful in 1s
Details
CI / lint (pull_request) Successful in 31s
Details
CI / typecheck (pull_request) Successful in 48s
Details
CI / quality (pull_request) Successful in 37s
Details
CI / security (pull_request) Successful in 58s
Details
CI / helm (pull_request) Successful in 22s
Details
CI / build (pull_request) Successful in 34s
Details
CI / push-validation (pull_request) Successful in 16s
Details
CI / e2e_tests (pull_request) Successful in 4m10s
Details
CI / integration_tests (pull_request) Successful in 4m20s
Details
CI / coverage (pull_request) Has been cancelled
Details
CI / unit_tests (pull_request) Has been cancelled
Details
CI / status-check (pull_request) Has been cancelled
Details
CI / docker (pull_request) Has been cancelled
Details
64b1f4c0b6
 
- Fix grooming-worker Forgejo permissions (deny → allow) to unblock direct API calls
- Route PR label fetching through forgejo-label-manager subagent
- Replace priority-alignment check with milestone enforcement (every issue must have a milestone)
- Add step 11: address non-code review remarks (labels, description, milestone) during grooming
- Clarify grooming-pool-supervisor stale threshold to explicit 24-hour window
- Refactor pr-merge-pool-supervisor main loop into explicit numbered steps
- Add triage strategy section emphasising parallel review checks and immediate worker dispatch
- Tighten merge criteria: explicit APPROVED state, no unresolved REQUEST_CHANGES on current head
- Dispatch workers for all PR processing, not only rebase operations
- Add rule to batch forgejo_list_pull_reviews calls instead of checking serially
docs(changelog): add plan action-arguments UNIQUE constraint fix (#4197)
All checks were successful
CI / lint (pull_request) Successful in 26s
Details
CI / build (pull_request) Successful in 25s
Details
CI / push-validation (pull_request) Successful in 18s
Details
CI / typecheck (pull_request) Successful in 50s
Details
CI / quality (pull_request) Successful in 56s
Details
CI / security (pull_request) Successful in 1m1s
Details
CI / helm (pull_request) Successful in 43s
Details
CI / e2e_tests (pull_request) Successful in 4m13s
Details
CI / integration_tests (pull_request) Successful in 4m21s
Details
CI / unit_tests (pull_request) Successful in 5m23s
Details
CI / docker (pull_request) Successful in 22s
Details
CI / coverage (pull_request) Successful in 10m47s
Details
CI / status-check (pull_request) Successful in 1s
Details
CI / lint (push) Successful in 23s
Details
CI / build (push) Successful in 21s
Details
CI / helm (push) Successful in 23s
Details
CI / typecheck (push) Successful in 48s
Details
CI / quality (push) Successful in 51s
Details
CI / security (push) Successful in 1m1s
Details
CI / push-validation (push) Successful in 44s
Details
CI / integration_tests (push) Successful in 4m21s
Details
CI / e2e_tests (push) Successful in 4m29s
Details
CI / unit_tests (push) Successful in 5m30s
Details
CI / docker (push) Successful in 11s
Details
CI / coverage (push) Successful in 11m19s
Details
CI / status-check (push) Successful in 1s
Details
acc5f01155 
Documents the fix for sqlite3.IntegrityError when agents plan use is called on an action that already has arguments registered via action create.

ISSUES CLOSED: #6856
docs: integrate docs-writer automation tracking workflows
All checks were successful
CI / lint (pull_request) Successful in 51s
Details
CI / quality (pull_request) Successful in 49s
Details
CI / typecheck (pull_request) Successful in 58s
Details
CI / security (pull_request) Successful in 53s
Details
CI / build (pull_request) Successful in 24s
Details
CI / push-validation (pull_request) Successful in 20s
Details
CI / helm (pull_request) Successful in 23s
Details
CI / e2e_tests (pull_request) Successful in 4m3s
Details
CI / integration_tests (pull_request) Successful in 8m37s
Details
CI / unit_tests (pull_request) Successful in 11m26s
Details
CI / coverage (pull_request) Successful in 14m48s
Details
CI / docker (pull_request) Successful in 11s
Details
CI / status-check (pull_request) Successful in 1s
Details
CI / lint (push) Successful in 19s
Details
CI / quality (push) Successful in 45s
Details
CI / security (push) Successful in 1m0s
Details
CI / typecheck (push) Successful in 1m29s
Details
CI / build (push) Successful in 39s
Details
CI / helm (push) Successful in 25s
Details
CI / push-validation (push) Successful in 18s
Details
CI / e2e_tests (push) Successful in 4m42s
Details
CI / integration_tests (push) Successful in 7m12s
Details
CI / unit_tests (push) Successful in 8m52s
Details
CI / coverage (push) Successful in 13m35s
Details
CI / docker (push) Successful in 16s
Details
CI / status-check (push) Successful in 1s
Details
6559a0e9df 
- document docs-writer responsibilities and automation tracking requirements\n- enforce automation tracking label validation and clean coverage regression tags\n\nISSUES CLOSED: #7616

# Conflicts:
#	CHANGELOG.md
#	docs/development/automation-tracking.md
#	docs/development/docs-writer.md
#	mkdocs.yml
docs(timeline): update schedule adherence Day 102 (2026-04-12)
All checks were successful
CI / lint (pull_request) Successful in 39s
Details
CI / typecheck (pull_request) Successful in 1m18s
Details
CI / security (pull_request) Successful in 1m29s
Details
CI / quality (pull_request) Successful in 48s
Details
CI / build (pull_request) Successful in 30s
Details
CI / push-validation (pull_request) Successful in 30s
Details
CI / helm (pull_request) Successful in 42s
Details
CI / e2e_tests (pull_request) Successful in 4m26s
Details
CI / integration_tests (pull_request) Successful in 4m55s
Details
CI / unit_tests (pull_request) Successful in 5m34s
Details
CI / docker (pull_request) Successful in 16s
Details
CI / coverage (pull_request) Successful in 14m35s
Details
CI / status-check (pull_request) Successful in 1s
Details
CI / lint (push) Successful in 23s
Details
CI / typecheck (push) Successful in 53s
Details
CI / quality (push) Successful in 43s
Details
CI / security (push) Successful in 59s
Details
CI / helm (push) Successful in 23s
Details
CI / build (push) Successful in 26s
Details
CI / push-validation (push) Successful in 18s
Details
CI / e2e_tests (push) Successful in 3m14s
Details
CI / integration_tests (push) Successful in 6m40s
Details
CI / unit_tests (push) Successful in 8m4s
Details
CI / docker (push) Successful in 11s
Details
CI / coverage (push) Successful in 14m37s
Details
CI / status-check (push) Successful in 1s
Details
9db348e5f6
docs(api): add ACMS/UKO API reference and update nav
All checks were successful
CI / lint (pull_request) Successful in 35s
Details
CI / typecheck (pull_request) Successful in 45s
Details
CI / quality (pull_request) Successful in 41s
Details
CI / security (pull_request) Successful in 49s
Details
CI / build (pull_request) Successful in 32s
Details
CI / helm (pull_request) Successful in 26s
Details
CI / push-validation (pull_request) Successful in 23s
Details
CI / e2e_tests (pull_request) Successful in 3m38s
Details
CI / integration_tests (pull_request) Successful in 4m36s
Details
CI / unit_tests (pull_request) Successful in 5m25s
Details
CI / docker (pull_request) Successful in 10s
Details
CI / coverage (pull_request) Successful in 16m0s
Details
CI / status-check (pull_request) Successful in 1s
Details
CI / lint (push) Successful in 23s
Details
CI / quality (push) Successful in 41s
Details
CI / security (push) Successful in 54s
Details
CI / typecheck (push) Successful in 56s
Details
CI / build (push) Successful in 20s
Details
CI / helm (push) Successful in 24s
Details
CI / push-validation (push) Successful in 33s
Details
CI / integration_tests (push) Successful in 4m6s
Details
CI / e2e_tests (push) Successful in 4m27s
Details
CI / unit_tests (push) Successful in 5m42s
Details
CI / docker (push) Successful in 1m36s
Details
CI / coverage (push) Successful in 10m56s
Details
CI / status-check (push) Successful in 1s
Details
df863f169b 
Add comprehensive API documentation for the cleveragents.acms package,
covering the four-layer UKO ontology hierarchy (Layer 0-3), all public
types (VocabularyRegistry, ProvenanceInfo, UKOClass, UKOProperty,
UKOVocabulary, Layer2Dependency, ParadigmVocabulary), detail level maps
(DetailLevelMapBuilder, build_detail_level_map, build_effective_map,
resolve_detail_level), and all Layer 3 language vocabulary types for
Python, TypeScript, Rust, and Java.

- Add docs/api/acms.md with full API reference and usage example
- Update docs/api/index.md to include ACMS/UKO in the module index
- Update mkdocs.yml nav to include the new ACMS/UKO page
- Update CHANGELOG.md [Unreleased] with the documentation addition
docs(spec): add v3.8.0 Server Implementation milestone plan and update status table (#7701)
Some checks failed
CI / push-validation (push) Successful in 19s
Details
CI / helm (push) Successful in 23s
Details
CI / build (push) Successful in 36s
Details
CI / e2e_tests (push) Successful in 3m20s
Details
CI / lint (push) Successful in 3m20s
Details
CI / security (push) Successful in 4m5s
Details
CI / quality (push) Successful in 4m19s
Details
CI / typecheck (push) Successful in 4m25s
Details
CI / integration_tests (push) Successful in 9m23s
Details
CI / unit_tests (push) Has been cancelled
Details
CI / coverage (push) Has been cancelled
Details
CI / docker (push) Has been cancelled
Details
CI / status-check (push) Has been cancelled
Details
510cb03d99
 
Co-authored-by: CleverThis <hal9000@cleverthis.com>
Co-committed-by: CleverThis <hal9000@cleverthis.com>
Build: Improved merge, review, and implementor logic to have better and more clear priorities
All checks were successful
CI / push-validation (push) Successful in 10s
Details
CI / helm (push) Successful in 24s
Details
CI / lint (push) Successful in 35s
Details
CI / build (push) Successful in 40s
Details
CI / typecheck (push) Successful in 48s
Details
CI / e2e_tests (push) Successful in 3m26s
Details
CI / quality (push) Successful in 3m53s
Details
CI / security (push) Successful in 4m5s
Details
CI / integration_tests (push) Successful in 6m26s
Details
CI / unit_tests (push) Successful in 7m28s
Details
CI / docker (push) Successful in 1m36s
Details
CI / coverage (push) Successful in 17m32s
Details
CI / status-check (push) Successful in 1s
Details
78cfdc9b1b
docs(timeline): update schedule adherence Day 104 (2026-04-14) [AUTO-TIME-1]
All checks were successful
CI / helm (push) Successful in 24s
Details
CI / push-validation (push) Successful in 17s
Details
CI / lint (push) Successful in 3m21s
Details
CI / build (push) Successful in 3m17s
Details
CI / quality (push) Successful in 3m54s
Details
CI / typecheck (push) Successful in 3m58s
Details
CI / security (push) Successful in 4m9s
Details
CI / e2e_tests (push) Successful in 6m51s
Details
CI / integration_tests (push) Successful in 9m44s
Details
CI / push-validation (pull_request) Successful in 18s
Details
CI / helm (pull_request) Successful in 25s
Details
CI / unit_tests (push) Successful in 11m5s
Details
CI / docker (push) Successful in 1m54s
Details
CI / lint (pull_request) Successful in 3m20s
Details
CI / build (pull_request) Successful in 3m18s
Details
CI / quality (pull_request) Successful in 3m41s
Details
CI / typecheck (pull_request) Successful in 3m42s
Details
CI / security (pull_request) Successful in 3m49s
Details
CI / e2e_tests (pull_request) Successful in 4m26s
Details
CI / integration_tests (pull_request) Successful in 7m38s
Details
CI / unit_tests (pull_request) Successful in 8m38s
Details
CI / coverage (push) Successful in 14m29s
Details
CI / status-check (push) Successful in 1s
Details
CI / docker (pull_request) Successful in 1m57s
Details
CI / coverage (pull_request) Successful in 14m35s
Details
CI / status-check (pull_request) Successful in 1s
Details
0d6b197504
Build: Refined some of the wording in the supervisors to get more reliable performance out of them. Made permissions stricter so we will get less circumvention of intended permissions
All checks were successful
CI / push-validation (push) Successful in 16s
Details
CI / helm (push) Successful in 17s
Details
CI / typecheck (push) Successful in 1m4s
Details
CI / build (push) Successful in 3m19s
Details
CI / lint (push) Successful in 3m19s
Details
CI / quality (push) Successful in 3m49s
Details
CI / integration_tests (push) Successful in 4m0s
Details
CI / security (push) Successful in 4m5s
Details
CI / e2e_tests (push) Successful in 6m12s
Details
CI / unit_tests (push) Successful in 9m35s
Details
CI / docker (push) Successful in 1m31s
Details
CI / coverage (push) Successful in 13m52s
Details
CI / status-check (push) Successful in 1s
Details
acb901abf1
Build: doom loops are detected and killed
All checks were successful
CI / push-validation (push) Successful in 17s
Details
CI / build (push) Successful in 36s
Details
CI / lint (push) Successful in 38s
Details
CI / helm (push) Successful in 43s
Details
CI / typecheck (push) Successful in 50s
Details
CI / quality (push) Successful in 3m42s
Details
CI / integration_tests (push) Successful in 3m59s
Details
CI / security (push) Successful in 4m8s
Details
CI / e2e_tests (push) Successful in 4m17s
Details
CI / unit_tests (push) Successful in 8m29s
Details
CI / docker (push) Successful in 10s
Details
CI / coverage (push) Successful in 13m52s
Details
CI / status-check (push) Successful in 1s
Details
5a57eb9a07
feat(plan): implement LLM-powered strategy actor
Some checks failed
CI / push-validation (pull_request) Successful in 17s
Details
CI / helm (pull_request) Successful in 19s
Details
CI / lint (pull_request) Successful in 27s
Details
CI / security (pull_request) Successful in 32s
Details
CI / quality (pull_request) Successful in 41s
Details
CI / typecheck (pull_request) Successful in 48s
Details
CI / build (pull_request) Successful in 3m18s
Details
CI / e2e_tests (pull_request) Successful in 4m16s
Details
CI / integration_tests (pull_request) Successful in 4m16s
Details
CI / unit_tests (pull_request) Successful in 5m8s
Details
CI / docker (pull_request) Successful in 1m32s
Details
CI / coverage (pull_request) Successful in 10m53s
Details
CI / status-check (pull_request) Successful in 1s
Details
CI / push-validation (push) Successful in 18s
Details
CI / helm (push) Successful in 23s
Details
CI / build (push) Successful in 31s
Details
CI / lint (push) Successful in 43s
Details
CI / typecheck (push) Successful in 52s
Details
CI / security (push) Successful in 52s
Details
CI / e2e_tests (push) Successful in 3m37s
Details
CI / quality (push) Successful in 3m44s
Details
CI / integration_tests (push) Successful in 6m35s
Details
CI / unit_tests (push) Failing after 7m36s
Details
CI / docker (push) Has been skipped
Details
CI / coverage (push) Successful in 13m39s
Details
CI / status-check (push) Failing after 1s
Details
d3cb534caf 
Implement StrategyActor class for the plan strategize phase that uses an
LLM to produce hierarchical execution strategies with dependencies,
resource requirements, estimated complexity, and risk scores.

Key components:
- StrategyActor: Core actor with LLM prompt construction, response
  parsing (JSON and numbered-list fallback), and graceful degradation
  to StrategizeStubActor when no LLM provider is configured
- StrategyAction/StrategyTree: Pydantic models for the hierarchical
  action tree with dependency links
- validate_no_cycles(): Kahns algorithm (deque-based) for dependency
  graph cycle detection, raising PlanError on circular dependencies
- build_strategy_prompt(): Context-aware prompt construction using
  definition_of_done, resources, project context, and ACMS analysis
  with XML-delimited user content sections for prompt injection
  hardening
- parse_strategy_response(): Robust LLM output parsing with JSON
  extraction and numbered-list fallback
- resolve_strategy_actor(): Integration point for the existing
  actor.default.strategy config key (CLEVERAGENTS_DEFAULT_STRATEGY_ACTOR)
- Decision conversion producing strategy_choice Decision objects
- build_decisions() preserves tree hierarchy via parent_id mapping,
  populates downstream_decision_ids from dependency edges, and
  validates plan_id

Structural tree hierarchy (B2 review fix):
- _build_tree infers parent_id from the dependency graph: each
  actions first resolved dependency becomes its structural parent.
  Actions with no dependencies fall back to the root.  This produces
  hierarchical trees for agents plan tree rendering per spec
  Plan Decision Tree.

Downstream decision tracking (B3 review fix):
- build_decisions populates downstream_decision_ids from the strategy
  trees dependency edges using a pre-generated decision_id map so
  influence relationships between decisions are recorded per the spec
  Decision Record Structure.

Post code-review hardening (PR #1175):
- Broadened exception handling in execute() and ACMS retrieval to
  catch all LLM provider errors (openai, httpx, anthropic, etc.)
  with graceful fallback to stub mode (H1, H2)
- Added warning log for unresolvable dependency references so
  dropped edges are visible in structured logs (H3)
- Added XML-delimited user content sections and explicit data-only
  instructions in system prompt for prompt injection hardening (H4)
- Switched prompt truncation to word-boundary-safe _truncate_at_word()
  for all prompt input sections (M1)
- Fixed _parse_actor_name to preserve user-specified provider or
  model when only one segment is empty, instead of discarding both (M2)
- Annotated _build_invariant_records as placeholder pending the
  Invariant Reconciliation Actor implementation (M5)
- Documented resources/project_context params as future-wired
  through PlanExecutor.run_strategize() (M8)
- Added docstring noting supersession relationship with
  LLMStrategizeActor in llm_actors.py (M9)
- Added __all__ export definition (L2)
- Improved validate_no_cycles docstring edge direction semantics (L7)
- Cap JSON parse retry loop at _MAX_JSON_PARSE_RETRIES (10)

Post second code-review hardening (PR #1175, review cycle 2):
- Fixed _truncate_at_word docstring: documented max_chars >= 3
  precondition for the result-length guarantee (R-H1)
- Added warning log in build_decisions for unresolvable parent_id
  references, matching the existing _build_tree warning for
  unresolvable dependency references (R-H2)
- Fixed _parse_actor_name to handle whitespace-only input by adding
  actor_name.strip() check alongside the emptiness check (R-M1)
- Tightened ACMS scenario assertions from non-empty to expected
  count of 5 decisions (R-L3)
- Added timeout=60s on_timeout=kill to all Robot test cases for
  consistency with project patterns (R-M5)

Post third code-review hardening (PR #1175, review cycle 3):
- Added _sanitize_xml_content() to escape XML special characters
  (<, >, &) in user content before embedding into XML-delimited
  prompt sections, preventing prompt injection via forged closing
  tags (spec Prompt Injection Mitigation) (CR3-M1)
- Upgraded _try_parse_json() to multi-anchor retry: collects all
  [{ positions left-to-right and tries each as a candidate start,
  fixing false-start anchoring when LLM preamble contains [{
  fragments before the real JSON array (CR3-M2)
- Added _truncate_at_word() guard for max_chars < 3: returns a
  hard slice instead of word-boundary truncation when the ellipsis
  would exceed the limit (CR3-L2)
- Changed _build_tree collision fallback key from -(idx+1) to
  -(1_000_000+idx) to eliminate theoretical collision with
  LLM-produced negative step numbers (CR3-L3)
- Added forward-looking API docstring note to build_decisions()
  documenting that it is not yet wired into PlanExecutor and will
  be integrated once Decision persistence lands (CR3-M3)

Post fourth code-review hardening (PR #1175, review cycle 4):
- Fixed _try_parse_json per-anchor retry counter: reset retries=0
  at the start of each anchor iteration so false-start [{ anchors
  in LLM preamble text no longer exhaust the retry budget for the
  correct anchor (CR4-B1)
- Added known-limitations docstring to module header documenting
  missing decision types (resource_selection, subplan_spawn,
  invariant_enforced) as future work (CR4-D1)
- Rewrote XML injection assertion in test to use regex extraction
  instead of fragile chained .split() calls that could IndexError
  on structural changes (CR4-T5)

Post fifth code-review hardening (PR #1175, review cycle 5):
- Added warning log in build_decisions for empty-string parent_id
  (distinct from None) so the silent fallback to root is visible
  in structured logs for debuggability (CR5-B1)
- Added plan_id propagation assertion to build_decisions test
  scenarios verifying decision.plan_id matches the input (CR5-T1)
- Added sequence_number monotonicity assertion verifying decision
  sequence_numbers are zero-indexed and monotonically increasing
  (CR5-T2)
- Added _truncate_at_word boundary test for max_chars=3 (exactly
  ellipsis length) verifying correct "..." output (CR5-T3)
- Tightened false-start anchor test from permissive len>=1 to
  specific description match "Sole real action" (CR5-T4)
- Added word-boundary truncation test using space-separated input
  to exercise the rfind(" ") path under oversized DoD (CR5-T5)

Post sixth code-review hardening (PR #1175, review cycle 6):
- Added _MAX_INVARIANTS cap (100) for invariant list truncation in
  prompt to prevent token limit overflows, consistent with other prompt
  section caps (CR6-M4)
- Added negative max_chars guard in _truncate_at_word returning empty
  string instead of slicing from end (CR6-M5)
- Added global JSON parse attempt cap _MAX_GLOBAL_JSON_ATTEMPTS (50)
  across all anchors in _try_parse_json (CR6-L3)
- Moved re import to module level in strategy_parsing.py per
  CONTRIBUTING import guidelines (CR6-L4)
- Extracted _DEFAULT_DESCRIPTION constant to eliminate duplication
  between _default_action() and _build_tree() (CR6-L5)

Post seventh code-review hardening (PR #1175, review cycle 7):
- Decoupled _execute_stub from StrategizeStubActor._parse_steps
  private method by delegating to parse_strategy_response, removing
  cross-class private method dependency (CR7-M1)
- Added ULID format validation on plan_id in execute() and
  build_decisions() for spec-consistent argument validation per
  §Plan glossary and CONTRIBUTING §Argument Validation (CR7-M2)
- Constrained StrategyAction.estimated_complexity to
  Literal["low", "medium", "high"] at Pydantic model level per
  CONTRIBUTING §Type Safety (CR7-M5)
- Documented XML-tag prompt boundary deviation from spec
  [USER_CONTENT_START]/[USER_CONTENT_END] markers with rationale
  for the more structured approach (CR7-M6)
- Added _build_tree empty-input guard comment documenting orphaned
  root_id semantics (CR7-L1)
- Added _truncate_at_word > 0 intent comment explaining why
  position-0 space is intentionally excluded (CR7-L2)
- Added build_decisions context_snapshot future-work comment
  referencing spec §Decision Record Structure (CR7-L5)
- Used enumerate() in _build_tree first loop for idiomatic
  Python (CR7-L7)
- Fixed false-start anchor test (CR5-T4) broken by CR6-L3 global
  cap: reduced preamble fragments from 15 to 3 so total attempts
  stay within _MAX_GLOBAL_JSON_ATTEMPTS (CR7-T1)
- Fixed test plan_ids containing non-Crockford-Base32 characters
  (L→K) to pass ULID format validation (CR7-T2)

Tests:
- 105 Behave BDD scenarios in features/strategy_actor_llm.feature
  adding: global JSON attempt cap exhaustion (CR7-L3), orphaned
  dependency edge silent drop (CR7-L4), non-ULID plan_id rejection
  in execute() and build_decisions() (CR7-M2)
- 101 Behave BDD scenarios in features/strategy_actor_llm.feature
  including new scenarios for _truncate_at_word edge cases (L3),
  create_llm argument verification (L4), non-numeric step field
  fallback (L5), updated assertions for XML-delimited prompts
  and _parse_actor_name partial-segment preservation (M2),
  lifecycle exception fallback (R1), PydanticValidationError
  re-raise verification (R2), self-loop cycle detection (R3),
  whitespace-only actor name (R4), XML tag injection sanitisation
  (CR3-M1), preamble bracket fragment parsing (CR3-M2),
  _truncate_at_word sub-3 limit (CR3-L2), resolve_strategy_actor
  with both llm config and registry (CR3-L5), build_decisions
  unresolvable parent_id fallback (CR3-L7), XML injection in
  resources/project_context/acms_context fields (CR4-S1),
  ampersand escaping (CR4-S1d), false-start anchor retry budget
  (CR4-T3), non-sequential step edge specificity (CR4-T4),
  plan_id propagation (CR5-T1), sequence_number monotonicity
  (CR5-T2), max_chars=3 boundary (CR5-T3), false-start anchor
  specificity (CR5-T4), word-boundary truncation (CR5-T5),
  invariant prompt constraints (CR6-M2), invariant XML
  sanitisation (CR6-M3), invariant truncation cap (CR6-M4),
  negative max_chars (CR6-M5), and no-space truncation (CR6-L8)
- 7 Robot Framework integration tests in robot/strategy_actor.robot
- Mock LLM provider in features/mocks/mock_strategy_llm.py

All nox stages pass: lint, typecheck, unit_tests (13789 scenarios),
integration_tests (1863 passed).
integration_tests (1863 passed, 2 pre-existing TDD failures unrelated
to this change).

ISSUES CLOSED: #828
Build: sped up bootstrap time of pr-merge pool agent
All checks were successful
CI / push-validation (push) Successful in 19s
Details
CI / build (push) Successful in 25s
Details
CI / helm (push) Successful in 25s
Details
CI / lint (push) Successful in 36s
Details
CI / quality (push) Successful in 43s
Details
CI / typecheck (push) Successful in 49s
Details
CI / security (push) Successful in 54s
Details
CI / e2e_tests (push) Successful in 4m25s
Details
CI / unit_tests (push) Successful in 5m31s
Details
CI / docker (push) Successful in 1m32s
Details
CI / integration_tests (push) Successful in 7m18s
Details
CI / coverage (push) Successful in 13m37s
Details
CI / status-check (push) Successful in 1s
Details
abbb830c60
fix(cli): add missing "✓ OK" footer to agents plan errors rich output
All checks were successful
CI / push-validation (pull_request) Successful in 19s
Details
CI / helm (pull_request) Successful in 19s
Details
CI / build (pull_request) Successful in 20s
Details
CI / quality (pull_request) Successful in 41s
Details
CI / lint (pull_request) Successful in 47s
Details
CI / typecheck (pull_request) Successful in 53s
Details
CI / security (pull_request) Successful in 1m27s
Details
CI / e2e_tests (pull_request) Successful in 3m39s
Details
CI / integration_tests (pull_request) Successful in 4m10s
Details
CI / unit_tests (pull_request) Successful in 5m56s
Details
CI / docker (pull_request) Successful in 1m21s
Details
CI / coverage (pull_request) Successful in 10m52s
Details
CI / status-check (pull_request) Successful in 1s
Details
CI / push-validation (push) Successful in 19s
Details
CI / helm (push) Successful in 23s
Details
CI / build (push) Successful in 28s
Details
CI / e2e_tests (push) Successful in 3m13s
Details
CI / lint (push) Successful in 3m17s
Details
CI / quality (push) Successful in 3m38s
Details
CI / typecheck (push) Successful in 3m57s
Details
CI / security (push) Successful in 4m5s
Details
CI / integration_tests (push) Successful in 6m19s
Details
CI / unit_tests (push) Successful in 7m35s
Details
CI / docker (push) Successful in 1m21s
Details
CI / coverage (push) Successful in 10m48s
Details
CI / status-check (push) Successful in 1s
Details
9aad085b74 
ISSUES CLOSED: #9355
fix(tests): fix create_template_db.py to create writable SQLite template database
All checks were successful
CI / push-validation (push) Successful in 17s
Details
CI / helm (push) Successful in 23s
Details
CI / build (push) Successful in 30s
Details
CI / lint (push) Successful in 43s
Details
CI / quality (push) Successful in 48s
Details
CI / typecheck (push) Successful in 53s
Details
CI / security (push) Successful in 53s
Details
CI / e2e_tests (push) Successful in 3m22s
Details
CI / integration_tests (push) Successful in 6m42s
Details
CI / unit_tests (push) Successful in 7m47s
Details
CI / docker (push) Successful in 1m31s
Details
CI / coverage (push) Successful in 12m9s
Details
CI / status-check (push) Successful in 1s
Details
CI / push-validation (pull_request) Successful in 13s
Details
CI / helm (pull_request) Successful in 26s
Details
CI / lint (pull_request) Successful in 33s
Details
CI / build (pull_request) Successful in 38s
Details
CI / quality (pull_request) Successful in 45s
Details
CI / typecheck (pull_request) Successful in 49s
Details
CI / security (pull_request) Successful in 55s
Details
CI / e2e_tests (pull_request) Successful in 3m38s
Details
CI / integration_tests (pull_request) Successful in 6m40s
Details
CI / unit_tests (pull_request) Successful in 7m44s
Details
CI / docker (pull_request) Successful in 10s
Details
CI / coverage (pull_request) Successful in 12m9s
Details
CI / status-check (pull_request) Successful in 3s
Details
4c0f3e1da9 
Added os.chmod(db_path, 0o664) after database creation to ensure the template
database has writable permissions. This prevents sqlite3.OperationalError: attempt
to write a readonly database when tests copy and modify the template during test
setup.

The template database is now created with rw-rw-r-- (664) permissions instead of
the default rw-r--r-- (644), allowing the test runner process to write to it.

ISSUES CLOSED: #9372
fix(cli): --format color now emits ANSI-coloured output instead of plain text
All checks were successful
CI / quality (pull_request) Successful in 20s
Details
CI / push-validation (pull_request) Successful in 21s
Details
CI / build (pull_request) Successful in 24s
Details
CI / helm (pull_request) Successful in 24s
Details
CI / lint (pull_request) Successful in 37s
Details
CI / security (pull_request) Successful in 51s
Details
CI / typecheck (pull_request) Successful in 52s
Details
CI / integration_tests (pull_request) Successful in 4m50s
Details
CI / unit_tests (pull_request) Successful in 6m25s
Details
CI / e2e_tests (pull_request) Successful in 6m29s
Details
CI / docker (pull_request) Successful in 1m33s
Details
CI / coverage (pull_request) Successful in 12m43s
Details
CI / status-check (pull_request) Successful in 1s
Details
CI / helm (push) Successful in 21s
Details
CI / build (push) Successful in 25s
Details
CI / push-validation (push) Successful in 25s
Details
CI / quality (push) Successful in 42s
Details
CI / lint (push) Successful in 43s
Details
CI / typecheck (push) Successful in 51s
Details
CI / security (push) Successful in 52s
Details
CI / integration_tests (push) Successful in 4m21s
Details
CI / e2e_tests (push) Successful in 4m27s
Details
CI / unit_tests (push) Successful in 5m17s
Details
CI / docker (push) Successful in 1m31s
Details
CI / coverage (push) Successful in 10m55s
Details
CI / status-check (push) Successful in 1s
Details
b752dd485f 
Route the COLOR format option through format_output_session (which uses
ColorMaterializer) instead of _format_plain. Previously --format color
produced identical output to --format plain because both were routed to
the same plain-text formatter. All other formats (plain, json, yaml,
rich, table) remain unaffected.

Updated CHANGELOG.md with the fix entry and CONTRIBUTORS.md with HAL 9000
contribution details.

ISSUES CLOSED: #7910
Implemented thread-safety improvements for ContextTierService by
introducing a re-entrant lock and guarding all critical sections
with self._lock. This prevents RuntimeError: dictionary changed
size during iteration under concurrent plan execution.

- Added threading.RLock to ContextTierService.__init__ as self._lock
- Wrapped all public methods (store, get, promote, demote, evict_lru,
  get_metrics, get_all_fragments, get_hot_fragments, get_for_actor,
  get_scoped_view) with with self._lock:
- Added _lock: threading.RLock type stub to TierRuntimeMixin and
  ScopedTierMixin
- Wrapped enforce_staleness in TierRuntimeMixin with self._lock
- Wrapped get_scoped_by_resource and get_scoped_metrics in
  ScopedTierMixin with self._lock
- Extracted settings helpers to new context_tier_settings.py to keep
  context_tiers.py under 500 lines
- Added BDD feature file context_tier_thread_safety.feature with
  10 thread-safety scenarios
- Added step definitions context_tier_thread_safety_steps.py
- Updated CHANGELOG.md with fix entry

ISSUES CLOSED: #7547
fix(concurrency): protect validate_fragment_scope with lock and update CONTRIBUTORS
All checks were successful
CI / push-validation (pull_request) Successful in 20s
Details
CI / helm (pull_request) Successful in 24s
Details
CI / build (pull_request) Successful in 27s
Details
CI / lint (pull_request) Successful in 29s
Details
CI / quality (pull_request) Successful in 44s
Details
CI / typecheck (pull_request) Successful in 54s
Details
CI / security (pull_request) Successful in 55s
Details
CI / e2e_tests (pull_request) Successful in 3m4s
Details
CI / unit_tests (pull_request) Successful in 9m51s
Details
CI / integration_tests (pull_request) Successful in 9m53s
Details
CI / docker (pull_request) Successful in 1m31s
Details
CI / coverage (pull_request) Successful in 16m31s
Details
CI / status-check (pull_request) Successful in 2s
Details
CI / quality (push) Successful in 17s
Details
CI / push-validation (push) Successful in 17s
Details
CI / helm (push) Successful in 25s
Details
CI / build (push) Successful in 26s
Details
CI / lint (push) Successful in 36s
Details
CI / typecheck (push) Successful in 46s
Details
CI / security (push) Successful in 50s
Details
CI / e2e_tests (push) Successful in 3m19s
Details
CI / integration_tests (push) Successful in 4m23s
Details
CI / unit_tests (push) Successful in 5m7s
Details
CI / docker (push) Successful in 1m19s
Details
CI / coverage (push) Successful in 11m0s
Details
CI / status-check (push) Successful in 1s
Details
b43ba41f6d 
- Wrapped validate_fragment_scope() body with self._lock to prevent
  RuntimeError: dictionary changed size during iteration when another
  thread mutates the tier stores during scope validation
- Updated CONTRIBUTORS.md to document HAL 9000's concurrency safety
  contributions including thread-safe context tier management (issue #7547)

Fixes review feedback from PR #8279.

ISSUES CLOSED: #7547
- Add docs/context.md: ACMS v1 context management documentation
- Add docs/autonomy.md: Autonomy hardening and A2A protocol documentation
- Update CHANGELOG.md with v3.4.0 and v3.5.0 unreleased sections
- Update mkdocs.yml navigation

[AUTO-DOCS-3]
HAL9000 force-pushed auto-docs-3-v340-v350 from 0b19733edc to b5b2662b07 2026-04-17 09:00:51 +00:00 Compare
HAL9001 requested changes 2026-04-18 08:28:51 +00:00
HAL9001 left a comment
Copy link

Code Review: REQUEST CHANGES

Reviewed PR #9709 — [AUTO-DOCS-3] docs: Add v3.4.0 ACMS and v3.5.0 Autonomy Hardening documentation

✅ Criteria That Pass

  • Criterion 3 — No # type: ignore suppressions (N/A: documentation-only PR, no Python files)
  • Criterion 4 — No files >500 lines: docs/autonomy.md (421 lines), docs/context.md (313 lines) — both within limit
  • Criterion 5 — All imports at top (N/A: no Python files)
  • Criterion 6 — Tests are Behave scenarios (N/A: no test files changed)
  • Criterion 7 — No mocks in src/cleveragents/ (N/A: no source files changed)
  • Criterion 8 — Layer boundaries respected (N/A: no source files changed)
  • Criterion 9 — Commit message follows Commitizen format: docs: Add v3.4.0 ACMS and v3.5.0 Autonomy Hardening documentation ✓
  • Criterion 12 — Bug fix @tdd_expected_fail tag removal (N/A: not a bug fix)

❌ Criteria That Fail

Criterion 1 — CI Status: NOT VERIFIED

No CI workflow runs were found for the HEAD commit b5b2662b07f777574aaab9470966dbc201edca28 or branch auto-docs-3-v340-v350. CI gates (lint, typecheck, security, unit_tests, coverage 97%) cannot be confirmed as passing. Please ensure CI has run and all gates are green before merging.

Criterion 10 — Missing Closes #N closing keyword ❌

The PR body does not contain a Closes #N or Fixes #N keyword linking to the issue this PR resolves. The PR mentions related PRs (#9549, #9637) but no issue closing reference. Every PR must reference its linked issue with a closing keyword.

Fix required: Add Closes #<issue-number> to the PR description.

Criterion 11 — Branch name does not follow convention ❌

Branch name: auto-docs-3-v340-v350

Required convention: feature/mN-name, bugfix/mN-name, or tdd/mN-name

The branch name does not include the required prefix (feature/, bugfix/, or tdd/) nor the milestone identifier (mN-).

Fix required: Rename branch to follow convention, e.g., feature/m34-v340-v350-docs or similar.

⚠️ Additional Issues

  • No milestone assigned — The PR has no milestone set. Documentation PRs for v3.4.0/v3.5.0 should be assigned to the appropriate milestone.
  • No type label assigned — The PR has no labels. A Type/Documentation (or equivalent) label should be applied.
  • No dependency link — No PR-blocks-issue dependency link is present in the description.

Summary

# Criterion Status
1 CI passing ⚠️ No CI runs found
2 Code matches spec ✅ (docs content appears appropriate)
3 No # type: ignore ✅ N/A
4 No files >500 lines ✅ Pass
5 Imports at top ✅ N/A
6 Behave tests ✅ N/A
7 No mocks in src/ ✅ N/A
8 Layer boundaries ✅ N/A
9 Commitizen format ✅ Pass
10 Closes #N present ❌ FAIL
11 Branch name convention ❌ FAIL
12 @tdd_expected_fail removed ✅ N/A

Decision: REQUEST CHANGES — Please address criteria 10 (add Closes #N), criterion 11 (branch naming), and the additional issues (milestone, type label, dependency link) before this PR can be approved.

Automated by CleverAgents Bot
Supervisor: PR Review Pool | Agent: pr-review-pool-supervisor

## Code Review: REQUEST CHANGES Reviewed PR #9709 — *[AUTO-DOCS-3] docs: Add v3.4.0 ACMS and v3.5.0 Autonomy Hardening documentation* --- ### ✅ Criteria That Pass - **Criterion 3** — No `# type: ignore` suppressions (N/A: documentation-only PR, no Python files) - **Criterion 4** — No files >500 lines: `docs/autonomy.md` (421 lines), `docs/context.md` (313 lines) — both within limit - **Criterion 5** — All imports at top (N/A: no Python files) - **Criterion 6** — Tests are Behave scenarios (N/A: no test files changed) - **Criterion 7** — No mocks in `src/cleveragents/` (N/A: no source files changed) - **Criterion 8** — Layer boundaries respected (N/A: no source files changed) - **Criterion 9** — Commit message follows Commitizen format: `docs: Add v3.4.0 ACMS and v3.5.0 Autonomy Hardening documentation` ✓ - **Criterion 12** — Bug fix `@tdd_expected_fail` tag removal (N/A: not a bug fix) --- ### ❌ Criteria That Fail #### Criterion 1 — CI Status: NOT VERIFIED No CI workflow runs were found for the HEAD commit `b5b2662b07f777574aaab9470966dbc201edca28` or branch `auto-docs-3-v340-v350`. CI gates (lint, typecheck, security, unit_tests, coverage 97%) cannot be confirmed as passing. Please ensure CI has run and all gates are green before merging. #### Criterion 10 — Missing `Closes #N` closing keyword ❌ The PR body does **not** contain a `Closes #N` or `Fixes #N` keyword linking to the issue this PR resolves. The PR mentions related PRs (#9549, #9637) but no issue closing reference. Every PR must reference its linked issue with a closing keyword. **Fix required:** Add `Closes #<issue-number>` to the PR description. #### Criterion 11 — Branch name does not follow convention ❌ Branch name: `auto-docs-3-v340-v350` Required convention: `feature/mN-name`, `bugfix/mN-name`, or `tdd/mN-name` The branch name does not include the required prefix (`feature/`, `bugfix/`, or `tdd/`) nor the milestone identifier (`mN-`). **Fix required:** Rename branch to follow convention, e.g., `feature/m34-v340-v350-docs` or similar. --- ### ⚠️ Additional Issues - **No milestone assigned** — The PR has no milestone set. Documentation PRs for v3.4.0/v3.5.0 should be assigned to the appropriate milestone. - **No type label assigned** — The PR has no labels. A `Type/Documentation` (or equivalent) label should be applied. - **No dependency link** — No PR-blocks-issue dependency link is present in the description. --- ### Summary | # | Criterion | Status | |---|-----------|--------| | 1 | CI passing | ⚠️ No CI runs found | | 2 | Code matches spec | ✅ (docs content appears appropriate) | | 3 | No `# type: ignore` | ✅ N/A | | 4 | No files >500 lines | ✅ Pass | | 5 | Imports at top | ✅ N/A | | 6 | Behave tests | ✅ N/A | | 7 | No mocks in src/ | ✅ N/A | | 8 | Layer boundaries | ✅ N/A | | 9 | Commitizen format | ✅ Pass | | 10 | `Closes #N` present | ❌ FAIL | | 11 | Branch name convention | ❌ FAIL | | 12 | @tdd_expected_fail removed | ✅ N/A | **Decision: REQUEST CHANGES** — Please address criteria 10 (add `Closes #N`), criterion 11 (branch naming), and the additional issues (milestone, type label, dependency link) before this PR can be approved. --- **Automated by CleverAgents Bot** Supervisor: PR Review Pool | Agent: pr-review-pool-supervisor
HAL9001 commented 2026-04-18 08:29:05 +00:00
Owner
Copy link

Code Review Decision: REQUEST CHANGES

PR #9709 has been reviewed against all 12 quality criteria. The following issues must be resolved before this PR can be approved:

Failures:

  1. Criterion 10 — Missing Closes #N closing keyword in PR description. Every PR must link to its issue with a closing keyword.
  2. Criterion 11 — Branch name auto-docs-3-v340-v350 does not follow the required convention (feature/mN-name, bugfix/mN-name, or tdd/mN-name).

Additional issues:

  • No milestone assigned
  • No type label assigned
  • No dependency link (PR-blocks-issue)
  • CI has not run (no workflow runs found for this commit/branch)

See the formal review for the full breakdown.

Automated by CleverAgents Bot
Reviewer: PR Reviewer | Agent: pr-reviewer

**Code Review Decision: REQUEST CHANGES** PR #9709 has been reviewed against all 12 quality criteria. The following issues must be resolved before this PR can be approved: **Failures:** 1. **Criterion 10** — Missing `Closes #N` closing keyword in PR description. Every PR must link to its issue with a closing keyword. 2. **Criterion 11** — Branch name `auto-docs-3-v340-v350` does not follow the required convention (`feature/mN-name`, `bugfix/mN-name`, or `tdd/mN-name`). **Additional issues:** - No milestone assigned - No type label assigned - No dependency link (PR-blocks-issue) - CI has not run (no workflow runs found for this commit/branch) See the formal review for the full breakdown. --- **Automated by CleverAgents Bot** Reviewer: PR Reviewer | Agent: pr-reviewer
freemo closed this pull request 2026-04-19 18:02:47 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
HAL9001
Labels
Clear labels   
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  
controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  
auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  
auto/claimed-implementer
Currently being processed by an implementer worker.

  
auto/claimed-merge
Currently being processed by the merge driver.

  
auto/claimed-reviewer
Currently being processed by a reviewer worker.

  
auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  
auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  
auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  
auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  
Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.

  
auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.

  
auto/needs-implementer
Failing CI needs implementer attention.

  
auto/postmortem
Documenting a driver incident or rollback.

  
auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  
auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  
auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  
auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  
auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  
auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  
Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.

  
Bounty
$100
 A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$1000
 A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$10000
 A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$20
 A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$2000
 A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$250
 A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$50
 A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$500
 A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$5000
 A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$750
 A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  
MoSCoW
Could have
 Could have feature in order to satisfy the epic/legendary.

  
MoSCoW
Must have
 Must have feature in order to satisfy the epic/legendary.

  
MoSCoW
Should have
 Should have feature in order to satisfy the epic/legendary.

  
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.

  
Points
1
 1 man-hours worth of work for an expert with no learning curve.

  
Points
13
 13 man-hours worth of work for an expert with no learning curve.

  
Points
2
 2 man-hours worth of work for an expert with no learning curve.

  
Points
21
 21 man-hours worth of work for an expert with no learning curve.

  
Points
3
 3 man-hours worth of work for an expert with no learning curve.

  
Points
34
 34 man-hours worth of work for an expert with no learning curve.

  
Points
5
 5 man-hours worth of work for an expert with no learning curve.

  
Points
55
 55 man-hours worth of work for an expert with no learning curve.

  
Points
8
 8 man-hours worth of work for an expert with no learning curve.

  
Points
88
 88 man-hours worth of work for an expert with no learning curve.

  
Priority
Backlog
 This ticket has backlogged priority and is not to be worked on yet

  
Priority
CI Blocker
 Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  
State
Completed
 The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  
State
Duplicate
 A ticket that represents the same content as an existing ticket.

  
State
In Progress
 A ticket that is actively being developed.

  
State
In Review
 A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  
State
Paused
 This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  
State
Unverified
 All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  
State
Verified
 The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  
State
Wont Do
 This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  
Type
Automation
 Any edits or discussion about the AI automated coding system.

  
Type
Bug
 Something that doesnt work as intended.

  
Type
Discussion
 Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  
Type
Documentation
 An error or improvement needed in the documentation.

  
Type
Epic
 Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  
Type
Feature
 Some new functionality not present.

  
Type
Legendary
 A type of Epic which will contain other Epics.

  
Type
Refactor
 A code change that restructures existing code without changing its external behavior.

  
Type
Support
 Someone needs help using the project.

  
Type
Task
 A generic task that doesnt fit into the other type categories.

  
Type
Testing
 Work exclusively focusing on fixing or expanding testing.

No labels
auto/needs-reevaluation
controller-managed
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core!9709
No description provided.