feat(tool): implement BuiltinAdapter class and MCP automatic resource slot creation #964

Merged
brent.edwards merged 7 commits from feature/m5-builtin-adapter-mcp-slots into master 2026-03-21 05:30:01 +00:00

7 Commits

Author SHA1 Message Date
brent.edwards 5c61475b63 Merge remote-tracking branch 'origin/master' into feature/m5-builtin-adapter-mcp-slots
CI / benchmark-publish (pull_request) Has been skipped
CI / build (pull_request) Successful in 31s
CI / lint (pull_request) Successful in 4m23s
CI / typecheck (pull_request) Successful in 4m48s
CI / quality (pull_request) Successful in 4m47s
CI / security (pull_request) Successful in 5m1s
CI / integration_tests (pull_request) Successful in 8m55s
CI / e2e_tests (pull_request) Successful in 9m15s
CI / unit_tests (pull_request) Successful in 9m58s
CI / docker (pull_request) Successful in 1m8s
CI / coverage (pull_request) Successful in 11m12s
CI / status-check (pull_request) Successful in 1s
CI / benchmark-regression (pull_request) Successful in 57m48s
# Conflicts:
#	CHANGELOG.md
2026-03-21 05:13:22 +00:00
brent.edwards 564e5054b2 Merge remote-tracking branch 'origin/master' into feature/m5-builtin-adapter-mcp-slots
CI / build (pull_request) Successful in 27s
CI / benchmark-publish (pull_request) Has been skipped
CI / lint (pull_request) Successful in 3m56s
CI / quality (pull_request) Successful in 4m11s
CI / typecheck (pull_request) Successful in 4m20s
CI / security (pull_request) Successful in 4m30s
CI / integration_tests (pull_request) Successful in 8m33s
CI / unit_tests (pull_request) Successful in 9m19s
CI / e2e_tests (pull_request) Successful in 9m41s
CI / docker (pull_request) Successful in 57s
CI / coverage (pull_request) Successful in 11m17s
CI / status-check (pull_request) Successful in 1s
CI / benchmark-regression (pull_request) Successful in 36m33s
# Conflicts:
#	CHANGELOG.md
2026-03-21 04:30:34 +00:00
brent.edwards d380924e58 Merge branch 'master' into feature/m5-builtin-adapter-mcp-slots
CI / benchmark-publish (pull_request) Has been skipped
CI / security (pull_request) Successful in 56s
CI / build (pull_request) Successful in 22s
CI / lint (pull_request) Successful in 3m18s
CI / integration_tests (pull_request) Successful in 3m30s
CI / unit_tests (pull_request) Successful in 3m34s
CI / quality (pull_request) Successful in 3m41s
CI / typecheck (pull_request) Successful in 3m53s
CI / docker (pull_request) Successful in 1m8s
CI / e2e_tests (pull_request) Successful in 5m59s
CI / coverage (pull_request) Successful in 11m55s
CI / status-check (pull_request) Successful in 3s
CI / benchmark-regression (pull_request) Successful in 37m7s
2026-03-21 01:54:32 +00:00
brent.edwards 496b456579 Merge remote-tracking branch 'origin/master' into feature/m5-builtin-adapter-mcp-slots
CI / benchmark-publish (pull_request) Has been skipped
CI / lint (pull_request) Successful in 24s
CI / build (pull_request) Successful in 22s
CI / quality (pull_request) Successful in 32s
CI / integration_tests (pull_request) Successful in 2m43s
CI / unit_tests (pull_request) Successful in 3m25s
CI / security (pull_request) Successful in 4m8s
CI / typecheck (pull_request) Successful in 4m15s
CI / docker (pull_request) Successful in 1m4s
CI / e2e_tests (pull_request) Successful in 8m35s
CI / coverage (pull_request) Successful in 11m58s
CI / status-check (pull_request) Successful in 2s
CI / benchmark-regression (pull_request) Has been cancelled
# Conflicts:
#	CHANGELOG.md
2026-03-21 01:17:56 +00:00
brent.edwards 5f420d896c Merge remote-tracking branch 'origin/master' into feature/m5-builtin-adapter-mcp-slots
CI / build (pull_request) Successful in 23s
CI / benchmark-publish (pull_request) Has been skipped
CI / quality (pull_request) Successful in 3m43s
CI / lint (pull_request) Successful in 3m46s
CI / typecheck (pull_request) Successful in 3m55s
CI / security (pull_request) Successful in 4m4s
CI / integration_tests (pull_request) Successful in 6m6s
CI / unit_tests (pull_request) Successful in 6m57s
CI / e2e_tests (pull_request) Successful in 8m20s
CI / docker (pull_request) Successful in 1m23s
CI / coverage (pull_request) Has been cancelled
CI / benchmark-regression (pull_request) Has been cancelled
CI / status-check (pull_request) Has been cancelled
2026-03-21 01:07:25 +00:00
brent.edwards e02e396738 Merge remote-tracking branch 'origin/master' into feature/m5-builtin-adapter-mcp-slots
CI / docker (pull_request) Blocked by required conditions
CI / benchmark-publish (pull_request) Has been skipped
CI / lint (pull_request) Successful in 24s
CI / build (pull_request) Successful in 23s
CI / quality (pull_request) Successful in 37s
CI / typecheck (pull_request) Successful in 42s
CI / integration_tests (pull_request) Successful in 3m25s
CI / coverage (pull_request) Successful in 6m51s
CI / e2e_tests (pull_request) Failing after 12m14s
CI / unit_tests (pull_request) Failing after 12m14s
CI / security (pull_request) Failing after 12m15s
CI / benchmark-regression (pull_request) Failing after 36m30s
# Conflicts:
#	CHANGELOG.md
2026-03-20 23:59:44 +00:00
brent.edwards 078e07ea3d feat(tool): implement BuiltinAdapter class and MCP automatic resource slot creation
Implement BuiltinAdapter class wrapping existing register_file_tools(),
register_git_tools(), and register_subplan_tool() into a unified adapter
following the AgentSkillLoader naming convention (activate/deactivate/discover/register).

Add MCP automatic resource slot inference via infer_resource_slots() static method
on McpAdapter that analyzes tool input schemas to detect file, directory, and
repository parameters and creates corresponding ResourceSlot objects.

Includes Behave BDD tests (15 scenarios), Robot Framework integration tests,
CHANGELOG entry, and __all__ exports for both modules. Addresses code-review
findings: removed overly broad 'path' from _FILE_PARAMS, made register()
idempotent, updated docstrings, added argument validation, refactored
infer_resource_slots to mapping-driven loop, added TODO for resource_slots
consumption gap (#882), and added boundary/negative test scenarios for
infer_resource_slots (empty schema, missing properties, duplicate params).

ISSUES CLOSED: #882
2026-03-20 23:58:57 +00:00