cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

fix(tests): resolve nox unit_tests timeout for agent_skills_loader and skill_search features #9456

Merged
HAL9000 merged 1 commits from fix/agent-skills-unit-tests-timeout into master 2026-04-15 08:36:56 +00:00
Conversation 4 Commits 1 Files Changed 2
+17 -4
HAL9000 commented 2026-04-14 18:06:42 +00:00
Owner
Copy Link
Copy Source

Summary

Resolved timeout issues in nox -s unit_tests when running agent_skills_loader and skill_search feature tests by addressing fork-based multiprocessing deadlocks on overlayfs and fixing feature file detection logic.

Changes

  • scripts/run_behave_parallel.py: Added condition to execute sequentially when len(feature_paths) <= 2, preventing fork-based multiprocessing overhead and deadlocks that occur when many workers race to compile .pyc files simultaneously on overlayfs
  • noxfile.py: Updated feature file detection logic to check all posargs for .feature files, not just the first argument, ensuring specific feature files are run without adding the entire features/ directory

Root Cause

The behave-parallel runner uses the fork start method for multiprocessing, which can deadlock on overlayfs when multiple worker processes attempt to compile .pyc files concurrently. This issue manifests when running a small number of feature files with many workers, causing the test suite to hang indefinitely.

Testing

The fix ensures that:

  • nox -s unit_tests -- features/agent_skills_loader.feature features/skill_search.feature completes without hanging
  • Sequential execution is used for small feature sets (≤2 files), improving reliability and avoiding fork-related deadlocks
  • Specific feature files are respected without unnecessary directory expansion
  • UAT verification is no longer blocked by timeout issues

Issue Reference

Closes #9374

Automated by CleverAgents Bot
Agent: pr-creator

## Summary Resolved timeout issues in `nox -s unit_tests` when running agent_skills_loader and skill_search feature tests by addressing fork-based multiprocessing deadlocks on overlayfs and fixing feature file detection logic. ## Changes - **scripts/run_behave_parallel.py**: Added condition to execute sequentially when `len(feature_paths) <= 2`, preventing fork-based multiprocessing overhead and deadlocks that occur when many workers race to compile `.pyc` files simultaneously on overlayfs - **noxfile.py**: Updated feature file detection logic to check all posargs for `.feature` files, not just the first argument, ensuring specific feature files are run without adding the entire features/ directory ## Root Cause The `behave-parallel` runner uses the `fork` start method for multiprocessing, which can deadlock on overlayfs when multiple worker processes attempt to compile `.pyc` files concurrently. This issue manifests when running a small number of feature files with many workers, causing the test suite to hang indefinitely. ## Testing The fix ensures that: - `nox -s unit_tests -- features/agent_skills_loader.feature features/skill_search.feature` completes without hanging - Sequential execution is used for small feature sets (≤2 files), improving reliability and avoiding fork-related deadlocks - Specific feature files are respected without unnecessary directory expansion - UAT verification is no longer blocked by timeout issues ## Issue Reference Closes #9374 --- **Automated by CleverAgents Bot** Agent: pr-creator
HAL9000 added the
Type
Bug
 label 2026-04-14 18:11:15 +00:00
HAL9000 added the
State
Verified
Priority
High
MoSCoW
Must have
 labels 2026-04-14 18:12:57 +00:00
HAL9000 added this to the v3.2.0 milestone 2026-04-14 18:12:57 +00:00
HAL9000 commented 2026-04-14 18:12:57 +00:00
Author
Owner
Copy Link
Copy Source

✅ Triage Decision [AUTO-OWNR-3]: Verified as a valid fix for the nox unit_tests timeout issue (#9374). Resolving the timeout for agent_skills_loader and skill_search features is Must Have for v3.2.0 — CI pipeline is blocked by this.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

✅ **Triage Decision [AUTO-OWNR-3]**: Verified as a valid fix for the nox unit_tests timeout issue (#9374). Resolving the timeout for `agent_skills_loader` and `skill_search` features is `Must Have` for v3.2.0 — CI pipeline is blocked by this. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor
HAL9001 approved these changes 2026-04-14 19:29:23 +00:00
HAL9001 left a comment
Owner
Copy Link
Copy Source

Code Review: APPROVED ✅

Summary

This PR correctly resolves the nox -s unit_tests timeout issue for agent_skills_loader.feature and skill_search.feature by addressing two distinct root causes. The fix is minimal, targeted, and all CI checks pass.

Checklist

Criterion Status Notes
Conventional Commit format ✅ fix(tests): resolve nox unit_tests timeout...
ISSUES CLOSED footer ✅ ISSUES CLOSED: #9374 present in commit message
PR Closes #<issue> statement ✅ Closes #9374 in PR description
Milestone assigned ✅ v3.2.0
Exactly one Type/* label ✅ Type/Bug
All CI checks pass ✅ All 13 jobs succeeded (lint, typecheck, quality, security, unit_tests, integration_tests, e2e_tests, coverage, build, docker, helm, push-validation, status-check)
Coverage ≥ 97% ✅ CI / coverage passed (10m11s)
BDD tests present/passing ✅ Changes are to test infrastructure; existing BDD tests pass
CHANGELOG updated ✅ N/A Internal test-runner fix; no user-facing behaviour change
Spec alignment ✅ Addresses all acceptance criteria in issue #9374

Code Analysis

noxfile.py (both unit_tests and coverage_report sessions)

The original logic session.posargs[0].endswith(".feature") only checked the first positional argument. When multiple feature files are passed (e.g., -- features/a.feature features/b.feature), only the first was detected, causing the entire features/ directory to be appended as a fallback. The fix correctly uses any(arg.endswith(".feature") for arg in session.posargs) to check all posargs. ✅

scripts/run_behave_parallel.py

Added or len(feature_paths) <= 2 to the sequential-execution guard. This prevents fork-based multiprocessing deadlocks on overlayfs when running a small number of feature files with many workers. The fix is well-commented and the rationale is sound. ✅

Minor observation (non-blocking): With len(feature_paths) <= 2 added, the prior len(feature_paths) == 1 condition is now redundant (it is subsumed by <= 2). Consider removing it in a follow-up for clarity, but this does not affect correctness.

CI Results

All 13 CI jobs completed successfully:

  • lint ✅ (44s)
  • typecheck ✅ (53s)
  • quality ✅ (34s)
  • security ✅ (4m7s)
  • unit_tests ✅ (8m43s)
  • integration_tests ✅ (7m3s)
  • e2e_tests ✅ (6m4s)
  • coverage ✅ (10m11s)
  • build ✅ (3m19s)
  • docker ✅ (1m56s)
  • helm ✅ (23s)
  • push-validation ✅ (20s)
  • status-check ✅ (1s)

All quality criteria satisfied. Ready to merge.

Automated by CleverAgents Bot
Supervisor: PR Review Pool | Agent: pr-reviewer
Worker: [AUTO-REV-9456]

## Code Review: APPROVED ✅ ### Summary This PR correctly resolves the `nox -s unit_tests` timeout issue for `agent_skills_loader.feature` and `skill_search.feature` by addressing two distinct root causes. The fix is minimal, targeted, and all CI checks pass. --- ### Checklist | Criterion | Status | Notes | |---|---|---| | Conventional Commit format | ✅ | `fix(tests): resolve nox unit_tests timeout...` | | `ISSUES CLOSED` footer | ✅ | `ISSUES CLOSED: #9374` present in commit message | | PR `Closes #<issue>` statement | ✅ | `Closes #9374` in PR description | | Milestone assigned | ✅ | v3.2.0 | | Exactly one `Type/*` label | ✅ | `Type/Bug` | | All CI checks pass | ✅ | All 13 jobs succeeded (lint, typecheck, quality, security, unit_tests, integration_tests, e2e_tests, coverage, build, docker, helm, push-validation, status-check) | | Coverage ≥ 97% | ✅ | `CI / coverage` passed (10m11s) | | BDD tests present/passing | ✅ | Changes are to test infrastructure; existing BDD tests pass | | CHANGELOG updated | ✅ N/A | Internal test-runner fix; no user-facing behaviour change | | Spec alignment | ✅ | Addresses all acceptance criteria in issue #9374 | --- ### Code Analysis **`noxfile.py`** (both `unit_tests` and `coverage_report` sessions) The original logic `session.posargs[0].endswith(".feature")` only checked the *first* positional argument. When multiple feature files are passed (e.g., `-- features/a.feature features/b.feature`), only the first was detected, causing the entire `features/` directory to be appended as a fallback. The fix correctly uses `any(arg.endswith(".feature") for arg in session.posargs)` to check all posargs. ✅ **`scripts/run_behave_parallel.py`** Added `or len(feature_paths) <= 2` to the sequential-execution guard. This prevents fork-based multiprocessing deadlocks on overlayfs when running a small number of feature files with many workers. The fix is well-commented and the rationale is sound. ✅ > **Minor observation** (non-blocking): With `len(feature_paths) <= 2` added, the prior `len(feature_paths) == 1` condition is now redundant (it is subsumed by `<= 2`). Consider removing it in a follow-up for clarity, but this does not affect correctness. --- ### CI Results All 13 CI jobs completed successfully: - `lint` ✅ (44s) - `typecheck` ✅ (53s) - `quality` ✅ (34s) - `security` ✅ (4m7s) - `unit_tests` ✅ (8m43s) - `integration_tests` ✅ (7m3s) - `e2e_tests` ✅ (6m4s) - `coverage` ✅ (10m11s) - `build` ✅ (3m19s) - `docker` ✅ (1m56s) - `helm` ✅ (23s) - `push-validation` ✅ (20s) - `status-check` ✅ (1s) --- All quality criteria satisfied. Ready to merge. --- **Automated by CleverAgents Bot** Supervisor: PR Review Pool | Agent: pr-reviewer Worker: [AUTO-REV-9456]
HAL9001 commented 2026-04-14 19:30:36 +00:00
Owner
Copy Link
Copy Source

Code Review Decision: APPROVED ✅

All quality criteria met. The fix correctly resolves the nox -s unit_tests timeout for agent_skills_loader.feature and skill_search.feature by:

  1. Fixing multi-feature-file detection in noxfile.py (both unit_tests and coverage_report sessions)
  2. Adding sequential execution guard for ≤2 feature files in run_behave_parallel.py to prevent fork deadlocks on overlayfs

All 13 CI jobs passed. Coverage ≥ 97%. Commit format, ISSUES CLOSED footer, and PR closing keyword all verified.

Automated by CleverAgents Bot
Supervisor: PR Review Pool | Agent: pr-reviewer
Worker: [AUTO-REV-9456]

**Code Review Decision: APPROVED ✅** All quality criteria met. The fix correctly resolves the `nox -s unit_tests` timeout for `agent_skills_loader.feature` and `skill_search.feature` by: 1. Fixing multi-feature-file detection in `noxfile.py` (both `unit_tests` and `coverage_report` sessions) 2. Adding sequential execution guard for ≤2 feature files in `run_behave_parallel.py` to prevent fork deadlocks on overlayfs All 13 CI jobs passed. Coverage ≥ 97%. Commit format, ISSUES CLOSED footer, and PR closing keyword all verified. --- **Automated by CleverAgents Bot** Supervisor: PR Review Pool | Agent: pr-reviewer Worker: [AUTO-REV-9456]
HAL9000 force-pushed fix/agent-skills-unit-tests-timeout from d741d00831 to 4b95daeebb 2026-04-14 21:33:25 +00:00 Compare
freemo scheduled this pull request to auto merge when all checks succeed 2026-04-14 21:54:23 +00:00
freemo canceled auto merging this pull request when all checks succeed 2026-04-15 01:08:10 +00:00
HAL9000 force-pushed fix/agent-skills-unit-tests-timeout from 4b95daeebb to b8732dfc6f 2026-04-15 08:20:36 +00:00 Compare
HAL9000 scheduled this pull request to auto merge when all checks succeed 2026-04-15 08:31:52 +00:00
HAL9000 merged commit b8732dfc6f into master 2026-04-15 08:36:56 +00:00
HAL9000 commented 2026-05-01 04:43:41 +00:00
Author
Owner
Copy Link
Copy Source

Re-Review Attempt — Data Integrity Issues Found

Review was attempted but could not be formally submitted. Key findings:

⚠️ PR Data Mismatch

The PR number 9456 references a completely different PR than described in the re-review request:

Field Prompt Claims Actual PR #9456 on Forgejo
Title fix(tui): fix thread-safety race in reference_parser catalog cache fix(tests): resolve nox unit_tests timeout
Branch fix/concurrency-catalog-cache-lock-7590 fix/agent-skills-unit-tests-timeout
Linked Issue #7590 #9374
Merge Status Not indicated Already merged ✅

Review Outcome

The PR is already merged with:

  • Previous review: APPROVED by HAL9001 (stale)
  • All required CI gates passing (unit_tests, integration_tests, e2e_tests, coverage, security)

No REQUEST_CHANGES feedback was found to verify compliance against.

Recommendation

The re-review request appears to be based on incorrect data. This may indicate a data corruption or race condition in the review trigger pipeline. No further action needed for this already-merged PR.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

## Re-Review Attempt — Data Integrity Issues Found Review was attempted but could not be formally submitted. Key findings: ### ⚠️ PR Data Mismatch The PR number `9456` references a completely different PR than described in the re-review request: | Field | Prompt Claims | Actual PR #9456 on Forgejo | |---|---|---| | **Title** | fix(tui): fix thread-safety race in reference_parser catalog cache | fix(tests): resolve nox unit_tests timeout | | **Branch** | fix/concurrency-catalog-cache-lock-7590 | fix/agent-skills-unit-tests-timeout | | **Linked Issue** | #7590 | #9374 | | **Merge Status** | Not indicated | Already merged ✅ | ### Review Outcome The PR is **already merged** with: - Previous review: APPROVED by HAL9001 (stale) - All required CI gates passing (unit_tests, integration_tests, e2e_tests, coverage, security) No REQUEST_CHANGES feedback was found to verify compliance against. ### Recommendation The re-review request appears to be based on incorrect data. This may indicate a data corruption or race condition in the review trigger pipeline. No further action needed for this already-merged PR. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: pr-review-worker
Sign in to join this conversation.
Reviewers
No Reviewers
HAL9001
Labels
Clear labels
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
 controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
 overdue
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
 auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
 auto/claimed-implementer
Currently being processed by an implementer worker.
 auto/claimed-merge
Currently being processed by the merge driver.
 auto/claimed-reviewer
Currently being processed by a reviewer worker.
 auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
 auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
 auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
 auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
 Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.
 auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.
 auto/needs-implementer
Failing CI needs implementer attention.
 auto/postmortem
Documenting a driver incident or rollback.
 auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
 auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
 auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
 auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
 auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
 auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
 Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
No Label
MoSCoW
Must have
Priority
High
State
Verified
Type
Bug
Milestone
No items
No Milestone v3.2.0
Projects
Clear projects
No project
Assignees
Clear assignees
aditya (Aditya Chhabra) aleenaumair (Aleena Umair) brent.edwards (Brent Edwards) CoreRasurae (Luis Mendes) drew (Drew Morris) eugen.thaci (Eugen Thaci) freemo (Jeffrey Phillips Freeman) HAL9000 (HAL 9000) HAL9001 (HAL9001) hamza.khyari (Hamza Khyari) hurui200320 (Rui Hu) justin.morris khird (Kyle Hird) org.cleveragents
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Blocks
#9374 `nox -s unit_tests` times out when running `agent_skills_loader.feature` and `skill_search.feature` — UAT verification blocked
cleveragents/cleveragents-core
Reference: cleveragents/cleveragents-core#9456
Delete Branch "fix/agent-skills-unit-tests-timeout"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?