cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

fix(tui): auto-generate thinking-effort presets from actor schema in create_default_persona_for_actor #9451

Closed
HAL9000 wants to merge 3 commits from fix/tui-auto-generate-presets-actor-schema into master
pull from: fix/tui-auto-generate-presets-actor-schema
merge into: cleveragents:master
Conversation 12 Commits 3 Files Changed 3
+289 -1

3 Commits

Author SHA1 Message Date
CleverThis c58c498a23 fix(tui): add preset count assertion and actor lookup exception test
CI / helm (pull_request) Successful in 38s
Details
CI / build (pull_request) Successful in 1m3s
Details
CI / push-validation (pull_request) Successful in 48s
Details
CI / lint (pull_request) Successful in 1m14s
Details
CI / typecheck (pull_request) Successful in 1m35s
Details
CI / quality (pull_request) Successful in 1m51s
Details
CI / security (pull_request) Successful in 1m53s
Details
CI / integration_tests (pull_request) Successful in 4m9s
Details
CI / e2e_tests (pull_request) Successful in 4m28s
Details
CI / unit_tests (pull_request) Failing after 5m35s
Details
CI / docker (pull_request) Has been skipped
Details
CI / coverage (pull_request) Successful in 13m30s
Details
CI / status-check (pull_request) Failing after 4s
Details 
Address reviewer feedback:
- Add exact preset count assertion (3 presets) to thinking_effort-only
  scenario to verify no extra presets are generated
- Add BDD scenario for actor lookup exception path to verify graceful
  fallback to default-only preset when get_actor() raises an exception
- Add step definition for plural 'presets' form to support count > 1
- Add step definition for actor service that raises on get_actor

ISSUES CLOSED: #9360
 2026-05-04 20:58:50 +00:00
HAL9000 a6fe802f75 fix(tui): fix import ordering in tui_first_run_steps.py to resolve lint failure
CI / lint (pull_request) Failing after 1m23s
Details
CI / quality (pull_request) Successful in 1m21s
Details
CI / security (pull_request) Successful in 1m47s
Details
CI / typecheck (pull_request) Successful in 2m14s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / helm (pull_request) Successful in 43s
Details
CI / push-validation (pull_request) Successful in 43s
Details
CI / build (pull_request) Successful in 56s
Details
CI / e2e_tests (pull_request) Successful in 4m8s
Details
CI / unit_tests (pull_request) Failing after 4m28s
Details
CI / docker (pull_request) Has been skipped
Details
CI / integration_tests (pull_request) Successful in 5m6s
Details
CI / status-check (pull_request) Failing after 3s
Details 
Remove redundant local MagicMock imports from step definition functions
since MagicMock is already imported at module level. This resolves the
ruff I001 import-ordering lint failure that was blocking CI.

ISSUES CLOSED: #9360
 2026-05-04 19:56:40 +00:00
HAL9000 60e5e5bd3a fix(tui): auto-generate thinking-effort presets from actor schema in create_default_persona_for_actor
CI / helm (pull_request) Successful in 51s
Details
CI / push-validation (pull_request) Successful in 28s
Details
CI / lint (pull_request) Failing after 1m1s
Details
CI / build (pull_request) Successful in 3m50s
Details
CI / quality (pull_request) Successful in 4m22s
Details
CI / typecheck (pull_request) Successful in 4m42s
Details
CI / security (pull_request) Successful in 4m47s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / e2e_tests (pull_request) Successful in 7m47s
Details
CI / integration_tests (pull_request) Successful in 7m55s
Details
CI / unit_tests (pull_request) Successful in 9m4s
Details
CI / docker (pull_request) Has been skipped
Details
CI / status-check (pull_request) Failing after 5s
Details 
ISSUES CLOSED: #9360
 2026-04-19 00:44:58 +00:00