chore(agents): add CONTRIBUTING.md compliance steps to agent-evolution-worker #9439

Merged
HAL9000 merged 3 commits from chore/agent-evolution-worker-contributing-compliance into master 2026-04-25 03:28:59 +00:00
3 changed files with 37 additions and 6 deletions
+28 -5
View File
@@ -59,11 +59,34 @@ You modify one or more agent definition files and submit a PR, then exit. You do
Your prompt describes the approved proposal: what change to make, and the evidence for why. It also provides CONTRIBUTING.md rules for commits and PRs.
1. Create an isolated clone using `repo-isolator`.
2. Modify the specified file(s) in `.opencode/agents/`.
3. Make surgical, focused changes — one pattern per PR.
4. Commit using `git-commit-helper` with a Conventional Changelog message.
5. Create a PR using `pr-creator` with `needs feedback` label.
6. Clean up and exit.
2. **Pre-flight check**: Verify the change isn't already present in master (prevents duplicate PRs like #7793).
3. Modify the specified file(s) in `.opencode/agents/`.
4. Update `CHANGELOG.md` with an entry under `[Unreleased] > Changed`.
5. Make surgical, focused changes — one pattern per PR.
6. Commit using `git-commit-helper` with a Conventional Changelog message.
7. Create a PR using `pr-creator` with `needs feedback` label and `Type/Task` label. Query the earliest open milestone using the Forgejo API and assign the PR to that milestone. To find the earliest open milestone, run:
```bash
curl -s -H "Authorization: token $FORGEJO_PAT" \
"https://git.cleverthis.com/api/v1/repos/cleveragents/cleveragents-core/milestones?state=open&limit=50" \
| python3 -c "import sys,json; ms=json.load(sys.stdin); print(sorted(ms, key=lambda m: m['id'])[0]['id'])"
```
Pass the returned milestone ID to `pr-creator` as the `milestone` parameter. Never hardcode a milestone ID.
8. Apply labels via `forgejo-label-manager` (never directly).
9. Clean up and exit.
### PR Compliance Checklist
Before submitting the PR, verify **all** of the following are complete:
- [ ] Pre-flight check passed — change is not already in master
- [ ] Agent file(s) in `.opencode/agents/` modified with surgical, focused changes
- [ ] `CHANGELOG.md` updated under `[Unreleased] > Changed` describing the agent improvement
- [ ] Commit message follows Conventional Changelog format (e.g. `chore(agents): ...`)
- [ ] Commit message includes `ISSUES CLOSED: #<issue>` footer per CONTRIBUTING.md
- [ ] PR description includes a summary and `Closes #<issue>` reference
- [ ] Earliest open milestone queried dynamically via Forgejo API and assigned to the PR
- [ ] `Type/Task` label applied via `forgejo-label-manager`
- [ ] `needs feedback` label applied via `forgejo-label-manager`
## **CRITICAL** Rules
+8
View File
@@ -208,6 +208,14 @@ The format follows [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
### Changed
- **`agent-evolution-worker` CONTRIBUTING.md Compliance** (#8370): Added pre-flight
duplicate-check step, mandatory `CHANGELOG.md` update, dynamic earliest-open-milestone
assignment (queried via Forgejo API at PR creation time — no hardcoded milestone IDs),
`Type/Task` label, an explicit PR compliance checklist, a concrete `curl` example
for querying the earliest open milestone, and an `ISSUES CLOSED: #<issue>` footer
requirement to the agent-evolution-worker instructions. Prevents duplicate PRs
(e.g. #7793) and ensures all agent-evolution PRs meet project CONTRIBUTING.md requirements.
- **Decision Tree Full ULID Display** (#5825): The `agents plan tree` command now
displays full 26-character ULIDs for all decisions instead of truncating them to
8 characters. This enables users to copy decision IDs directly from tree output
+1 -1
View File
@@ -15,12 +15,12 @@ Below are some of the specific details of various contributions.
* Jeffrey Phillips Freeman has acted as Lead Developer, daily contributor, and Project Owner.
* Brent E. Edwards has contributed quality assurance, test coverage, and CI pipeline improvements.
* HAL 9000 has contributed automated implementation, bug fixes, and feature development as part of the CleverAgents automation pool.
* HAL 9000 has contributed concurrency safety improvements, including thread-safe context tier management (issue #7547) for parallel plan execution.
* HAL 9000 has contributed the plan concurrency race-condition fix (#7989): wired `LockService` into the plan lifecycle, guarding `execute_plan()` and `apply_plan()` with plan-level advisory locks and unique per-invocation owner identities to prevent silent concurrent state corruption.
* HAL 9000 has contributed the bug-hunt-pool-supervisor non-blocking tracking fix: updated step 5 to be best-effort and added rule 9 to prevent the automation-tracking-manager call from blocking the main supervisor loop.
* HAL 9000 has contributed the plugin entry point security hardening fix (#7476): enforced entry point allowlist validation before importing plugin modules to prevent malicious plugin loading.
* HAL 9000 has contributed the benchmark workflow separation (#9040): moved the benchmark-regression job out of the default PR workflow into a dedicated scheduled workflow, reducing median PR CI turnaround time from 99-132 minutes to under 30 minutes.
* HAL 9000 has contributed automated bug fixes, security improvements, and migration safety enhancements including the migration prompt safe-default fix (#7503).
* HAL 9000 has contributed CONTRIBUTING.md compliance improvements to the agent-evolution-worker (#8370): replaced hardcoded milestone references with dynamic Forgejo API queries and standardised label usage to `Type/Task`.
* This project was made possible thanks to considerable donation of time, money, and resources by CleverThis, Inc.
* HAL 9000 has contributed automated bug fixes, CLI output formatting improvements, and ongoing maintenance as part of the CleverAgents automation system.
* HAL 9000 has contributed the file edit encoding parameter fix (PR #8258 / issue #7559).