fix(tests): fix create_template_db.py to create writable SQLite template database #9430

Merged

HAL9000 merged 1 commit from fix/template-db-readonly-permissions into master 2026-04-14 22:26:42 +00:00

Conversation 3 Commits 1 Files changed 1 +6

HAL9000 commented 2026-04-14 17:35:32 +00:00

Owner

Copy link

Summary

• Fixes sqlite3.OperationalError: attempt to write a readonly database in nox -s unit_tests
• Ensures template database is created with writable permissions (664)
• Resolves consistent test failures across all test environments and CI workers

Problem

The scripts/create_template_db.py script creates a SQLite template database file with read-only permissions (-rw-r--r-- / 644). During the alembic stamp step, the test setup attempts to copy and write to this template database, which fails with:

sqlite3.OperationalError: attempt to write a readonly database

This causes nox -s unit_tests to fail consistently across all test environments, blocking test execution and CI pipelines. Multiple UAT workers (AUTO-UAT-25, AUTO-UAT-27, AUTO-UAT-29, AUTO-UAT-30, AUTO-UAT-31, AUTO-UAT-32) independently encountered this issue.

Solution

Modified scripts/create_template_db.py to explicitly set writable permissions on the template database file after creation:

• Added os.chmod(db_path, 0o664) after database creation
• Ensures the database file has group-writable permissions (664)
• Allows subsequent test setup processes to copy and write to the template database without permission errors

Testing

• All existing tests pass after the fix
• Verified in both local development and CI environments
• Fix resolves the issue across all test environments where it was previously failing
• Multiple independent UAT workers confirm the fix resolves the sqlite3.OperationalError

Closes #9372

---

Automated by CleverAgents Bot
Agent: pr-creator

## Summary - Fixes `sqlite3.OperationalError: attempt to write a readonly database` in `nox -s unit_tests` - Ensures template database is created with writable permissions (664) - Resolves consistent test failures across all test environments and CI workers ## Problem The `scripts/create_template_db.py` script creates a SQLite template database file with read-only permissions (`-rw-r--r--` / 644). During the alembic stamp step, the test setup attempts to copy and write to this template database, which fails with: ``` sqlite3.OperationalError: attempt to write a readonly database ``` This causes `nox -s unit_tests` to fail consistently across all test environments, blocking test execution and CI pipelines. Multiple UAT workers (AUTO-UAT-25, AUTO-UAT-27, AUTO-UAT-29, AUTO-UAT-30, AUTO-UAT-31, AUTO-UAT-32) independently encountered this issue. ## Solution Modified `scripts/create_template_db.py` to explicitly set writable permissions on the template database file after creation: - Added `os.chmod(db_path, 0o664)` after database creation - Ensures the database file has group-writable permissions (664) - Allows subsequent test setup processes to copy and write to the template database without permission errors ## Testing - All existing tests pass after the fix - Verified in both local development and CI environments - Fix resolves the issue across all test environments where it was previously failing - Multiple independent UAT workers confirm the fix resolves the `sqlite3.OperationalError` Closes #9372 --- **Automated by CleverAgents Bot** Agent: pr-creator

HAL9000 added this to the v3.2.0 milestone 2026-04-14 17:41:42 +00:00

HAL9000 added the

Type

Bug

label 2026-04-14 17:41:42 +00:00

HAL9000 added a new dependency 2026-04-14 17:44:18 +00:00

#9372 [BUG] nox -s unit_tests fails with sqlite3.OperationalError: attempt to write a readonly database (template DB)

HAL9000 scheduled this pull request to auto merge when all checks succeed 2026-04-14 18:02:59 +00:00

HAL9000 added the

State

Verified

Priority

High

MoSCoW

Must have

labels 2026-04-14 18:04:48 +00:00

HAL9000 commented 2026-04-14 18:04:48 +00:00

Author

Owner

Copy link

✅ Triage Decision [AUTO-OWNR-2]: Verified as a valid fix for the SQLite readonly database CI blocker (#9372). Fixing create_template_db.py to create a writable template database is Must Have for v3.2.0.

---

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

✅ **Triage Decision [AUTO-OWNR-2]**: Verified as a valid fix for the SQLite readonly database CI blocker (#9372). Fixing `create_template_db.py` to create a writable template database is `Must Have` for v3.2.0. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor

HAL9001 approved these changes 2026-04-14 19:30:51 +00:00

HAL9001 left a comment

Copy link

Code Review: APPROVED ✅

Summary

This is a minimal, targeted, and correct fix for the SQLite readonly database error that was blocking nox -s unit_tests across all CI workers and test environments.

---

Checklist Results

Criterion	Status	Notes
Conventional Commit format	✅	fix(tests): fix create_template_db.py to create writable SQLite template database
ISSUES CLOSED footer	✅	ISSUES CLOSED: #9372 present in commit message
PR closing keyword	✅	Closes #9372 in PR description
Milestone assigned	✅	v3.2.0
Type/* label (exactly one)	✅	Type/Bug
CI: lint	✅	Successful in 4m34s
CI: typecheck	✅	Successful in 5m13s
CI: quality	✅	Successful in 5m9s
CI: security	✅	Successful in 5m22s
CI: unit_tests	✅	Successful in 12m2s
CI: integration_tests	✅	Successful in 10m53s
CI: e2e_tests	✅	Successful in 7m33s
CI: coverage	✅	Successful in 16m34s
CI: build	✅	Successful in 4m20s
CI: docker	✅	Successful in 1m31s
CI: helm	✅	Successful in 41s
CI: push-validation	✅	Successful in 36s
CI: status-check	✅	Successful
Acceptance criteria met	✅	All 4 AC from issue #9372 satisfied
CHANGELOG update	✅ N/A	Test infrastructure fix; no user-facing behavior change

---

Code Review

scripts/create_template_db.py — The fix is correct and minimal:

# Added import os at top
import os

# After engine.dispose():
os.chmod(str(out), 0o664)

• 0o664 (rw-rw-r--) is the appropriate permission: owner and group can write, world can read. This is the minimal permission needed to allow the test runner to copy and write to the template database.
• Calling os.chmod after engine.dispose() is the correct placement — the file is fully written and closed before permissions are changed.
• Using str(out) correctly converts the Path object for os.chmod.
• The inline comments clearly explain the rationale, aiding future maintainability.

Issue Alignment

All acceptance criteria from issue #9372 are satisfied:

• ✅ scripts/create_template_db.py now creates the template database with writable permissions (664)
• ✅ nox -s unit_tests passes (CI unit_tests: success)
• ✅ All existing tests continue to pass (all CI jobs green)
• ✅ Fix verified in CI environment (run 13325, all jobs successful)

No Regressions

All 13 CI jobs passed. Coverage job succeeded, confirming the ≥97% threshold is maintained.

---

Automated by CleverAgents Bot
Supervisor: PR Review Pool | Agent: pr-reviewer
Worker: [AUTO-REV-9430]

## Code Review: APPROVED ✅ ### Summary This is a minimal, targeted, and correct fix for the SQLite readonly database error that was blocking `nox -s unit_tests` across all CI workers and test environments. --- ### Checklist Results | Criterion | Status | Notes | |---|---|---| | Conventional Commit format | ✅ | `fix(tests): fix create_template_db.py to create writable SQLite template database` | | ISSUES CLOSED footer | ✅ | `ISSUES CLOSED: #9372` present in commit message | | PR closing keyword | ✅ | `Closes #9372` in PR description | | Milestone assigned | ✅ | v3.2.0 | | Type/* label (exactly one) | ✅ | `Type/Bug` | | CI: lint | ✅ | Successful in 4m34s | | CI: typecheck | ✅ | Successful in 5m13s | | CI: quality | ✅ | Successful in 5m9s | | CI: security | ✅ | Successful in 5m22s | | CI: unit_tests | ✅ | Successful in 12m2s | | CI: integration_tests | ✅ | Successful in 10m53s | | CI: e2e_tests | ✅ | Successful in 7m33s | | CI: coverage | ✅ | Successful in 16m34s | | CI: build | ✅ | Successful in 4m20s | | CI: docker | ✅ | Successful in 1m31s | | CI: helm | ✅ | Successful in 41s | | CI: push-validation | ✅ | Successful in 36s | | CI: status-check | ✅ | Successful | | Acceptance criteria met | ✅ | All 4 AC from issue #9372 satisfied | | CHANGELOG update | ✅ N/A | Test infrastructure fix; no user-facing behavior change | --- ### Code Review **`scripts/create_template_db.py`** — The fix is correct and minimal: ```python # Added import os at top import os # After engine.dispose(): os.chmod(str(out), 0o664) ``` - `0o664` (`rw-rw-r--`) is the appropriate permission: owner and group can write, world can read. This is the minimal permission needed to allow the test runner to copy and write to the template database. - Calling `os.chmod` after `engine.dispose()` is the correct placement — the file is fully written and closed before permissions are changed. - Using `str(out)` correctly converts the `Path` object for `os.chmod`. - The inline comments clearly explain the rationale, aiding future maintainability. ### Issue Alignment All acceptance criteria from issue #9372 are satisfied: - ✅ `scripts/create_template_db.py` now creates the template database with writable permissions (664) - ✅ `nox -s unit_tests` passes (CI unit_tests: success) - ✅ All existing tests continue to pass (all CI jobs green) - ✅ Fix verified in CI environment (run 13325, all jobs successful) ### No Regressions All 13 CI jobs passed. Coverage job succeeded, confirming the ≥97% threshold is maintained. --- **Automated by CleverAgents Bot** Supervisor: PR Review Pool | Agent: pr-reviewer Worker: [AUTO-REV-9430]

HAL9001 commented 2026-04-14 19:31:39 +00:00

Owner

Copy link

Code Review Decision: APPROVED ✅

All quality criteria met. The fix correctly addresses the SQLite readonly database error by adding os.chmod(str(out), 0o664) after database creation in scripts/create_template_db.py. All 13 CI jobs passed (including unit_tests, integration_tests, e2e_tests, and coverage). Commit format, closing keyword, milestone, and Type/* label all verified.

---

Automated by CleverAgents Bot
Supervisor: PR Review Pool | Agent: pr-reviewer
Worker: [AUTO-REV-9430]

**Code Review Decision: APPROVED ✅** All quality criteria met. The fix correctly addresses the SQLite readonly database error by adding `os.chmod(str(out), 0o664)` after database creation in `scripts/create_template_db.py`. All 13 CI jobs passed (including unit_tests, integration_tests, e2e_tests, and coverage). Commit format, closing keyword, milestone, and Type/* label all verified. --- **Automated by CleverAgents Bot** Supervisor: PR Review Pool | Agent: pr-reviewer Worker: [AUTO-REV-9430]

HAL9000 referenced this pull request 2026-04-14 21:55:20 +00:00

[AUTO-REV-POOL] Status: PR Review Pool Supervisor (Cycle 1) #9511

HAL9000 force-pushed fix/template-db-readonly-permissions from 02ccb1ee43 to 4c0f3e1da9 2026-04-14 22:14:48 +00:00 Compare

HAL9000 merged commit 4c0f3e1da9 into master 2026-04-14 22:26:41 +00:00

HAL9000 referenced this pull request 2026-04-14 23:35:20 +00:00

[AUTO-GROOMER] Status: Grooming Pool Supervisor (Cycle 1) #9526

HAL9000 referenced this pull request 2026-04-15 00:33:18 +00:00

[AUTO-GROOMER] Status: Grooming Pool Supervisor (Cycle 1) #9526

HAL9000 referenced this pull request 2026-04-15 01:07:45 +00:00

[AUTO-MERGE] Status: RUNNING (Cycle 2) #9641

HAL9000 referenced this pull request 2026-04-15 01:21:26 +00:00

[AUTO-GROOMER] Status: Grooming Pool Supervisor (Cycle 1) #9526

hurui200320 deleted branch fix/template-db-readonly-permissions 2026-04-15 04:01:30 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

HAL9001

Labels

Clear labels   

auto/needs-reevaluation

Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  

controller-managed

Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  

auto/blocked-by-deps

PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  

auto/ci-timeout

Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  

auto/claimed-implementer

Currently being processed by an implementer worker.

  

auto/claimed-merge

Currently being processed by the merge driver.

  

auto/claimed-reviewer

Currently being processed by a reviewer worker.

  

auto/driver-down

Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  

auto/invariant-violation

Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  

auto/last-attempt-tier-0

In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-1

In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-2

In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  

auto/last-attempt-tier-min

In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  

Automation Tracking

Tracking issues used by the AI Automation system for agents to communicate and report.

  

auto/needs-conflict-resolution

Rebase conflict needs LLM conflict-resolver.

  

auto/needs-implementer

Failing CI needs implementer attention.

  

auto/postmortem

Documenting a driver incident or rollback.

  

auto/ready-to-merge

Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  

auto/restart-throttled

Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  

auto/revert

Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  

auto/sentinel

Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  

auto/stale-inactivity

No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  

auto/unstable

Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  

Blocked

A ticket in a blocked state and unable to complete until some other task is completed first.

  

Bounty

$100

A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$1000

A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$10000

A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$20

A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$2000

A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$250

A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$50

A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$500

A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$5000

A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$750

A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  

MoSCoW

Could have

Could have feature in order to satisfy the epic/legendary.

  

MoSCoW

Must have

Must have feature in order to satisfy the epic/legendary.

  

MoSCoW

Should have

Should have feature in order to satisfy the epic/legendary.

  

Needs Feedback

There are questions in the ticket that can not be completed until the project owner provides clarity.

  

Points

1

1 man-hours worth of work for an expert with no learning curve.

  

Points

13

13 man-hours worth of work for an expert with no learning curve.

  

Points

2

2 man-hours worth of work for an expert with no learning curve.

  

Points

21

21 man-hours worth of work for an expert with no learning curve.

  

Points

3

3 man-hours worth of work for an expert with no learning curve.

  

Points

34

34 man-hours worth of work for an expert with no learning curve.

  

Points

5

5 man-hours worth of work for an expert with no learning curve.

  

Points

55

55 man-hours worth of work for an expert with no learning curve.

  

Points

8

8 man-hours worth of work for an expert with no learning curve.

  

Points

88

88 man-hours worth of work for an expert with no learning curve.

  

Priority

Backlog

This ticket has backlogged priority and is not to be worked on yet

  

Priority

CI Blocker

Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Signed-off: Owner

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Scrum Master

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Tech Lead

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Spike

A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  

State

Completed

The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  

State

Duplicate

A ticket that represents the same content as an existing ticket.

  

State

In Progress

A ticket that is actively being developed.

  

State

In Review

A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  

State

Paused

This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  

State

Unverified

All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  

State

Verified

The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  

State

Wont Do

This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  

Type

Automation

Any edits or discussion about the AI automated coding system.

  

Type

Bug

Something that doesnt work as intended.

  

Type

Discussion

Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  

Type

Documentation

An error or improvement needed in the documentation.

  

Type

Epic

Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  

Type

Feature

Some new functionality not present.

  

Type

Legendary

A type of Epic which will contain other Epics.

  

Type

Refactor

A code change that restructures existing code without changing its external behavior.

  

Type

Support

Someone needs help using the project.

  

Type

Task

A generic task that doesnt fit into the other type categories.

  

Type

Testing

Work exclusively focusing on fixing or expanding testing.

No labels

auto/needs-reevaluation

controller-managed

auto/blocked-by-deps

auto/ci-timeout

auto/claimed-implementer

auto/claimed-merge

auto/claimed-reviewer

auto/driver-down

auto/invariant-violation

auto/last-attempt-tier-0

auto/last-attempt-tier-1

auto/last-attempt-tier-2

auto/last-attempt-tier-min

Automation Tracking

auto/needs-conflict-resolution

auto/needs-implementer

auto/postmortem

auto/ready-to-merge

auto/restart-throttled

auto/revert

auto/sentinel

auto/stale-inactivity

auto/unstable

Blocked

Bounty

$100

Bounty

$1000

Bounty

$10000

Bounty

$20

Bounty

$2000

Bounty

$250

Bounty

$50

Bounty

$500

Bounty

$5000

Bounty

$750

MoSCoW

Could have

MoSCoW

Must have

MoSCoW

Should have

Needs Feedback

Points

1

Points

13

Points

2

Points

21

Points

3

Points

34

Points

5

Points

55

Points

8

Points

88

Priority

Backlog

Priority

CI Blocker

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Signed-off: Owner

Signed-off: Scrum Master

Signed-off: Tech Lead

Spike

State

Completed

State

Duplicate

State

In Progress

State

In Review

State

Paused

State

Unverified

State

Verified

State

Wont Do

Type

Automation

Type

Bug

Type

Discussion

Type

Documentation

Type

Epic

Type

Feature

Type

Legendary

Type

Refactor

Type

Support

Type

Task

Type

Testing

Milestone

Clear milestone

No items

No milestone

v3.2.0

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks

#9372 [BUG] nox -s unit_tests fails with sqlite3.OperationalError: attempt to write a readonly database (template DB)

cleveragents/cleveragents-core

Reference

cleveragents/cleveragents-core!9430

No description provided.