fix(test): remove expected_rc bypass mechanism from common E2E resource #909

Merged
freemo merged 3 commits from fix/e2e-remove-rc-bypass into master 2026-03-14 03:50:52 +00:00
Owner

Summary

Fixes #899

  • Removed the IF expected_rc != None guard around the return code assertion in Run CleverAgents Command
  • The RC assertion now executes unconditionally — callers can still specify expected_rc=${1} for expected failures, but cannot pass expected_rc=None to skip verification entirely
  • This closes the latent bypass mechanism that could be reintroduced by future test authors after the E2E cleanup (Epic #739)

Part of Epic #892.

## Summary Fixes #899 - Removed the `IF expected_rc != None` guard around the return code assertion in `Run CleverAgents Command` - The RC assertion now executes unconditionally — callers can still specify `expected_rc=${1}` for expected failures, but cannot pass `expected_rc=None` to skip verification entirely - This closes the latent bypass mechanism that could be reintroduced by future test authors after the E2E cleanup (Epic #739) Part of Epic #892.
freemo scheduled this pull request to auto merge when all checks succeed 2026-03-14 03:05:42 +00:00
freemo force-pushed fix/e2e-remove-rc-bypass from 3416c39a05 to 8c9d9c8c33 2026-03-14 03:45:20 +00:00 Compare
freemo merged commit 8c9d9c8c33 into master 2026-03-14 03:50:52 +00:00
freemo deleted branch fix/e2e-remove-rc-bypass 2026-03-14 03:50:53 +00:00
Sign in to join this conversation.
No Reviewers
No Label
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cleveragents/cleveragents-core#909