fix(test): fix tolerant exit code and missing RC check in resource CLI test #907

Merged

freemo merged 1 commit from fix/integration-resource-cli-tolerant-rc into master 2026-03-14 19:55:33 +00:00

Conversation 1 Commits 1 Files changed 2 +75 -4

freemo commented 2026-03-13 23:55:01 +00:00

Owner

Copy link

Summary

Fixes #896

• Changed resource type list exit code check from rc == 0 or rc == 1 to strict rc == 0 — the test should fail if the command returns an error
• Added return code assertion to Suite Setup database schema creation — if schema creation fails, all subsequent tests would pass for wrong reasons
• Broadened exception handling in all 14 resource CLI command handlers (resource.py) with except Exception catch-all blocks so unhandled exceptions produce a clean "Unexpected error" message and Aborted! exit instead of raw tracebacks
• Added isinstance guard to re-raise typer.Abort and typer.Exit in the catch-all handlers — these are subclasses of Exception (via click.exceptions) and must propagate normally for typer's exit machinery to work
• Replaced Unicode arrow characters (→) with ASCII (->) in resource_stop and resource_rebuild docstrings to avoid encoding issues

Part of Epic #892.

## Summary Fixes #896 - Changed `resource type list` exit code check from `rc == 0 or rc == 1` to strict `rc == 0` — the test should fail if the command returns an error - Added return code assertion to Suite Setup database schema creation — if schema creation fails, all subsequent tests would pass for wrong reasons - Broadened exception handling in all 14 resource CLI command handlers (`resource.py`) with `except Exception` catch-all blocks so unhandled exceptions produce a clean "Unexpected error" message and `Aborted!` exit instead of raw tracebacks - Added `isinstance` guard to re-raise `typer.Abort` and `typer.Exit` in the catch-all handlers — these are subclasses of `Exception` (via `click.exceptions`) and must propagate normally for typer's exit machinery to work - Replaced Unicode arrow characters (`→`) with ASCII (`->`) in `resource_stop` and `resource_rebuild` docstrings to avoid encoding issues Part of Epic #892.

freemo force-pushed fix/integration-resource-cli-tolerant-rc from 9f86ea4e66 to f2b8580e15 2026-03-13 23:56:20 +00:00 Compare

freemo force-pushed fix/integration-resource-cli-tolerant-rc from c3a153f2df to e580f57b60 2026-03-14 03:04:35 +00:00 Compare

freemo scheduled this pull request to auto merge when all checks succeed 2026-03-14 03:04:47 +00:00

freemo added the

MoSCoW

Must have

Priority

Critical

State

In Review

Type

Testing

labels 2026-03-14 04:34:35 +00:00

freemo added this to the v3.2.0 milestone 2026-03-14 04:34:40 +00:00

freemo commented 2026-03-14 04:39:53 +00:00

Author

Owner

Copy link

PM Review — Day 34

Status: Mergeable, 0 reviews, Priority/Critical, M3 (v3.2.0)
Fixes: #896 (assigned to @brent.edwards) | Part of: Epic #892

Review Summary

The Robot Framework test changes are correct and well-scoped:

• Suite Setup RC assertion: Previously the DB schema creation result was discarded — schema failures would silently let all downstream tests pass against a broken database. Now fails fast. ✓
• Strict RC check: rc == 0 or rc == 1 → rc == 0. Eliminates masking of real CLI errors. ✓

Scope Concern

The third commit (e580f57) adds 14 catch-all except Exception handlers to src/cleveragents/cli/commands/resource.py — production code not mentioned in the PR title or description. This is scope creep:

• The PR title says "fix(test)" but commit 3 is "fix(cli)"
• The exception handlers are reasonable (clean error UX for CLI users), but should be documented in the PR body
• Consider adding logger.exception() alongside the console print to preserve debuggability

Action Items

Who	Action	Deadline
@freemo	Update PR description to document the resource.py exception handling changes	Day 35
@brent.edwards	Review this PR — you're the assignee on parent issue #896 and the QA lead	Day 35

Labels Applied This Session

• Type/Testing, Priority/Critical, State/In Review, MoSCoW/Must have
• Milestone set to v3.2.0 (matching parent issue #896)

## PM Review — Day 34 **Status**: Mergeable, 0 reviews, Priority/Critical, M3 (v3.2.0) **Fixes**: #896 (assigned to @brent.edwards) | **Part of**: Epic #892 ### Review Summary The Robot Framework test changes are correct and well-scoped: - **Suite Setup RC assertion**: Previously the DB schema creation result was discarded — schema failures would silently let all downstream tests pass against a broken database. Now fails fast. ✓ - **Strict RC check**: `rc == 0 or rc == 1` → `rc == 0`. Eliminates masking of real CLI errors. ✓ ### Scope Concern The third commit (`e580f57`) adds 14 catch-all `except Exception` handlers to `src/cleveragents/cli/commands/resource.py` — **production code not mentioned in the PR title or description**. This is scope creep: - The PR title says "fix(test)" but commit 3 is "fix(cli)" - The exception handlers are reasonable (clean error UX for CLI users), but should be documented in the PR body - Consider adding `logger.exception()` alongside the console print to preserve debuggability ### Action Items | Who | Action | Deadline | |-----|--------|----------| | @freemo | Update PR description to document the `resource.py` exception handling changes | Day 35 | | @brent.edwards | **Review this PR** — you're the assignee on parent issue #896 and the QA lead | Day 35 | ### Labels Applied This Session - Type/Testing, Priority/Critical, State/In Review, MoSCoW/Must have - Milestone set to v3.2.0 (matching parent issue #896)

freemo force-pushed fix/integration-resource-cli-tolerant-rc from 4121521893 to a76166909f 2026-03-14 16:09:13 +00:00 Compare

freemo added a new dependency 2026-03-14 18:12:30 +00:00

#896 fix(test): fix tolerant exit code and missing RC check in resource CLI test

freemo force-pushed fix/integration-resource-cli-tolerant-rc from a76166909f to 2e3c48071b 2026-03-14 19:46:05 +00:00 Compare

freemo force-pushed fix/integration-resource-cli-tolerant-rc from 2e3c48071b to ec450e9085 2026-03-14 19:48:46 +00:00 Compare

freemo merged commit ec450e9085 into master 2026-03-14 19:55:33 +00:00

freemo deleted branch fix/integration-resource-cli-tolerant-rc 2026-03-14 19:55:33 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

auto/needs-reevaluation

Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  

controller-managed

Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  

auto/blocked-by-deps

PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  

auto/ci-timeout

Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  

auto/claimed-implementer

Currently being processed by an implementer worker.

  

auto/claimed-merge

Currently being processed by the merge driver.

  

auto/claimed-reviewer

Currently being processed by a reviewer worker.

  

auto/driver-down

Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  

auto/invariant-violation

Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  

auto/last-attempt-tier-0

In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-1

In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-2

In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  

auto/last-attempt-tier-min

In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  

Automation Tracking

Tracking issues used by the AI Automation system for agents to communicate and report.

  

auto/needs-conflict-resolution

Rebase conflict needs LLM conflict-resolver.

  

auto/needs-implementer

Failing CI needs implementer attention.

  

auto/postmortem

Documenting a driver incident or rollback.

  

auto/ready-to-merge

Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  

auto/restart-throttled

Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  

auto/revert

Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  

auto/sentinel

Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  

auto/stale-inactivity

No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  

auto/unstable

Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  

Blocked

A ticket in a blocked state and unable to complete until some other task is completed first.

  

Bounty

$100

A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$1000

A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$10000

A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$20

A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$2000

A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$250

A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$50

A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$500

A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$5000

A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$750

A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  

MoSCoW

Could have

Could have feature in order to satisfy the epic/legendary.

  

MoSCoW

Must have

Must have feature in order to satisfy the epic/legendary.

  

MoSCoW

Should have

Should have feature in order to satisfy the epic/legendary.

  

Needs Feedback

There are questions in the ticket that can not be completed until the project owner provides clarity.

  

Points

1

1 man-hours worth of work for an expert with no learning curve.

  

Points

13

13 man-hours worth of work for an expert with no learning curve.

  

Points

2

2 man-hours worth of work for an expert with no learning curve.

  

Points

21

21 man-hours worth of work for an expert with no learning curve.

  

Points

3

3 man-hours worth of work for an expert with no learning curve.

  

Points

34

34 man-hours worth of work for an expert with no learning curve.

  

Points

5

5 man-hours worth of work for an expert with no learning curve.

  

Points

55

55 man-hours worth of work for an expert with no learning curve.

  

Points

8

8 man-hours worth of work for an expert with no learning curve.

  

Points

88

88 man-hours worth of work for an expert with no learning curve.

  

Priority

Backlog

This ticket has backlogged priority and is not to be worked on yet

  

Priority

CI Blocker

Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Signed-off: Owner

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Scrum Master

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Tech Lead

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Spike

A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  

State

Completed

The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  

State

Duplicate

A ticket that represents the same content as an existing ticket.

  

State

In Progress

A ticket that is actively being developed.

  

State

In Review

A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  

State

Paused

This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  

State

Unverified

All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  

State

Verified

The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  

State

Wont Do

This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  

Type

Automation

Any edits or discussion about the AI automated coding system.

  

Type

Bug

Something that doesnt work as intended.

  

Type

Discussion

Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  

Type

Documentation

An error or improvement needed in the documentation.

  

Type

Epic

Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  

Type

Feature

Some new functionality not present.

  

Type

Legendary

A type of Epic which will contain other Epics.

  

Type

Refactor

A code change that restructures existing code without changing its external behavior.

  

Type

Support

Someone needs help using the project.

  

Type

Task

A generic task that doesnt fit into the other type categories.

  

Type

Testing

Work exclusively focusing on fixing or expanding testing.

No labels

auto/needs-reevaluation

controller-managed

auto/blocked-by-deps

auto/ci-timeout

auto/claimed-implementer

auto/claimed-merge

auto/claimed-reviewer

auto/driver-down

auto/invariant-violation

auto/last-attempt-tier-0

auto/last-attempt-tier-1

auto/last-attempt-tier-2

auto/last-attempt-tier-min

Automation Tracking

auto/needs-conflict-resolution

auto/needs-implementer

auto/postmortem

auto/ready-to-merge

auto/restart-throttled

auto/revert

auto/sentinel

auto/stale-inactivity

auto/unstable

Blocked

Bounty

$100

Bounty

$1000

Bounty

$10000

Bounty

$20

Bounty

$2000

Bounty

$250

Bounty

$50

Bounty

$500

Bounty

$5000

Bounty

$750

MoSCoW

Could have

MoSCoW

Must have

MoSCoW

Should have

Needs Feedback

Points

1

Points

13

Points

2

Points

21

Points

3

Points

34

Points

5

Points

55

Points

8

Points

88

Priority

Backlog

Priority

CI Blocker

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Signed-off: Owner

Signed-off: Scrum Master

Signed-off: Tech Lead

Spike

State

Completed

State

Duplicate

State

In Progress

State

In Review

State

Paused

State

Unverified

State

Verified

State

Wont Do

Type

Automation

Type

Bug

Type

Discussion

Type

Documentation

Type

Epic

Type

Feature

Type

Legendary

Type

Refactor

Type

Support

Type

Task

Type

Testing

Milestone

Clear milestone

No items

No milestone

v3.2.0

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks

#896 fix(test): fix tolerant exit code and missing RC check in resource CLI test

cleveragents/cleveragents-core

Reference

cleveragents/cleveragents-core!907

No description provided.