Build: Added back the benchmark tests but made them so they only run after pull requests into master #9004

Closed
freemo wants to merge 1 commit from benchmark-ci into master
Owner
No description provided.
Build: Added back the benchmark tests but made them so they only run after pull requests into master
All checks were successful
CI / lint (pull_request) Successful in 27s
CI / build (pull_request) Successful in 27s
CI / helm (pull_request) Successful in 25s
CI / typecheck (pull_request) Successful in 54s
CI / quality (pull_request) Successful in 56s
CI / security (pull_request) Successful in 1m1s
CI / push-validation (pull_request) Successful in 39s
CI / e2e_tests (pull_request) Successful in 4m15s
CI / integration_tests (pull_request) Successful in 4m19s
CI / unit_tests (pull_request) Successful in 5m24s
CI / docker (pull_request) Successful in 1m17s
CI / coverage (pull_request) Successful in 10m49s
CI / status-check (pull_request) Successful in 1s
d5ab9fc53e
freemo scheduled this pull request to auto merge when all checks succeed 2026-04-14 05:02:32 +00:00
HAL9000 added this to the v3.2.0 milestone 2026-04-14 05:23:38 +00:00
Owner

Thank you for this contribution, @freemo.

This PR has been received and logged. Based on the title, the bot understands this change to involve the following:

  • Benchmark tests have been re-added to the CI pipeline after a prior removal.
  • The benchmark tests are now gated so they only execute when a pull request targets the master branch, preventing unnecessary benchmark runs on feature or development branch PRs.

This is a CI/build infrastructure improvement that reduces noise in the pipeline while preserving benchmark coverage at the point of integration.

Action requested: The PR body is currently empty. Please consider adding a brief description to help reviewers understand the scope of the change, which workflow files were modified, and any relevant context (e.g., why the benchmarks were previously removed, what triggered the re-addition). This will expedite the review process.

Triage applied:

  • Labels: Type/Testing, Priority/Medium, State/In Review, MoSCoW/Should have
  • Milestone: v3.2.0 (current active milestone)

The automated review pipeline will assess this PR in due course.


Automated by CleverAgents Bot
Supervisor: Human Liaison | Agent: human-liaison-pool-supervisor
Worker: [AUTO-HUMAN-1]

Thank you for this contribution, @freemo. This PR has been received and logged. Based on the title, the bot understands this change to involve the following: - Benchmark tests have been re-added to the CI pipeline after a prior removal. - The benchmark tests are now gated so they only execute when a pull request targets the `master` branch, preventing unnecessary benchmark runs on feature or development branch PRs. This is a CI/build infrastructure improvement that reduces noise in the pipeline while preserving benchmark coverage at the point of integration. **Action requested:** The PR body is currently empty. Please consider adding a brief description to help reviewers understand the scope of the change, which workflow files were modified, and any relevant context (e.g., why the benchmarks were previously removed, what triggered the re-addition). This will expedite the review process. **Triage applied:** - Labels: `Type/Testing`, `Priority/Medium`, `State/In Review`, `MoSCoW/Should have` - Milestone: `v3.2.0` (current active milestone) The automated review pipeline will assess this PR in due course. --- **Automated by CleverAgents Bot** Supervisor: Human Liaison | Agent: human-liaison-pool-supervisor Worker: [AUTO-HUMAN-1]
Owner

Summary:

  • Discovered that the PR is missing a description and a linked issue reference required by CONTRIBUTING.

Actions Taken:

  • Applied State/In Review, Priority/Medium, Type/Testing, and MoSCoW/Should have labels to categorize the PR.

Requests:

  • Please update the PR description with a clear summary of the changes and how benchmarks are exercised.
  • Please link the corresponding issue (e.g., reference it in the description) so we can trace the work item.

Automated by CleverAgents Bot
Supervisor: Grooming | Agent: grooming-pool-supervisor

Summary: - Discovered that the PR is missing a description and a linked issue reference required by CONTRIBUTING. Actions Taken: - Applied State/In Review, Priority/Medium, Type/Testing, and MoSCoW/Should have labels to categorize the PR. Requests: - Please update the PR description with a clear summary of the changes and how benchmarks are exercised. - Please link the corresponding issue (e.g., reference it in the description) so we can trace the work item. --- **Automated by CleverAgents Bot** Supervisor: Grooming | Agent: grooming-pool-supervisor ---
Owner

[GROOMED]


Automated by CleverAgents Bot
Supervisor: Grooming | Agent: grooming-pool-supervisor

[GROOMED] --- **Automated by CleverAgents Bot** Supervisor: Grooming | Agent: grooming-pool-supervisor ---
HAL9001 left a comment

Code Review: REQUEST CHANGES

Thank you for this CI infrastructure improvement, @freemo. The benchmark workflow addition is a good idea, but this PR has several blocking issues that must be resolved before it can be merged.


Passing Criteria

Check Status
CI / lint Passed
CI / typecheck Passed
CI / security Passed
CI / quality Passed
CI / unit_tests Passed
CI / integration_tests Passed
CI / e2e_tests Passed
CI / build Passed
CI / helm Passed
CI / docker Passed
CI / coverage Passed
CI / push-validation Passed
CI / status-check Passed
Milestone assigned (v3.2.0) Present
Exactly one Type/ label (Type/Testing) Present

Blocking Issues

The commit message is:

Build: Added back the benchmark tests but made them so they only run after pull requests into master

It is missing the required ISSUES CLOSED: #N footer as mandated by CONTRIBUTING.md. Please amend the commit to include the footer referencing the relevant issue number.

2. PR body is empty — no linked issue / closing keyword

The PR description is completely empty. CONTRIBUTING.md requires:

  • A description of the change
  • A closing keyword (e.g., Closes #NNNN) linking to the relevant issue

Please update the PR body with a description and a Closes #NNNN reference.

3. CHANGELOG.md not updated

Only .forgejo/workflows/master.yml was changed. CHANGELOG.md must be updated to document this CI infrastructure change.

4. CONTRIBUTORS.md not updated

CONTRIBUTORS.md must be updated as required by CONTRIBUTING.md.


⚠️ Workflow Logic Bugs

The new workflow file has two significant logic errors:

Bug 1 — Dead job condition: The benchmark-regression job has:

if: forgejo.event_name == 'pull_request'

However, the workflow trigger is:

on:
    push:
        branches: [master, develop]

This workflow only fires on push events, so forgejo.event_name will always be push — the benchmark-regression job will never execute. To run on pull requests, the trigger must include pull_request: as an event.

Bug 2 — Missing job dependencies: The benchmark-regression job declares:

needs: [lint, typecheck, security, quality]

But none of those jobs (lint, typecheck, security, quality) are defined in this workflow file. This would cause the workflow to fail immediately if it ever ran.

Please fix both bugs — either add a pull_request: trigger and define the prerequisite jobs, or remove the needs: block and adjust the trigger accordingly.


Summary

Requirement Status
All CI checks pass
Coverage >= 97% (CI coverage job passed)
Commit has ISSUES CLOSED: #N footer Missing
PR closes a linked issue Missing
Milestone assigned
Exactly one Type/ label
CHANGELOG.md updated Missing
CONTRIBUTORS.md updated Missing
Workflow logic correct Two bugs found

4 blocking process violations + 2 workflow logic bugs must be resolved before this PR can be approved.


Automated by CleverAgents Bot
Supervisor: PR Review Pool | Agent: pr-reviewer
Worker: [AUTO-REV-9004]

## Code Review: REQUEST CHANGES Thank you for this CI infrastructure improvement, @freemo. The benchmark workflow addition is a good idea, but this PR has several blocking issues that must be resolved before it can be merged. --- ### ✅ Passing Criteria | Check | Status | |---|---| | CI / lint | ✅ Passed | | CI / typecheck | ✅ Passed | | CI / security | ✅ Passed | | CI / quality | ✅ Passed | | CI / unit_tests | ✅ Passed | | CI / integration_tests | ✅ Passed | | CI / e2e_tests | ✅ Passed | | CI / build | ✅ Passed | | CI / helm | ✅ Passed | | CI / docker | ✅ Passed | | CI / coverage | ✅ Passed | | CI / push-validation | ✅ Passed | | CI / status-check | ✅ Passed | | Milestone assigned (v3.2.0) | ✅ Present | | Exactly one Type/ label (Type/Testing) | ✅ Present | --- ### ❌ Blocking Issues #### 1. Missing `ISSUES CLOSED: #N` commit footer The commit message is: ``` Build: Added back the benchmark tests but made them so they only run after pull requests into master ``` It is missing the required `ISSUES CLOSED: #N` footer as mandated by CONTRIBUTING.md. Please amend the commit to include the footer referencing the relevant issue number. #### 2. PR body is empty — no linked issue / closing keyword The PR description is completely empty. CONTRIBUTING.md requires: - A description of the change - A closing keyword (e.g., `Closes #NNNN`) linking to the relevant issue Please update the PR body with a description and a `Closes #NNNN` reference. #### 3. CHANGELOG.md not updated Only `.forgejo/workflows/master.yml` was changed. CHANGELOG.md must be updated to document this CI infrastructure change. #### 4. CONTRIBUTORS.md not updated CONTRIBUTORS.md must be updated as required by CONTRIBUTING.md. --- ### ⚠️ Workflow Logic Bugs The new workflow file has two significant logic errors: **Bug 1 — Dead job condition:** The `benchmark-regression` job has: ```yaml if: forgejo.event_name == 'pull_request' ``` However, the workflow trigger is: ```yaml on: push: branches: [master, develop] ``` This workflow only fires on `push` events, so `forgejo.event_name` will always be `push` — the `benchmark-regression` job will **never execute**. To run on pull requests, the trigger must include `pull_request:` as an event. **Bug 2 — Missing job dependencies:** The `benchmark-regression` job declares: ```yaml needs: [lint, typecheck, security, quality] ``` But none of those jobs (`lint`, `typecheck`, `security`, `quality`) are defined in this workflow file. This would cause the workflow to fail immediately if it ever ran. Please fix both bugs — either add a `pull_request:` trigger and define the prerequisite jobs, or remove the `needs:` block and adjust the trigger accordingly. --- ### Summary | Requirement | Status | |---|---| | All CI checks pass | ✅ | | Coverage >= 97% | ✅ (CI coverage job passed) | | Commit has `ISSUES CLOSED: #N` footer | ❌ Missing | | PR closes a linked issue | ❌ Missing | | Milestone assigned | ✅ | | Exactly one Type/ label | ✅ | | CHANGELOG.md updated | ❌ Missing | | CONTRIBUTORS.md updated | ❌ Missing | | Workflow logic correct | ❌ Two bugs found | **4 blocking process violations + 2 workflow logic bugs must be resolved before this PR can be approved.** --- **Automated by CleverAgents Bot** Supervisor: PR Review Pool | Agent: pr-reviewer Worker: [AUTO-REV-9004]
Owner

Code Review Decision: REQUEST CHANGES

This PR has been formally reviewed and changes are required before it can be merged.

Blocking Issues (4)

  1. Missing ISSUES CLOSED: #N commit footer — The commit message lacks the required footer referencing the closed issue number.
  2. Empty PR body / no linked issue — The PR description is empty; a Closes #NNNN closing keyword is required.
  3. CHANGELOG.md not updated — This file must be updated to document the CI infrastructure change.
  4. CONTRIBUTORS.md not updated — This file must be updated per CONTRIBUTING.md requirements.

Workflow Logic Bugs (2)

  • Bug 1: benchmark-regression job has if: forgejo.event_name == 'pull_request' but the workflow only triggers on push events — the job will never run.
  • Bug 2: benchmark-regression job declares needs: [lint, typecheck, security, quality] but those jobs are not defined in this workflow file.

Passing Criteria

  • All 13 CI checks passed
  • Milestone v3.2.0 assigned
  • Exactly one Type/ label (Type/Testing)

Please address all 4 blocking process violations and 2 workflow bugs, then request a re-review.


Automated by CleverAgents Bot
Supervisor: PR Review Pool | Agent: pr-reviewer
Worker: [AUTO-REV-9004]

**Code Review Decision: REQUEST CHANGES** This PR has been formally reviewed and changes are required before it can be merged. ### Blocking Issues (4) 1. **Missing `ISSUES CLOSED: #N` commit footer** — The commit message lacks the required footer referencing the closed issue number. 2. **Empty PR body / no linked issue** — The PR description is empty; a `Closes #NNNN` closing keyword is required. 3. **CHANGELOG.md not updated** — This file must be updated to document the CI infrastructure change. 4. **CONTRIBUTORS.md not updated** — This file must be updated per CONTRIBUTING.md requirements. ### Workflow Logic Bugs (2) - **Bug 1:** `benchmark-regression` job has `if: forgejo.event_name == 'pull_request'` but the workflow only triggers on `push` events — the job will never run. - **Bug 2:** `benchmark-regression` job declares `needs: [lint, typecheck, security, quality]` but those jobs are not defined in this workflow file. ### Passing Criteria - ✅ All 13 CI checks passed - ✅ Milestone v3.2.0 assigned - ✅ Exactly one Type/ label (Type/Testing) Please address all 4 blocking process violations and 2 workflow bugs, then request a re-review. --- **Automated by CleverAgents Bot** Supervisor: PR Review Pool | Agent: pr-reviewer Worker: [AUTO-REV-9004]
Owner

@freemo — The automated review pool has completed a code review of PR #9004 and has submitted REQUEST CHANGES. The following issues must be addressed before this PR can be merged:

Blocking Process Issues (4)

  1. Missing ISSUES CLOSED: #N commit footer — The commit message must include a footer referencing the closed issue number (e.g., ISSUES CLOSED: #NNNN).
  2. Empty PR body / no linked issue — The PR description is currently empty. A Closes #NNNN closing keyword referencing the linked issue is required per CONTRIBUTING.md.
  3. CHANGELOG.md not updated — This CI infrastructure change must be documented in CHANGELOG.md.
  4. CONTRIBUTORS.md not updated — This file must be updated per CONTRIBUTING.md requirements.

Workflow Logic Bugs (2)

  1. benchmark-regression job condition mismatch — The job has if: forgejo.event_name == 'pull_request' but the workflow only triggers on push events. The job will never run as currently configured.
  2. Missing job dependencies — The benchmark-regression job declares needs: [lint, typecheck, security, quality] but those jobs are not defined in this workflow file.

What Passes

All 13 CI checks pass, milestone v3.2.0 is assigned, and the Type/Testing label is correctly set.

Please address the 4 process violations and 2 workflow bugs, then push an updated commit. The review pool will re-review once changes are pushed.


Automated by CleverAgents Bot
Supervisor: Human Liaison | Agent: human-liaison-pool-supervisor
Worker: [AUTO-HUMAN-7]

@freemo — The automated review pool has completed a code review of PR #9004 and has submitted REQUEST CHANGES. The following issues must be addressed before this PR can be merged: ### Blocking Process Issues (4) 1. **Missing `ISSUES CLOSED: #N` commit footer** — The commit message must include a footer referencing the closed issue number (e.g., `ISSUES CLOSED: #NNNN`). 2. **Empty PR body / no linked issue** — The PR description is currently empty. A `Closes #NNNN` closing keyword referencing the linked issue is required per CONTRIBUTING.md. 3. **CHANGELOG.md not updated** — This CI infrastructure change must be documented in CHANGELOG.md. 4. **CONTRIBUTORS.md not updated** — This file must be updated per CONTRIBUTING.md requirements. ### Workflow Logic Bugs (2) 1. **`benchmark-regression` job condition mismatch** — The job has `if: forgejo.event_name == 'pull_request'` but the workflow only triggers on `push` events. The job will never run as currently configured. 2. **Missing job dependencies** — The `benchmark-regression` job declares `needs: [lint, typecheck, security, quality]` but those jobs are not defined in this workflow file. ### What Passes All 13 CI checks pass, milestone v3.2.0 is assigned, and the `Type/Testing` label is correctly set. Please address the 4 process violations and 2 workflow bugs, then push an updated commit. The review pool will re-review once changes are pushed. --- **Automated by CleverAgents Bot** Supervisor: Human Liaison | Agent: human-liaison-pool-supervisor Worker: [AUTO-HUMAN-7]
freemo force-pushed benchmark-ci from d5ab9fc53e
All checks were successful
CI / lint (pull_request) Successful in 27s
CI / build (pull_request) Successful in 27s
CI / helm (pull_request) Successful in 25s
CI / typecheck (pull_request) Successful in 54s
CI / quality (pull_request) Successful in 56s
CI / security (pull_request) Successful in 1m1s
CI / push-validation (pull_request) Successful in 39s
CI / e2e_tests (pull_request) Successful in 4m15s
CI / integration_tests (pull_request) Successful in 4m19s
CI / unit_tests (pull_request) Successful in 5m24s
CI / docker (pull_request) Successful in 1m17s
CI / coverage (pull_request) Successful in 10m49s
CI / status-check (pull_request) Successful in 1s
to 201de8bbf3
All checks were successful
CI / push-validation (pull_request) Successful in 21s
CI / helm (pull_request) Successful in 23s
CI / lint (pull_request) Successful in 39s
CI / quality (pull_request) Successful in 40s
CI / typecheck (pull_request) Successful in 55s
CI / security (pull_request) Successful in 56s
CI / build (pull_request) Successful in 3m20s
CI / integration_tests (pull_request) Successful in 4m3s
CI / e2e_tests (pull_request) Successful in 7m38s
CI / unit_tests (pull_request) Successful in 8m46s
CI / docker (pull_request) Successful in 8s
CI / coverage (pull_request) Successful in 13m22s
CI / status-check (pull_request) Successful in 2s
2026-04-15 17:09:14 +00:00
Compare
Author
Owner

merged in directly

merged in directly
freemo closed this pull request 2026-04-15 17:10:01 +00:00
All checks were successful
CI / push-validation (pull_request) Successful in 21s
CI / helm (pull_request) Successful in 23s
CI / lint (pull_request) Successful in 39s
Required
Details
CI / quality (pull_request) Successful in 40s
Required
Details
CI / typecheck (pull_request) Successful in 55s
Required
Details
CI / security (pull_request) Successful in 56s
Required
Details
CI / build (pull_request) Successful in 3m20s
Required
Details
CI / integration_tests (pull_request) Successful in 4m3s
Required
Details
CI / e2e_tests (pull_request) Successful in 7m38s
CI / unit_tests (pull_request) Successful in 8m46s
Required
Details
CI / docker (pull_request) Successful in 8s
Required
Details
CI / coverage (pull_request) Successful in 13m22s
Required
Details
CI / status-check (pull_request) Successful in 2s

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core!9004
No description provided.