fix(tui): restore LoadingThrobber widget and tui_throbber integration tests #8873

Merged
HAL9000 merged 4 commits from fix/uat-tui-throbber-test-update into master 2026-04-30 21:18:44 +00:00

4 Commits

Author SHA1 Message Date
HAL9000 4351848c51 fix(tui): extract _FALLBACK_BLOCK_WIDTH constant in LoadingThrobber
CI / benchmark-publish (pull_request) Has been skipped
CI / helm (pull_request) Successful in 47s
CI / lint (pull_request) Successful in 1m8s
CI / build (pull_request) Successful in 1m4s
CI / quality (pull_request) Successful in 1m35s
CI / typecheck (pull_request) Successful in 1m47s
CI / security (pull_request) Successful in 1m48s
CI / push-validation (pull_request) Successful in 38s
CI / e2e_tests (pull_request) Successful in 5m15s
CI / integration_tests (pull_request) Successful in 5m52s
CI / unit_tests (pull_request) Successful in 10m28s
CI / docker (pull_request) Successful in 2m15s
CI / coverage (pull_request) Successful in 10m54s
CI / status-check (pull_request) Successful in 3s
CI / helm (push) Successful in 40s
CI / benchmark-publish (push) Failing after 51s
CI / build (push) Successful in 59s
CI / push-validation (push) Successful in 24s
CI / lint (push) Successful in 1m33s
CI / typecheck (push) Successful in 1m34s
CI / quality (push) Successful in 1m34s
CI / security (push) Successful in 1m50s
CI / integration_tests (push) Successful in 3m29s
CI / e2e_tests (push) Failing after 3m50s
CI / unit_tests (push) Successful in 6m8s
CI / docker (push) Successful in 1m37s
CI / coverage (push) Successful in 15m49s
CI / status-check (push) Failing after 3s
Replace magic number 30 with class constant _FALLBACK_BLOCK_WIDTH per reviewer recommendation. No functional change.

ISSUES CLOSED: #6357
2026-04-30 20:52:27 +00:00
HAL9000 90b6b2a43f fix(tui): fix Throbber Rejects Invalid Styles test indentation and add CHANGELOG entry
Use Fix Python Indentation + temp file in robot/tui_throbber.robot to correctly
reconstruct indentation stripped by Robot Framework's Catenate keyword in the
Throbber Rejects Invalid Styles test case. Add indentation_library.py to the
suite's Library imports. Add CHANGELOG.md fix entry for #6357.

ISSUES CLOSED: #6357
2026-04-30 20:52:27 +00:00
HAL9000 7be0078963 fix(tui): narrow exception handling and add test tags to throbber widget 2026-04-30 20:52:19 +00:00
HAL9000 f3ba86a520 fix(tui): restore LoadingThrobber widget and tui_throbber robot tests
The LoadingThrobber widget and its associated Robot Framework integration
tests were developed on the feat/issue-6357-tui-loading-states branch but
were never merged to master. This commit restores:

- robot/tui_throbber.robot: Integration tests for the LoadingThrobber widget
  covering show/hide cycle, style switching, and invalid style rejection
- src/cleveragents/tui/widgets/throbber.py: The LoadingThrobber implementation
  with rainbow and quotes animation styles
- src/cleveragents/tui/quotes.py: Quote loader module for the throbber
- src/cleveragents/tui/data/throbber_quotes.txt: Curated quote collection

The failing test 'Throbber Rejects Invalid Styles' in robot/tui_throbber.robot
was identified by UAT testing [AUTO-UAT-3] as failing because the production
code (LoadingThrobber) was missing from master while the test file was
expected to be present.

ISSUES CLOSED: #6357
2026-04-30 20:52:19 +00:00