cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

fix(cli): add agents validation list command to validation CLI #8667

Open
HAL9000 wants to merge 8 commits from fix/validation-list-command into master
pull from: fix/validation-list-command
merge into: cleveragents:master
Conversation 66 Commits 8 Files Changed 17
+637 -115

8 Commits

Author SHA1 Message Date
controller-ci-rerun a28ad0202e chore: re-trigger CI [controller]
CI / load-versions (pull_request) Successful in 27s
Details
CI / push-validation (pull_request) Successful in 28s
Details
CI / lint (pull_request) Successful in 51s
Details
CI / typecheck (pull_request) Successful in 1m17s
Details
CI / security (pull_request) Successful in 1m22s
Details
CI / build (pull_request) Successful in 48s
Details
CI / helm (pull_request) Successful in 51s
Details
CI / quality (pull_request) Successful in 1m29s
Details
CI / integration_tests (pull_request) Failing after 17m33s
Details
CI / unit_tests (pull_request) Failing after 17m34s
Details
CI / coverage (pull_request) Has been cancelled
Details
CI / docker (pull_request) Has been cancelled
Details
CI / status-check (pull_request) Has been cancelled
Details
2026-06-18 09:51:13 -04:00
HAL9000 96e6a9c567 fix(tests): drop removed mix_stderr kwarg from validation list CliRunner
CI / load-versions (pull_request) Successful in 17s
Details
CI / push-validation (pull_request) Successful in 40s
Details
CI / lint (pull_request) Successful in 55s
Details
CI / typecheck (pull_request) Successful in 1m12s
Details
CI / quality (pull_request) Successful in 1m32s
Details
CI / security (pull_request) Successful in 1m39s
Details
CI / build (pull_request) Successful in 42s
Details
CI / unit_tests (pull_request) Successful in 5m29s
Details
CI / helm (pull_request) Successful in 45s
Details
CI / docker (pull_request) Successful in 2m28s
Details
CI / integration_tests (pull_request) Failing after 15m20s
Details
CI / coverage (pull_request) Failing after 15m43s
Details
CI / status-check (pull_request) Has been cancelled
Details 
Click 8.2 removed the mix_stderr=False keyword argument from
CliRunner.__init__. Every CliRunner(...) call in
features/steps/validation_list_command_steps.py was passing it,
causing all 7 scenarios in features/validation_list_command.feature
to error with TypeError during the @when steps. Drop the keyword
to restore the default (which now always merges stderr into stdout,
matching what the tests previously did with mix_stderr=False = True
semantics via result.output).

ISSUES CLOSED: #8621
 2026-06-18 09:06:40 -04:00
HAL9000 9d60b424fa fix(validation): add missing @tdd_issue tag and fix JSON/YAML envelope assertions 
All 7 scenarios in validation_list_command.feature were tagged with
@tdd_issue_8621 but missing the required @tdd_issue companion tag.
validate_tdd_tags() in before_scenario raises ValueError when the
numbered tag is present without @tdd_issue, causing every scenario
to error at hook-level in behave-parallel.

Also fix the JSON and YAML Then steps: format_output() returns an
envelope dict {"data": [...], "command": "", ...} not a plain list.

ISSUES CLOSED: #8621
 2026-06-18 09:06:40 -04:00
CleverAgents Bot 51ac078c73 fix(cli): repair validation list and attach commands 2026-06-18 09:06:40 -04:00
controller-ci-rerun 5c6d39aa83 chore: re-trigger CI [controller] 2026-06-18 09:06:40 -04:00
controller-ci-rerun 621392ff2f chore: re-trigger CI [controller] 2026-06-18 09:06:40 -04:00
HAL9000 4acea435de fix(tests): update stale mock patch targets after validation helper refactor 
The PR moved `_get_tool_registry_service` from a private helper in
`validation.py` to a public `get_tool_registry_service` in
`validation_helpers.py`, re-exported into the `validation` module
namespace. All test files that patched the old private name via
`mock.patch()` raised `AttributeError` at runtime.

Updated all 14 affected files to patch the public name:
- features/steps/: 8 step files updated patch targets and direct imports
- robot/: 4 helper scripts updated patch targets
- benchmarks/: 2 benchmark files updated patch targets

Also fixed `validation_list_command_steps.py`:
- Added `patch` import
- Added proper `get_tool_registry_service` patcher in all @given steps
  so the CLI is mocked correctly during scenario execution
- Removed invalid import from non-existent `validation_app` module

ISSUES CLOSED: #8667
 2026-06-18 09:06:40 -04:00
HAL9000 7ea13cb6d6 fix(cli): add agents validation list command to validation CLI 
Add the `list` subcommand to the validation CLI command group. This fixes issue #8621 where users were unable to list registered validations through the CLI interface due to the command not being implemented and registered.

Changes:
- Added `list` command with --namespace/-n, --source/-s, and --pattern/-p (regex) filters for listing validation agents
- Extracted shared helper functions into new validation_helpers.py module
- Updated imports in validation.py to use extracted helpers instead of inline private functions
- Fixed lint and formatting issues

Testing:
- Added BDD regression test feature file (features/validation_list_command.feature) with 7 scenarios covering: empty state, rich table display, namespace/source/pattern filtering, JSON output, and YAML output modes
- Added corresponding step definitions in features/steps/validation_list_command_steps.py

ISSUES CLOSED: #8621
 2026-06-18 09:06:40 -04:00