cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

fix(cli): add agents plan start alias or update spec to reflect v3 plan use/execute commands #8661

Closed
HAL9000 wants to merge 5 commits from fix/plan-start-spec-alignment into master
pull from: fix/plan-start-spec-alignment
merge into: cleveragents:master
Conversation 42 Commits 5 Files Changed 8
+1798 -627

5 Commits

Author SHA1 Message Date
HAL9000 b71e74e0ce fix(cli,sandbox,tests): remove duplicate method definitions and scope-creep tests
CI / build (pull_request) Successful in 28s
Details
CI / helm (pull_request) Successful in 29s
Details
CI / lint (pull_request) Successful in 38s
Details
CI / quality (pull_request) Successful in 48s
Details
CI / push-validation (pull_request) Successful in 35s
Details
CI / typecheck (pull_request) Successful in 1m5s
Details
CI / security (pull_request) Successful in 1m14s
Details
CI / unit_tests (pull_request) Failing after 4m54s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / docker (pull_request) Has been skipped
Details
CI / integration_tests (pull_request) Successful in 8m10s
Details
CI / status-check (pull_request) Failing after 3s
Details 
The post-conflict-resolution merge left several methods defined twice on
the same class (F811/reportRedeclaration), where Python silently kept
the LAST definition and the failing CI runs were the visible symptom:

- PlanApplyService.correction_diff at line 1064 overrode the correct
  unit-of-work-validating implementation at line 548. The duplicate
  was a broken fallback that did not raise on missing corrections, so
  the canonical robot tests in robot/plan_correction_diff.robot failed
  all 6 scenarios.
- GitWorktreeSandbox.cleanup_stale and diff_against_head were defined
  twice each; the earlier copies are removed (the later copies use the
  more defensive _sanitise_branch_name path and are what was being
  invoked in practice).
- features/steps/agent_evolution_label_milestone_steps.py declared the
  step "it MUST mention milestone assignment" twice, raising
  AmbiguousStep at collection time and erroring all 31 features in the
  Behave unit suite. The two definitions are consolidated into a
  single context-tracking step; the prior label-assertion step records
  which section is in focus.
- plan.py called ActorRegistry.ensure_built_in_actors(), which does not
  exist on the class (reportAttributeAccessIssue); the call sat inside
  a suppress(Exception) block and was a silent no-op, so removing it
  preserves runtime behavior while resolving the pyright error.
- Lint-only: drop the stray f prefix from a non-interpolating raw
  string regex in agent_evolution_label_milestone_steps.py (F541).

The dead scope-creep tests that exercised the deleted code paths are
removed:

- features/plan_apply_correction_diff.feature and its step file: tests
  for the deleted PlanApplyService.correction_diff fallback. The
  canonical features/plan_correction_diff.feature (already on master)
  continues to cover correction_diff comprehensively against the
  unit-of-work-aware implementation.
- features/agent_evolution_label_milestone_compliance.feature and its
  step file: tests that asserted the existence and contents of
  .opencode/agents/agent-evolution-{worker,pool-supervisor}.md, files
  that do not exist anywhere in the worktree (or on master) and are
  not introduced by this PR.
- 2 Correction Diff scenarios in
  robot/git_worktree_class_methods.robot plus their helpers: tests for
  the deleted fallback impl.

ISSUES CLOSED: #8628
 2026-06-02 06:57:24 -04:00
HAL9000 4bd87f3f09 fix(cli): replace private _commit_plan calls with public save_plan API (PR #8661) 
Resolve the SOLID principle violation where CLI layer accessed private
_lifecycle._commit_plan() method directly, breaking encapsulation. All
four CLI call sites and two PlanService call sites now use the public
save_plan() method which is designed as the intended persistence interface.

ISSUES CLOSED: #8628
 2026-06-02 06:57:24 -04:00
HAL9000 a5c1b2dda4 fix(cli): resolve typecheck failures and add missing infrastructure methods 
Add GitWorktreeSandbox.cleanup_stale() and diff_against_head() class
methods, create strategy_actor module with resolve_strategy_actor(),
add PlanApplyService.correction_diff() method, and fix _get_apply_service()
and _get_plan_executor() to use correct API signatures.

Add Behave BDD unit tests and Robot Framework integration tests for all
new functionality.

ISSUES CLOSED: #8628
 2026-06-02 06:57:24 -04:00
HAL9000 7cd81a898c fix(cli): revert plan start and plan show aliases that contradict v3 spec 
Revert the 'agents plan start' and 'agents plan show' command aliases
because the v3 specification mandates 'agents plan use' and 'agents plan
status'. The spec explicitly states that the 'use' verb is the command
that transitions a plan from the Action phase into Strategize, and there
are 86 occurrences of 'plan use' in docs/specification.md with zero for
'plan start'.

The aliases diverged from the authoritative specification rather than
aligning with it, creating competing API surfaces.

ISSUES CLOSED: #8628
 2026-06-02 06:57:24 -04:00
HAL9000 a7cbc776b2 fix(cli): add agents plan start alias or update spec to reflect v3 plan use/execute commands 
- Added 'agents plan start' as an alias for 'agents plan use' to match v3 spec
- Added 'agents plan show' as an alias for 'agents plan status' to match v3 spec
- Both commands delegate to their canonical counterparts with full feature parity
- Updated module docstring to document the new aliases
- Added BDD tests for both new commands with comprehensive scenarios
- Updated CHANGELOG.md with the new feature entry
 2026-06-02 06:57:24 -04:00