fix(error-handling): _handle_file_edit() now respects encoding parameter #8258

Merged
HAL9000 merged 3 commits from fix/7559-file-edit-encoding into master 2026-04-21 09:05:40 +00:00

3 Commits

Author SHA1 Message Date
HAL9000 482eaf559b fix(error-handling): _handle_file_edit() now respects encoding parameter
CI / benchmark-regression (push) Failing after 0s
CI / benchmark-publish (push) Failing after 0s
CI / push-validation (push) Successful in 24s
CI / helm (push) Successful in 30s
CI / build (push) Successful in 3m49s
CI / lint (push) Successful in 3m56s
CI / quality (push) Successful in 4m19s
CI / typecheck (push) Successful in 4m44s
CI / security (push) Successful in 4m49s
CI / e2e_tests (push) Successful in 7m2s
CI / unit_tests (push) Successful in 8m42s
CI / docker (push) Successful in 1m37s
CI / coverage (push) Successful in 14m56s
CI / lint (pull_request) Successful in 4m17s
CI / helm (pull_request) Successful in 39s
CI / push-validation (pull_request) Successful in 36s
CI / build (pull_request) Successful in 4m8s
CI / quality (pull_request) Successful in 4m48s
CI / security (pull_request) Successful in 5m16s
CI / typecheck (pull_request) Successful in 5m18s
CI / e2e_tests (pull_request) Successful in 7m53s
CI / integration_tests (pull_request) Successful in 10m44s
CI / unit_tests (pull_request) Successful in 11m35s
CI / docker (pull_request) Successful in 1m28s
CI / coverage (pull_request) Successful in 14m47s
CI / status-check (pull_request) Successful in 3s
CI / status-check (push) Blocked by required conditions
CI / integration_tests (push) Has started running
- Update encoding scenario to use latin-1 with non-ASCII content (café → naïve)
  to properly test the encoding parameter fix
- Add CONTRIBUTORS.md entry for PR #8258 / issue #7559

ISSUES CLOSED: #7559
2026-04-21 08:45:06 +00:00
HAL9000 2e3e116b42 fix(error-handling): _handle_file_edit() now respects encoding parameter
Remove duplicate step function definition in tool_builtins_steps.py that
was shadowing the decorated @when handler, causing the Behave step to be
orphaned at runtime. Add CHANGELOG entry documenting the encoding fix for
issue #7559.

ISSUES CLOSED: #7559

# Conflicts:
#	CHANGELOG.md
2026-04-21 08:45:06 +00:00
HAL9000 fca440a62c fix(error-handling): _handle_file_edit() now respects encoding parameter
- Fixed _handle_file_edit() to use encoding=inputs.get("encoding", "utf-8") for both read_text() and write_text() calls, ensuring encoding is explicit and not dependent on the platform default.
- Added encoding field to the FILE_EDIT_SPEC schema to surface encoding choices to callers.

ISSUES CLOSED: #7559
2026-04-21 08:45:06 +00:00