fix(data-integrity): remove silent argument swap in ValidationAttachmentRepository.attach #8177

Merged
HAL9000 merged 1 commits from bugfix/7492-validation-attachment-argument-swap into master 2026-05-16 17:43:48 +00:00

1 Commits

Author SHA1 Message Date
HAL9000 531ce47704 fix(data-integrity): remove silent argument swap in ValidationAttachmentRepository.attach
CI / helm (pull_request) Successful in 44s
CI / push-validation (pull_request) Successful in 29s
CI / build (pull_request) Successful in 1m15s
CI / lint (pull_request) Successful in 1m34s
CI / quality (pull_request) Successful in 1m49s
CI / security (pull_request) Successful in 2m3s
CI / typecheck (pull_request) Successful in 2m24s
CI / integration_tests (pull_request) Successful in 4m57s
CI / unit_tests (pull_request) Successful in 10m59s
CI / docker (pull_request) Successful in 1m38s
CI / coverage (pull_request) Successful in 12m5s
CI / status-check (pull_request) Successful in 3s
Fixes a critical data integrity bug where validation_name and resource_id
arguments were being silently swapped based on a fragile heuristic when
resource_id contained '/'. This caused silent data corruption without any
error being raised.

The 3-line conditional swap block has been removed from
ValidationAttachmentRepository.attach(), ensuring arguments flow directly
from caller to the persistence layer in the correct order.
2026-05-16 13:58:23 +00:00