cleveragents/cleveragents-core
cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.1k Pull requests 489 Projects Releases Packages Wiki Activity Actions

test(e2e): E2E acceptance criteria for M1 (v3.0.0) — minimal plan execution flow #789

Closed
freemo wants to merge 1 commit from test/e2e-m1-acceptance into master
pull from: test/e2e-m1-acceptance
merge into: cleveragents:master
Conversation 2 Commits 1 Files changed 2 +139
freemo commented 2026-03-12 22:54:47 +00:00
Owner
Copy link

Summary

E2E acceptance test for M1 (v3.0.0) — minimal plan execution flow. Tests the complete plan lifecycle: init, resource registration, project creation, action creation from YAML, plan use, two-phase execute (strategize + implement), diff review, and lifecycle-apply.

Closes #741

ISSUES CLOSED: #741

Manual Verification

To manually verify the CLI commands exercised by this E2E test, run the following in a fresh temporary directory:

Prerequisites

  • OPENAI_API_KEY or GEMINI_API_KEY environment variable set
  • Git installed

Commands

# 1. Create a sample git repo as the target resource
REPO=$(mktemp -d)
cd "$REPO" && git init && git checkout -b main
echo "def greet(): return 'hello'" > main.py
git add . && git commit -m "initial commit"

# 2. Create a working directory and initialize CleverAgents
WORKDIR=$(mktemp -d) && cd "$WORKDIR"
python -m cleveragents init --yes --force

# 3. Register the git repo as a resource
python -m cleveragents resource add git-checkout "$REPO"

# 4. Create a project
python -m cleveragents project create my-project

# 5. Create an action from YAML (write a minimal action.yaml first)
cat > action.yaml << 'EOF'
name: fix-greeting
description: Fix the greeting function to return a proper message
action_type: code_modification
EOF
python -m cleveragents action create --config action.yaml

# 6. Start a plan
python -m cleveragents plan use fix-greeting
# → Look for: a plan ID in the output

# 7. Execute strategize phase
python -m cleveragents plan execute PLAN_ID
# → Look for: no Traceback, strategize completes

# 8. Execute implementation phase
python -m cleveragents plan execute PLAN_ID
# → Look for: no Traceback, execute completes

# 9. Review pending changes
python -m cleveragents plan diff PLAN_ID
# → Look for: diff output showing proposed changes

# 10. Apply changes via lifecycle
python -m cleveragents plan lifecycle-apply PLAN_ID
# → Look for: successful apply, changes committed

What to Look For

  • All commands exit without Traceback in stderr
  • plan use returns a plan ID (UUID format)
  • Both plan execute phases complete without error
  • plan diff shows pending file changes
  • plan lifecycle-apply commits changes to the target repo
  • git log in the target repo shows at least 2 commits after apply
## Summary E2E acceptance test for M1 (v3.0.0) — minimal plan execution flow. Tests the complete plan lifecycle: init, resource registration, project creation, action creation from YAML, plan use, two-phase execute (strategize + implement), diff review, and lifecycle-apply. Closes #741 ISSUES CLOSED: #741 ## Manual Verification To manually verify the CLI commands exercised by this E2E test, run the following in a fresh temporary directory: ### Prerequisites - `OPENAI_API_KEY` or `GEMINI_API_KEY` environment variable set - Git installed ### Commands ```bash # 1. Create a sample git repo as the target resource REPO=$(mktemp -d) cd "$REPO" && git init && git checkout -b main echo "def greet(): return 'hello'" > main.py git add . && git commit -m "initial commit" # 2. Create a working directory and initialize CleverAgents WORKDIR=$(mktemp -d) && cd "$WORKDIR" python -m cleveragents init --yes --force # 3. Register the git repo as a resource python -m cleveragents resource add git-checkout "$REPO" # 4. Create a project python -m cleveragents project create my-project # 5. Create an action from YAML (write a minimal action.yaml first) cat > action.yaml << 'EOF' name: fix-greeting description: Fix the greeting function to return a proper message action_type: code_modification EOF python -m cleveragents action create --config action.yaml # 6. Start a plan python -m cleveragents plan use fix-greeting # → Look for: a plan ID in the output # 7. Execute strategize phase python -m cleveragents plan execute PLAN_ID # → Look for: no Traceback, strategize completes # 8. Execute implementation phase python -m cleveragents plan execute PLAN_ID # → Look for: no Traceback, execute completes # 9. Review pending changes python -m cleveragents plan diff PLAN_ID # → Look for: diff output showing proposed changes # 10. Apply changes via lifecycle python -m cleveragents plan lifecycle-apply PLAN_ID # → Look for: successful apply, changes committed ``` ### What to Look For - All commands exit without `Traceback` in stderr - `plan use` returns a plan ID (UUID format) - Both `plan execute` phases complete without error - `plan diff` shows pending file changes - `plan lifecycle-apply` commits changes to the target repo - `git log` in the target repo shows at least 2 commits after apply
test(e2e): E2E acceptance criteria for M1 (v3.0.0) — minimal plan execution flow
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 14s
Details
CI / build (pull_request) Successful in 16s
Details
CI / quality (pull_request) Successful in 20s
Details
CI / e2e_tests (pull_request) Failing after 32s
Details
CI / security (pull_request) Successful in 35s
Details
CI / typecheck (pull_request) Successful in 39s
Details
CI / unit_tests (pull_request) Successful in 2m53s
Details
CI / docker (pull_request) Successful in 40s
Details
CI / integration_tests (pull_request) Successful in 3m43s
Details
CI / coverage (pull_request) Successful in 6m32s
Details
CI / benchmark-regression (pull_request) Successful in 36m30s
Details
0f0baaf7e7 
Added Robot Framework E2E test suite for M1 milestone acceptance criteria.
Tests the complete plan lifecycle (action create → resource add → project
create → plan use → plan execute strategize → plan execute → plan diff →
plan apply) with real LLM API keys and no mocking.

Key implementation details:
- Uses openai/gpt-4o-mini as strategy/execution actor (cost-effective)
- Simple definition_of_done: "Create a file called HELLO.md"
- Creates isolated temp git repo via Create Temp Git Repo keyword
- Extracts plan ID via ULID regex from plain-text output
- Uses expected_rc=None for LLM-dependent steps (execute, diff, apply)
  to handle non-deterministic LLM behavior gracefully
- Flexible structural assertions: checks rc, output presence, git log
- Skips gracefully when no LLM API keys (ANTHROPIC/OPENAI) are set
- Tagged [E2E] so it runs only in nox -s e2e_tests session

ISSUES CLOSED: #741
freemo added this to the v3.0.0 milestone 2026-03-12 22:54:51 +00:00
freemo force-pushed test/e2e-m1-acceptance from 0f0baaf7e7
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 14s
Details
CI / build (pull_request) Successful in 16s
Details
CI / quality (pull_request) Successful in 20s
Details
CI / e2e_tests (pull_request) Failing after 32s
Details
CI / security (pull_request) Successful in 35s
Details
CI / typecheck (pull_request) Successful in 39s
Details
CI / unit_tests (pull_request) Successful in 2m53s
Details
CI / docker (pull_request) Successful in 40s
Details
CI / integration_tests (pull_request) Successful in 3m43s
Details
CI / coverage (pull_request) Successful in 6m32s
Details
CI / benchmark-regression (pull_request) Successful in 36m30s
Details
to 9c20fb972a
Some checks failed
CI / lint (pull_request) Successful in 15s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / quality (pull_request) Successful in 18s
Details
CI / e2e_tests (pull_request) Failing after 29s
Details
CI / security (pull_request) Successful in 32s
Details
CI / typecheck (pull_request) Successful in 32s
Details
CI / build (pull_request) Successful in 15s
Details
CI / unit_tests (pull_request) Successful in 2m29s
Details
CI / integration_tests (pull_request) Successful in 2m36s
Details
CI / docker (pull_request) Successful in 1m19s
Details
CI / coverage (pull_request) Successful in 5m14s
Details
CI / benchmark-regression (pull_request) Has been cancelled
Details
2026-03-13 16:12:31 +00:00 Compare
freemo force-pushed test/e2e-m1-acceptance from 9c20fb972a
Some checks failed
CI / lint (pull_request) Successful in 15s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / quality (pull_request) Successful in 18s
Details
CI / e2e_tests (pull_request) Failing after 29s
Details
CI / security (pull_request) Successful in 32s
Details
CI / typecheck (pull_request) Successful in 32s
Details
CI / build (pull_request) Successful in 15s
Details
CI / unit_tests (pull_request) Successful in 2m29s
Details
CI / integration_tests (pull_request) Successful in 2m36s
Details
CI / docker (pull_request) Successful in 1m19s
Details
CI / coverage (pull_request) Successful in 5m14s
Details
CI / benchmark-regression (pull_request) Has been cancelled
Details
to d43cee47c6
All checks were successful
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / build (pull_request) Successful in 16s
Details
CI / lint (pull_request) Successful in 23s
Details
CI / quality (pull_request) Successful in 29s
Details
CI / typecheck (pull_request) Successful in 33s
Details
CI / security (pull_request) Successful in 34s
Details
CI / e2e_tests (pull_request) Successful in 1m1s
Details
CI / unit_tests (pull_request) Successful in 3m40s
Details
CI / integration_tests (pull_request) Successful in 4m42s
Details
CI / docker (pull_request) Successful in 38s
Details
CI / coverage (pull_request) Successful in 6m3s
Details
CI / benchmark-regression (pull_request) Successful in 34m44s
Details
2026-03-13 16:23:58 +00:00 Compare
freemo force-pushed test/e2e-m1-acceptance from d43cee47c6
All checks were successful
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / build (pull_request) Successful in 16s
Details
CI / lint (pull_request) Successful in 23s
Details
CI / quality (pull_request) Successful in 29s
Details
CI / typecheck (pull_request) Successful in 33s
Details
CI / security (pull_request) Successful in 34s
Details
CI / e2e_tests (pull_request) Successful in 1m1s
Details
CI / unit_tests (pull_request) Successful in 3m40s
Details
CI / integration_tests (pull_request) Successful in 4m42s
Details
CI / docker (pull_request) Successful in 38s
Details
CI / coverage (pull_request) Successful in 6m3s
Details
CI / benchmark-regression (pull_request) Successful in 34m44s
Details
to 0d7a06efbb
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 15s
Details
CI / build (pull_request) Successful in 17s
Details
CI / quality (pull_request) Successful in 18s
Details
CI / e2e_tests (pull_request) Failing after 25s
Details
CI / security (pull_request) Successful in 33s
Details
CI / typecheck (pull_request) Successful in 36s
Details
CI / integration_tests (pull_request) Successful in 2m53s
Details
CI / unit_tests (pull_request) Successful in 3m52s
Details
CI / docker (pull_request) Successful in 54s
Details
CI / coverage (pull_request) Successful in 6m53s
Details
CI / benchmark-regression (pull_request) Successful in 34m3s
Details
2026-03-13 23:19:26 +00:00 Compare
freemo commented 2026-03-14 04:44:23 +00:00
Author
Owner
Copy link

PM Review — Day 34

Status: NOT mergeable (conflicts), 0 reviews, M1 (v3.0.0), State/In Review
Author: @freemo

E2E acceptance criteria for M1 (v3.0.0) — minimal plan execution flow.

[BLOCKING] Merge conflicts — rebase required before review.

Action Items

Who Action Deadline
@freemo Rebase onto master Day 36
@brent.edwards Peer review after rebase Day 37
## PM Review — Day 34 **Status**: NOT mergeable (conflicts), 0 reviews, M1 (v3.0.0), State/In Review **Author**: @freemo E2E acceptance criteria for M1 (v3.0.0) — minimal plan execution flow. **[BLOCKING] Merge conflicts** — rebase required before review. ### Action Items | Who | Action | Deadline | |-----|--------|----------| | @freemo | Rebase onto master | Day 36 | | @brent.edwards | **Peer review** after rebase | Day 37 |
freemo commented 2026-03-15 21:57:20 +00:00
Author
Owner
Copy link

merged in through another PR

merged in through another PR
freemo closed this pull request 2026-03-15 21:57:20 +00:00
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 15s
Required
Details
CI / build (pull_request) Successful in 17s
Required
Details
CI / quality (pull_request) Successful in 18s
Required
Details
CI / e2e_tests (pull_request) Failing after 25s
Details
CI / security (pull_request) Successful in 33s
Required
Details
CI / typecheck (pull_request) Successful in 36s
Required
Details
CI / integration_tests (pull_request) Successful in 2m53s
Required
Details
CI / unit_tests (pull_request) Successful in 3m52s
Required
Details
CI / docker (pull_request) Successful in 54s
Required
Details
CI / coverage (pull_request) Successful in 6m53s
Required
Details
CI / benchmark-regression (pull_request) Successful in 34m3s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  
controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  
auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  
auto/claimed-implementer
Currently being processed by an implementer worker.

  
auto/claimed-merge
Currently being processed by the merge driver.

  
auto/claimed-reviewer
Currently being processed by a reviewer worker.

  
auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  
auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  
auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  
auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  
Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.

  
auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.

  
auto/needs-implementer
Failing CI needs implementer attention.

  
auto/postmortem
Documenting a driver incident or rollback.

  
auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  
auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  
auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  
auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  
auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  
auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  
Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.

  
Bounty
$100
 A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$1000
 A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$10000
 A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$20
 A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$2000
 A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$250
 A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$50
 A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$500
 A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$5000
 A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$750
 A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  
MoSCoW
Could have
 Could have feature in order to satisfy the epic/legendary.

  
MoSCoW
Must have
 Must have feature in order to satisfy the epic/legendary.

  
MoSCoW
Should have
 Should have feature in order to satisfy the epic/legendary.

  
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.

  
Points
1
 1 man-hours worth of work for an expert with no learning curve.

  
Points
13
 13 man-hours worth of work for an expert with no learning curve.

  
Points
2
 2 man-hours worth of work for an expert with no learning curve.

  
Points
21
 21 man-hours worth of work for an expert with no learning curve.

  
Points
3
 3 man-hours worth of work for an expert with no learning curve.

  
Points
34
 34 man-hours worth of work for an expert with no learning curve.

  
Points
5
 5 man-hours worth of work for an expert with no learning curve.

  
Points
55
 55 man-hours worth of work for an expert with no learning curve.

  
Points
8
 8 man-hours worth of work for an expert with no learning curve.

  
Points
88
 88 man-hours worth of work for an expert with no learning curve.

  
Priority
Backlog
 This ticket has backlogged priority and is not to be worked on yet

  
Priority
CI Blocker
 Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  
State
Completed
 The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  
State
Duplicate
 A ticket that represents the same content as an existing ticket.

  
State
In Progress
 A ticket that is actively being developed.

  
State
In Review
 A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  
State
Paused
 This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  
State
Unverified
 All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  
State
Verified
 The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  
State
Wont Do
 This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  
Type
Automation
 Any edits or discussion about the AI automated coding system.

  
Type
Bug
 Something that doesnt work as intended.

  
Type
Discussion
 Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  
Type
Documentation
 An error or improvement needed in the documentation.

  
Type
Epic
 Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  
Type
Feature
 Some new functionality not present.

  
Type
Legendary
 A type of Epic which will contain other Epics.

  
Type
Refactor
 A code change that restructures existing code without changing its external behavior.

  
Type
Support
 Someone needs help using the project.

  
Type
Task
 A generic task that doesnt fit into the other type categories.

  
Type
Testing
 Work exclusively focusing on fixing or expanding testing.

No labels
auto/needs-reevaluation
controller-managed
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
Milestone
Clear milestone
No items
No milestone
v3.0.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core!789
No description provided.