feat(tests): replace all @skip tags with proper @tdd_expected_fail tags or remove them across the entire codebase #7221

Merged
hurui200320 merged 2 commits from feat/skip-tag-to-tdd-expected-fail into master 2026-04-13 04:56:01 +00:00

2 Commits

Author SHA1 Message Date
HAL9000 b7f708bc9b fix(tests): comment regression guard metadata
CI / benchmark-publish (pull_request) Has been skipped
CI / push-validation (pull_request) Successful in 17s
CI / helm (pull_request) Successful in 24s
CI / lint (pull_request) Successful in 25s
CI / build (pull_request) Successful in 28s
CI / quality (pull_request) Successful in 44s
CI / typecheck (pull_request) Successful in 52s
CI / security (pull_request) Successful in 1m18s
CI / e2e_tests (pull_request) Successful in 3m20s
CI / integration_tests (pull_request) Successful in 6m25s
CI / unit_tests (pull_request) Successful in 10m37s
CI / docker (pull_request) Successful in 11s
CI / coverage (pull_request) Successful in 14m2s
CI / status-check (pull_request) Successful in 1s
CI / benchmark-regression (pull_request) Successful in 57m47s
Refs: #7025
ISSUES CLOSED: #7025
2026-04-13 04:01:01 +00:00
hurui200320 69eb1c1b8b feat(tests): replace all @skip tags with proper @tdd_expected_fail tags or remove them across the entire codebase
Replace 234 bare @skip occurrences across 82 Behave feature files with
the correct TDD issue-capture tagging system described in CONTRIBUTING.md
§ Bug Fix Workflow.  Previously, the noxfile ran Behave with
`--tags=not @skip`, silently excluding all @skip-tagged scenarios from
every CI run.

Mechanical conversion (234 replacements across 82 files):
- Extracted the proper TDD tags from the comment hint above each @skip
  line, removed @skip from the tag set, and replaced the @skip line
  with those tags.
- Removed the now-redundant comment hint lines alongside each
  replacement.

Bug-fixed scenarios — @tdd_expected_fail removed (84 scenarios):
- Ran nox -s unit_tests to identify which newly-enabled
  @tdd_expected_fail scenarios now pass (their referenced bugs have
  already been fixed). Removed @tdd_expected_fail from those 84
  scenarios, leaving only permanent @tdd_issue @tdd_issue_<N>
  regression-guard tags.

Noxfile cleanup:
- Removed all four --tags=not @skip arguments from noxfile.py
  (unit_tests and coverage sessions).  With zero @skip tags remaining,
  this filter was dead code.

Regression guard files:
- Split tdd_regression_guards.feature into two focused files:
  tdd_regression_guards_exec_env.feature (bug #4281) and
  tdd_regression_guards_session_list.feature (bug #4271).
  Each file carries only its own @tdd_issue tags, avoiding
  cross-contamination via Behave tag inheritance.

Known edge cases (follow-up tickets):
- tdd_exec_env_resolution_precedence.feature retains feature-level
  @tdd_expected_fail for bug #1080 (closed, but the specific
  precedence-level-2-vs-4 scenario still fails on master).
- session_list_summary_dedup.feature retains feature-level
  @tdd_expected_fail for bug #3046 (closed, but the specific
  dedup-consistency scenarios still fail on master).
- actor_add_update_enforcement.feature retains @tdd_expected_fail for
  bug #2609 (closed, but the enforcement scenarios still fail on
  master).
- ci_workflow_validation.feature:134 retains @tdd_expected_fail for
  #4227 (closed, but the CI YAML threshold assertion still fails).

ISSUES CLOSED: #7025
2026-04-13 04:01:01 +00:00