cleveragents/cleveragents-core

Fork 3

feat(extensibility): implement Custom Sandbox Strategy Registration via SandboxStrategy Protocol #709

Merged

freemo merged 1 commit from feature/m6plus-custom-sandbox-strategy-registration into master

2026-03-16 23:06:03 +00:00

freemo commented

2026-03-12 01:31:14 +00:00

Owner

Summary

Implements the SandboxStrategy Protocol and config-driven registration mechanism for custom sandbox isolation strategies, enabling extensibility beyond the 6 built-in strategies (git_worktree, copy_on_write, filesystem_copy, overlay, transaction_rollback, none).

Closes #586

Changes

New modules in `src/cleveragents/infrastructure/sandbox/`

sandbox_strategy.py — SandboxStrategy Protocol with all 9 methods (create, read, write, diff, commit, rollback, checkpoint, restore_checkpoint, cleanup) plus SandboxRef, Change, and DiffView domain models
strategy_adapter.py — Adapter layer refactoring existing built-in strategies to implement the SandboxStrategy Protocol
strategy_registry.py — Config-driven custom strategy registration supporting:
- sandbox.custom_strategies.<name>.module + .class configuration
- Plugin resolution via module:ClassName pattern
- Protocol validation before registration (verifies all 9 methods)
- Resource type sandbox_strategy field resolution for both built-in and custom strategies

Test files

features/extensibility/custom_sandbox_strategy.feature + step definitions — BDD tests for Protocol compliance checking and custom strategy registration lifecycle
robot/ integration test — Register a custom strategy, create sandbox, verify full lifecycle

Quality Checks

nox -e typecheck — 0 Pyright errors
nox -e lint — all checks passed
nox -e format — all files unchanged

## Summary Implements the `SandboxStrategy` Protocol and config-driven registration mechanism for custom sandbox isolation strategies, enabling extensibility beyond the 6 built-in strategies (git_worktree, copy_on_write, filesystem_copy, overlay, transaction_rollback, none). Closes #586 ## Changes ### New modules in `src/cleveragents/infrastructure/sandbox/` - **`sandbox_strategy.py`** — `SandboxStrategy` Protocol with all 9 methods (`create`, `read`, `write`, `diff`, `commit`, `rollback`, `checkpoint`, `restore_checkpoint`, `cleanup`) plus `SandboxRef`, `Change`, and `DiffView` domain models - **`strategy_adapter.py`** — Adapter layer refactoring existing built-in strategies to implement the `SandboxStrategy` Protocol - **`strategy_registry.py`** — Config-driven custom strategy registration supporting: - `sandbox.custom_strategies.<name>.module` + `.class` configuration - Plugin resolution via `module:ClassName` pattern - Protocol validation before registration (verifies all 9 methods) - Resource type `sandbox_strategy` field resolution for both built-in and custom strategies ### Test files - `features/extensibility/custom_sandbox_strategy.feature` + step definitions — BDD tests for Protocol compliance checking and custom strategy registration lifecycle - `robot/` integration test — Register a custom strategy, create sandbox, verify full lifecycle ## Quality Checks - `nox -e typecheck` — 0 Pyright errors - `nox -e lint` — all checks passed - `nox -e format` — all files unchanged

freemo added this to the v3.6.0 milestone

2026-03-12 01:31:20 +00:00

freemo added the

Type

Feature

label

2026-03-12 01:31:20 +00:00

freemo added a new dependency

2026-03-12 01:31:54 +00:00

#586 feat(extensibility): implement Custom Sandbox Strategy Registration via SandboxStrategy Protocol

freemo self-assigned this

2026-03-12 20:33:28 +00:00

freemo added the

labels

2026-03-12 20:43:50 +00:00

freemo reviewed

2026-03-12 20:44:54 +00:00

freemo left a comment

PM Review — Day 32

Status: COMMENT — Needs peer code review before approval

Summary

Custom Sandbox Strategy Registration via SandboxStrategy Protocol by @freemo. Implements extensibility for sandbox isolation strategies beyond the 6 built-in ones. Mergeable, no conflicts.

Process Compliance

PR body: Adequate — summary, module descriptions, quality checks. Missing: diff coverage table, spec reference lines, CHANGELOG entry.
Closes keyword: Closes #586 — correct.
Labels: Added (Priority/Medium, MoSCoW/Should have, Points/8, State/In Progress).
Milestone: v3.6.0 (M7) — correct.
Assignee: @freemo — correct.

Technical Assessment (from PR body)

SandboxStrategy Protocol with 9 methods + 3 domain models.
Config-driven registration with module:ClassName pattern.
Protocol validation before registration.
BDD + Robot tests.
Pyright 0 errors, lint passed, format clean.

Action Required

@CoreRasurae or @brent.edwards: Please perform a code review. Protocol design and plugin registration patterns benefit from a second pair of eyes on the API surface. Mergeable, M7 (due Mar 28).

Labels Added

Priority/Medium, MoSCoW/Should have, Points/8, State/In Progress

## PM Review — Day 32 ### Status: COMMENT — Needs peer code review before approval ### Summary Custom Sandbox Strategy Registration via `SandboxStrategy` Protocol by @freemo. Implements extensibility for sandbox isolation strategies beyond the 6 built-in ones. Mergeable, no conflicts. ### Process Compliance - **PR body**: Adequate — summary, module descriptions, quality checks. Missing: diff coverage table, spec reference lines, CHANGELOG entry. - **Closes keyword**: `Closes #586` — correct. - **Labels**: Added (Priority/Medium, MoSCoW/Should have, Points/8, State/In Progress). - **Milestone**: v3.6.0 (M7) — correct. - **Assignee**: @freemo — correct. ### Technical Assessment (from PR body) - `SandboxStrategy` Protocol with 9 methods + 3 domain models. - Config-driven registration with `module:ClassName` pattern. - Protocol validation before registration. - BDD + Robot tests. - Pyright 0 errors, lint passed, format clean. ### Action Required - **@CoreRasurae or @brent.edwards**: Please perform a code review. Protocol design and plugin registration patterns benefit from a second pair of eyes on the API surface. Mergeable, M7 (due Mar 28). ### Labels Added - Priority/Medium, MoSCoW/Should have, Points/8, State/In Progress

freemo commented

2026-03-14 04:45:08 +00:00

Author

Owner

PM Review — Day 34

Status: Mergeable, 0 reviews, M7 (v3.6.0), Priority/Medium, Points/8
Author: @freemo

Custom Sandbox Strategy Registration via SandboxStrategy Protocol. M7 due March 28 — medium urgency.

Action Items

Who	Action	Deadline
@hamza.khyari	Peer review	Day 38

## PM Review — Day 34 **Status**: Mergeable, 0 reviews, M7 (v3.6.0), Priority/Medium, Points/8 **Author**: @freemo Custom Sandbox Strategy Registration via SandboxStrategy Protocol. M7 due March 28 — medium urgency. ### Action Items | Who | Action | Deadline | |-----|--------|----------| | @hamza.khyari | **Peer review** | Day 38 |

freemo reviewed

2026-03-16 16:26:42 +00:00

freemo left a comment

PM Day 36: Custom Sandbox Strategy Registration. Closes #586. M7 scope. Reviewer: @hamza.khyari (sandbox domain).