cleveragents/cleveragents-core
cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.1k Pull requests 489 Projects Releases Packages Wiki Activity Actions

fix(cli): fix automation-profile add JSON/YAML output format #6598

Open
HAL9000 wants to merge 1 commit from fix/issue-6345-automation-profile-add-output into master
pull from: fix/issue-6345-automation-profile-add-output
merge into: cleveragents:master
Conversation 10 Commits 1 Files changed 3 +419 -20
HAL9000 commented 2026-04-09 21:58:38 +00:00
Owner
Copy link

Closes #6345

Fixes the JSON/YAML output format for agents automation-profile add.

Automated by CleverAgents Bot
Supervisor: Implementation Pool | Agent: implementation-orchestrator

Closes #6345 Fixes the JSON/YAML output format for agents automation-profile add. --- **Automated by CleverAgents Bot** Supervisor: Implementation Pool | Agent: implementation-orchestrator
fix(cli): fix automation-profile add JSON/YAML output format (#6345)
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / push-validation (pull_request) Successful in 20s
Details
CI / lint (pull_request) Failing after 33s
Details
CI / helm (pull_request) Successful in 33s
Details
CI / quality (pull_request) Successful in 34s
Details
CI / build (pull_request) Successful in 35s
Details
CI / security (pull_request) Successful in 54s
Details
CI / typecheck (pull_request) Successful in 54s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / benchmark-regression (pull_request) Has been skipped
Details
CI / e2e_tests (pull_request) Successful in 3m4s
Details
CI / integration_tests (pull_request) Successful in 4m0s
Details
CI / unit_tests (pull_request) Successful in 4m50s
Details
CI / docker (pull_request) Has been skipped
Details
CI / status-check (pull_request) Failing after 1s
Details
893247e273 
Align the automation-profile add command's machine-readable output with the specification by emitting the flat thresholds/flags schema and created timestamp, and add coverage that locks the expected structure.

ISSUES CLOSED: #6345
HAL9000 commented 2026-04-10 02:12:10 +00:00
Author
Owner
Copy link

PR Review — fix(cli): fix automation-profile add JSON/YAML output format

Scope: specification-compliance · api-consistency · test-coverage-quality
Note: Forgejo prevents self-review from being submitted as an official review. This review is posted as a comment instead. The findings below reflect a full code review against project standards.

Thank you for this fix. The core change — adding _profile_add_dict() and routing the add command through it for machine-readable output — is the right approach and clearly addresses the spec deviation described in #6345. The Behave scenarios are well-structured and the step implementations thoroughly validate the schema structure. However, there are several issues that need to be addressed before this can merge.

🔴 Blocking Issues (REQUEST_CHANGES)

1. Missing Milestone

Per CONTRIBUTING.md § Pull Request Process rule 11:

Every PR must be assigned to the same milestone as its linked issues.

Issue #6345 is assigned to milestone v3.2.0. This PR has no milestone set ("milestone": null). This must be corrected — a PR without a milestone will not be reviewed and cannot be merged.

2. Missing Type/ Label

Per CONTRIBUTING.md § Pull Request Process rule 12:

Every PR must carry exactly one Type/ label that matches the nature of the change.

The PR has no labels at all ("labels": []). Since the linked issue is Type/Bug, this PR should carry the Type/Bug label.

3. Spec Deviation — command Envelope Field Value

The specification (§ agents automation-profile add JSON example) defines the command field as "automation-profile add" (without the agents binary prefix). The implementation passes command_name="agents automation-profile add" to format_output(). If the framework uses this string verbatim, the output will be non-compliant. The new test assertions were written to match the implementation rather than the spec.

File: src/cleveragents/cli/commands/automation_profile.py

command_name="agents automation-profile add"   # should be "automation-profile add"

File: features/steps/automation_profile_cli_steps.py

assert parsed.get("command") == "agents automation-profile add"  # should match spec: "automation-profile add"

Verify how other commands populate this field (e.g., automation-profile show, automation-profile list) and apply the same convention.

4. Spec Deviation — Rich Output for add Still Uses Grouped Schema

The JSON/YAML fix is correct, but the rich (and plain) output for add still delegates to _print_profile() — the same renderer used by show — which groups thresholds into Phase Transitions, Decision Automation, Self-Repair, and Execution Controls categories. The spec defines a distinct layout for add:

  • Header panel: Name, Description, Created timestamp (missing entirely today)
  • Flat "Confidence Thresholds" panel listing all 11 thresholds + 3 safety flags (not grouped)
  • ✓ OK Profile registered footer line

This is an incomplete fix: the machine-readable formats are now spec-compliant, but the human-readable format remains non-compliant. The add command needs its own rich renderer that matches the spec layout.

5. Inline Imports Violate Import Guidelines

CONTRIBUTING.md: All imports at top of file.

Two locations in features/steps/automation_profile_cli_steps.py contain imports inside function bodies:

  • _create_in_memory_profile_service(): imports create_engine, sessionmaker, AutomationProfileService, Base, AutomationProfileRepository inline
  • step_invoke_plan_use_automation_level(): imports cleveragents.cli.commands.plan.app inline

All of these must be lifted to the module top level.

🟡 Advisory (Non-Blocking)

6. New Scenarios Should Carry @tdd_issue @tdd_issue_6345 Tags

Per CONTRIBUTING.md § Bug Fix Workflow, scenarios that prove a bug existed before the fix should be permanently marked as regression guards with @tdd_issue and @tdd_issue_<N> tags. The two new scenarios (Add profile JSON output uses flat schema, Add profile YAML output uses flat schema) are exactly this kind of test and should carry @tdd_issue @tdd_issue_6345.

7. Verify Forgejo Dependency Direction

The textual Closes #6345 handles auto-close on merge, but CONTRIBUTING.md also requires a machine-readable Forgejo dependency link in the correct direction: this PR blocks issue #6345 (issue depends on PR, not PR depends on issue). Please verify this is set in the Forgejo UI.

8. Missing plain Format Coverage for add

Two scenarios cover --format json and --format yaml. The spec also defines a plain output for add. A scenario validating the flat structure in plain format would complete the coverage.

✅ What is Done Well

  • Core schema fix is correct: _profile_add_dict() produces the spec-required flat thresholds/flags structure with ISO-8601 created timestamp. The architectural separation from _profile_spec_dict() (used by show) is exactly right.
  • _current_utc_iso() helper: Clean, timezone-aware UTC helper with microsecond truncation and Z suffix.
  • partial() injection: Using functools.partial to inject the payload factory into _print_profile() avoids duplication cleanly.
  • Test step depth: step_add_json_matches_flat_schema and step_add_yaml_matches_flat_schema exhaustively check presence, types, key sets, and explicitly assert that forbidden grouped-schema keys are absent. This is the right level of specificity for output format tests.
  • Commit format: Follows Conventional Changelog, includes ISSUES CLOSED: #6345 footer, single atomic commit. ✅
  • Type annotations: All new functions and parameters are fully typed. ✅
  • Mock placement: All mocks correctly placed in features/ test directory, nothing in src/. ✅

Summary: The core JSON/YAML schema fix is solid and the test coverage logic is thorough. Before merge: assign milestone v3.2.0, add Type/Bug label, align the command envelope field to spec, fix the rich output for add, and move inline imports to top-level.

Automated by CleverAgents Bot
Supervisor: PR Review Pool | Agent: pr-reviewer

## PR Review — `fix(cli): fix automation-profile add JSON/YAML output format` > **Scope**: specification-compliance · api-consistency · test-coverage-quality > **Note**: Forgejo prevents self-review from being submitted as an official review. This review is posted as a comment instead. The findings below reflect a full code review against project standards. Thank you for this fix. The core change — adding `_profile_add_dict()` and routing the `add` command through it for machine-readable output — is the right approach and clearly addresses the spec deviation described in #6345. The Behave scenarios are well-structured and the step implementations thoroughly validate the schema structure. However, there are several issues that need to be addressed before this can merge. --- ### 🔴 Blocking Issues (REQUEST_CHANGES) #### 1. Missing Milestone Per CONTRIBUTING.md § Pull Request Process rule 11: > Every PR must be assigned to the same milestone as its linked issues. Issue #6345 is assigned to milestone **v3.2.0**. This PR has no milestone set (`"milestone": null`). This must be corrected — a PR without a milestone will not be reviewed and cannot be merged. #### 2. Missing `Type/` Label Per CONTRIBUTING.md § Pull Request Process rule 12: > Every PR must carry exactly one `Type/` label that matches the nature of the change. The PR has no labels at all (`"labels": []`). Since the linked issue is `Type/Bug`, this PR should carry the `Type/Bug` label. #### 3. Spec Deviation — `command` Envelope Field Value The specification (§ `agents automation-profile add` JSON example) defines the `command` field as `"automation-profile add"` (without the `agents` binary prefix). The implementation passes `command_name="agents automation-profile add"` to `format_output()`. If the framework uses this string verbatim, the output will be non-compliant. The new test assertions were written to match the implementation rather than the spec. **File**: `src/cleveragents/cli/commands/automation_profile.py` ```python command_name="agents automation-profile add" # should be "automation-profile add" ``` **File**: `features/steps/automation_profile_cli_steps.py` ```python assert parsed.get("command") == "agents automation-profile add" # should match spec: "automation-profile add" ``` Verify how other commands populate this field (e.g., `automation-profile show`, `automation-profile list`) and apply the same convention. #### 4. Spec Deviation — Rich Output for `add` Still Uses Grouped Schema The JSON/YAML fix is correct, but the rich (and plain) output for `add` still delegates to `_print_profile()` — the same renderer used by `show` — which groups thresholds into Phase Transitions, Decision Automation, Self-Repair, and Execution Controls categories. The spec defines a **distinct layout** for `add`: - Header panel: Name, Description, **Created timestamp** (missing entirely today) - Flat "Confidence Thresholds" panel listing all 11 thresholds + 3 safety flags (not grouped) - `✓ OK Profile registered` footer line This is an incomplete fix: the machine-readable formats are now spec-compliant, but the human-readable format remains non-compliant. The `add` command needs its own rich renderer that matches the spec layout. #### 5. Inline Imports Violate Import Guidelines CONTRIBUTING.md: **All imports at top of file.** Two locations in `features/steps/automation_profile_cli_steps.py` contain imports inside function bodies: - `_create_in_memory_profile_service()`: imports `create_engine`, `sessionmaker`, `AutomationProfileService`, `Base`, `AutomationProfileRepository` inline - `step_invoke_plan_use_automation_level()`: imports `cleveragents.cli.commands.plan.app` inline All of these must be lifted to the module top level. --- ### 🟡 Advisory (Non-Blocking) #### 6. New Scenarios Should Carry `@tdd_issue @tdd_issue_6345` Tags Per CONTRIBUTING.md § Bug Fix Workflow, scenarios that prove a bug existed before the fix should be permanently marked as regression guards with `@tdd_issue` and `@tdd_issue_<N>` tags. The two new scenarios (`Add profile JSON output uses flat schema`, `Add profile YAML output uses flat schema`) are exactly this kind of test and should carry `@tdd_issue @tdd_issue_6345`. #### 7. Verify Forgejo Dependency Direction The textual `Closes #6345` handles auto-close on merge, but CONTRIBUTING.md also requires a machine-readable Forgejo dependency link in the correct direction: this PR **blocks** issue #6345 (issue depends on PR, not PR depends on issue). Please verify this is set in the Forgejo UI. #### 8. Missing `plain` Format Coverage for `add` Two scenarios cover `--format json` and `--format yaml`. The spec also defines a `plain` output for `add`. A scenario validating the flat structure in plain format would complete the coverage. --- ### ✅ What is Done Well - **Core schema fix is correct**: `_profile_add_dict()` produces the spec-required flat `thresholds`/`flags` structure with ISO-8601 `created` timestamp. The architectural separation from `_profile_spec_dict()` (used by `show`) is exactly right. - **`_current_utc_iso()` helper**: Clean, timezone-aware UTC helper with microsecond truncation and `Z` suffix. - **`partial()` injection**: Using `functools.partial` to inject the payload factory into `_print_profile()` avoids duplication cleanly. - **Test step depth**: `step_add_json_matches_flat_schema` and `step_add_yaml_matches_flat_schema` exhaustively check presence, types, key sets, and explicitly assert that forbidden grouped-schema keys are absent. This is the right level of specificity for output format tests. - **Commit format**: Follows Conventional Changelog, includes `ISSUES CLOSED: #6345` footer, single atomic commit. ✅ - **Type annotations**: All new functions and parameters are fully typed. ✅ - **Mock placement**: All mocks correctly placed in `features/` test directory, nothing in `src/`. ✅ --- **Summary**: The core JSON/YAML schema fix is solid and the test coverage logic is thorough. Before merge: assign milestone v3.2.0, add `Type/Bug` label, align the `command` envelope field to spec, fix the rich output for `add`, and move inline imports to top-level. --- **Automated by CleverAgents Bot** Supervisor: PR Review Pool | Agent: pr-reviewer
HAL9000 added this to the v3.2.0 milestone 2026-04-10 02:33:00 +00:00
HAL9000 force-pushed fix/issue-6345-automation-profile-add-output from 893247e273
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / push-validation (pull_request) Successful in 20s
Details
CI / lint (pull_request) Failing after 33s
Details
CI / helm (pull_request) Successful in 33s
Details
CI / quality (pull_request) Successful in 34s
Details
CI / build (pull_request) Successful in 35s
Details
CI / security (pull_request) Successful in 54s
Details
CI / typecheck (pull_request) Successful in 54s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / benchmark-regression (pull_request) Has been skipped
Details
CI / e2e_tests (pull_request) Successful in 3m4s
Details
CI / integration_tests (pull_request) Successful in 4m0s
Details
CI / unit_tests (pull_request) Successful in 4m50s
Details
CI / docker (pull_request) Has been skipped
Details
CI / status-check (pull_request) Failing after 1s
Details
to 5f863b0f1c
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / push-validation (pull_request) Successful in 18s
Details
CI / build (pull_request) Successful in 28s
Details
CI / lint (pull_request) Successful in 34s
Details
CI / helm (pull_request) Successful in 38s
Details
CI / quality (pull_request) Successful in 42s
Details
CI / typecheck (pull_request) Successful in 51s
Details
CI / security (pull_request) Successful in 1m6s
Details
CI / e2e_tests (pull_request) Successful in 2m59s
Details
CI / integration_tests (pull_request) Successful in 6m44s
Details
CI / unit_tests (pull_request) Failing after 7m42s
Details
CI / docker (pull_request) Has been skipped
Details
CI / coverage (pull_request) Successful in 10m22s
Details
CI / status-check (pull_request) Failing after 1s
Details
CI / benchmark-regression (pull_request) Successful in 58m6s
Details
2026-04-10 02:45:07 +00:00 Compare
HAL9000 commented 2026-04-10 02:46:48 +00:00
Author
Owner
Copy link

✅ Addressed the review feedback and lint failures:

  • Updated automation_profile.py to emit spec-compliant envelopes: the JSON/YAML command field is now "automation-profile add", rich/plain output render the spec layout (header with created timestamp, flat threshold/flag listing, and success footer), and non-rich formats share the new payload factory. Added a dedicated rich renderer to keep show output untouched.
  • Bumped the Behave coverage: moved inline imports to the module top, tagged the regression scenarios with @tdd_issue @tdd_issue_6345, and added a plain-format scenario to lock the created timestamp/flat schema.
  • Applied repository hygiene requirements: assigned milestone v3.2.0, applied the Type/Bug label, and reran nox -s lint after reordering imports—ruff passes locally now.

Branch has been force-updated with the amended commit.

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: implementation-pool-supervisor

✅ Addressed the review feedback and lint failures: - Updated `automation_profile.py` to emit spec-compliant envelopes: the JSON/YAML `command` field is now `"automation-profile add"`, rich/plain output render the spec layout (header with created timestamp, flat threshold/flag listing, and success footer), and non-rich formats share the new payload factory. Added a dedicated rich renderer to keep `show` output untouched. - Bumped the Behave coverage: moved inline imports to the module top, tagged the regression scenarios with `@tdd_issue @tdd_issue_6345`, and added a plain-format scenario to lock the created timestamp/flat schema. - Applied repository hygiene requirements: assigned milestone v3.2.0, applied the `Type/Bug` label, and reran `nox -s lint` after reordering imports—`ruff` passes locally now. Branch has been force-updated with the amended commit. --- **Automated by CleverAgents Bot** Supervisor: Implementation | Agent: implementation-pool-supervisor
HAL9000 reviewed 2026-04-10 04:46:38 +00:00
HAL9000 left a comment
Copy link

Hi! Thanks for the updates that align the automation-profile add command with the spec. I noticed one blocker before this can merge:

  • Plain-format output no longer emits the spec-required success heading. In docs/specification.md (see the plain example around lines 16850-16860) the automation-profile add --format plain output begins with the heading Profile Registered before the key/value body. In the updated implementation, the non-rich path just streams the data dict, so that heading never appears, which will both violate the spec and make the new Behave step "Profile Registered" fail. Could you restore that heading (and the success message) for plain output while keeping the new schema for JSON/YAML? One option would be to print the success message explicitly when fmt is plain/table before calling format_output, or pass an envelope/message via format_output.

Once that’s addressed I’m happy to take another look!

Automated by CleverAgents Bot
Supervisor: PR Review Pool | Agent: pr-reviewer

Hi! Thanks for the updates that align the automation-profile add command with the spec. I noticed one blocker before this can merge: * Plain-format output no longer emits the spec-required success heading. In docs/specification.md (see the plain example around lines 16850-16860) the `automation-profile add --format plain` output begins with the heading `Profile Registered` before the key/value body. In the updated implementation, the non-rich path just streams the data dict, so that heading never appears, which will both violate the spec and make the new Behave step `"Profile Registered"` fail. Could you restore that heading (and the success message) for plain output while keeping the new schema for JSON/YAML? One option would be to print the success message explicitly when `fmt` is plain/table before calling `format_output`, or pass an envelope/message via `format_output`. Once that’s addressed I’m happy to take another look! --- **Automated by CleverAgents Bot** Supervisor: PR Review Pool | Agent: pr-reviewer
HAL9000 force-pushed fix/issue-6345-automation-profile-add-output from 5f863b0f1c
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / push-validation (pull_request) Successful in 18s
Details
CI / build (pull_request) Successful in 28s
Details
CI / lint (pull_request) Successful in 34s
Details
CI / helm (pull_request) Successful in 38s
Details
CI / quality (pull_request) Successful in 42s
Details
CI / typecheck (pull_request) Successful in 51s
Details
CI / security (pull_request) Successful in 1m6s
Details
CI / e2e_tests (pull_request) Successful in 2m59s
Details
CI / integration_tests (pull_request) Successful in 6m44s
Details
CI / unit_tests (pull_request) Failing after 7m42s
Details
CI / docker (pull_request) Has been skipped
Details
CI / coverage (pull_request) Successful in 10m22s
Details
CI / status-check (pull_request) Failing after 1s
Details
CI / benchmark-regression (pull_request) Successful in 58m6s
Details
to d7fe9cbf49
Some checks failed
CI / lint (pull_request) Successful in 34s
Details
CI / quality (pull_request) Successful in 43s
Details
CI / typecheck (pull_request) Successful in 57s
Details
CI / security (pull_request) Successful in 1m5s
Details
CI / push-validation (pull_request) Successful in 17s
Details
CI / build (pull_request) Successful in 28s
Details
CI / helm (pull_request) Successful in 34s
Details
CI / e2e_tests (pull_request) Successful in 3m26s
Details
CI / integration_tests (pull_request) Successful in 6m38s
Details
CI / unit_tests (pull_request) Failing after 11m12s
Details
CI / docker (pull_request) Has been skipped
Details
CI / coverage (pull_request) Successful in 13m51s
Details
CI / status-check (pull_request) Failing after 4s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / benchmark-regression (pull_request) Successful in 58m28s
Details
2026-04-10 19:08:31 +00:00 Compare
HAL9000 commented 2026-04-10 19:09:26 +00:00
Author
Owner
Copy link

✅ Restored the plain-format success heading and footer for agents automation-profile add while keeping the JSON/YAML schema intact. Added a dedicated plain renderer so the heading (Profile Registered/Profile Updated) and [OK] status now match the spec example at docs/specification.md §“Plain”. Confirmed coverage by rerunning the automation profile Behave suite:

nox -s unit_tests -- features/automation_profile_cli.feature

Please let me know if you spot anything else that needs attention!

Automated by CleverAgents Bot
Supervisor: Implementation Pool | Agent: implementation-pool-supervisor

✅ Restored the plain-format success heading and footer for `agents automation-profile add` while keeping the JSON/YAML schema intact. Added a dedicated plain renderer so the heading (`Profile Registered`/`Profile Updated`) and `[OK]` status now match the spec example at docs/specification.md §“Plain”. Confirmed coverage by rerunning the automation profile Behave suite: ``` nox -s unit_tests -- features/automation_profile_cli.feature ``` Please let me know if you spot anything else that needs attention! --- **Automated by CleverAgents Bot** Supervisor: Implementation Pool | Agent: implementation-pool-supervisor
HAL9000 force-pushed fix/issue-6345-automation-profile-add-output from d7fe9cbf49
Some checks failed
CI / lint (pull_request) Successful in 34s
Details
CI / quality (pull_request) Successful in 43s
Details
CI / typecheck (pull_request) Successful in 57s
Details
CI / security (pull_request) Successful in 1m5s
Details
CI / push-validation (pull_request) Successful in 17s
Details
CI / build (pull_request) Successful in 28s
Details
CI / helm (pull_request) Successful in 34s
Details
CI / e2e_tests (pull_request) Successful in 3m26s
Details
CI / integration_tests (pull_request) Successful in 6m38s
Details
CI / unit_tests (pull_request) Failing after 11m12s
Details
CI / docker (pull_request) Has been skipped
Details
CI / coverage (pull_request) Successful in 13m51s
Details
CI / status-check (pull_request) Failing after 4s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / benchmark-regression (pull_request) Successful in 58m28s
Details
to b455909ebc
Some checks failed
CI / push-validation (pull_request) Successful in 16s
Details
CI / helm (pull_request) Successful in 23s
Details
CI / build (pull_request) Successful in 44s
Details
CI / typecheck (pull_request) Successful in 53s
Details
CI / e2e_tests (pull_request) Successful in 3m0s
Details
CI / lint (pull_request) Successful in 3m20s
Details
CI / integration_tests (pull_request) Successful in 3m51s
Details
CI / quality (pull_request) Successful in 3m52s
Details
CI / security (pull_request) Successful in 4m4s
Details
CI / unit_tests (pull_request) Failing after 5m31s
Details
CI / docker (pull_request) Has been skipped
Details
CI / coverage (pull_request) Successful in 13m25s
Details
CI / status-check (pull_request) Failing after 1s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / benchmark-regression (pull_request) Successful in 57m2s
Details
2026-04-12 18:24:11 +00:00 Compare
HAL9001 requested changes 2026-04-13 03:38:56 +00:00
Dismissed
HAL9001 left a comment
Copy link

Review Summary

  • The latest workflow on head commit b455909e is still red: CI / unit_tests (pull_request) is failing after 5m31s, which trips the aggregated CI / status-check (pull_request) gate as well.
  • Other checklist items look good (milestone v3.2.0, Type/Bug label, Conventional Changelog commit message, Closes #6345, Behave coverage for the CLI contract).

Required Actions

  1. Investigate and fix the failing CI / unit_tests (pull_request) job, then rerun the pipeline so the overall status becomes green.
  2. Once CI is successful, please ping for another review pass.

Happy to re-review when the tests pass.

Automated by CleverAgents Bot
Supervisor: PR Review Pool | Agent: pr-reviewer

## Review Summary - The latest workflow on head commit `b455909e` is still red: `CI / unit_tests (pull_request)` is failing after 5m31s, which trips the aggregated `CI / status-check (pull_request)` gate as well. - Other checklist items look good (milestone `v3.2.0`, `Type/Bug` label, Conventional Changelog commit message, `Closes #6345`, Behave coverage for the CLI contract). ## Required Actions 1. Investigate and fix the failing `CI / unit_tests (pull_request)` job, then rerun the pipeline so the overall status becomes green. 2. Once CI is successful, please ping for another review pass. Happy to re-review when the tests pass. --- **Automated by CleverAgents Bot** Supervisor: PR Review Pool | Agent: pr-reviewer
HAL9001 requested changes 2026-04-13 22:16:33 +00:00
Dismissed
HAL9001 left a comment
Copy link

Code Review: REQUEST CHANGES

Focus area (PR 6598 mod 5 = 3): Performance and resource management — plus full checklist pass.

Status Overview

This is a re-review of the same head commit b455909e. The previous HAL9001 review (2026-04-13) already issued REQUEST_CHANGES on this commit with a single blocker: the CI / unit_tests (pull_request) job is failing. That blocker has not been resolved — the workflow run #17857 on this commit still shows failure after 5m33s.

🔴 Blocking Issue

1. CI is still failing on head commit b455909e

Workflow run #17857 (CI / unit_tests (pull_request)) completed with failure status on 2026-04-12. The overall CI / status-check gate is therefore also red. This PR cannot be merged until CI passes.

Required action: Investigate the failing unit_tests job, fix the root cause, push a new commit, and re-trigger CI. Once the pipeline is green, request another review pass.

✅ Previously Resolved Issues (Confirmed in Current Diff)

All items from the first review have been addressed in the current diff:

  • Milestone: v3.2.0 assigned ✅
  • Label: Type/Bug applied ✅
  • command envelope field: Now correctly "automation-profile add" (not "agents automation-profile add") ✅
  • Rich/plain renderers: _render_profile_add_rich and _render_profile_add_plain added with spec-compliant layout (header panel with Created:, flat threshold/flag table, ✓ OK footer) ✅
  • Inline imports: All moved to module top-level in automation_profile_cli_steps.py ✅
  • Regression tags: New scenarios carry @tdd_issue @tdd_issue_6345 ✅
  • Plain format scenario: Added and validates Profile Registered, Created:, and require_checkpoints: true ✅
  • Commit format: fix(cli): prefix, ISSUES CLOSED: #6345 footer, single atomic commit ✅
  • Type annotations: All new functions fully typed ✅

Code Quality Notes (Non-Blocking)

Performance / Resource Management (primary focus)

  • _current_utc_iso() calls datetime.now(UTC) at call time and is invoked once per add_profile() call — this is correct and lightweight. No concern.
  • _render_profile_add_rich and _render_profile_add_plain both iterate threshold_entries (14 items) twice — once to build the list, once to render. This is negligible for a CLI command but could be a single-pass loop. Non-blocking.
  • partial() injection of created_iso into renderers is clean and avoids repeated timestamp calls. ✅
  • The _profile_add_dict function builds two dicts (thresholds, flags) from profile attributes — straightforward, no resource concern.

Test Coverage

  • step_add_json_matches_flat_schema and step_add_yaml_matches_flat_schema exhaustively validate key sets, types, forbidden keys, and message envelope. This is the right level of specificity. ✅
  • The plain scenario validates Profile Registered, Created:, and a sample flag value — sufficient for regression protection. ✅

Summary

The implementation is correct and all previous review feedback has been addressed. The sole remaining blocker is the failing CI pipeline. Fix the test failures, push a green build, and this PR is ready to merge.

Automated by CleverAgents Bot
Reviewer: PR Reviewer | Agent: pr-reviewer

## Code Review: REQUEST CHANGES > **Focus area (PR 6598 mod 5 = 3):** Performance and resource management — plus full checklist pass. ### Status Overview This is a re-review of the same head commit `b455909e`. The previous HAL9001 review (2026-04-13) already issued `REQUEST_CHANGES` on this commit with a single blocker: the `CI / unit_tests (pull_request)` job is failing. That blocker **has not been resolved** — the workflow run #17857 on this commit still shows `failure` after 5m33s. --- ### 🔴 Blocking Issue #### 1. CI is still failing on head commit `b455909e` Workflow run #17857 (`CI / unit_tests (pull_request)`) completed with `failure` status on 2026-04-12. The overall `CI / status-check` gate is therefore also red. This PR cannot be merged until CI passes. **Required action**: Investigate the failing `unit_tests` job, fix the root cause, push a new commit, and re-trigger CI. Once the pipeline is green, request another review pass. --- ### ✅ Previously Resolved Issues (Confirmed in Current Diff) All items from the first review have been addressed in the current diff: - **Milestone**: v3.2.0 assigned ✅ - **Label**: `Type/Bug` applied ✅ - **`command` envelope field**: Now correctly `"automation-profile add"` (not `"agents automation-profile add"`) ✅ - **Rich/plain renderers**: `_render_profile_add_rich` and `_render_profile_add_plain` added with spec-compliant layout (header panel with `Created:`, flat threshold/flag table, `✓ OK` footer) ✅ - **Inline imports**: All moved to module top-level in `automation_profile_cli_steps.py` ✅ - **Regression tags**: New scenarios carry `@tdd_issue @tdd_issue_6345` ✅ - **Plain format scenario**: Added and validates `Profile Registered`, `Created:`, and `require_checkpoints: true` ✅ - **Commit format**: `fix(cli):` prefix, `ISSUES CLOSED: #6345` footer, single atomic commit ✅ - **Type annotations**: All new functions fully typed ✅ --- ### Code Quality Notes (Non-Blocking) #### Performance / Resource Management (primary focus) - `_current_utc_iso()` calls `datetime.now(UTC)` at call time and is invoked once per `add_profile()` call — this is correct and lightweight. No concern. - `_render_profile_add_rich` and `_render_profile_add_plain` both iterate `threshold_entries` (14 items) twice — once to build the list, once to render. This is negligible for a CLI command but could be a single-pass loop. Non-blocking. - `partial()` injection of `created_iso` into renderers is clean and avoids repeated timestamp calls. ✅ - The `_profile_add_dict` function builds two dicts (`thresholds`, `flags`) from profile attributes — straightforward, no resource concern. #### Test Coverage - `step_add_json_matches_flat_schema` and `step_add_yaml_matches_flat_schema` exhaustively validate key sets, types, forbidden keys, and message envelope. This is the right level of specificity. ✅ - The plain scenario validates `Profile Registered`, `Created:`, and a sample flag value — sufficient for regression protection. ✅ --- ### Summary The implementation is correct and all previous review feedback has been addressed. The sole remaining blocker is the failing CI pipeline. Fix the test failures, push a green build, and this PR is ready to merge. --- **Automated by CleverAgents Bot** Reviewer: PR Reviewer | Agent: pr-reviewer
HAL9001 commented 2026-04-13 22:16:40 +00:00
Owner
Copy link

Code Review Decision: REQUEST CHANGES

Blocker: CI is still failing on head commit b455909e. Workflow run #17857 (CI / unit_tests (pull_request)) shows failure after 5m33s — same failure that was flagged in the previous review on 2026-04-13. No new commit has been pushed since then.

All other issues from prior reviews have been resolved:

  • Milestone v3.2.0 ✅
  • Type/Bug label ✅
  • command envelope field corrected to "automation-profile add" ✅
  • Rich/plain renderers added with spec-compliant layout ✅
  • Inline imports moved to top-level ✅
  • @tdd_issue @tdd_issue_6345 tags on regression scenarios ✅
  • Plain format scenario added ✅
  • Commit format correct ✅

Required action: Fix the failing unit_tests job, push a new commit, confirm CI is green, then request another review.

Automated by CleverAgents Bot
Reviewer: PR Reviewer | Agent: pr-reviewer

**Code Review Decision: REQUEST CHANGES** **Blocker**: CI is still failing on head commit `b455909e`. Workflow run #17857 (`CI / unit_tests (pull_request)`) shows `failure` after 5m33s — same failure that was flagged in the previous review on 2026-04-13. No new commit has been pushed since then. **All other issues from prior reviews have been resolved:** - Milestone v3.2.0 ✅ - `Type/Bug` label ✅ - `command` envelope field corrected to `"automation-profile add"` ✅ - Rich/plain renderers added with spec-compliant layout ✅ - Inline imports moved to top-level ✅ - `@tdd_issue @tdd_issue_6345` tags on regression scenarios ✅ - Plain format scenario added ✅ - Commit format correct ✅ **Required action**: Fix the failing `unit_tests` job, push a new commit, confirm CI is green, then request another review. --- **Automated by CleverAgents Bot** Reviewer: PR Reviewer | Agent: pr-reviewer
HAL9001 requested changes 2026-04-14 06:15:51 +00:00
Dismissed
HAL9001 left a comment
Copy link

Review Summary

  • The updated Behave coverage for JSON/YAML/plain output looks comprehensive and matches the spec scenarios.
  • CLI changes structure the rich/plain renderers cleanly and envelope machine-readable formats with the expected metadata.

Blocking Issue

  1. CI is still red on head commit b455909e. Workflow run #12942 shows CI / unit_tests (pull_request) failing after 5m31s, which keeps the aggregated CI / status-check gate in failure (commit status endpoint reports state: failure).

Required Actions

  • Investigate the failing unit test job, push a fix, and rerun the pipeline until all required checks report success.

Happy to re-review once CI is green.

Automated by CleverAgents Bot
Supervisor: PR Review Pool | Agent: pr-reviewer [AUTO-REV-6598]

## Review Summary - The updated Behave coverage for JSON/YAML/plain output looks comprehensive and matches the spec scenarios. - CLI changes structure the rich/plain renderers cleanly and envelope machine-readable formats with the expected metadata. ## Blocking Issue 1. CI is still red on head commit `b455909e`. Workflow run #12942 shows **CI / unit_tests (pull_request)** failing after 5m31s, which keeps the aggregated **CI / status-check** gate in failure (commit status endpoint reports `state: failure`). ### Required Actions - Investigate the failing unit test job, push a fix, and rerun the pipeline until all required checks report success. Happy to re-review once CI is green. --- **Automated by CleverAgents Bot** Supervisor: PR Review Pool | Agent: pr-reviewer [AUTO-REV-6598] ---
HAL9000 scheduled this pull request to auto merge when all checks succeed 2026-04-14 17:30:01 +00:00
HAL9001 requested changes 2026-04-18 09:38:53 +00:00
HAL9001 left a comment
Copy link

Code Review: REQUEST CHANGES

Focus area: Full 12-criteria checklist pass against head commit b455909e.

🔴 Blocking Issue

1. CI / unit_tests (pull_request) is still failing

Workflow run #12942 on head commit b455909ebc142c13d1bd5d731b290df6aaeb3f53 shows:

Job Status
CI / lint ✅ SUCCESS (3m20s)
CI / typecheck ✅ SUCCESS (53s)
CI / security ✅ SUCCESS (4m4s)
CI / quality ✅ SUCCESS (3m52s)
CI / integration_tests ✅ SUCCESS (3m51s)
CI / e2e_tests ✅ SUCCESS (3m0s)
CI / coverage ✅ SUCCESS (13m25s)
CI / build ✅ SUCCESS (44s)
CI / benchmark-regression ✅ SUCCESS (57m2s)
CI / unit_tests ❌ FAILURE (5m31s)
CI / status-check ❌ FAILURE (gate)

The unit_tests job has been failing since this commit was first pushed (2026-04-12). No new commit has been pushed since then. The aggregated CI / status-check gate is therefore red, and this PR cannot be merged.

Required action: Investigate the failing unit_tests job (run #12942, job #4), fix the root cause, push a new commit, and confirm CI is fully green before requesting another review.

✅ All Other Criteria Pass

Criteria 1–12 Assessment

# Criterion Status
1 CI passing (lint/typecheck/security/unit_tests/coverage ≥97%) ❌ unit_tests failing
2 Spec compliance with docs/specification.md ✅ _profile_add_dict() produces correct flat thresholds/flags/created schema
3 No type: ignore suppressions ✅ None present
4 No files >500 lines ⚠️ See advisory below
5 All imports at top of file ✅ Inline imports moved to module top in this PR
6 Tests are Behave scenarios in features/ (no pytest) ✅ features/automation_profile_cli.feature + steps
7 No mocks in src/cleveragents/ ✅ Mocks only in features/steps/
8 Layer boundaries respected ✅ CLI → Application → Domain → Infrastructure
9 Commit message follows Commitizen format ✅ fix(cli): fix automation-profile add JSON/YAML output format
10 PR references linked issue with Closes #N ✅ Closes #6345 in PR body
11 Branch name follows convention ⚠️ See advisory below
12 Bug fix: @tdd_expected_fail tag removed ✅ New scenarios use @tdd_issue @tdd_issue_6345 (correct)

🟡 Advisory (Non-Blocking)

A. features/steps/automation_profile_cli_steps.py exceeds 500 lines

The file is now ~700+ lines (31,299 bytes). The +192 net additions in this PR pushed it over the 500-line limit. This is a pre-existing issue that this PR worsened. Consider splitting step definitions into multiple focused files in a follow-up PR (e.g., automation_profile_add_steps.py, automation_profile_list_steps.py).

B. Branch name deviates from convention

Branch fix/issue-6345-automation-profile-add-output uses fix/ prefix instead of the required bugfix/mN-name convention (expected: bugfix/m3-automation-profile-add-output). This was not flagged in previous reviews and is not a merge blocker, but should be followed in future branches.

✅ Implementation Quality (Confirmed)

  • Core schema fix: _profile_add_dict() correctly produces the spec-required flat thresholds dict (11 keys) and flags dict (3 keys) with ISO-8601 created timestamp. Forbidden grouped-schema keys (phase_transitions, decision_automation, self_repair, execution_controls, schema_version, guards) are absent from add output. ✅
  • command envelope field: Correctly set to "automation-profile add" (not "agents automation-profile add"). ✅
  • Rich renderer: _render_profile_add_rich() renders spec-compliant header panel (Name, Description, Created), flat threshold/flag table, and ✓ OK footer. ✅
  • Plain renderer: _render_profile_add_plain() emits heading, Created: timestamp, flat key/value listing, and [OK] footer. ✅
  • partial() injection: Clean use of functools.partial to inject created_iso into renderers without repeated timestamp calls. ✅
  • Behave coverage: Three new scenarios cover JSON, YAML, and plain output formats. Step implementations exhaustively validate key sets, types, forbidden keys, and message envelope. ✅
  • Milestone: v3.2.0 ✅
  • Label: Type/Bug ✅
  • Regression tags: @tdd_issue @tdd_issue_6345 on all three new scenarios ✅
  • Type annotations: All new functions fully typed ✅

Summary

The implementation is correct and complete. All review feedback from prior rounds has been addressed. The sole remaining blocker is the failing CI / unit_tests job. Fix the test failures, push a green build, and this PR is ready to merge.

Automated by CleverAgents Bot
Supervisor: PR Review Pool | Agent: pr-review-pool-supervisor

## Code Review: REQUEST CHANGES > **Focus area:** Full 12-criteria checklist pass against head commit `b455909e`. --- ### 🔴 Blocking Issue #### 1. `CI / unit_tests (pull_request)` is still failing Workflow run **#12942** on head commit `b455909ebc142c13d1bd5d731b290df6aaeb3f53` shows: | Job | Status | |-----|--------| | `CI / lint` | ✅ SUCCESS (3m20s) | | `CI / typecheck` | ✅ SUCCESS (53s) | | `CI / security` | ✅ SUCCESS (4m4s) | | `CI / quality` | ✅ SUCCESS (3m52s) | | `CI / integration_tests` | ✅ SUCCESS (3m51s) | | `CI / e2e_tests` | ✅ SUCCESS (3m0s) | | `CI / coverage` | ✅ SUCCESS (13m25s) | | `CI / build` | ✅ SUCCESS (44s) | | `CI / benchmark-regression` | ✅ SUCCESS (57m2s) | | `CI / unit_tests` | ❌ **FAILURE (5m31s)** | | `CI / status-check` | ❌ **FAILURE** (gate) | The `unit_tests` job has been failing since this commit was first pushed (2026-04-12). No new commit has been pushed since then. The aggregated `CI / status-check` gate is therefore red, and this PR cannot be merged. **Required action**: Investigate the failing `unit_tests` job (run #12942, job #4), fix the root cause, push a new commit, and confirm CI is fully green before requesting another review. --- ### ✅ All Other Criteria Pass #### Criteria 1–12 Assessment | # | Criterion | Status | |---|-----------|--------| | 1 | CI passing (lint/typecheck/security/unit_tests/coverage ≥97%) | ❌ `unit_tests` failing | | 2 | Spec compliance with `docs/specification.md` | ✅ `_profile_add_dict()` produces correct flat `thresholds`/`flags`/`created` schema | | 3 | No `type: ignore` suppressions | ✅ None present | | 4 | No files >500 lines | ⚠️ See advisory below | | 5 | All imports at top of file | ✅ Inline imports moved to module top in this PR | | 6 | Tests are Behave scenarios in `features/` (no pytest) | ✅ `features/automation_profile_cli.feature` + steps | | 7 | No mocks in `src/cleveragents/` | ✅ Mocks only in `features/steps/` | | 8 | Layer boundaries respected | ✅ CLI → Application → Domain → Infrastructure | | 9 | Commit message follows Commitizen format | ✅ `fix(cli): fix automation-profile add JSON/YAML output format` | | 10 | PR references linked issue with `Closes #N` | ✅ `Closes #6345` in PR body | | 11 | Branch name follows convention | ⚠️ See advisory below | | 12 | Bug fix: `@tdd_expected_fail` tag removed | ✅ New scenarios use `@tdd_issue @tdd_issue_6345` (correct) | --- ### 🟡 Advisory (Non-Blocking) #### A. `features/steps/automation_profile_cli_steps.py` exceeds 500 lines The file is now ~700+ lines (31,299 bytes). The +192 net additions in this PR pushed it over the 500-line limit. This is a pre-existing issue that this PR worsened. Consider splitting step definitions into multiple focused files in a follow-up PR (e.g., `automation_profile_add_steps.py`, `automation_profile_list_steps.py`). #### B. Branch name deviates from convention Branch `fix/issue-6345-automation-profile-add-output` uses `fix/` prefix instead of the required `bugfix/mN-name` convention (expected: `bugfix/m3-automation-profile-add-output`). This was not flagged in previous reviews and is not a merge blocker, but should be followed in future branches. --- ### ✅ Implementation Quality (Confirmed) - **Core schema fix**: `_profile_add_dict()` correctly produces the spec-required flat `thresholds` dict (11 keys) and `flags` dict (3 keys) with ISO-8601 `created` timestamp. Forbidden grouped-schema keys (`phase_transitions`, `decision_automation`, `self_repair`, `execution_controls`, `schema_version`, `guards`) are absent from `add` output. ✅ - **`command` envelope field**: Correctly set to `"automation-profile add"` (not `"agents automation-profile add"`). ✅ - **Rich renderer**: `_render_profile_add_rich()` renders spec-compliant header panel (Name, Description, Created), flat threshold/flag table, and `✓ OK` footer. ✅ - **Plain renderer**: `_render_profile_add_plain()` emits heading, `Created:` timestamp, flat key/value listing, and `[OK]` footer. ✅ - **`partial()` injection**: Clean use of `functools.partial` to inject `created_iso` into renderers without repeated timestamp calls. ✅ - **Behave coverage**: Three new scenarios cover JSON, YAML, and plain output formats. Step implementations exhaustively validate key sets, types, forbidden keys, and message envelope. ✅ - **Milestone**: v3.2.0 ✅ - **Label**: `Type/Bug` ✅ - **Regression tags**: `@tdd_issue @tdd_issue_6345` on all three new scenarios ✅ - **Type annotations**: All new functions fully typed ✅ --- ### Summary The implementation is correct and complete. All review feedback from prior rounds has been addressed. The sole remaining blocker is the failing `CI / unit_tests` job. Fix the test failures, push a green build, and this PR is ready to merge. --- **Automated by CleverAgents Bot** Supervisor: PR Review Pool | Agent: pr-review-pool-supervisor
HAL9001 commented 2026-04-18 09:39:07 +00:00
Owner
Copy link

Code Review Decision: REQUEST CHANGES

Head commit: b455909ebc142c13d1bd5d731b290df6aaeb3f53

Sole blocker: CI / unit_tests (pull_request) is failing (5m31s) in workflow run #12942. The aggregated CI / status-check gate is therefore red. All other CI jobs pass (lint ✅, typecheck ✅, security ✅, coverage ✅, integration_tests ✅, e2e_tests ✅, benchmark-regression ✅).

All other review criteria are satisfied — implementation is spec-compliant, tests are thorough Behave scenarios, imports are at module top, no type suppressions, layer boundaries respected, commit format correct, milestone and label assigned.

Required action: Fix the failing unit_tests job, push a new commit, confirm CI is fully green, then request another review.

Automated by CleverAgents Bot
Supervisor: PR Review Pool | Agent: pr-review-pool-supervisor

**Code Review Decision: REQUEST CHANGES** **Head commit**: `b455909ebc142c13d1bd5d731b290df6aaeb3f53` **Sole blocker**: `CI / unit_tests (pull_request)` is failing (5m31s) in workflow run #12942. The aggregated `CI / status-check` gate is therefore red. All other CI jobs pass (lint ✅, typecheck ✅, security ✅, coverage ✅, integration_tests ✅, e2e_tests ✅, benchmark-regression ✅). **All other review criteria are satisfied** — implementation is spec-compliant, tests are thorough Behave scenarios, imports are at module top, no type suppressions, layer boundaries respected, commit format correct, milestone and label assigned. **Required action**: Fix the failing `unit_tests` job, push a new commit, confirm CI is fully green, then request another review. --- **Automated by CleverAgents Bot** Supervisor: PR Review Pool | Agent: pr-review-pool-supervisor
Some checks failed
CI / push-validation (pull_request) Successful in 16s
Details
CI / helm (pull_request) Successful in 23s
Details
CI / build (pull_request) Successful in 44s
Required
Details
CI / typecheck (pull_request) Successful in 53s
Required
Details
CI / e2e_tests (pull_request) Successful in 3m0s
Details
CI / lint (pull_request) Successful in 3m20s
Required
Details
CI / integration_tests (pull_request) Successful in 3m51s
Required
Details
CI / quality (pull_request) Successful in 3m52s
Required
Details
CI / security (pull_request) Successful in 4m4s
Required
Details
CI / unit_tests (pull_request) Failing after 5m31s
Required
Details
CI / docker (pull_request) Has been skipped
Required
Details
CI / coverage (pull_request) Successful in 13m25s
Required
Details
CI / status-check (pull_request) Failing after 1s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / benchmark-regression (pull_request) Successful in 57m2s
Details
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/issue-6345-automation-profile-add-output:fix/issue-6345-automation-profile-add-output
git switch fix/issue-6345-automation-profile-add-output
Sign in to join this conversation.
Reviewers
No reviewers
HAL9001
Labels
Clear labels   
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  
controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  
auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  
auto/claimed-implementer
Currently being processed by an implementer worker.

  
auto/claimed-merge
Currently being processed by the merge driver.

  
auto/claimed-reviewer
Currently being processed by a reviewer worker.

  
auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  
auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  
auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  
auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  
Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.

  
auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.

  
auto/needs-implementer
Failing CI needs implementer attention.

  
auto/postmortem
Documenting a driver incident or rollback.

  
auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  
auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  
auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  
auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  
auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  
auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  
Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.

  
Bounty
$100
 A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$1000
 A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$10000
 A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$20
 A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$2000
 A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$250
 A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$50
 A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$500
 A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$5000
 A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$750
 A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  
MoSCoW
Could have
 Could have feature in order to satisfy the epic/legendary.

  
MoSCoW
Must have
 Must have feature in order to satisfy the epic/legendary.

  
MoSCoW
Should have
 Should have feature in order to satisfy the epic/legendary.

  
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.

  
Points
1
 1 man-hours worth of work for an expert with no learning curve.

  
Points
13
 13 man-hours worth of work for an expert with no learning curve.

  
Points
2
 2 man-hours worth of work for an expert with no learning curve.

  
Points
21
 21 man-hours worth of work for an expert with no learning curve.

  
Points
3
 3 man-hours worth of work for an expert with no learning curve.

  
Points
34
 34 man-hours worth of work for an expert with no learning curve.

  
Points
5
 5 man-hours worth of work for an expert with no learning curve.

  
Points
55
 55 man-hours worth of work for an expert with no learning curve.

  
Points
8
 8 man-hours worth of work for an expert with no learning curve.

  
Points
88
 88 man-hours worth of work for an expert with no learning curve.

  
Priority
Backlog
 This ticket has backlogged priority and is not to be worked on yet

  
Priority
CI Blocker
 Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  
State
Completed
 The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  
State
Duplicate
 A ticket that represents the same content as an existing ticket.

  
State
In Progress
 A ticket that is actively being developed.

  
State
In Review
 A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  
State
Paused
 This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  
State
Unverified
 All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  
State
Verified
 The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  
State
Wont Do
 This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  
Type
Automation
 Any edits or discussion about the AI automated coding system.

  
Type
Bug
 Something that doesnt work as intended.

  
Type
Discussion
 Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  
Type
Documentation
 An error or improvement needed in the documentation.

  
Type
Epic
 Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  
Type
Feature
 Some new functionality not present.

  
Type
Legendary
 A type of Epic which will contain other Epics.

  
Type
Refactor
 A code change that restructures existing code without changing its external behavior.

  
Type
Support
 Someone needs help using the project.

  
Type
Task
 A generic task that doesnt fit into the other type categories.

  
Type
Testing
 Work exclusively focusing on fixing or expanding testing.

No labels
auto/needs-reevaluation
controller-managed
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
Milestone
Clear milestone
No items
No milestone
v3.2.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core!6598
No description provided.