test(e2e): validate M4 acceptance criteria for v3.3.0 milestone closure #560

Merged
hurui200320 merged 1 commits from test/m4-acceptance-gate into master 2026-03-06 03:22:45 +00:00

1 Commits

Author SHA1 Message Date
hurui200320 d02aa33150 test(e2e): validate M4 acceptance criteria for v3.3.0 milestone closure
CI / benchmark-publish (pull_request) Has been skipped
CI / lint (pull_request) Successful in 15s
CI / build (pull_request) Successful in 15s
CI / quality (pull_request) Successful in 18s
CI / security (pull_request) Successful in 33s
CI / typecheck (pull_request) Successful in 36s
CI / unit_tests (pull_request) Successful in 2m8s
CI / docker (pull_request) Successful in 40s
CI / integration_tests (pull_request) Successful in 3m9s
CI / coverage (pull_request) Successful in 4m24s
CI / benchmark-regression (pull_request) Successful in 29m15s
Ran the M4 E2E verification suite against the complete v3.3.0
implementation. All 10 M4 E2E verification tests (7 existing + 3 new)
and 8 correction/subplan smoke tests pass against the final codebase.

Added CLI-exercising integration tests for three subplan commands:
- plan use: Typer CliRunner invokes plan_app["use", ...] with mocked
  lifecycle service; verifies get_action_by_name and use_action calls
- plan execute: invokes plan_app["execute", ...]; verifies plan
  transitions to Execute phase with subplan statuses
- plan tree: invokes plan_app["tree", ..., "--format", "json"] with
  real Decision objects (PROMPT_DEFINITION, STRATEGY_CHOICE,
  SUBPLAN_PARALLEL_SPAWN, SUBPLAN_SPAWN); verifies JSON tree output

Fixed pre-existing unit test failure in repositories_uncovered_branches
feature (scenario: upsert profile with schema version mismatch). Root
cause: plain sessionmaker returns a new session per call, so the insert
in the Given step and the commit in a second session were isolated.
Fix: use scoped_session to share the same thread-local session.

Fixed CONTRIBUTORS.md alphabetical ordering (Hu between Freeman and
Khyari).

Full nox quality gate results:
- lint, format, typecheck: pass
- unit_tests: 8524 scenarios, 0 failures
- integration_tests: 1110/1118 pass (8 pre-existing failures in
  cli_plan_context_commands.robot, identical on master)
- coverage_report: 97% (threshold: 97%)
- security_scan, dead_code, docs, build, benchmark: pass

ISSUES CLOSED: #495
2026-03-06 03:17:31 +00:00