Ran the M4 E2E verification suite against the complete v3.3.0
implementation. All 10 M4 E2E verification tests (7 existing + 3 new)
and 8 correction/subplan smoke tests pass against the final codebase.
Added CLI-exercising integration tests for three subplan commands:
- plan use: Typer CliRunner invokes plan_app["use", ...] with mocked
lifecycle service; verifies get_action_by_name and use_action calls
- plan execute: invokes plan_app["execute", ...]; verifies plan
transitions to Execute phase with subplan statuses
- plan tree: invokes plan_app["tree", ..., "--format", "json"] with
real Decision objects (PROMPT_DEFINITION, STRATEGY_CHOICE,
SUBPLAN_PARALLEL_SPAWN, SUBPLAN_SPAWN); verifies JSON tree output
Fixed pre-existing unit test failure in repositories_uncovered_branches
feature (scenario: upsert profile with schema version mismatch). Root
cause: plain sessionmaker returns a new session per call, so the insert
in the Given step and the commit in a second session were isolated.
Fix: use scoped_session to share the same thread-local session.
Fixed CONTRIBUTORS.md alphabetical ordering (Hu between Freeman and
Khyari).
Full nox quality gate results:
- lint, format, typecheck: pass
- unit_tests: 8524 scenarios, 0 failures
- integration_tests: 1110/1118 pass (8 pre-existing failures in
cli_plan_context_commands.robot, identical on master)
- coverage_report: 97% (threshold: 97%)
- security_scan, dead_code, docs, build, benchmark: pass
ISSUES CLOSED: #495