chore(agents): improve pr-self-reviewer — add blocking vs non-blocking severity classification #5301

Merged
HAL9000 merged 2 commits from improvement/agent-pr-self-reviewer-blocking-vs-nonblocking into master 2026-06-03 05:56:49 +00:00

2 Commits

Author SHA1 Message Date
HAL9000 8eebe5734f chore(agents): improve pr-self-reviewer — add blocking vs non-blocking severity classification
CI / lint (pull_request) Successful in 38s
CI / quality (pull_request) Successful in 1m1s
CI / typecheck (pull_request) Successful in 1m12s
CI / security (pull_request) Successful in 1m25s
CI / helm (pull_request) Successful in 30s
CI / build (pull_request) Successful in 38s
CI / push-validation (pull_request) Successful in 40s
CI / unit_tests (pull_request) Successful in 5m36s
CI / docker (pull_request) Successful in 1m37s
CI / integration_tests (pull_request) Successful in 9m30s
CI / coverage (pull_request) Successful in 9m33s
CI / status-check (pull_request) Successful in 3s
2026-06-03 01:13:54 -04:00
HAL9000 3eb49e4afe chore(agents): improve pr-self-reviewer — add blocking vs non-blocking severity classification
Approved proposal: #4506
Pattern: prompt_improvement
Evidence: 100% REQUEST_CHANGES rate across 20+ PR reviews — zero APPROVEs.
All issues treated equally regardless of severity (missing metadata = security bug).
Fix: Add severity classification section distinguishing BLOCKING issues (code
correctness, security, spec violations, forbidden patterns) from NON-BLOCKING
issues (missing PR metadata, minor style, merge conflicts). Decision rule:
REQUEST_CHANGES only if BLOCKING issues exist; APPROVE with comments if only
NON-BLOCKING issues.

ISSUES CLOSED: #4506
2026-06-03 01:13:54 -04:00