cleveragents/cleveragents-core
cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.1k Pull requests 489 Projects Releases Packages Wiki Activity Actions

perf(tests): optimize coverage instrumentation and reporting pipeline #484

Closed
brent.edwards wants to merge 3 commits from perf/optimize-coverage-pipeline into master
pull from: perf/optimize-coverage-pipeline
merge into: cleveragents:master
Conversation 2 Commits 3 Files changed 5 +149 -41
brent.edwards commented 2026-03-01 02:58:00 +00:00
Member
Copy link

Summary

  • Replace coverage.py (sys.settrace) with slipcover (bytecode instrumentation) for faster coverage collection
  • Each behave-parallel worker produces per-feature JSON coverage files; slipcover --merge combines them
  • CI workflow JSON key lookups handle both slipcover and coverage.py output formats
  • Documentation updated to reflect slipcover as the coverage tool

Type of Change

  • Performance improvement
  • CI/CD changes
  • Documentation update

Quality Checklist

  • Code follows the project's coding standards (see CONTRIBUTING.md)
  • nox -s typecheck passes with no errors
  • nox -s lint passes with no errors
  • Integration tests pass (Robot coverage_threshold.robot: 6/6)
  • Coverage remains above 97%
  • No security issues introduced
  • Documentation updated

Testing

  • Robot Framework coverage_threshold.robot passes all 6 tests
  • Coverage JSON output verified: 97.5% with slipcover

Related Issues

Part of #478. Closes #482.

## Summary - Replace coverage.py (sys.settrace) with slipcover (bytecode instrumentation) for faster coverage collection - Each behave-parallel worker produces per-feature JSON coverage files; slipcover --merge combines them - CI workflow JSON key lookups handle both slipcover and coverage.py output formats - Documentation updated to reflect slipcover as the coverage tool ## Type of Change - [x] Performance improvement - [x] CI/CD changes - [x] Documentation update ## Quality Checklist - [x] Code follows the project's coding standards (see CONTRIBUTING.md) - [x] `nox -s typecheck` passes with no errors - [x] `nox -s lint` passes with no errors - [x] Integration tests pass (Robot coverage_threshold.robot: 6/6) - [x] Coverage remains above 97% - [x] No security issues introduced - [x] Documentation updated ## Testing - Robot Framework `coverage_threshold.robot` passes all 6 tests - Coverage JSON output verified: 97.5% with slipcover ## Related Issues Part of #478. Closes #482.
perf(tests): optimize coverage instrumentation and reporting pipeline
All checks were successful
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 14s
Details
CI / build (pull_request) Successful in 17s
Details
CI / quality (pull_request) Successful in 17s
Details
CI / security (pull_request) Successful in 30s
Details
CI / typecheck (pull_request) Successful in 33s
Details
CI / integration_tests (pull_request) Successful in 2m42s
Details
CI / unit_tests (pull_request) Successful in 11m53s
Details
CI / coverage (pull_request) Successful in 11m52s
Details
CI / docker (pull_request) Successful in 1m3s
Details
CI / benchmark-regression (pull_request) Successful in 25m37s
Details
4629c44fc0 
Replace coverage.py (sys.settrace-based) with slipcover (bytecode-based
instrumentation) for significantly faster coverage collection:

- Each behave-parallel worker runs under slipcover, producing per-feature
  JSON coverage files with unique UUIDs to avoid write contention.
- After all workers finish, slipcover --merge combines per-worker data
  into a single build/coverage.json report.
- XML report generated via slipcover --merge --xml for CI tooling.
- Terminal report with --fail-under=97 threshold enforcement.
- Robust JSON key-fallback logic handles both slipcover ('summary') and
  coverage.py ('totals') output formats.

CI workflow fixes:
- ci.yml 'Surface coverage summary' step uses defensive key lookup
  instead of hardcoded ['totals']['percent_covered'].
- nightly-quality.yml applies same fallback pattern.

Documentation updated to reflect slipcover as the coverage tool.

Part of #478. Closes #482.
Merge branch 'master' into perf/optimize-coverage-pipeline
All checks were successful
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 14s
Details
CI / build (pull_request) Successful in 24s
Details
CI / quality (pull_request) Successful in 30s
Details
CI / typecheck (pull_request) Successful in 33s
Details
CI / security (pull_request) Successful in 50s
Details
CI / integration_tests (pull_request) Successful in 4m44s
Details
CI / coverage (pull_request) Successful in 12m31s
Details
CI / benchmark-regression (pull_request) Successful in 20m58s
Details
CI / unit_tests (pull_request) Successful in 25m18s
Details
CI / docker (pull_request) Successful in 38s
Details
812a880811
Merge branch 'master' into perf/optimize-coverage-pipeline
All checks were successful
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 16s
Details
CI / build (pull_request) Successful in 15s
Details
CI / quality (pull_request) Successful in 23s
Details
CI / security (pull_request) Successful in 30s
Details
CI / typecheck (pull_request) Successful in 55s
Details
CI / integration_tests (pull_request) Successful in 2m55s
Details
CI / benchmark-regression (pull_request) Successful in 21m55s
Details
CI / unit_tests (pull_request) Successful in 24m41s
Details
CI / docker (pull_request) Successful in 52s
Details
CI / coverage (pull_request) Successful in 24m45s
Details
fd82a9852c
freemo requested changes 2026-03-01 16:08:24 +00:00
freemo left a comment
Copy link

Code Review: PR #484 — perf(tests): optimize coverage instrumentation and reporting pipeline

What I Fixed

  • Labels: Removed incorrectly applied State/Verified, Priority/High, MoSCoW/Should have, Points/8 labels (these belong on issues only per CONTRIBUTING.md §8.1). Only Type/Task remains.

Code Quality Assessment

The code changes are solid. Key observations:

  1. slipcover migration — Clean replacement of coverage.py with slipcover. The per-worker UUID file approach avoids write contention correctly.
  2. Defensive JSON parsing — The fallback logic in noxfile.py (checking summary, totals, multiple key names, computing percentage from raw counts) is thorough — perhaps overly so, but it won't break anything and handles format differences gracefully.
  3. CI workflow fixes — The ci.yml and nightly-quality.yml changes correctly apply the same defensive key lookup pattern.
  4. Documentation — docs/development/testing.md properly updated to reflect slipcover.
  5. Dependency change — coverage>=7.11.0 → slipcover>=1.0.17 in pyproject.toml is clean.
  6. Whitespace cleanup in CI YAML files is fine.

No bugs or design issues identified in the code itself.

Process Violations Requiring Changes

  1. Merge commits present — This PR has 3 commits (2 merge commits from syncing with master + 1 real commit). Per CONTRIBUTING.md §4.1, each PR should contain exactly one atomic commit. Please rebase and squash to a single commit.

  2. Missing ISSUES CLOSED: footer in commit message — The commit message uses Closes #482. in the body text, but CONTRIBUTING.md §5.5 requires the footer format:

    ISSUES CLOSED: #482

  3. Missing CHANGELOG.md update — Per CONTRIBUTING.md §8.3, every PR must include a CHANGELOG entry.

  4. Missing milestone — Per CONTRIBUTING.md §8.2, every PR must have a milestone matching the linked issue. Neither this PR nor issue #482 has a milestone set. Please determine the correct milestone and set it on both.

  5. Missing dependency links — Per CONTRIBUTING.md §7.3-7.4, this PR should have a "blocks #482" link, and issue #482 should have a "depends on #484" link. Please add these in the Forgejo UI.

Verdict

REQUEST CHANGES — The code is well-implemented, but the process requirements above must be addressed before merge.

## Code Review: PR #484 — perf(tests): optimize coverage instrumentation and reporting pipeline ### What I Fixed - **Labels**: Removed incorrectly applied `State/Verified`, `Priority/High`, `MoSCoW/Should have`, `Points/8` labels (these belong on issues only per CONTRIBUTING.md §8.1). Only `Type/Task` remains. ### Code Quality Assessment The code changes are solid. Key observations: 1. **slipcover migration** — Clean replacement of coverage.py with slipcover. The per-worker UUID file approach avoids write contention correctly. 2. **Defensive JSON parsing** — The fallback logic in `noxfile.py` (checking `summary`, `totals`, multiple key names, computing percentage from raw counts) is thorough — perhaps overly so, but it won't break anything and handles format differences gracefully. 3. **CI workflow fixes** — The `ci.yml` and `nightly-quality.yml` changes correctly apply the same defensive key lookup pattern. 4. **Documentation** — `docs/development/testing.md` properly updated to reflect slipcover. 5. **Dependency change** — `coverage>=7.11.0` → `slipcover>=1.0.17` in `pyproject.toml` is clean. 6. **Whitespace cleanup** in CI YAML files is fine. No bugs or design issues identified in the code itself. ### Process Violations Requiring Changes 1. **Merge commits present** — This PR has 3 commits (2 merge commits from syncing with `master` + 1 real commit). Per CONTRIBUTING.md §4.1, each PR should contain exactly one atomic commit. Please rebase and squash to a single commit. 2. **Missing `ISSUES CLOSED:` footer in commit message** — The commit message uses `Closes #482.` in the body text, but CONTRIBUTING.md §5.5 requires the footer format: ``` ISSUES CLOSED: #482 ``` 3. **Missing CHANGELOG.md update** — Per CONTRIBUTING.md §8.3, every PR must include a CHANGELOG entry. 4. **Missing milestone** — Per CONTRIBUTING.md §8.2, every PR must have a milestone matching the linked issue. Neither this PR nor issue #482 has a milestone set. Please determine the correct milestone and set it on both. 5. **Missing dependency links** — Per CONTRIBUTING.md §7.3-7.4, this PR should have a "blocks #482" link, and issue #482 should have a "depends on #484" link. Please add these in the Forgejo UI. ### Verdict **REQUEST CHANGES** — The code is well-implemented, but the process requirements above must be addressed before merge.
freemo commented 2026-03-02 01:45:22 +00:00
Owner
Copy link

Superseded by #493 — this PR has been consolidated with all code review fixes applied into a single clean branch (perf/bdd-test-optimization) with one commit per issue and no merge commits.

Superseded by #493 — this PR has been consolidated with all code review fixes applied into a single clean branch (`perf/bdd-test-optimization`) with one commit per issue and no merge commits.
freemo closed this pull request 2026-03-02 01:45:31 +00:00
All checks were successful
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 16s
Required
Details
CI / build (pull_request) Successful in 15s
Required
Details
CI / quality (pull_request) Successful in 23s
Required
Details
CI / security (pull_request) Successful in 30s
Required
Details
CI / typecheck (pull_request) Successful in 55s
Required
Details
CI / integration_tests (pull_request) Successful in 2m55s
Required
Details
CI / benchmark-regression (pull_request) Successful in 21m55s
Details
CI / unit_tests (pull_request) Successful in 24m41s
Required
Details
CI / docker (pull_request) Successful in 52s
Required
Details
CI / coverage (pull_request) Successful in 24m45s
Required
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
freemo
Labels
Clear labels   
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  
controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  
auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  
auto/claimed-implementer
Currently being processed by an implementer worker.

  
auto/claimed-merge
Currently being processed by the merge driver.

  
auto/claimed-reviewer
Currently being processed by a reviewer worker.

  
auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  
auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  
auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  
auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  
Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.

  
auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.

  
auto/needs-implementer
Failing CI needs implementer attention.

  
auto/postmortem
Documenting a driver incident or rollback.

  
auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  
auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  
auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  
auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  
auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  
auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  
Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.

  
Bounty
$100
 A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$1000
 A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$10000
 A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$20
 A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$2000
 A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$250
 A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$50
 A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$500
 A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$5000
 A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$750
 A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  
MoSCoW
Could have
 Could have feature in order to satisfy the epic/legendary.

  
MoSCoW
Must have
 Must have feature in order to satisfy the epic/legendary.

  
MoSCoW
Should have
 Should have feature in order to satisfy the epic/legendary.

  
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.

  
Points
1
 1 man-hours worth of work for an expert with no learning curve.

  
Points
13
 13 man-hours worth of work for an expert with no learning curve.

  
Points
2
 2 man-hours worth of work for an expert with no learning curve.

  
Points
21
 21 man-hours worth of work for an expert with no learning curve.

  
Points
3
 3 man-hours worth of work for an expert with no learning curve.

  
Points
34
 34 man-hours worth of work for an expert with no learning curve.

  
Points
5
 5 man-hours worth of work for an expert with no learning curve.

  
Points
55
 55 man-hours worth of work for an expert with no learning curve.

  
Points
8
 8 man-hours worth of work for an expert with no learning curve.

  
Points
88
 88 man-hours worth of work for an expert with no learning curve.

  
Priority
Backlog
 This ticket has backlogged priority and is not to be worked on yet

  
Priority
CI Blocker
 Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  
State
Completed
 The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  
State
Duplicate
 A ticket that represents the same content as an existing ticket.

  
State
In Progress
 A ticket that is actively being developed.

  
State
In Review
 A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  
State
Paused
 This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  
State
Unverified
 All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  
State
Verified
 The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  
State
Wont Do
 This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  
Type
Automation
 Any edits or discussion about the AI automated coding system.

  
Type
Bug
 Something that doesnt work as intended.

  
Type
Discussion
 Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  
Type
Documentation
 An error or improvement needed in the documentation.

  
Type
Epic
 Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  
Type
Feature
 Some new functionality not present.

  
Type
Legendary
 A type of Epic which will contain other Epics.

  
Type
Refactor
 A code change that restructures existing code without changing its external behavior.

  
Type
Support
 Someone needs help using the project.

  
Type
Task
 A generic task that doesnt fit into the other type categories.

  
Type
Testing
 Work exclusively focusing on fixing or expanding testing.

No labels
auto/needs-reevaluation
controller-managed
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core!484
No description provided.