feat(actor): add plan_subplan tool and decision emission #463

Merged

aditya merged 11 commits from feature/m5-subplan-actor into master 2026-03-05 07:12:22 +00:00

Conversation 5 Commits 11 Files Changed 11

+1570 -4

11 Commits

Author	SHA1	Message	Date
aditya	7ab5d8661a	Merge branch 'master' into feature/m5-subplan-actor	2026-03-05 06:35:45 +00:00
aditya	5f0bc97d46	Merge branch 'master' into feature/m5-subplan-actor ... # Conflicts: # CHANGELOG.md	2026-03-03 14:55:28 +00:00
aditya	c4cda5d6d8	fix(actor): address second round code review on plan_subplan tool ... - Fix rationale test to assert goal text appears in rationale rather than only checking non-empty (P1-1) - Align side_effects value to specification: use ["spawn_subplan"] instead of ["emit_decision"] per docs/specification.md §18259 (P2-1) - Remove dead TYPE_CHECKING import guard that contained only pass (P2-2) - Replace frozenset with tuple for _VALID_CONTEXT_VIEWS to ensure deterministic JSON schema enum ordering and eliminate CI noise (P2-3) - Simplify validation error message and schema unpacking now that context_view values are in a pre-sorted tuple	2026-03-03 14:40:37 +00:00
aditya	d2f9e4a43b	Merge branch 'master' into feature/m5-subplan-actor	2026-03-02 12:31:06 +00:00
aditya	eb4e6f59d9	Merge branch 'master' into feature/m5-subplan-actor	2026-03-02 09:02:40 +00:00
aditya	da21881c0c	Merge branch 'master' into feature/m5-subplan-actor	2026-03-02 08:22:39 +00:00
aditya	6ca7712585	Merge branch 'master' into feature/m5-subplan-actor	2026-03-02 08:21:38 +00:00
aditya	ef65996ca2	fix(actor): address code review findings on plan_subplan tool ... - Return parent_decision_id in handler result dict and add meaningful assertion to the corresponding Behave scenario (B1) - Add ULID format validators to SubplanPayload for plan_id, dependencies, and parent_decision_id, consistent with Decision model validation (S1) - Add non-empty string validator for resource_scopes items (S2) - Narrow broad except Exception to except (ValidationError, ValueError) so programming errors surface as real failures (S3) - Document strategy_with_subplan.yaml in actors_examples.md and assert it is referenced in the "Verify all examples are documented" scenario (B2) ISSUES CLOSED: #198	2026-03-02 08:17:21 +00:00
aditya	131be21e80	fix(tests): update actor_examples count to 7 after subplan example ... Refs: #198	2026-02-27 09:24:34 +00:00
aditya	2b5b73c689	Merge branch 'master' into feature/m5-subplan-actor	2026-02-27 08:43:40 +00:00
aditya	b888afab71	feat(actor): add plan_subplan tool and decision emission ... Add builtin/plan-subplan tool for strategy actors to emit SUBPLAN_SPAWN or SUBPLAN_PARALLEL_SPAWN decisions when decomposing a plan into child plans. Implements all acceptance criteria from issue #198: - SubplanPayload (Pydantic) validates goal, resource_scopes/project_ref (at least one required), merge_strategy, max_parallel (1-50), parallel flag, dependencies, and context_view override. - Defaults: merge_strategy=git_three_way, max_parallel=5, parallel=False, dependencies=[]. Omitted fields inherit sensible values automatically. - make_plan_subplan_spec(decision_service=None) factory supports optional DecisionService injection for persistent decision recording. - _build_rationale() generates human-readable rationale text (goal, scope, execution mode, dependencies, context_view) surfaced in plan explain. - register_subplan_tool() added to tool/builtins/__init__.py for bulk registration. PLAN_SUBPLAN_SPEC exported as the default ready-to-use spec. - Actor YAML example (examples/actors/strategy_with_subplan.yaml) with annotated serial and parallel spawn payload examples. - Behave BDD: 20 scenarios, 70 steps covering validation, defaults, decision type, rationale, service injection, registry, and ToolRunner. - Robot Framework: 9 smoke tests via robot/plan_subplan_tool.robot. - ASV benchmarks: benchmarks/subplan_actor_tool_bench.py (5 suites). - Coverage: 100% on subplan_tool.py. Lint, typecheck, and security clean. ISSUES CLOSED: #198	2026-02-27 08:02:48 +00:00