cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

docs: architecture — correct SandboxStrategy protocol name, write() return type, and registration config #4583

Closed
HAL9000 wants to merge 1 commits from spec/fix-sandbox-strategy-protocol-name into master
pull from: spec/fix-sandbox-strategy-protocol-name
merge into: cleveragents:master
Conversation 13 Commits 1 Files Changed 1
+27 -3

1 Commits

Author SHA1 Message Date
HAL9000 e4288c4a44 docs(spec): correct SandboxStrategy protocol name, write() return type, and registration config
CI / lint (pull_request) Successful in 39s
Details
CI / quality (pull_request) Successful in 36s
Details
CI / typecheck (pull_request) Successful in 51s
Details
CI / security (pull_request) Successful in 50s
Details
CI / push-validation (pull_request) Successful in 21s
Details
CI / helm (pull_request) Successful in 41s
Details
CI / build (pull_request) Successful in 3m17s
Details
CI / e2e_tests (pull_request) Successful in 6m22s
Details
CI / integration_tests (pull_request) Successful in 7m34s
Details
CI / unit_tests (pull_request) Successful in 8m29s
Details
CI / docker (pull_request) Successful in 11s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / coverage (pull_request) Successful in 14m5s
Details
CI / status-check (pull_request) Successful in 1s
Details
CI / benchmark-regression (pull_request) Successful in 1h0m11s
Details 
Fix three inaccuracies in the Custom Sandbox Strategies section:

1. Rename SandboxStrategy to SandboxStrategyProtocol to match the
   implementation in sandbox_strategy.py (Protocol suffix is the
   correct Python convention for structural protocols)

2. Correct write() return type from Change to DiffEntry — Change
   does not exist in the sandbox strategy module; DiffEntry is the
   actual Pydantic model used

3. Replace vague registration description with concrete TOML config
   example showing sandbox.custom_strategies.<name>.module and .class
   keys, plus YAML resource type reference

All corrections verified against:
  src/cleveragents/domain/models/core/sandbox_strategy.py

ISSUES CLOSED: #4523
 2026-04-12 16:48:33 +00:00