feat(examples/actors/code_review.yaml): add a new code review tool #458

Merged

brent.edwards merged 2 commits from feature/code-reviewer into master 2026-03-19 22:42:16 +00:00

Conversation 13 Commits 2 Files changed 2 +48 -1

brent.edwards commented 2026-02-27 00:48:14 +00:00

Member

Copy link

Summary

Add a code_review.yaml actor example that uses Claude Opus 4 with file and git tools to perform automated code reviews against the project's review playbook.

Changes

• New file: examples/actors/code_review.yaml — LLM actor configured with files/read_file, files/list_directory, and builtin/git-* tools, with a system prompt that reads docs/development/review-playbook.md and diffs against master
• Updated: features/actor_examples.feature — bumped example count from 7 to 8 and added code_review.yaml to the file listing assertion

Verification

• nox -e lint — passed
• nox -e typecheck — 0 errors
• nox -e format -- --check — all files formatted
• nox -s unit_tests -- features/actor_examples.feature — 25 scenarios passed

Rebase Notes

• Rebased onto current master (4d3499dc)
• Squashed 2 commits into 1 (eliminated 3 merge commits)
• Resolved conflict in actor_examples.feature: master added strategy_with_subplan.yaml (count 7), our branch adds code_review.yaml (count now 8)

## Summary Add a `code_review.yaml` actor example that uses Claude Opus 4 with file and git tools to perform automated code reviews against the project's review playbook. ### Changes - **New file**: `examples/actors/code_review.yaml` — LLM actor configured with `files/read_file`, `files/list_directory`, and `builtin/git-*` tools, with a system prompt that reads `docs/development/review-playbook.md` and diffs against `master` - **Updated**: `features/actor_examples.feature` — bumped example count from 7 to 8 and added `code_review.yaml` to the file listing assertion ### Verification - `nox -e lint` — passed - `nox -e typecheck` — 0 errors - `nox -e format -- --check` — all files formatted - `nox -s unit_tests -- features/actor_examples.feature` — 25 scenarios passed ### Rebase Notes - Rebased onto current master (`4d3499dc`) - Squashed 2 commits into 1 (eliminated 3 merge commits) - Resolved conflict in `actor_examples.feature`: master added `strategy_with_subplan.yaml` (count 7), our branch adds `code_review.yaml` (count now 8)

brent.edwards scheduled this pull request to auto merge when all checks succeed 2026-02-28 01:11:09 +00:00

brent.edwards canceled auto merging this pull request when all checks succeed 2026-02-28 01:12:15 +00:00

freemo added the

Type

Feature

label 2026-02-28 02:14:51 +00:00

freemo added the

MoSCoW

Could have

Points

1

Priority

Low

State

Verified

labels 2026-03-01 04:36:10 +00:00

freemo added this to the v3.6.0 milestone 2026-03-04 01:04:19 +00:00

freemo self-assigned this 2026-03-04 01:41:44 +00:00

freemo reviewed 2026-03-05 03:35:25 +00:00

freemo left a comment

Copy link

PM Review — Day 25

Status

• Stale — opened Feb 27, zero reviews, zero comments in 6 days.
• Incomplete PR template — quality checklist unchecked, no description, no testing evidence, no linked issues.
• Labeled as Points/1, Priority/Low, MoSCoW/Could have — appropriately low priority.

Action Items

• @freemo / @brent.edwards: This PR was created by Brent but assigned to Jeff. Please clarify ownership. If this is still relevant, fill out the PR template and request a review. If it has been superseded or deprioritized, please close it to reduce clutter.

Priority

Very low — v3.6.0, MoSCoW/Could have. No action needed until current milestone work is resolved.

## PM Review — Day 25 ### Status - **Stale** — opened Feb 27, zero reviews, zero comments in 6 days. - **Incomplete PR template** — quality checklist unchecked, no description, no testing evidence, no linked issues. - Labeled as Points/1, Priority/Low, MoSCoW/Could have — appropriately low priority. ### Action Items - **@freemo / @brent.edwards**: This PR was created by Brent but assigned to Jeff. Please clarify ownership. If this is still relevant, fill out the PR template and request a review. If it has been superseded or deprioritized, please close it to reduce clutter. ### Priority Very low — v3.6.0, MoSCoW/Could have. No action needed until current milestone work is resolved.

freemo commented 2026-03-06 23:23:46 +00:00

Owner

Copy link

PM Note (Day 26 — Stale PR Triage):

This PR has been open 8+ days, has a merge conflict, and is tagged v3.6.0/Could Have/Points 1. The PR body has not been filled in beyond the template.

Observations:

• The branch feature/code-reviewer has a merge conflict with master
• No issue is linked (the Related Issues section is empty)
• The description says only "The new tool is the simplest code review tool"
• Quality checklist is entirely unchecked
• This is a v3.6.0 item — not on the critical path

Recommendation: @brent.edwards @freemo — This PR should be closed until it's ready to be properly submitted. When the time comes (v3.6.0 scope), it should be rebased, linked to a proper issue per CONTRIBUTING.md, and the PR body filled out completely. The feature/code-reviewer branch can be kept for future use.

Please confirm closure or provide a plan to update this PR within 48 hours.

**PM Note (Day 26 — Stale PR Triage):** This PR has been open 8+ days, has a **merge conflict**, and is tagged v3.6.0/Could Have/Points 1. The PR body has not been filled in beyond the template. **Observations:** - The branch `feature/code-reviewer` has a merge conflict with master - No issue is linked (the `Related Issues` section is empty) - The description says only "The new tool is the simplest code review tool" - Quality checklist is entirely unchecked - This is a v3.6.0 item — not on the critical path **Recommendation:** @brent.edwards @freemo — This PR should be **closed** until it's ready to be properly submitted. When the time comes (v3.6.0 scope), it should be rebased, linked to a proper issue per CONTRIBUTING.md, and the PR body filled out completely. The feature/code-reviewer branch can be kept for future use. Please confirm closure or provide a plan to update this PR within 48 hours.

brent.edwards commented 2026-03-07 01:45:54 +00:00

Author

Member

Copy link

Closing.

Closing.

brent.edwards closed this pull request 2026-03-07 01:45:54 +00:00

brent.edwards reopened this pull request 2026-03-10 23:59:38 +00:00

freemo commented 2026-03-11 04:45:19 +00:00

Owner

Copy link

@brent.edwards this looks like a great tool. Just test it to make sure it works of course, and if it does it has my approval!

@brent.edwards this looks like a great tool. Just test it to make sure it works of course, and if it does it has my approval!

freemo approved these changes 2026-03-11 04:45:28 +00:00

Dismissed

freemo commented 2026-03-11 05:51:06 +00:00

Owner

Copy link

PM Status (Day 31):

This PR is APPROVED by @freemo but has a merge conflict.

Action required: @brent.edwards — rebase and push. Once conflict resolved, this can merge.

Priority: LOW — Priority/Low, MoSCoW/Could have. Focus on bugs #554/#570 first (see escalation comments on those issues).

**PM Status (Day 31)**: This PR is APPROVED by @freemo but has a merge conflict. **Action required**: @brent.edwards — rebase and push. Once conflict resolved, this can merge. **Priority**: LOW — `Priority/Low`, `MoSCoW/Could have`. Focus on bugs #554/#570 first (see escalation comments on those issues).

brent.edwards force-pushed feature/code-reviewer from cd79cebc0c to 312b21dccc 2026-03-11 18:10:43 +00:00 Compare

brent.edwards dismissed freemo's review 2026-03-11 18:10:53 +00:00

Reason:

New commits pushed, approval review dismissed automatically according to repository settings

brent.edwards commented 2026-03-11 18:11:05 +00:00

Author

Member

Copy link

Rebased onto master (4d3499dc), squashed 2 commits + 3 merge commits into a single clean commit (312b21dc).

Conflict resolved: features/actor_examples.feature — master added strategy_with_subplan.yaml (count went from 6→7), our branch adds code_review.yaml (count now 8). Both entries preserved.

Local checks passed: lint, typecheck, format, unit_tests (25 scenarios in actor_examples.feature).

Ready for merge per @freemo's approval.

Rebased onto master (`4d3499dc`), squashed 2 commits + 3 merge commits into a single clean commit (`312b21dc`). **Conflict resolved**: `features/actor_examples.feature` — master added `strategy_with_subplan.yaml` (count went from 6→7), our branch adds `code_review.yaml` (count now 8). Both entries preserved. **Local checks passed**: lint, typecheck, format, unit_tests (25 scenarios in `actor_examples.feature`). Ready for merge per @freemo's approval.

freemo commented 2026-03-11 18:17:30 +00:00

Owner

Copy link

PM Review — Day 31 (Specification Update)

Merge conflict detected. This conflict is due to significant specification changes made today (ACP→A2A protocol adoption, TUI overhaul, server architecture redesign — see ADR-047, ADR-048).

Status

• APPROVED by @freemo but needs rebase
• v3.6.0/M7 — low priority, focus on bug fixes first
• PR #676 (server) and #667 (TUI) have been closed as obsolete due to spec changes

Action Required

@brent.edwards — Rebase against master when ready. This is LOW priority — focus on bugs #554/#570 and TDD work first.

Milestone: Remains v3.6.0 (M7 — Advanced Concepts).

## PM Review — Day 31 (Specification Update) **Merge conflict** detected. This conflict is due to significant specification changes made today (ACP→A2A protocol adoption, TUI overhaul, server architecture redesign — see ADR-047, ADR-048). ### Status - APPROVED by @freemo but needs rebase - v3.6.0/M7 — low priority, focus on bug fixes first - PR #676 (server) and #667 (TUI) have been closed as obsolete due to spec changes ### Action Required @brent.edwards — Rebase against `master` when ready. This is LOW priority — focus on bugs #554/#570 and TDD work first. **Milestone**: Remains v3.6.0 (M7 — Advanced Concepts).

freemo reviewed 2026-03-12 20:45:13 +00:00

freemo left a comment

Copy link

PM Review Update — Day 32

Status: Updated since Day 25 stale review

Changes Since Last Review

This PR has been significantly improved since the Day 25 stale review:

• PR body now includes full summary, changes list, verification results, and rebase notes.
• Rebased onto current master (4d3499dc), squashed to 1 clean commit.
• Resolved conflict in actor_examples.feature (count 7 → 8).
• Jeff's prior APPROVED review is now stale (dismissed) due to the rebase.

Current State

• Mergeable: Yes.
• Labels: Complete (Type/Feature, Priority/Low, MoSCoW/Could have, Points/1, State/Verified).
• Milestone: v3.6.0 (M7) — appropriate for a code review tool example.
• Quality gates: lint, typecheck, format all pass. 25 BDD scenarios pass.

Recommendation

This is a low-priority, low-risk PR (1 story point, Could have). The previous approval was dismissed by the rebase. @freemo: Since you approved the previous commit and you're already the assignee, a quick re-approval of the rebased commit would unblock the merge. No urgency — M7 due Mar 28.

## PM Review Update — Day 32 ### Status: Updated since Day 25 stale review ### Changes Since Last Review This PR has been significantly improved since the Day 25 stale review: - PR body now includes full summary, changes list, verification results, and rebase notes. - Rebased onto current master (`4d3499dc`), squashed to 1 clean commit. - Resolved conflict in `actor_examples.feature` (count 7 → 8). - Jeff's prior APPROVED review is now stale (dismissed) due to the rebase. ### Current State - **Mergeable**: Yes. - **Labels**: Complete (Type/Feature, Priority/Low, MoSCoW/Could have, Points/1, State/Verified). - **Milestone**: v3.6.0 (M7) — appropriate for a code review tool example. - **Quality gates**: lint, typecheck, format all pass. 25 BDD scenarios pass. ### Recommendation This is a low-priority, low-risk PR (1 story point, Could have). The previous approval was dismissed by the rebase. **@freemo**: Since you approved the previous commit and you're already the assignee, a quick re-approval of the rebased commit would unblock the merge. No urgency — M7 due Mar 28.

freemo reviewed 2026-03-16 16:26:54 +00:00

freemo left a comment

Copy link

PM Day 36: Code review actor YAML example. Closes related example issue. M7 scope. Low priority. @aditya author.

PM Day 36: Code review actor YAML example. Closes related example issue. M7 scope. Low priority. @aditya author.

freemo approved these changes 2026-03-16 23:00:30 +00:00

Dismissed

brent.edwards was assigned by freemo 2026-03-16 23:01:20 +00:00

freemo removed their assignment 2026-03-16 23:01:20 +00:00

freemo commented 2026-03-16 23:01:48 +00:00

Owner

Copy link

@brent.edwards Why assigned to me. I approve, just get it working ont he integration tests and then your good. I re-assigned it back to you

@brent.edwards Why assigned to me. I approve, just get it working ont he integration tests and then your good. I re-assigned it back to you

freemo commented 2026-03-17 18:39:19 +00:00

Owner

Copy link

PM Status — Day 37 (2026-03-17)

Status: APPROVED by @freemo, but has merge conflicts (again). Reassigned back to @brent.edwards. v3.6.0, Could Have, 1 point — lowest priority.

Blocker: Merge conflict with master. Needs rebase + integration test verification.

Action required:

• @brent.edwards — Rebase when bandwidth allows. This is LOW priority — focus on M3 bug fixes and #791/#798 first. Verify integration tests pass after rebase.

PM status — Day 37

## PM Status — Day 37 (2026-03-17) **Status**: APPROVED by @freemo, but has merge conflicts (again). Reassigned back to @brent.edwards. v3.6.0, Could Have, 1 point — lowest priority. **Blocker**: Merge conflict with master. Needs rebase + integration test verification. **Action required**: - @brent.edwards — Rebase when bandwidth allows. This is LOW priority — focus on M3 bug fixes and #791/#798 first. Verify integration tests pass after rebase. *PM status — Day 37*

brent.edwards force-pushed feature/code-reviewer from 312b21dccc to 907ec6ee5f 2026-03-19 22:04:30 +00:00 Compare

brent.edwards dismissed freemo's review 2026-03-19 22:04:31 +00:00

Reason:

New commits pushed, approval review dismissed automatically according to repository settings

brent.edwards added 1 commit 2026-03-19 22:32:27 +00:00

Merge branch 'master' into feature/code-reviewer cc1a63d995

brent.edwards scheduled this pull request to auto merge when all checks succeed 2026-03-19 22:39:46 +00:00

brent.edwards merged commit 714d799ae9 into master 2026-03-19 22:42:16 +00:00

brent.edwards deleted branch feature/code-reviewer 2026-03-19 22:42:16 +00:00

brent.edwards referenced this pull request from a commit 2026-03-19 22:42:17 +00:00

feat(examples/actors/code_review.yaml): add a new code review tool (#458)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

auto/needs-reevaluation

Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  

controller-managed

Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  

auto/blocked-by-deps

PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  

auto/ci-timeout

Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  

auto/claimed-implementer

Currently being processed by an implementer worker.

  

auto/claimed-merge

Currently being processed by the merge driver.

  

auto/claimed-reviewer

Currently being processed by a reviewer worker.

  

auto/driver-down

Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  

auto/invariant-violation

Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  

auto/last-attempt-tier-0

In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-1

In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-2

In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  

auto/last-attempt-tier-min

In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  

Automation Tracking

Tracking issues used by the AI Automation system for agents to communicate and report.

  

auto/needs-conflict-resolution

Rebase conflict needs LLM conflict-resolver.

  

auto/needs-implementer

Failing CI needs implementer attention.

  

auto/postmortem

Documenting a driver incident or rollback.

  

auto/ready-to-merge

Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  

auto/restart-throttled

Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  

auto/revert

Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  

auto/sentinel

Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  

auto/stale-inactivity

No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  

auto/unstable

Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  

Blocked

A ticket in a blocked state and unable to complete until some other task is completed first.

  

Bounty

$100

A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$1000

A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$10000

A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$20

A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$2000

A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$250

A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$50

A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$500

A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$5000

A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$750

A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  

MoSCoW

Could have

Could have feature in order to satisfy the epic/legendary.

  

MoSCoW

Must have

Must have feature in order to satisfy the epic/legendary.

  

MoSCoW

Should have

Should have feature in order to satisfy the epic/legendary.

  

Needs Feedback

There are questions in the ticket that can not be completed until the project owner provides clarity.

  

Points

1

1 man-hours worth of work for an expert with no learning curve.

  

Points

13

13 man-hours worth of work for an expert with no learning curve.

  

Points

2

2 man-hours worth of work for an expert with no learning curve.

  

Points

21

21 man-hours worth of work for an expert with no learning curve.

  

Points

3

3 man-hours worth of work for an expert with no learning curve.

  

Points

34

34 man-hours worth of work for an expert with no learning curve.

  

Points

5

5 man-hours worth of work for an expert with no learning curve.

  

Points

55

55 man-hours worth of work for an expert with no learning curve.

  

Points

8

8 man-hours worth of work for an expert with no learning curve.

  

Points

88

88 man-hours worth of work for an expert with no learning curve.

  

Priority

Backlog

This ticket has backlogged priority and is not to be worked on yet

  

Priority

CI Blocker

Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Signed-off: Owner

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Scrum Master

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Tech Lead

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Spike

A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  

State

Completed

The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  

State

Duplicate

A ticket that represents the same content as an existing ticket.

  

State

In Progress

A ticket that is actively being developed.

  

State

In Review

A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  

State

Paused

This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  

State

Unverified

All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  

State

Verified

The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  

State

Wont Do

This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  

Type

Automation

Any edits or discussion about the AI automated coding system.

  

Type

Bug

Something that doesnt work as intended.

  

Type

Discussion

Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  

Type

Documentation

An error or improvement needed in the documentation.

  

Type

Epic

Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  

Type

Feature

Some new functionality not present.

  

Type

Legendary

A type of Epic which will contain other Epics.

  

Type

Refactor

A code change that restructures existing code without changing its external behavior.

  

Type

Support

Someone needs help using the project.

  

Type

Task

A generic task that doesnt fit into the other type categories.

  

Type

Testing

Work exclusively focusing on fixing or expanding testing.

No labels

auto/needs-reevaluation

controller-managed

auto/blocked-by-deps

auto/ci-timeout

auto/claimed-implementer

auto/claimed-merge

auto/claimed-reviewer

auto/driver-down

auto/invariant-violation

auto/last-attempt-tier-0

auto/last-attempt-tier-1

auto/last-attempt-tier-2

auto/last-attempt-tier-min

Automation Tracking

auto/needs-conflict-resolution

auto/needs-implementer

auto/postmortem

auto/ready-to-merge

auto/restart-throttled

auto/revert

auto/sentinel

auto/stale-inactivity

auto/unstable

Blocked

Bounty

$100

Bounty

$1000

Bounty

$10000

Bounty

$20

Bounty

$2000

Bounty

$250

Bounty

$50

Bounty

$500

Bounty

$5000

Bounty

$750

MoSCoW

Could have

MoSCoW

Must have

MoSCoW

Should have

Needs Feedback

Points

1

Points

13

Points

2

Points

21

Points

3

Points

34

Points

5

Points

55

Points

8

Points

88

Priority

Backlog

Priority

CI Blocker

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Signed-off: Owner

Signed-off: Scrum Master

Signed-off: Tech Lead

Spike

State

Completed

State

Duplicate

State

In Progress

State

In Review

State

Paused

State

Unverified

State

Verified

State

Wont Do

Type

Automation

Type

Bug

Type

Discussion

Type

Documentation

Type

Epic

Type

Feature

Type

Legendary

Type

Refactor

Type

Support

Type

Task

Type

Testing

Milestone

Clear milestone

No items

No milestone

v3.6.0

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

brent.edwards

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

cleveragents/cleveragents-core!458

No description provided.