cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

feat(skill): add agent skills loader #453

Merged
aditya merged 6 commits from feature/m3-agent-skills-loader into master 2026-02-27 10:22:02 +00:00
Conversation 2 Commits 6 Files Changed 12
+3159
aditya commented 2026-02-26 09:29:10 +00:00
Member
Copy Link
Copy Source

Description

Implements the Agent Skills Standard loader (AgentSkillSpec) that parses SKILL.md frontmatter and progressive disclosure sections into structured tool definitions. Agent Skills are mapped to Tool/Validation definitions with namespaced naming, resource binding slots, and read-only defaults.

Changes

Core Implementation

  • src/cleveragents/skills/agent_skill_loader.py — Full AgentSkillSpec loader (~780 lines)
    • AgentSkillSpec, AgentSkillStep, AgentSkillSupportDir Pydantic models
    • AgentSkillLoadError exception with actionable messages
    • load_agent_skill_spec() — full SKILL.md parser (frontmatter + steps + support dirs)
    • scan_support_directories() — scripts/references/assets scanning
    • map_agent_skill_to_tool() — maps to Tool domain model with resource slots + read-only defaults
    • map_agent_skill_to_tool_spec() — maps to ToolSpec for registry
    • validate_skill_spec() — post-load validation
  • src/cleveragents/skills/__init__.py — Updated imports and __all__ with 9 new exports

Tests

  • features/agent_skill_loader.feature — 35 Behave scenarios covering:
    • Valid/invalid SKILL.md parsing
    • Step ordering and heading level handling
    • Support directory scanning
    • Namespaced tool mapping
    • Missing frontmatter field errors
    • Path traversal prevention
  • features/steps/agent_skill_loader_steps.py — Step implementations
  • robot/agent_skill_loader.robot — 10 Robot integration test cases
  • robot/helper_agent_skill_loader.py — Robot helper

Benchmarks & Documentation

  • benchmarks/agent_skills_loader_bench.py — 6 ASV benchmark suites
  • docs/reference/agent_skills.md — Full reference documentation

Acceptance Criteria

  • AgentSkillSpec loader parses SKILL.md frontmatter + progressive disclosure sections
  • Map Agent Skills to Tool/Validation definitions with namespaced naming
  • Support scripts/, references/, and assets/ folders with path normalization
  • Explicit validation for missing frontmatter fields with actionable errors
  • Docs: docs/reference/agent_skills.md
  • Behave tests: valid/invalid SKILL.md parsing, namespaced naming, step ordering
  • Robot tests: Load sample Agent Skills folder and verify tool metadata
  • ASV benchmarks: benchmarks/agent_skills_loader_bench.py
  • nox -s lint passes
  • nox -s typecheck passes

Closes #160

## Description Implements the Agent Skills Standard loader (`AgentSkillSpec`) that parses `SKILL.md` frontmatter and progressive disclosure sections into structured tool definitions. Agent Skills are mapped to Tool/Validation definitions with namespaced naming, resource binding slots, and read-only defaults. ## Changes ### Core Implementation - `src/cleveragents/skills/agent_skill_loader.py` — Full `AgentSkillSpec` loader (~780 lines) - `AgentSkillSpec`, `AgentSkillStep`, `AgentSkillSupportDir` Pydantic models - `AgentSkillLoadError` exception with actionable messages - `load_agent_skill_spec()` — full SKILL.md parser (frontmatter + steps + support dirs) - `scan_support_directories()` — scripts/references/assets scanning - `map_agent_skill_to_tool()` — maps to Tool domain model with resource slots + read-only defaults - `map_agent_skill_to_tool_spec()` — maps to ToolSpec for registry - `validate_skill_spec()` — post-load validation - `src/cleveragents/skills/__init__.py` — Updated imports and `__all__` with 9 new exports ### Tests - `features/agent_skill_loader.feature` — 35 Behave scenarios covering: - Valid/invalid SKILL.md parsing - Step ordering and heading level handling - Support directory scanning - Namespaced tool mapping - Missing frontmatter field errors - Path traversal prevention - `features/steps/agent_skill_loader_steps.py` — Step implementations - `robot/agent_skill_loader.robot` — 10 Robot integration test cases - `robot/helper_agent_skill_loader.py` — Robot helper ### Benchmarks & Documentation - `benchmarks/agent_skills_loader_bench.py` — 6 ASV benchmark suites - `docs/reference/agent_skills.md` — Full reference documentation ## Acceptance Criteria - [x] AgentSkillSpec loader parses SKILL.md frontmatter + progressive disclosure sections - [x] Map Agent Skills to Tool/Validation definitions with namespaced naming - [x] Support scripts/, references/, and assets/ folders with path normalization - [x] Explicit validation for missing frontmatter fields with actionable errors - [x] Docs: docs/reference/agent_skills.md - [x] Behave tests: valid/invalid SKILL.md parsing, namespaced naming, step ordering - [x] Robot tests: Load sample Agent Skills folder and verify tool metadata - [x] ASV benchmarks: benchmarks/agent_skills_loader_bench.py - [x] nox -s lint passes - [x] nox -s typecheck passes Closes #160
aditya added 1 commit 2026-02-26 09:29:10 +00:00
feat(skill): add agent skills loader cb82fc51df 
Implemented AgentSkillSpec loader that parses SKILL.md frontmatter and
progressive disclosure sections (discover/activate/deactivate) into
structured SkillStep objects with stable 1-based ordering.

Mapped Agent Skills to AgentSkillToolDescriptor with namespaced naming
(namespace/short_name), source="agent_skill", read-only defaults, and
AgentSkillResourceSlot bindings for scripts/, references/, and assets/
directories. All resource slots are unconditionally read_only.

Added explicit validation for missing frontmatter fields (name,
description) and invalid namespace format with actionable error messages.

Added docs/reference/agent_skills.md covering folder layout, SKILL.md
parsing rules, progressive disclosure model, and tool mapping.

Added Behave scenarios covering valid/invalid SKILL.md parsing,
namespaced naming, step ordering, missing frontmatter errors, progressive
disclosure lifecycle, tool mapping, and resource binding slots.

Added Robot Framework integration tests using the deploy-to-staging
example skill folder (robot/agent_skills_loader.robot).

Added ASV benchmarks for parsing throughput, folder load, progressive
disclosure lifecycle, and resource listing
(benchmarks/agent_skills_loader_bench.py).

ISSUES CLOSED: #160
aditya requested review from CoreRasurae 2026-02-26 09:29:21 +00:00
hamza.khyari commented 2026-02-26 13:31:04 +00:00
Member
Copy Link
Copy Source

What It Does

Adds the Agent Skills Standard loader (AgentSkillSpec / AgentSkillLoader) that parses SKILL.md frontmatter into structured tool definitions with a three-tier progressive disclosure model (discover / activate / deactivate). Includes Pydantic v2 models, resource binding slots for scripts/, references/, assets/ directories, full Behave test suite (50 scenarios), Robot integration tests (8 cases), ASV benchmarks, and reference docs.

Blocking Issues

  1. PR title not matching the the standard naming convention
  2. PR has zero labels — Needs exactly one Type/Feature label.
  3. Any used in function signatures — agent_skills_loader.py has dict[str, Any] in multiple signatures and Pydantic fields. Must eliminate Any.
  4. CHANGELOG commit missing issue footer — The chore: update CHANGELOG... commit has no Refs: #160 footer.
    Non-Blocking Issues
  5. Three files exceed 500-line limit — agent_skills_loader.py (~792), step defs (786), feature file (695). Should be split as a follow-up.

What Looks Good

  • Clean architecture: spec (data) / loader (lifecycle) / descriptor (registry view)
  • Frozen Pydantic models, strong validation with actionable error messages
  • Thorough test coverage across all layers (Behave, Robot, ASV)
  • No mocks in production code, proper temp dir cleanup
  • Path safety enforced via Path.resolve() + rglob()
## What It Does Adds the Agent Skills Standard loader (AgentSkillSpec / AgentSkillLoader) that parses SKILL.md frontmatter into structured tool definitions with a three-tier progressive disclosure model (discover / activate / deactivate). Includes Pydantic v2 models, resource binding slots for scripts/, references/, assets/ directories, full Behave test suite (50 scenarios), Robot integration tests (8 cases), ASV benchmarks, and reference docs. ## Blocking Issues 0. PR title not matching the the standard naming convention 1. PR has zero labels — Needs exactly one Type/Feature label. 2. Any used in function signatures — agent_skills_loader.py has dict[str, Any] in multiple signatures and Pydantic fields. Must eliminate Any. 3. CHANGELOG commit missing issue footer — The chore: update CHANGELOG... commit has no Refs: #160 footer. Non-Blocking Issues 4. Three files exceed 500-line limit — agent_skills_loader.py (~792), step defs (786), feature file (695). Should be split as a follow-up. ## What Looks Good - Clean architecture: spec (data) / loader (lifecycle) / descriptor (registry view) - Frozen Pydantic models, strong validation with actionable error messages - Thorough test coverage across all layers (Behave, Robot, ASV) - No mocks in production code, proper temp dir cleanup - Path safety enforced via Path.resolve() + rglob()
aditya added this to the v3.1.0 milestone 2026-02-26 13:36:12 +00:00
aditya force-pushed feature/m3-agent-skills-loader from 476823dd1a to f8bc02869a 2026-02-26 14:47:16 +00:00 Compare
aditya added 1 commit 2026-02-26 14:53:24 +00:00
Merge branch 'master' into feature/m3-agent-skills-loader
CI / lint (pull_request) Successful in 22s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / quality (pull_request) Successful in 29s
Details
CI / build (pull_request) Successful in 27s
Details
CI / security (pull_request) Successful in 55s
Details
CI / typecheck (pull_request) Successful in 1m1s
Details
CI / integration_tests (pull_request) Successful in 4m35s
Details
CI / unit_tests (pull_request) Successful in 23m50s
Details
CI / docker (pull_request) Successful in 50s
Details
CI / benchmark-regression (pull_request) Successful in 26m46s
Details
CI / coverage (pull_request) Successful in 55m34s
Details
76db58414a
aditya changed title from feature/m3-agent-skills-loader to feat(skill): add agent skills loader 2026-02-26 14:53:47 +00:00
aditya added the
Type
Feature
 label 2026-02-26 14:54:33 +00:00
hamza.khyari requested review from hamza.khyari 2026-02-26 15:16:57 +00:00
hamza.khyari declined to review 2026-02-26 15:26:40 +00:00
hamza.khyari requested review from hamza.khyari 2026-02-26 15:26:52 +00:00
hamza.khyari approved these changes 2026-02-26 16:04:30 +00:00
Dismissed
hamza.khyari left a comment
Member
Copy Link
Copy Source

CI passing, one thing to consider is to split the files above 500 lines agent_skills_loader.py, agent_skills_loader_steps.py, agent_skills_loader.feature

CI passing, one thing to consider is to split the files above 500 lines agent_skills_loader.py, agent_skills_loader_steps.py, agent_skills_loader.feature
brent.edwards force-pushed feature/m3-agent-skills-loader from 76db58414a to ba46f53b5d 2026-02-26 20:46:23 +00:00 Compare
brent.edwards dismissed hamza.khyari's review 2026-02-26 20:46:23 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

aditya force-pushed feature/m3-agent-skills-loader from ba46f53b5d to 4c4bd74d94 2026-02-27 09:41:14 +00:00 Compare
aditya merged commit 9fd29b2748 into master 2026-02-27 10:22:02 +00:00
aditya deleted branch feature/m3-agent-skills-loader 2026-02-27 10:22:02 +00:00
freemo added the
State
Completed
 label 2026-03-04 00:58:41 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
CoreRasurae
Labels
Clear labels
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
 controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
 overdue
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
 auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
 auto/claimed-implementer
Currently being processed by an implementer worker.
 auto/claimed-merge
Currently being processed by the merge driver.
 auto/claimed-reviewer
Currently being processed by a reviewer worker.
 auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
 auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
 auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
 auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
 Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.
 auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.
 auto/needs-implementer
Failing CI needs implementer attention.
 auto/postmortem
Documenting a driver incident or rollback.
 auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
 auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
 auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
 auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
 auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
 auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
 Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
No Label
State
Completed
Type
Feature
Milestone
No items
No Milestone v3.1.0
Projects
Clear projects
No project
Assignees
Clear assignees
aditya (Aditya Chhabra) aleenaumair (Aleena Umair) brent.edwards (Brent Edwards) CoreRasurae (Luis Mendes) drew (Drew Morris) eugen.thaci (Eugen Thaci) freemo (Jeffrey Phillips Freeman) HAL9000 (HAL 9000) HAL9001 (HAL9001) hamza.khyari (Hamza Khyari) hurui200320 (Rui Hu) justin.morris khird (Kyle Hird) org.cleveragents
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cleveragents/cleveragents-core#453
Delete Branch "feature/m3-agent-skills-loader"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?