feature/m2-actor-yaml #432

Merged

aditya merged 4 commits from feature/m2-actor-yaml into master

2026-02-26 13:19:01 +00:00

aditya commented

2026-02-25 11:17:33 +00:00

Member

Description

Extends the hierarchical actor YAML schema and loader with per-node LSP bindings, tool-source references, subgraph actor references, and graph reachability validation. Updates the loader to report precise error locations and field paths. Adds docs/reference/actor_config.md as the authoritative configuration reference.

Type of Change

New feature (non-breaking change which adds functionality)
Documentation update
Test improvements

Quality Checklist

Code follows the project's coding standards (see CONTRIBUTING.md)
All public/protected methods have argument validation
Static typing is complete (no Any unless justified)
nox -s typecheck passes with no errors
nox -s lint passes with no errors
Unit tests written/updated (Behave scenarios in features/)
Integration tests written/updated (Robot suites in robot/) if applicable
Coverage remains above 85% (nox -s coverage_report)
No security issues introduced (nox -s security_scan)
No dead code introduced (nox -s dead_code)
Documentation updated if behavior changed

Testing

Ran the full nox suite against the implementation.

Test Commands Run

nox -s unit_tests       # Behave tests
nox -s typecheck        # Type checking
nox -s lint             # Linting
nox -s coverage_report  # Coverage
nox -s security_scan    # Security
nox -s integration_tests # Robot Framework
nox                     # Full suite including benchmark

Results:

95 Behave scenarios passed (actor_schema, actor_hierarchy, actor_loading)
10 Robot smoke tests passed (including new hierarchical loader test)
Typecheck: 0 errors, 0 warnings
Lint: all checks passed
Security scan: no issues identified
Coverage: 99% on schema.py and loader.py (threshold 97%)

Closes #157

Implementation Notes

Reachability validation accounts for both explicit edges and implicit routing targets defined inside conditional node config.conditions[].route_to — without this, valid graphs with conditional branching would be incorrectly rejected.
Loader error format now emits dotted Pydantic field paths (e.g. route.nodes.0.id) and YAML line/column positions, making schema errors actionable without manual inspection.
graph_workflow.yaml was updated to replace the deprecated config.actor_path with the top-level actor_ref field, consistent with the hierarchical schema extension.
docs/reference/actor_config.md is a new practical reference (distinct from actors_schema.md) focused on hierarchical examples, topology rules, and error-case guidance.

## Description Extends the hierarchical actor YAML schema and loader with per-node LSP bindings, tool-source references, subgraph actor references, and graph reachability validation. Updates the loader to report precise error locations and field paths. Adds `docs/reference/actor_config.md` as the authoritative configuration reference. ## Type of Change - [x] New feature (non-breaking change which adds functionality) - [x] Documentation update - [x] Test improvements ## Quality Checklist - [x] Code follows the project's coding standards (see CONTRIBUTING.md) - [x] All public/protected methods have argument validation - [x] Static typing is complete (no `Any` unless justified) - [x] `nox -s typecheck` passes with no errors - [x] `nox -s lint` passes with no errors - [x] Unit tests written/updated (Behave scenarios in `features/`) - [x] Integration tests written/updated (Robot suites in `robot/`) if applicable - [x] Coverage remains above 85% (`nox -s coverage_report`) - [x] No security issues introduced (`nox -s security_scan`) - [x] No dead code introduced (`nox -s dead_code`) - [x] Documentation updated if behavior changed ## Testing Ran the full nox suite against the implementation. ### Test Commands Run ```bash nox -s unit_tests # Behave tests nox -s typecheck # Type checking nox -s lint # Linting nox -s coverage_report # Coverage nox -s security_scan # Security nox -s integration_tests # Robot Framework nox # Full suite including benchmark ``` **Results:** - 95 Behave scenarios passed (actor_schema, actor_hierarchy, actor_loading) - 10 Robot smoke tests passed (including new hierarchical loader test) - Typecheck: 0 errors, 0 warnings - Lint: all checks passed - Security scan: no issues identified - Coverage: 99% on `schema.py` and `loader.py` (threshold 97%) ## Related Issues Closes #157 ## Implementation Notes - **Reachability validation** accounts for both explicit edges and implicit routing targets defined inside `conditional` node `config.conditions[].route_to` — without this, valid graphs with conditional branching would be incorrectly rejected. - **Loader error format** now emits dotted Pydantic field paths (e.g. `route.nodes.0.id`) and YAML line/column positions, making schema errors actionable without manual inspection. - **`graph_workflow.yaml`** was updated to replace the deprecated `config.actor_path` with the top-level `actor_ref` field, consistent with the hierarchical schema extension. - **`docs/reference/actor_config.md`** is a new practical reference (distinct from `actors_schema.md`) focused on hierarchical examples, topology rules, and error-case guidance.

Rows
Columns