feat: Add Q0: Pre-commit hooks setup. #41

Merged
brent.edwards merged 25 commits from Q0-quality-automation into master 2026-02-12 07:21:53 +00:00

25 Commits

Author SHA1 Message Date
brent.edwards 63b54ac8ab fix(nox): run asv machine --yes before benchmarks
CI / lint (pull_request) Successful in 16s
CI / typecheck (pull_request) Successful in 25s
CI / security (pull_request) Successful in 16s
CI / quality (pull_request) Successful in 14s
CI / build (pull_request) Successful in 12s
CI / behave (3.13) (pull_request) Successful in 3m45s
CI / coverage (pull_request) Successful in 4m10s
CI / docker (pull_request) Successful in 47s
asv requires machine info to be configured before running benchmarks.
Without this, asv run fails on first use or in CI/containers.
2026-02-12 07:03:31 +00:00
brent.edwards 64f58f6406 fix(deps): pin behave==1.2.6 in tests extra to match dev extra
behave-parallel pulls behave>=1.2.6 which resolves to 1.3.3. Behave
1.3.3 no longer strips trailing colons from step text before tables,
breaking the architecture.feature step matcher.
2026-02-12 07:01:08 +00:00
brent.edwards 58d79558ce fix(docker): copy README.md into build stage for hatchling
CI / lint (pull_request) Successful in 14s
CI / typecheck (pull_request) Successful in 24s
CI / security (pull_request) Successful in 16s
CI / quality (pull_request) Successful in 14s
CI / build (pull_request) Successful in 41s
CI / behave (3.13) (pull_request) Successful in 3m39s
CI / docker (pull_request) Successful in 39s
CI / coverage (pull_request) Successful in 4m17s
2026-02-12 06:35:02 +00:00
brent.edwards d0f1c8bae3 fix(ci): use docker:dind as main container instead of services
CI / lint (pull_request) Successful in 15s
CI / security (pull_request) Successful in 17s
CI / typecheck (pull_request) Successful in 23s
CI / quality (pull_request) Successful in 15s
CI / build (pull_request) Successful in 12s
CI / behave (3.13) (pull_request) Successful in 3m41s
CI / docker (pull_request) Failing after 22s
CI / coverage (pull_request) Successful in 4m19s
Forgejo act_runner service container networking fails with 'network not
found'. Use docker:dind directly with --privileged and start dockerd
inline to avoid the services networking issue.
2026-02-12 06:26:56 +00:00
brent.edwards 945cced381 fix(ci): fix docker build job and Dockerfile
CI / lint (pull_request) Successful in 16s
CI / typecheck (pull_request) Successful in 24s
CI / security (pull_request) Successful in 17s
CI / quality (pull_request) Successful in 15s
CI / build (pull_request) Successful in 12s
CI / behave (3.13) (pull_request) Successful in 3m45s
CI / docker (pull_request) Failing after 6s
CI / coverage (pull_request) Successful in 4m12s
- Add DinD service container and docker:cli image so docker CLI is available
- Fix Dockerfile: remove missing uv.lock, fix build order (copy source before build)
- Remove helm job (k8s/ directory does not exist yet)
2026-02-12 06:17:36 +00:00
brent.edwards 04070ca3ff Merge branch 'master' into Q0-quality-automation
CI / lint (pull_request) Successful in 17s
CI / typecheck (pull_request) Successful in 27s
CI / security (pull_request) Successful in 16s
CI / quality (pull_request) Successful in 14s
CI / build (pull_request) Successful in 11s
CI / behave (3.13) (pull_request) Successful in 3m47s
CI / docker (pull_request) Failing after 32s
CI / helm (pull_request) Failing after 7s
CI / coverage (pull_request) Successful in 4m16s
# Conflicts:
#	implementation_plan.md
2026-02-12 06:05:43 +00:00
brent.edwards c9605c9381 test(features/steps): remove ansi codes
CI / lint (pull_request) Successful in 17s
CI / security (pull_request) Successful in 17s
CI / typecheck (pull_request) Successful in 24s
CI / quality (pull_request) Successful in 15s
CI / build (pull_request) Successful in 13s
CI / behave (3.13) (pull_request) Successful in 3m43s
CI / docker (pull_request) Failing after 33s
CI / helm (pull_request) Failing after 6s
CI / coverage (pull_request) Successful in 4m20s
Remove rich formatting from output
2026-02-12 05:44:57 +00:00
brent.edwards d4a48caeec test(features/steps): fix features that depend on running as user not superuser
CI / lint (pull_request) Successful in 16s
CI / typecheck (pull_request) Successful in 25s
CI / security (pull_request) Successful in 16s
CI / quality (pull_request) Successful in 14s
CI / build (pull_request) Successful in 12s
CI / behave (3.13) (pull_request) Failing after 3m54s
CI / docker (pull_request) Has been skipped
CI / helm (pull_request) Has been skipped
CI / coverage (pull_request) Failing after 4m17s
2026-02-12 05:23:29 +00:00
brent.edwards 17fe46d925 test(behave): fix behave tests
CI / lint (pull_request) Successful in 18s
CI / typecheck (pull_request) Successful in 26s
CI / security (pull_request) Successful in 17s
CI / quality (pull_request) Successful in 14s
CI / build (pull_request) Successful in 12s
CI / behave (3.13) (pull_request) Failing after 3m50s
CI / docker (pull_request) Has been skipped
CI / helm (pull_request) Has been skipped
CI / coverage (pull_request) Failing after 4m20s
There had been over 100 behave tests failing. There should be none failing now.
2026-02-12 04:47:02 +00:00
brent.edwards 3ed11f7988 build(behave.ini): remove ", src" from "paths"
CI / lint (pull_request) Successful in 17s
CI / typecheck (pull_request) Successful in 25s
CI / security (pull_request) Successful in 16s
CI / quality (pull_request) Successful in 14s
CI / build (pull_request) Successful in 13s
CI / behave (3.13) (pull_request) Failing after 3m46s
CI / docker (pull_request) Has been skipped
CI / helm (pull_request) Has been skipped
CI / coverage (pull_request) Failing after 4m20s
The code was seeing the whole text as one path.
2026-02-12 03:36:51 +00:00
brent.edwards 4ae8a9ee3a ci(.forgejo/workflows/ci.yml): remove unused behave-parallel
CI / lint (pull_request) Successful in 17s
CI / typecheck (pull_request) Successful in 26s
CI / security (pull_request) Successful in 17s
CI / quality (pull_request) Successful in 14s
CI / behave (3.13) (pull_request) Failing after 14s
CI / docker (pull_request) Has been skipped
CI / helm (pull_request) Has been skipped
CI / build (pull_request) Successful in 11s
CI / coverage (pull_request) Failing after 14s
No longer installing behave-parallel. Also removed other uploads that won't work.
2026-02-12 03:30:13 +00:00
brent.edwards ea783c57e9 ci(.forgejo/workflows/ci.yml): remove behave 3.11 and 3.12
CI / lint (pull_request) Successful in 17s
CI / typecheck (pull_request) Successful in 24s
CI / security (pull_request) Successful in 18s
CI / quality (pull_request) Failing after 16s
CI / behave (3.13) (pull_request) Failing after 15s
CI / helm (pull_request) Has been skipped
CI / docker (pull_request) Has been skipped
CI / build (pull_request) Failing after 14s
CI / coverage (pull_request) Failing after 17s
2026-02-12 03:17:26 +00:00
brent.edwards 3cc662f5cc ci(.forgejo/workflows/ci.yml): remove the attempt to upload complexity report
Forgejo shows the following error: ::error::@actions/artifact v2.0.0+, upload-artifact@v4+ and download-artifact@v4+ are not currently supported on GHES.
2026-02-12 03:14:37 +00:00
brent.edwards a40d48cbea style(src/cleveragents/reactive/application.py): simplify the code that gets an F on complexity metric
CI / lint (pull_request) Successful in 16s
CI / typecheck (pull_request) Successful in 26s
CI / security (pull_request) Successful in 17s
CI / quality (pull_request) Failing after 16s
CI / behave (3.11) (pull_request) Failing after 11s
CI / behave (3.12) (pull_request) Failing after 11s
CI / behave (3.13) (pull_request) Failing after 14s
CI / docker (pull_request) Has been skipped
CI / helm (pull_request) Has been skipped
CI / build (pull_request) Failing after 14s
CI / coverage (pull_request) Failing after 16s
2026-02-12 03:04:18 +00:00
brent.edwards 51bfee28a9 style(robot/-and-typings/numpy): fix style problems found by ruff check
CI / lint (pull_request) Successful in 15s
CI / typecheck (pull_request) Successful in 25s
CI / security (pull_request) Successful in 18s
CI / quality (pull_request) Failing after 15s
CI / behave (3.11) (pull_request) Failing after 11s
CI / behave (3.12) (pull_request) Failing after 11s
CI / behave (3.13) (pull_request) Failing after 13s
CI / docker (pull_request) Has been skipped
CI / helm (pull_request) Has been skipped
CI / build (pull_request) Failing after 14s
CI / coverage (pull_request) Failing after 15s
2026-02-12 02:47:08 +00:00
brent.edwards c5004ae918 build(features/steps): fix 14 files to match new ruff format
CI / lint (pull_request) Failing after 16s
CI / typecheck (pull_request) Successful in 27s
CI / coverage (pull_request) Has been skipped
CI / security (pull_request) Successful in 19s
CI / quality (pull_request) Failing after 15s
CI / behave (3.11) (pull_request) Failing after 11s
CI / behave (3.12) (pull_request) Failing after 10s
CI / behave (3.13) (pull_request) Failing after 14s
CI / docker (pull_request) Has been skipped
CI / helm (pull_request) Has been skipped
CI / build (pull_request) Failing after 13s
2026-02-12 02:26:03 +00:00
brent.edwards 16794e43ae build(.pre-commit-config.yaml): moving ruff to version 0.15.0
CI / lint (pull_request) Failing after 15s
CI / typecheck (pull_request) Successful in 26s
CI / coverage (pull_request) Has been skipped
CI / security (pull_request) Successful in 18s
CI / quality (pull_request) Failing after 17s
CI / behave (3.11) (pull_request) Failing after 12s
CI / behave (3.12) (pull_request) Failing after 11s
CI / behave (3.13) (pull_request) Failing after 13s
CI / docker (pull_request) Has been skipped
CI / helm (pull_request) Has been skipped
CI / build (pull_request) Failing after 13s
The version of ruff wasn't right in .pre-commit-config.yaml
2026-02-12 02:15:34 +00:00
brent.edwards 1774debbc4 ci(pyproject.toml): force the version of ruff
CI / lint (pull_request) Failing after 16s
CI / typecheck (pull_request) Successful in 27s
CI / coverage (pull_request) Has been skipped
CI / security (pull_request) Successful in 18s
CI / quality (pull_request) Failing after 15s
CI / behave (3.11) (pull_request) Failing after 11s
CI / behave (3.12) (pull_request) Failing after 11s
CI / behave (3.13) (pull_request) Failing after 13s
CI / docker (pull_request) Has been skipped
CI / helm (pull_request) Has been skipped
CI / build (pull_request) Failing after 14s
ruff should now be version 0.15.
2026-02-12 02:07:59 +00:00
brent.edwards 3c63a4c132 ci(.forgejo/workflows/ci.yml): adding node to the jobs
CI / lint (pull_request) Failing after 16s
CI / typecheck (pull_request) Successful in 26s
CI / coverage (pull_request) Has been skipped
CI / security (pull_request) Successful in 20s
CI / quality (pull_request) Failing after 16s
CI / behave (3.11) (pull_request) Failing after 11s
CI / behave (3.12) (pull_request) Failing after 11s
CI / behave (3.13) (pull_request) Failing after 14s
CI / docker (pull_request) Has been skipped
CI / helm (pull_request) Has been skipped
CI / build (pull_request) Failing after 13s
Many steps in ci were failing due to missing `node`.
2026-02-12 01:27:19 +00:00
brent.edwards 761db2518c test: harden code sandbox, add path traversal protection, and fix test mocks
CI / lint (pull_request) Failing after 3s
CI / typecheck (pull_request) Failing after 3s
CI / coverage (pull_request) Has been skipped
CI / quality (pull_request) Failing after 5s
CI / security (pull_request) Failing after 6s
CI / behave (3.11) (pull_request) Failing after 2s
CI / behave (3.12) (pull_request) Failing after 2s
CI / behave (3.13) (pull_request) Failing after 3s
CI / docker (pull_request) Has been skipped
CI / helm (pull_request) Has been skipped
CI / build (pull_request) Failing after 3s
2026-02-12 01:07:44 +00:00
brent.edwards 0511261ebe Merge branch 'master' into Q0-quality-automation 2026-02-11 01:28:24 +00:00
brent.edwards 7caac2714e refactor: changes requested by Rui
Removed `run-semgrep.sh` and automatically run setup-dev.sh
2026-02-11 00:59:58 +00:00
brent.edwards 395df78b94 test(qa): add validation fixtures, edge-case scenarios, and quality baseline
Complete Brent QA tasks Q1.5, 10B.4, 10C.1, and 10C.4 on the Q0-quality-automation branch.

- Add edge_case_plan_scenarios.feature (26 scenarios) covering concurrent
  plan execution, resource conflicts, validation failure chains, and
  rollback edge cases
- Add validation_test_fixtures.feature (34 scenarios) covering AST
  security, lambda validation, content sanitization, project model
  validation, change-list coercion, and ActionArgument parsing
- Add branch protection rules documentation in docs/development/ci-cd.md
- Establish quality metrics baseline (96% coverage, 0 lint/type/security
  findings)
- Fix missing langchain-anthropic dependency in pyproject.toml
- Fix Rich table column wrapping in plan_lifecycle_cli_steps.py by
  patching console width during tests

Suite: 107 features, 1673 scenarios, 7777 steps — all passing.
2026-02-10 22:19:21 +00:00
brent.edwards 3f7cb06981 feat(Adding-commitizen-to-the-list-of-tools.): adds commitizen to the list of tools 2026-02-10 16:04:17 +00:00
brent.edwards 7ef5ebb695 feat: Add Q0: Pre-commit hooks setup.
This should automatically check for problems on build.
2026-02-10 16:04:17 +00:00