cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

fix(resource): add overlay to ResourceTypeConfigSchema._VALID_STRATEGIES #3846

Merged
HAL9000 merged 1 commits from bugfix/backlog-resource-schema-missing-overlay-strategy into master 2026-05-30 20:44:32 +00:00
Conversation 17 Commits 1 Files Changed 2
+8 -2

1 Commits

Author SHA1 Message Date
freemo e201aa07c9 fix(resource): add overlay to ResourceTypeConfigSchema._VALID_STRATEGIES
CI / push-validation (pull_request) Successful in 25s
Details
CI / helm (pull_request) Successful in 28s
Details
CI / build (pull_request) Successful in 28s
Details
CI / lint (pull_request) Successful in 53s
Details
CI / quality (pull_request) Successful in 52s
Details
CI / typecheck (pull_request) Successful in 54s
Details
CI / security (pull_request) Successful in 1m27s
Details
CI / unit_tests (pull_request) Successful in 8m0s
Details
CI / docker (pull_request) Successful in 1m54s
Details
CI / coverage (pull_request) Successful in 15m56s
Details
CI / integration_tests (pull_request) Successful in 29m30s
Details
CI / status-check (pull_request) Successful in 3s
Details
CI / helm (push) Successful in 28s
Details
CI / lint (push) Successful in 43s
Details
CI / push-validation (push) Successful in 21s
Details
CI / build (push) Successful in 50s
Details
CI / quality (push) Successful in 1m6s
Details
CI / e2e_tests (push) Successful in 55s
Details
CI / typecheck (push) Successful in 1m27s
Details
CI / security (push) Successful in 1m27s
Details
CI / benchmark-regression (push) Failing after 39s
Details
CI / unit_tests (push) Successful in 15m13s
Details
CI / docker (push) Successful in 1m36s
Details
CI / integration_tests (push) Successful in 25m29s
Details
CI / coverage (push) Successful in 16m5s
Details
CI / status-check (push) Successful in 2s
Details
CI / benchmark-publish (push) Has been cancelled
Details 
Implemented test coverage and documentation updates to ensure overlay is properly recognized and communicated across the sandbox strategy validation surface.

- Verification: Confirmed that overlay already exists in the _VALID_STRATEGIES frozenset within src/cleveragents/resource/schema.py (introduced in a prior commit that closed issue #2827).
- Comprehensive audit: Audited strategy validation points to ensure consistency:
  - _VALID_STRATEGIES in schema.py
  - _IMPLEMENTED_STRATEGIES and _SUPPORTED_STRATEGIES in factory.py
  - SandboxStrategy enum definitions in both resource.py and resource_type.py
  All include overlay as an allowed strategy.
- Tests: Added a new BDD scenario titled: "Invalid sandbox_strategy error message lists overlay as allowed" to features/consolidated_resource.feature. This asserts that validation errors explicitly list overlay among the allowed values when an invalid strategy is used.
- Documentation: Updated docstring in src/cleveragents/infrastructure/sandbox/strategy_registry.py to reflect that the built-in SandboxFactory handles six strategies, including snapshot and overlay.
- Design considerations: The fix itself was already applied in a previous commit (dbf3b8d7) addressing #2827. Issue #3614, raised by the UAT bot, required additional test coverage and accurate documentation of the available strategies.
- Impact: No behavioral changes beyond ensuring test coverage and documentation are aligned with the existing implementation. The added test guarantees that error messages remain accurate and comprehensive as strategies evolve.
- Affected areas: resource/schema.py, factory.py, resource.py, resource_type.py, features/consolidated_resource.feature, strategy_registry.py.

ISSUES CLOSED: #3614
 2026-05-30 16:14:46 -04:00