ci.yml / fix(tool-registry): enforce type discriminator in attach_validation to reject plain tools (pull_request) Verified locally - CI runner unavailable
This change updates the attach command in src/cleveragents/cli/commands/validation.py to adopt a named option format for tool validation, replacing the previous positional key=value syntax. The command now uses Typer with a custom Context to capture arbitrary --key value pairs, enabling flexible, spec-compliant input while preserving a strict discriminator path for attach_validation.
What was implemented
- Replaced positional key=value format with named options of the form --key value for attach_validation.
- Introduced context_settings="{"allow_extra_args": True, "ignore_unknown_options": True}" and Typer Context to capture extra named options without needing explicit definitions.
- Implemented parsing to translate named options into a standard dictionary payload. For example, --coverage-threshold 90 is parsed to {"coverage_threshold": "90"}.
- Explicitly rejects the old positional key=value format with a helpful error message guiding users to the new --key value syntax.
- Validates named options to ensure each provided option has an accompanying value; otherwise, returns a clear error describing the missing value.
- Adjusted test and spec coverage to reflect the new named option format: - Updated features/tool_cli.feature to use --key value format. - Added new step definition in features/steps/tool_cli_steps.py to support named option parsing. - Added new step definitions in features/steps/validation_attach_type_guard_steps.py for named-option tests. - Created new features/validation_attach_named_options.feature to test spec-compliant named options.
- Fixed a pre-existing mix_stderr issue in features/steps/tdd_cli_incomplete_subcommand_registration_steps.py to stabilize tests.
Key design decisions
- Used Typer Context with allow_extra_args and ignore_unknown_options to capture arbitrary --key value pairs reliably, without hard-coding every possible option.
- Hyphen-to-underscore normalization: converts option names like --coverage-threshold to coverage_threshold for consistent keys in the payload.
- Explicit rejection of positional key=value format ensures a consistent, forward-compatible API and provides users with clear guidance to adopt the new named-option approach.
- Parsing logic centralizes input normalization, enabling robust enforcement of the attach_validation type discriminator while keeping the CLI layer lean.
ISSUES CLOSED: #3683
freemo