chore(agents): fix ca-test-infra-improver health comment spam #3478

Merged
HAL9000 merged 2 commits from improvement/agent-test-infra-health-spam-fix into master 2026-04-30 08:31:38 +00:00

2 Commits

Author SHA1 Message Date
HAL9000 87f44e556a chore(agents): fix ca-test-infra-improver health comment spam
CI / lint (push) Successful in 59s
CI / quality (push) Successful in 1m16s
CI / build (push) Successful in 37s
CI / typecheck (push) Successful in 1m18s
CI / helm (push) Successful in 36s
CI / security (push) Successful in 1m24s
CI / push-validation (push) Successful in 22s
CI / benchmark-publish (push) Failing after 42s
CI / integration_tests (push) Successful in 4m48s
CI / e2e_tests (push) Successful in 4m48s
CI / unit_tests (push) Successful in 6m6s
CI / docker (push) Successful in 1m30s
CI / coverage (push) Successful in 11m52s
CI / status-check (push) Successful in 3s
CI / benchmark-publish (pull_request) Has been skipped
CI / helm (pull_request) Successful in 39s
CI / lint (pull_request) Successful in 1m16s
CI / build (pull_request) Successful in 58s
CI / quality (pull_request) Successful in 1m45s
CI / typecheck (pull_request) Successful in 1m52s
CI / security (pull_request) Successful in 1m58s
CI / push-validation (pull_request) Successful in 23s
CI / e2e_tests (pull_request) Successful in 4m10s
CI / unit_tests (pull_request) Successful in 5m43s
CI / integration_tests (pull_request) Successful in 5m55s
CI / docker (pull_request) Successful in 1m32s
CI / coverage (pull_request) Successful in 11m12s
CI / status-check (pull_request) Successful in 3s
Replace fragile cycle-modulo health posting guard with timestamp-based
approach and state-change-only posting. The inner monitoring loop no
longer posts health comments — posting is gated by a 10-minute timer
OR meaningful state changes (worker completion, dispatch events).

Approved proposal: #3385
Pattern: workflow_fix
Evidence: Agent posted 44 of 52 session comments in 20 minutes, all
identical, drowning out other agent signals.
Fix: Timestamp-based health posting with state-change triggers.
2026-04-30 08:15:32 +00:00
freemo 602d56f347 chore(agents): fix ca-test-infra-improver health comment spam
Approved proposal: #3385
Pattern: workflow_fix
Evidence: Agent posted 44 of 52 comments in 20 minutes, drowning out all
other agent signals. The cycle % 60 guard was ambiguous and ignored by the
model.
Fix: Replace fragile modulo guard with explicit timestamp-based rate
limiting (10-minute minimum between health posts). Add prominent CRITICAL
warning about rate limiting. Clarify that health posting runs in the outer
loop, not the inner monitoring loop.

ISSUES CLOSED: #3385
2026-04-30 08:15:32 +00:00