cleveragents/cleveragents-core
cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.1k Pull requests 489 Projects Releases Packages Wiki Activity Actions

fix(tui): synchronize HelpPanelOverlay keybinding display with actual app BINDINGS #3471

Merged
freemo merged 1 commit from fix/tui-help-panel-keybinding-accuracy into master 2026-04-05 21:06:54 +00:00
Conversation 3 Commits 1 Files changed 3 +24 -3
freemo commented 2026-04-05 18:09:56 +00:00
Owner
Copy link

Summary

This PR fixes a double-inconsistency in the TUI help panel where HelpPanelOverlay displayed ctrl+tab for preset cycling while the actual registered binding in app.py is ctrl+t. It also removes a stale tab → "Cycle to next persona" entry that had no corresponding BINDINGS entry (tracked in #3338).

Root cause: The static _CONTEXT_ITEMS dict in help_panel_overlay.py was not kept in sync with the BINDINGS list in app.py, causing users who followed the help panel instructions to press the wrong key and get no response.

Changes

File Change
src/cleveragents/tui/widgets/help_panel_overlay.py _CONTEXT_ITEMS["Main Screen"]: removed stale tab entry, changed ctrl+tab → ctrl+t
features/tui_help_panel_overlay_coverage.feature Added 2 new BDD scenarios for keybinding accuracy
features/steps/tui_help_panel_overlay_coverage_steps.py Added should not contain step definition; improved assertion messages

Motivation

Per ADR-044, the help panel should "dynamically reflect the current context's available hotkeys." The static _CONTEXT_ITEMS dict was out of sync with app.BINDINGS, creating a double-inconsistency:

  1. The help panel showed ctrl+tab for preset cycling, but the actual binding is ctrl+t
  2. The help panel showed tab → "Cycle to next persona", but no such binding exists in app.BINDINGS

Users following the help panel instructions would press the wrong key and get no response — actively misleading behavior.

Approach

  • Minimal, targeted fix: Only the incorrect data entries in _CONTEXT_ITEMS were changed — no logic changes, no new code paths
  • Cross-referenced against app.py: All three Main Screen context entries (ctrl+q, F1, ctrl+t) now match the actual registered BINDINGS
  • Regression tests added: New BDD scenarios assert positive presence of ctrl+t and negative absence of ctrl+tab and stale tab entry
  • Deferred dynamic derivation: ADR-044's "dynamically reflect" requirement is acknowledged; the long-term solution of deriving _CONTEXT_ITEMS from app.BINDINGS at runtime is noted in the issue but correctly deferred as a separate enhancement

Testing

New BDD scenarios in features/tui_help_panel_overlay_coverage.feature:

  • help panel Main Screen keybindings match actual app BINDINGS: Asserts ctrl+t is present, ctrl+tab is absent, stale tab entry is absent
  • help panel global keybindings match actual app BINDINGS: Asserts ctrl+q and F1 are present as regression guards

New step definition should not contain added to support negative-assertion scenarios, with descriptive failure messages that include the actual rendered help panel text.

Related Issues

  • Closes #3444
  • Related: #3316 (app uses ctrl+t instead of spec-correct ctrl+tab)
  • Related: #3338 (help panel shows tab for persona cycling, no such binding exists)

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: ca-issue-worker

## Summary This PR fixes a double-inconsistency in the TUI help panel where `HelpPanelOverlay` displayed `ctrl+tab` for preset cycling while the actual registered binding in `app.py` is `ctrl+t`. It also removes a stale `tab` → "Cycle to next persona" entry that had no corresponding `BINDINGS` entry (tracked in #3338). **Root cause:** The static `_CONTEXT_ITEMS` dict in `help_panel_overlay.py` was not kept in sync with the `BINDINGS` list in `app.py`, causing users who followed the help panel instructions to press the wrong key and get no response. ## Changes | File | Change | |------|--------| | `src/cleveragents/tui/widgets/help_panel_overlay.py` | `_CONTEXT_ITEMS["Main Screen"]`: removed stale `tab` entry, changed `ctrl+tab` → `ctrl+t` | | `features/tui_help_panel_overlay_coverage.feature` | Added 2 new BDD scenarios for keybinding accuracy | | `features/steps/tui_help_panel_overlay_coverage_steps.py` | Added `should not contain` step definition; improved assertion messages | ## Motivation Per **ADR-044**, the help panel should "dynamically reflect the current context's available hotkeys." The static `_CONTEXT_ITEMS` dict was out of sync with `app.BINDINGS`, creating a double-inconsistency: 1. The help panel showed `ctrl+tab` for preset cycling, but the actual binding is `ctrl+t` 2. The help panel showed `tab` → "Cycle to next persona", but no such binding exists in `app.BINDINGS` Users following the help panel instructions would press the wrong key and get no response — actively misleading behavior. ## Approach - **Minimal, targeted fix**: Only the incorrect data entries in `_CONTEXT_ITEMS` were changed — no logic changes, no new code paths - **Cross-referenced against `app.py`**: All three Main Screen context entries (`ctrl+q`, `F1`, `ctrl+t`) now match the actual registered `BINDINGS` - **Regression tests added**: New BDD scenarios assert positive presence of `ctrl+t` and negative absence of `ctrl+tab` and stale `tab` entry - **Deferred dynamic derivation**: ADR-044's "dynamically reflect" requirement is acknowledged; the long-term solution of deriving `_CONTEXT_ITEMS` from `app.BINDINGS` at runtime is noted in the issue but correctly deferred as a separate enhancement ## Testing New BDD scenarios in `features/tui_help_panel_overlay_coverage.feature`: - **`help panel Main Screen keybindings match actual app BINDINGS`**: Asserts `ctrl+t` is present, `ctrl+tab` is absent, stale `tab` entry is absent - **`help panel global keybindings match actual app BINDINGS`**: Asserts `ctrl+q` and `F1` are present as regression guards New step definition `should not contain` added to support negative-assertion scenarios, with descriptive failure messages that include the actual rendered help panel text. ## Related Issues - Closes #3444 - Related: #3316 (app uses `ctrl+t` instead of spec-correct `ctrl+tab`) - Related: #3338 (help panel shows `tab` for persona cycling, no such binding exists) --- **Automated by CleverAgents Bot** Supervisor: Implementation | Agent: ca-issue-worker
fix(tui): synchronize HelpPanelOverlay keybinding display with actual app BINDINGS
All checks were successful
CI / lint (pull_request) Successful in 27s
Details
CI / quality (pull_request) Successful in 33s
Details
CI / typecheck (pull_request) Successful in 50s
Details
CI / security (pull_request) Successful in 1m28s
Details
CI / build (pull_request) Successful in 23s
Details
CI / helm (pull_request) Successful in 23s
Details
CI / unit_tests (pull_request) Successful in 6m47s
Details
CI / e2e_tests (pull_request) Successful in 18m21s
Details
CI / integration_tests (pull_request) Successful in 23m14s
Details
CI / docker (pull_request) Successful in 1m24s
Details
CI / coverage (pull_request) Successful in 11m22s
Details
CI / status-check (pull_request) Successful in 1s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / benchmark-regression (pull_request) Successful in 56m50s
Details
66ac33b185 
- Replace ctrl+tab with ctrl+t for preset cycling in _CONTEXT_ITEMS Main Screen
  context, matching the actual BINDINGS registered in app.py
- Remove the tab/Cycle to next persona entry from Main Screen context since
  no such binding exists in app.BINDINGS (tracked separately in #3338)
- Add Behave BDD scenarios asserting that help panel keybindings match the
  actual registered BINDINGS: ctrl+t present, ctrl+tab absent, no stale tab
  entry for persona cycling
- Add step definition for 'should not contain' assertion to support the new
  negative-assertion scenarios

Resolves the double-inconsistency where users following the help panel
instructions (ctrl+tab) would press the wrong key and get no response.

ISSUES CLOSED: #3444
freemo reviewed 2026-04-05 18:15:14 +00:00
freemo left a comment
Copy link

Code Review — PR #3471

Focus areas: specification-compliance, behavior-correctness, code-maintainability

Summary

This PR fixes a double-inconsistency in the TUI help panel where HelpPanelOverlay displayed ctrl+tab for preset cycling, but the actual registered binding in app.py is ctrl+t. It also removes a stale tab → "Cycle to next persona" entry that had no corresponding BINDINGS entry (tracked in #3338).

Changes Reviewed

File Change
src/cleveragents/tui/widgets/help_panel_overlay.py _CONTEXT_ITEMS["Main Screen"]: removed stale tab entry, changed ctrl+tab → ctrl+t
features/tui_help_panel_overlay_coverage.feature Added 2 new BDD scenarios for keybinding accuracy
features/steps/tui_help_panel_overlay_coverage_steps.py Added should not contain step definition; improved assertion messages

✅ Specification Compliance

  • Keybinding accuracy verified: Cross-referenced _CONTEXT_ITEMS against app.py BINDINGS (ctrl+q, f1, ctrl+t). All three Main Screen context entries now match the actual registered bindings. ✓
  • ADR-044 alignment: The issue notes ADR-044 requires the help panel to "dynamically reflect the current context's available hotkeys." This PR takes the pragmatic approach of fixing the static dict to match reality, which is appropriate for a bug fix. The subtask to consider dynamic derivation from app.BINDINGS is noted in the issue but correctly deferred — that would be a separate enhancement.
  • Stale entry removal: Removing ("tab", "Cycle to next persona") is correct — no such binding exists in app.BINDINGS, and the discrepancy is tracked in #3338.

✅ Behavior Correctness

  • Fix is correct: ctrl+t in _CONTEXT_ITEMS now matches ("ctrl+t", "cycle_preset", "Cycle Preset") in app.py BINDINGS. Users following the help panel will now press the correct key.
  • No regressions: The remaining context entries (Slash Commands, Reference Picker, Shell Mode) are unchanged and were not affected by this bug.
  • Rendered output verified: The render_help_panel("Main Screen") output will correctly show ctrl+t in the keybinding column with proper formatting via the {key:<10} f-string.

✅ Test Quality

  • Positive assertions: New scenario verifies ctrl+t is present in the rendered help panel text.
  • Negative assertions: New should not contain step correctly verifies both ctrl+tab (old incorrect binding) and tab (stale persona cycling entry) are absent. The substring check is safe here — "tab" does not appear as a substring of any Main Screen entry in the rendered output.
  • Global bindings scenario: Verifies ctrl+q and F1 are present, providing a regression guard for global keybindings.
  • Improved assertion messages: The existing should contain step now includes the actual help panel text in failure messages, which aids debugging. Good improvement.

✅ Code Quality

  • No # type: ignore suppressions ✓
  • File sizes well under 500 lines ✓
  • Single atomic commit with implementation + tests ✓
  • Commit message follows Conventional Changelog format ✓
  • ISSUES CLOSED: #3444 footer present ✓
  • Closes #3444 in PR body ✓
  • Type/Bug label present ✓

⚠️ Process Issue: Missing Milestone

The linked issue #3444 is assigned to milestone v3.7.0, but this PR has no milestone assigned. Per CONTRIBUTING.md: "Every PR must be assigned to the same milestone as its linked issue." Please assign milestone v3.7.0 to this PR.

💡 Minor Observations (Non-blocking)

  1. Test fragility note: The should not contain "tab" assertion works correctly for the current Main Screen context, but is worth noting that it checks the entire rendered text (including global section). If a future global binding description happened to contain the substring "tab", this test would fail. This is acceptable as a regression guard — it would flag the change for review — but worth being aware of.

  2. Static vs. dynamic approach: As noted in issue #3444 subtask 3, the long-term solution per ADR-044 would be to derive _CONTEXT_ITEMS dynamically from app.BINDINGS. The current static approach is correct for this bug fix, but the drift risk remains for future binding changes. Consider filing a follow-up enhancement issue if one doesn't already exist.

  3. Step definition type annotations: The new step functions (step_standalone_help_panel_text_not_contains) lack parameter type annotations. This is consistent with the existing step definitions in the same file, so not a new issue, but worth noting for a future cleanup pass.

Decision

The code changes are correct, well-scoped, and well-tested. The single process issue (missing milestone) should be addressed before merge. No code changes required.

Automated by CleverAgents Bot
Reviewer: Code Quality | Agent: ca-pr-self-reviewer

## Code Review — PR #3471 **Focus areas:** specification-compliance, behavior-correctness, code-maintainability ### Summary This PR fixes a double-inconsistency in the TUI help panel where `HelpPanelOverlay` displayed `ctrl+tab` for preset cycling, but the actual registered binding in `app.py` is `ctrl+t`. It also removes a stale `tab` → "Cycle to next persona" entry that had no corresponding `BINDINGS` entry (tracked in #3338). ### Changes Reviewed | File | Change | |------|--------| | `src/cleveragents/tui/widgets/help_panel_overlay.py` | `_CONTEXT_ITEMS["Main Screen"]`: removed stale `tab` entry, changed `ctrl+tab` → `ctrl+t` | | `features/tui_help_panel_overlay_coverage.feature` | Added 2 new BDD scenarios for keybinding accuracy | | `features/steps/tui_help_panel_overlay_coverage_steps.py` | Added `should not contain` step definition; improved assertion messages | ### ✅ Specification Compliance - **Keybinding accuracy verified**: Cross-referenced `_CONTEXT_ITEMS` against `app.py` `BINDINGS` (`ctrl+q`, `f1`, `ctrl+t`). All three Main Screen context entries now match the actual registered bindings. ✓ - **ADR-044 alignment**: The issue notes ADR-044 requires the help panel to "dynamically reflect the current context's available hotkeys." This PR takes the pragmatic approach of fixing the static dict to match reality, which is appropriate for a bug fix. The subtask to consider dynamic derivation from `app.BINDINGS` is noted in the issue but correctly deferred — that would be a separate enhancement. - **Stale entry removal**: Removing `("tab", "Cycle to next persona")` is correct — no such binding exists in `app.BINDINGS`, and the discrepancy is tracked in #3338. ### ✅ Behavior Correctness - **Fix is correct**: `ctrl+t` in `_CONTEXT_ITEMS` now matches `("ctrl+t", "cycle_preset", "Cycle Preset")` in `app.py` `BINDINGS`. Users following the help panel will now press the correct key. - **No regressions**: The remaining context entries (Slash Commands, Reference Picker, Shell Mode) are unchanged and were not affected by this bug. - **Rendered output verified**: The `render_help_panel("Main Screen")` output will correctly show `ctrl+t` in the keybinding column with proper formatting via the `{key:<10}` f-string. ### ✅ Test Quality - **Positive assertions**: New scenario verifies `ctrl+t` is present in the rendered help panel text. - **Negative assertions**: New `should not contain` step correctly verifies both `ctrl+tab` (old incorrect binding) and `tab` (stale persona cycling entry) are absent. The substring check is safe here — `"tab"` does not appear as a substring of any Main Screen entry in the rendered output. - **Global bindings scenario**: Verifies `ctrl+q` and `F1` are present, providing a regression guard for global keybindings. - **Improved assertion messages**: The existing `should contain` step now includes the actual help panel text in failure messages, which aids debugging. Good improvement. ### ✅ Code Quality - No `# type: ignore` suppressions ✓ - File sizes well under 500 lines ✓ - Single atomic commit with implementation + tests ✓ - Commit message follows Conventional Changelog format ✓ - `ISSUES CLOSED: #3444` footer present ✓ - `Closes #3444` in PR body ✓ - `Type/Bug` label present ✓ ### ⚠️ Process Issue: Missing Milestone The linked issue #3444 is assigned to milestone **v3.7.0**, but this PR has **no milestone assigned**. Per CONTRIBUTING.md: *"Every PR must be assigned to the same milestone as its linked issue."* Please assign milestone v3.7.0 to this PR. ### 💡 Minor Observations (Non-blocking) 1. **Test fragility note**: The `should not contain "tab"` assertion works correctly for the current Main Screen context, but is worth noting that it checks the entire rendered text (including global section). If a future global binding description happened to contain the substring "tab", this test would fail. This is acceptable as a regression guard — it would flag the change for review — but worth being aware of. 2. **Static vs. dynamic approach**: As noted in issue #3444 subtask 3, the long-term solution per ADR-044 would be to derive `_CONTEXT_ITEMS` dynamically from `app.BINDINGS`. The current static approach is correct for this bug fix, but the drift risk remains for future binding changes. Consider filing a follow-up enhancement issue if one doesn't already exist. 3. **Step definition type annotations**: The new step functions (`step_standalone_help_panel_text_not_contains`) lack parameter type annotations. This is consistent with the existing step definitions in the same file, so not a new issue, but worth noting for a future cleanup pass. ### Decision The code changes are **correct, well-scoped, and well-tested**. The single process issue (missing milestone) should be addressed before merge. No code changes required. --- **Automated by CleverAgents Bot** Reviewer: Code Quality | Agent: ca-pr-self-reviewer
features/steps/tui_help_panel_overlay_coverage_steps.py
@ -45,1 +45,3 @@
assert text in context.help_panel._text
assert text in context.help_panel._text, (
f"Expected {text!r} in help panel text, got:\n{context.help_panel._text}"
)
freemo commented 2026-04-05 18:15:14 +00:00
Author
Owner
Copy link

Nice addition of the should not contain step with a clear failure message. The improved assertion message on the existing should contain step (line 40-42) is also a welcome improvement over the bare assert in master.

Nice addition of the `should not contain` step with a clear failure message. The improved assertion message on the existing `should contain` step (line 40-42) is also a welcome improvement over the bare `assert` in master.
features/tui_help_panel_overlay_coverage.feature
@ -25,3 +25,16 @@ Feature: TUI Help Panel Overlay Coverage
And the standalone help panel text should contain "Help: Slash Commands"
When I toggle help for context "Slash Commands"
Then the help panel should be hidden
freemo commented 2026-04-05 18:15:14 +00:00
Author
Owner
Copy link

Good regression guard. The combination of positive (ctrl+t present) and negative (ctrl+tab absent, tab absent) assertions provides strong coverage against both the original bug and the stale entry.

Good regression guard. The combination of positive (`ctrl+t` present) and negative (`ctrl+tab` absent, `tab` absent) assertions provides strong coverage against both the original bug and the stale entry.
src/cleveragents/tui/widgets/help_panel_overlay.py
@ -36,3 +35,3 @@
("ctrl+tab", "Cycle to next argument preset"),
("ctrl+t", "Cycle to next argument preset"),
("@", "Open Reference Picker overlay"),
("/", "Open Slash Command overlay"),
freemo commented 2026-04-05 18:15:14 +00:00
Author
Owner
Copy link

✅ Correctly updated from ctrl+tab → ctrl+t to match app.py BINDINGS. Also correctly removed the stale ("tab", "Cycle to next persona") entry (tracked in #3338).

✅ Correctly updated from `ctrl+tab` → `ctrl+t` to match `app.py` `BINDINGS`. Also correctly removed the stale `("tab", "Cycle to next persona")` entry (tracked in #3338).
freemo commented 2026-04-05 19:33:32 +00:00
Author
Owner
Copy link

Code Review — PR #3471

Review Focus: architecture-alignment, module-boundaries, interface-contracts
Review Type: initial-review

Reviewed PR #3471 with focus on architecture-alignment, module-boundaries, and interface-contracts.

This PR fixes a user-facing bug where HelpPanelOverlay displayed ctrl+tab for preset cycling while the actual registered binding in app.py is ctrl+t. It also removes a phantom tab → "Cycle to next persona" entry that had no corresponding binding. The fix is correct, well-scoped, and includes good regression tests.

✅ Specification Compliance

The code change correctly aligns _CONTEXT_ITEMS in help_panel_overlay.py with the actual BINDINGS in app.py:

  • ctrl+tab → ctrl+t for preset cycling — verified against app.py line 95: ("ctrl+t", "cycle_preset", "Cycle Preset")
  • Removed stale ("tab", "Cycle to next persona") — verified no such binding exists in app.BINDINGS (tracked in #3338)

✅ Architecture Alignment (Deep Dive)

Module boundaries respected: help_panel_overlay.py lives correctly in tui/widgets/ and does not import from app.py (which would create a circular dependency). The widget maintains proper encapsulation.

Interface contracts preserved: All public interfaces (show_context(), hide(), toggle(), visible, context_name, resolve_help_context(), render_help_panel()) are unchanged. Only internal data (_CONTEXT_ITEMS) was modified.

Architectural observation (non-blocking): The static _CONTEXT_ITEMS dict approach still requires manual synchronization with app.BINDINGS, which conflicts with ADR-044's "dynamically reflect the current context's available hotkeys" requirement. This is acknowledged in the issue (#3444 subtask 3) and is a separate concern from this bug fix. However, the current approach remains fragile — any future change to BINDINGS requires a corresponding manual update to _CONTEXT_ITEMS. I note this for awareness, not as a blocking concern for this PR.

✅ Code Correctness

  • Fix is minimal and targeted — only data changes, no logic changes
  • No new code paths, no risk of regressions
  • Single atomic commit with implementation + tests

✅ Test Quality

New BDD scenarios are well-structured:

  • Positive assertion: ctrl+t is present in Main Screen help text
  • Negative assertions: ctrl+tab and tab are absent from Main Screen help text
  • Global bindings: ctrl+q and F1 verified present
  • New should not contain step definition has clear error messages

The existing should contain step was also improved with a descriptive assertion message — good housekeeping.

✅ Commit Message & Branch

  • Commit: fix(tui): synchronize HelpPanelOverlay keybinding display with actual app BINDINGS — correct Conventional Changelog format ✅
  • Footer: ISSUES CLOSED: #3444 ✅
  • Branch: fix/tui-help-panel-keybinding-accuracy — matches issue metadata ✅
  • Single atomic commit ✅
  • Labels: Type/Bug present ✅

⚠️ Required Change Before Merge

  1. [PROCESS] Missing Milestone on PR
    • Issue #3444 is assigned to milestone v3.7.0, but this PR has no milestone assigned.
    • Per CONTRIBUTING.md: "Every PR must be assigned to the same milestone as its primary issue."
    • Required: Assign milestone v3.7.0 to this PR before merge.

Minor Suggestions (Non-blocking)

  1. The global keybindings test scenario checks ctrl+q and F1 but omits escape — consider adding it for completeness.
  2. The should not contain "tab" assertion works correctly for Main Screen context, but note that "tab" does appear in Shell Mode's description ("Tab-complete file or directory path"). The test is correctly scoped to Main Screen rendering, so this is fine — just worth being aware of if tests are later expanded.

Decision: REQUEST CHANGES 🔄

The code itself is correct and well-tested. The only required change is a metadata fix: assign milestone v3.7.0 to this PR to comply with CONTRIBUTING.md requirements. Once the milestone is assigned, this PR is ready for approval.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## Code Review — PR #3471 **Review Focus:** architecture-alignment, module-boundaries, interface-contracts **Review Type:** initial-review --- Reviewed PR #3471 with focus on **architecture-alignment**, **module-boundaries**, and **interface-contracts**. This PR fixes a user-facing bug where `HelpPanelOverlay` displayed `ctrl+tab` for preset cycling while the actual registered binding in `app.py` is `ctrl+t`. It also removes a phantom `tab` → "Cycle to next persona" entry that had no corresponding binding. The fix is correct, well-scoped, and includes good regression tests. ### ✅ Specification Compliance The code change correctly aligns `_CONTEXT_ITEMS` in `help_panel_overlay.py` with the actual `BINDINGS` in `app.py`: - `ctrl+tab` → `ctrl+t` for preset cycling — **verified** against `app.py` line 95: `("ctrl+t", "cycle_preset", "Cycle Preset")` - Removed stale `("tab", "Cycle to next persona")` — **verified** no such binding exists in `app.BINDINGS` (tracked in #3338) ### ✅ Architecture Alignment (Deep Dive) **Module boundaries respected:** `help_panel_overlay.py` lives correctly in `tui/widgets/` and does not import from `app.py` (which would create a circular dependency). The widget maintains proper encapsulation. **Interface contracts preserved:** All public interfaces (`show_context()`, `hide()`, `toggle()`, `visible`, `context_name`, `resolve_help_context()`, `render_help_panel()`) are unchanged. Only internal data (`_CONTEXT_ITEMS`) was modified. **Architectural observation (non-blocking):** The static `_CONTEXT_ITEMS` dict approach still requires manual synchronization with `app.BINDINGS`, which conflicts with ADR-044's "dynamically reflect the current context's available hotkeys" requirement. This is acknowledged in the issue (#3444 subtask 3) and is a separate concern from this bug fix. However, the current approach remains fragile — any future change to `BINDINGS` requires a corresponding manual update to `_CONTEXT_ITEMS`. I note this for awareness, not as a blocking concern for this PR. ### ✅ Code Correctness - Fix is minimal and targeted — only data changes, no logic changes - No new code paths, no risk of regressions - Single atomic commit with implementation + tests ### ✅ Test Quality New BDD scenarios are well-structured: - **Positive assertion**: `ctrl+t` is present in Main Screen help text - **Negative assertions**: `ctrl+tab` and `tab` are absent from Main Screen help text - **Global bindings**: `ctrl+q` and `F1` verified present - New `should not contain` step definition has clear error messages The existing `should contain` step was also improved with a descriptive assertion message — good housekeeping. ### ✅ Commit Message & Branch - Commit: `fix(tui): synchronize HelpPanelOverlay keybinding display with actual app BINDINGS` — correct Conventional Changelog format ✅ - Footer: `ISSUES CLOSED: #3444` ✅ - Branch: `fix/tui-help-panel-keybinding-accuracy` — matches issue metadata ✅ - Single atomic commit ✅ - Labels: `Type/Bug` present ✅ ### ⚠️ Required Change Before Merge 1. **[PROCESS] Missing Milestone on PR** - Issue #3444 is assigned to milestone **v3.7.0**, but this PR has **no milestone** assigned. - Per CONTRIBUTING.md: "Every PR must be assigned to the same milestone as its primary issue." - **Required:** Assign milestone v3.7.0 to this PR before merge. ### Minor Suggestions (Non-blocking) 1. The global keybindings test scenario checks `ctrl+q` and `F1` but omits `escape` — consider adding it for completeness. 2. The `should not contain "tab"` assertion works correctly for Main Screen context, but note that "tab" does appear in Shell Mode's description ("Tab-complete file or directory path"). The test is correctly scoped to Main Screen rendering, so this is fine — just worth being aware of if tests are later expanded. ### Decision: REQUEST CHANGES 🔄 The code itself is correct and well-tested. The only required change is a metadata fix: assign milestone v3.7.0 to this PR to comply with CONTRIBUTING.md requirements. Once the milestone is assigned, this PR is ready for approval. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
freemo added this to the v3.7.0 milestone 2026-04-05 19:44:57 +00:00
freemo commented 2026-04-05 20:58:18 +00:00
Author
Owner
Copy link

Addressed the process issue flagged in the review:

  1. Added PR description: The PR body was empty — added a full description covering summary, motivation, approach, changes table, testing details, and related issue links.
  2. Assigned milestone v3.7.0: Per CONTRIBUTING.md, every PR must be assigned to the same milestone as its linked issue (#3444 is in v3.7.0).

The code changes themselves were already correct and well-tested per the review. No code modifications were needed.

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: ca-issue-worker

Addressed the process issue flagged in the review: 1. **Added PR description**: The PR body was empty — added a full description covering summary, motivation, approach, changes table, testing details, and related issue links. 2. **Assigned milestone v3.7.0**: Per CONTRIBUTING.md, every PR must be assigned to the same milestone as its linked issue (#3444 is in v3.7.0). The code changes themselves were already correct and well-tested per the review. No code modifications were needed. --- **Automated by CleverAgents Bot** Supervisor: Implementation | Agent: ca-issue-worker
freemo merged commit 219470f548 into master 2026-04-05 21:06:54 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  
controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  
auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  
auto/claimed-implementer
Currently being processed by an implementer worker.

  
auto/claimed-merge
Currently being processed by the merge driver.

  
auto/claimed-reviewer
Currently being processed by a reviewer worker.

  
auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  
auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  
auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  
auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  
Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.

  
auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.

  
auto/needs-implementer
Failing CI needs implementer attention.

  
auto/postmortem
Documenting a driver incident or rollback.

  
auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  
auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  
auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  
auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  
auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  
auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  
Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.

  
Bounty
$100
 A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$1000
 A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$10000
 A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$20
 A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$2000
 A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$250
 A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$50
 A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$500
 A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$5000
 A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$750
 A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  
MoSCoW
Could have
 Could have feature in order to satisfy the epic/legendary.

  
MoSCoW
Must have
 Must have feature in order to satisfy the epic/legendary.

  
MoSCoW
Should have
 Should have feature in order to satisfy the epic/legendary.

  
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.

  
Points
1
 1 man-hours worth of work for an expert with no learning curve.

  
Points
13
 13 man-hours worth of work for an expert with no learning curve.

  
Points
2
 2 man-hours worth of work for an expert with no learning curve.

  
Points
21
 21 man-hours worth of work for an expert with no learning curve.

  
Points
3
 3 man-hours worth of work for an expert with no learning curve.

  
Points
34
 34 man-hours worth of work for an expert with no learning curve.

  
Points
5
 5 man-hours worth of work for an expert with no learning curve.

  
Points
55
 55 man-hours worth of work for an expert with no learning curve.

  
Points
8
 8 man-hours worth of work for an expert with no learning curve.

  
Points
88
 88 man-hours worth of work for an expert with no learning curve.

  
Priority
Backlog
 This ticket has backlogged priority and is not to be worked on yet

  
Priority
CI Blocker
 Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  
State
Completed
 The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  
State
Duplicate
 A ticket that represents the same content as an existing ticket.

  
State
In Progress
 A ticket that is actively being developed.

  
State
In Review
 A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  
State
Paused
 This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  
State
Unverified
 All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  
State
Verified
 The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  
State
Wont Do
 This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  
Type
Automation
 Any edits or discussion about the AI automated coding system.

  
Type
Bug
 Something that doesnt work as intended.

  
Type
Discussion
 Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  
Type
Documentation
 An error or improvement needed in the documentation.

  
Type
Epic
 Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  
Type
Feature
 Some new functionality not present.

  
Type
Legendary
 A type of Epic which will contain other Epics.

  
Type
Refactor
 A code change that restructures existing code without changing its external behavior.

  
Type
Support
 Someone needs help using the project.

  
Type
Task
 A generic task that doesnt fit into the other type categories.

  
Type
Testing
 Work exclusively focusing on fixing or expanding testing.

No labels
auto/needs-reevaluation
controller-managed
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
Milestone
Clear milestone
No items
No milestone
v3.7.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core!3471
No description provided.