fix(providers): wire OpenAIChatProvider and AnthropicChatProvider into ProviderRegistry #3464

Merged

freemo merged 1 commit from fix/backlog-openai-anthropic-provider-registry-integration into master 2026-04-05 21:07:03 +00:00

Conversation 2 Commits 1 Files changed 4 +101 -6

freemo commented 2026-04-05 18:00:48 +00:00

Owner

Copy link

Summary

Fixes #3427 — OpenAIChatProvider and AnthropicChatProvider were dead code in production because ProviderRegistry.create_ai_provider() never instantiated them.

Changes

Core Fix: src/cleveragents/providers/registry.py

• Added ProviderType.OPENAI dispatch branch in create_ai_provider() that instantiates OpenAIChatProvider with the configured API key and model
• Added ProviderType.ANTHROPIC dispatch branch in create_ai_provider() that instantiates AnthropicChatProvider with the configured API key and model
• Both new branches raise ValueError with the missing env var name when the API key is not configured, consistent with the existing Google and OpenRouter branches

Package Exports: src/cleveragents/providers/llm/__init__.py

• Was empty; now exports all four dedicated provider classes: OpenAIChatProvider, AnthropicChatProvider, GoogleChatProvider, OpenRouterChatProvider

Tests: features/provider_registry_coverage.feature

• Updated "Create AI provider succeeds for configured provider string" to assert OpenAIChatProvider (was LangChainChatProvider)
• Updated "Create AI provider without specifying provider uses fallback" to assert OpenAIChatProvider (was LangChainChatProvider)
• Updated "AI provider exposes working llm factory" to use groq provider (which still goes through the generic LangChainChatProvider path) since OpenAI now uses the dedicated class
• Added new scenario: "Create AI provider returns Anthropic adapter" — asserts AnthropicChatProvider with correct name and model
• Added new scenario: "Create AI provider raises error when OpenAI API key is missing" — asserts ValueError mentioning OPENAI_API_KEY
• Added new scenario: "Create AI provider raises error when Anthropic API key is missing" — asserts ValueError mentioning ANTHROPIC_API_KEY

Step Definitions: features/steps/provider_registry_steps.py

• Added imports for OpenAIChatProvider and AnthropicChatProvider
• Added @then("the provider registry AI provider should be an OpenAIChatProvider") step
• Added @then("the provider registry AI provider should be an AnthropicChatProvider") step

Verification

All changes verified with direct Python tests:

• OpenAIChatProvider returned for ProviderType.OPENAI ✓
• AnthropicChatProvider returned for ProviderType.ANTHROPIC ✓
• ValueError with OPENAI_API_KEY when key missing ✓
• ValueError with ANTHROPIC_API_KEY when key missing ✓
• llm/__init__.py exports all four classes ✓
• groq still uses generic LangChainChatProvider path ✓
• nox -s lint passes ✓
• nox -s typecheck passes (0 errors, 0 warnings) ✓

---

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: ca-issue-worker

## Summary Fixes #3427 — `OpenAIChatProvider` and `AnthropicChatProvider` were dead code in production because `ProviderRegistry.create_ai_provider()` never instantiated them. ## Changes ### Core Fix: `src/cleveragents/providers/registry.py` - Added `ProviderType.OPENAI` dispatch branch in `create_ai_provider()` that instantiates `OpenAIChatProvider` with the configured API key and model - Added `ProviderType.ANTHROPIC` dispatch branch in `create_ai_provider()` that instantiates `AnthropicChatProvider` with the configured API key and model - Both new branches raise `ValueError` with the missing env var name when the API key is not configured, consistent with the existing Google and OpenRouter branches ### Package Exports: `src/cleveragents/providers/llm/__init__.py` - Was empty; now exports all four dedicated provider classes: `OpenAIChatProvider`, `AnthropicChatProvider`, `GoogleChatProvider`, `OpenRouterChatProvider` ### Tests: `features/provider_registry_coverage.feature` - Updated "Create AI provider succeeds for configured provider string" to assert `OpenAIChatProvider` (was `LangChainChatProvider`) - Updated "Create AI provider without specifying provider uses fallback" to assert `OpenAIChatProvider` (was `LangChainChatProvider`) - Updated "AI provider exposes working llm factory" to use `groq` provider (which still goes through the generic `LangChainChatProvider` path) since OpenAI now uses the dedicated class - Added new scenario: "Create AI provider returns Anthropic adapter" — asserts `AnthropicChatProvider` with correct name and model - Added new scenario: "Create AI provider raises error when OpenAI API key is missing" — asserts `ValueError` mentioning `OPENAI_API_KEY` - Added new scenario: "Create AI provider raises error when Anthropic API key is missing" — asserts `ValueError` mentioning `ANTHROPIC_API_KEY` ### Step Definitions: `features/steps/provider_registry_steps.py` - Added imports for `OpenAIChatProvider` and `AnthropicChatProvider` - Added `@then("the provider registry AI provider should be an OpenAIChatProvider")` step - Added `@then("the provider registry AI provider should be an AnthropicChatProvider")` step ## Verification All changes verified with direct Python tests: - `OpenAIChatProvider` returned for `ProviderType.OPENAI` ✓ - `AnthropicChatProvider` returned for `ProviderType.ANTHROPIC` ✓ - `ValueError` with `OPENAI_API_KEY` when key missing ✓ - `ValueError` with `ANTHROPIC_API_KEY` when key missing ✓ - `llm/__init__.py` exports all four classes ✓ - `groq` still uses generic `LangChainChatProvider` path ✓ - `nox -s lint` passes ✓ - `nox -s typecheck` passes (0 errors, 0 warnings) ✓ --- **Automated by CleverAgents Bot** Supervisor: Implementation | Agent: ca-issue-worker

freemo added 1 commit 2026-04-05 18:00:48 +00:00

fix(providers): wire OpenAIChatProvider and AnthropicChatProvider into ProviderRegistry ... f44060e857

Previously, ProviderRegistry.create_ai_provider() dispatched to dedicated
provider classes only for Google and OpenRouter. For OpenAI and Anthropic,
execution fell through to the generic LangChainChatProvider factory, leaving
OpenAIChatProvider and AnthropicChatProvider as dead code in production.

This commit:
- Adds ProviderType.OPENAI dispatch branch in create_ai_provider() to
  instantiate OpenAIChatProvider with the configured API key and model
- Adds ProviderType.ANTHROPIC dispatch branch in create_ai_provider() to
  instantiate AnthropicChatProvider with the configured API key and model
- Both branches raise ValueError with the missing env var name when the
  API key is not configured, consistent with Google and OpenRouter branches
- Updates src/cleveragents/providers/llm/__init__.py to export all four
  dedicated provider classes (OpenAIChatProvider, AnthropicChatProvider,
  GoogleChatProvider, OpenRouterChatProvider)
- Updates provider_registry_coverage.feature to assert that create_ai_provider
  returns OpenAIChatProvider for openai and AnthropicChatProvider for anthropic
- Adds new scenarios for Anthropic dispatch and missing-key error paths for
  both OpenAI and Anthropic
- Updates the 'AI provider exposes working llm factory' scenario to use groq
  (which still goes through the generic LangChainChatProvider path) since
  OpenAI now uses the dedicated class
- Adds step definitions for OpenAIChatProvider and AnthropicChatProvider
  isinstance assertions

Closes #3427

freemo referenced this pull request 2026-04-05 18:01:04 +00:00

UAT: Dedicated OpenAIChatProvider and AnthropicChatProvider classes exist but are never used by the provider registry #3427

freemo reviewed 2026-04-05 18:17:29 +00:00

freemo left a comment

Copy link

PR #3464 Review — fix(providers): wire OpenAIChatProvider and AnthropicChatProvider into ProviderRegistry

Review Focus Areas: architecture-alignment, module-boundaries, interface-contracts

Summary

This PR addresses issue #3427, which identified that OpenAIChatProvider and AnthropicChatProvider were dead code — they existed as dedicated provider classes but were never instantiated by ProviderRegistry.create_ai_provider(). Instead, OpenAI and Anthropic fell through to the generic LangChainChatProvider path, creating an architectural inconsistency with Google and OpenRouter (which already had dedicated dispatch branches).

Files Reviewed

File	Change
src/cleveragents/providers/registry.py	Added ProviderType.OPENAI and ProviderType.ANTHROPIC dispatch branches in create_ai_provider()
src/cleveragents/providers/llm/__init__.py	Was empty → now exports all 4 dedicated provider classes with __all__
features/provider_registry_coverage.feature	Updated existing scenarios + added 3 new scenarios
features/steps/provider_registry_steps.py	Added imports and step definitions for OpenAIChatProvider / AnthropicChatProvider assertions

---

✅ Architecture Alignment

Dispatch pattern consistency: The new OpenAI and Anthropic branches in create_ai_provider() follow the exact same pattern already established by Google and OpenRouter:

1. Lazy import of the dedicated provider class
2. Look up key_attr from PROVIDER_KEY_ATTRS
3. Retrieve API key from settings
4. Fail-fast ValueError if key is missing (with informative env var name)
5. Instantiate the dedicated provider class with api_key, model, and max_retries

This correctly resolves the architectural inconsistency. All four providers with dedicated classes (OpenAI, Anthropic, Google, OpenRouter) are now wired into the registry, while providers without dedicated classes (Groq, Together, Cohere, etc.) correctly fall through to the generic LangChainChatProvider path.

✅ Module Boundaries

• llm/__init__.py exports: Properly exports all 4 dedicated provider classes with explicit __all__. This makes the cleveragents.providers.llm subpackage a proper public API surface, consistent with Python packaging conventions.
• Lazy imports in registry: The dedicated provider classes are imported inside the dispatch branches (not at module level), consistent with the existing pattern and avoiding circular import issues.
• No cross-layer violations: The registry correctly delegates to the provider adapter layer without bypassing architectural boundaries.

✅ Interface Contracts

• OpenAIChatProvider and AnthropicChatProvider both extend LangChainChatProvider and accept api_key, model, max_retries — the registry passes all three correctly.
• Both provider classes perform fail-fast validation (if not api_key: raise ValueError) in their constructors, satisfying the project's fail-fast argument validation requirement.
• The AIProviderInterface contract is satisfied since both classes inherit from LangChainChatProvider which implements it.

✅ Test Quality

New and updated BDD scenarios are comprehensive:

• "Create AI provider succeeds for configured provider string" — updated to assert OpenAIChatProvider (was LangChainChatProvider)
• "Create AI provider without specifying provider uses fallback" — updated to assert OpenAIChatProvider (was LangChainChatProvider)
• "AI provider exposes working llm factory" — correctly switched to groq provider (which still uses the generic LangChainChatProvider path)
• NEW: "Create AI provider returns Anthropic adapter" — verifies AnthropicChatProvider with correct name and model
• NEW: "Create AI provider raises error when OpenAI API key is missing" — verifies ValueError mentioning OPENAI_API_KEY
• NEW: "Create AI provider raises error when Anthropic API key is missing" — verifies ValueError mentioning ANTHROPIC_API_KEY

Step definitions follow existing patterns and are well-structured.

✅ Commit Message Format

Title follows Conventional Commits: fix(providers): wire OpenAIChatProvider and AnthropicChatProvider into ProviderRegistry ✓

⚠️ Minor Observations (Non-blocking)

1. PR metadata incomplete: The PR is missing a Type/Bug label and milestone assignment. The linked issue #3427 has Type/Bug and Priority/Backlog labels. Per CONTRIBUTING.md, PRs should include a Type/ label. Since this is a backlog item with no milestone, this is understandable but should be addressed.

2. Pre-existing code duplication: The API key lookup + validation boilerplate is now repeated 4 times in create_ai_provider() (OpenAI, Anthropic, Google, OpenRouter). This is a pre-existing pattern — the PR is consistent with what was already there for Google/OpenRouter. A future refactoring could extract a _resolve_api_key(provider_type) helper, but that's out of scope for this bug fix.

3. Pre-existing # type: ignore comments: The _create_provider_llm method and the llm_factory closure in create_ai_provider() contain # type: ignore[arg-type] and # type: ignore[import-untyped] comments. These are all pre-existing on master and not introduced by this PR. The new OpenAI and Anthropic branches do NOT add any new type suppressions, which is good.

4. behave import suppression in steps: from behave import given, then, when # type: ignore[import-untyped] in the step definitions file is pre-existing and is a known necessity since behave doesn't ship type stubs.

Verdict

The implementation is clean, architecturally consistent, and well-tested. It correctly resolves the dead-code issue described in #3427 by wiring OpenAIChatProvider and AnthropicChatProvider into the registry dispatch, following the exact same pattern used by Google and OpenRouter. The llm/__init__.py exports are properly configured. Test coverage for the new branches is comprehensive with both happy-path and error-path scenarios.

No blocking issues found. The minor observations above are either pre-existing concerns or metadata housekeeping items.

---

Automated by CleverAgents Bot
Reviewer: Code Quality | Agent: ca-pr-self-reviewer

## PR #3464 Review — `fix(providers): wire OpenAIChatProvider and AnthropicChatProvider into ProviderRegistry` **Review Focus Areas:** architecture-alignment, module-boundaries, interface-contracts ### Summary This PR addresses issue #3427, which identified that `OpenAIChatProvider` and `AnthropicChatProvider` were dead code — they existed as dedicated provider classes but were never instantiated by `ProviderRegistry.create_ai_provider()`. Instead, OpenAI and Anthropic fell through to the generic `LangChainChatProvider` path, creating an architectural inconsistency with Google and OpenRouter (which already had dedicated dispatch branches). ### Files Reviewed | File | Change | |---|---| | `src/cleveragents/providers/registry.py` | Added `ProviderType.OPENAI` and `ProviderType.ANTHROPIC` dispatch branches in `create_ai_provider()` | | `src/cleveragents/providers/llm/__init__.py` | Was empty → now exports all 4 dedicated provider classes with `__all__` | | `features/provider_registry_coverage.feature` | Updated existing scenarios + added 3 new scenarios | | `features/steps/provider_registry_steps.py` | Added imports and step definitions for `OpenAIChatProvider` / `AnthropicChatProvider` assertions | --- ### ✅ Architecture Alignment **Dispatch pattern consistency:** The new OpenAI and Anthropic branches in `create_ai_provider()` follow the exact same pattern already established by Google and OpenRouter: 1. Lazy import of the dedicated provider class 2. Look up `key_attr` from `PROVIDER_KEY_ATTRS` 3. Retrieve API key from settings 4. Fail-fast `ValueError` if key is missing (with informative env var name) 5. Instantiate the dedicated provider class with `api_key`, `model`, and `max_retries` This correctly resolves the architectural inconsistency. All four providers with dedicated classes (OpenAI, Anthropic, Google, OpenRouter) are now wired into the registry, while providers without dedicated classes (Groq, Together, Cohere, etc.) correctly fall through to the generic `LangChainChatProvider` path. ### ✅ Module Boundaries - **`llm/__init__.py` exports:** Properly exports all 4 dedicated provider classes with explicit `__all__`. This makes the `cleveragents.providers.llm` subpackage a proper public API surface, consistent with Python packaging conventions. - **Lazy imports in registry:** The dedicated provider classes are imported inside the dispatch branches (not at module level), consistent with the existing pattern and avoiding circular import issues. - **No cross-layer violations:** The registry correctly delegates to the provider adapter layer without bypassing architectural boundaries. ### ✅ Interface Contracts - **`OpenAIChatProvider`** and **`AnthropicChatProvider`** both extend `LangChainChatProvider` and accept `api_key`, `model`, `max_retries` — the registry passes all three correctly. - Both provider classes perform fail-fast validation (`if not api_key: raise ValueError`) in their constructors, satisfying the project's fail-fast argument validation requirement. - The `AIProviderInterface` contract is satisfied since both classes inherit from `LangChainChatProvider` which implements it. ### ✅ Test Quality New and updated BDD scenarios are comprehensive: - **"Create AI provider succeeds for configured provider string"** — updated to assert `OpenAIChatProvider` (was `LangChainChatProvider`) - **"Create AI provider without specifying provider uses fallback"** — updated to assert `OpenAIChatProvider` (was `LangChainChatProvider`) - **"AI provider exposes working llm factory"** — correctly switched to `groq` provider (which still uses the generic `LangChainChatProvider` path) - **NEW: "Create AI provider returns Anthropic adapter"** — verifies `AnthropicChatProvider` with correct name and model - **NEW: "Create AI provider raises error when OpenAI API key is missing"** — verifies `ValueError` mentioning `OPENAI_API_KEY` - **NEW: "Create AI provider raises error when Anthropic API key is missing"** — verifies `ValueError` mentioning `ANTHROPIC_API_KEY` Step definitions follow existing patterns and are well-structured. ### ✅ Commit Message Format Title follows Conventional Commits: `fix(providers): wire OpenAIChatProvider and AnthropicChatProvider into ProviderRegistry` ✓ ### ⚠️ Minor Observations (Non-blocking) 1. **PR metadata incomplete:** The PR is missing a `Type/Bug` label and milestone assignment. The linked issue #3427 has `Type/Bug` and `Priority/Backlog` labels. Per CONTRIBUTING.md, PRs should include a `Type/` label. Since this is a backlog item with no milestone, this is understandable but should be addressed. 2. **Pre-existing code duplication:** The API key lookup + validation boilerplate is now repeated 4 times in `create_ai_provider()` (OpenAI, Anthropic, Google, OpenRouter). This is a pre-existing pattern — the PR is consistent with what was already there for Google/OpenRouter. A future refactoring could extract a `_resolve_api_key(provider_type)` helper, but that's out of scope for this bug fix. 3. **Pre-existing `# type: ignore` comments:** The `_create_provider_llm` method and the `llm_factory` closure in `create_ai_provider()` contain `# type: ignore[arg-type]` and `# type: ignore[import-untyped]` comments. These are all pre-existing on `master` and not introduced by this PR. The new OpenAI and Anthropic branches do NOT add any new type suppressions, which is good. 4. **`behave` import suppression in steps:** `from behave import given, then, when # type: ignore[import-untyped]` in the step definitions file is pre-existing and is a known necessity since `behave` doesn't ship type stubs. ### Verdict The implementation is clean, architecturally consistent, and well-tested. It correctly resolves the dead-code issue described in #3427 by wiring `OpenAIChatProvider` and `AnthropicChatProvider` into the registry dispatch, following the exact same pattern used by Google and OpenRouter. The `llm/__init__.py` exports are properly configured. Test coverage for the new branches is comprehensive with both happy-path and error-path scenarios. **No blocking issues found.** The minor observations above are either pre-existing concerns or metadata housekeeping items. --- **Automated by CleverAgents Bot** Reviewer: Code Quality | Agent: ca-pr-self-reviewer

freemo referenced this pull request 2026-04-05 19:29:09 +00:00

[Automated] CleverAgents Build Session - 2026-04-05 #3377

freemo commented 2026-04-05 19:33:37 +00:00

Author

Owner

Copy link

Code Review — PR #3464

Review Focus: api-consistency, naming-conventions, code-patterns
Review Type: initial-review
Recommendation: REQUEST CHANGES (process issues only — code is ready)

---

This PR correctly wires OpenAIChatProvider and AnthropicChatProvider into ProviderRegistry.create_ai_provider(), resolving the dead-code issue described in #3427. The implementation follows the established pattern used by GoogleChatProvider and OpenRouterChatProvider, and the test coverage is thorough. The code itself is well-written.

However, there are process compliance issues that must be addressed per CONTRIBUTING.md before merge.

Required Changes

1. [PROCESS] Missing Milestone on PR

   • Location: PR metadata
   • Issue: CONTRIBUTING.md requires every PR to be assigned to a milestone. This PR has milestone: null.
   • Required: Assign this PR to the appropriate milestone (the issue is tagged Priority/Backlog, so assign to the relevant backlog or current milestone).

2. [PROCESS] Missing Type/ Label on PR

   • Location: PR metadata
   • Issue: CONTRIBUTING.md requires every PR to have a Type/ label (e.g., Type/Bug, Type/Feature). This PR has no labels.
   • Required: Add the Type/Bug label to match the linked issue #3427.

Deep Dive Results — Focus Areas

API Consistency ✅

Given special attention to API consistency across the provider dispatch branches in create_ai_provider():

• The new OpenAI and Anthropic branches follow the exact same pattern as the existing Google and OpenRouter branches: import → key lookup → API key validation → provider instantiation with api_key, model, and max_retries.
• Error messages use the same format string: "Provider {provider_type.value} is not configured. Please set the {missing_env} environment variable."
• The missing_env computation logic (key_attr.upper() if key_attr else provider_type.value.upper()) is identical across all four branches.
• Constructor call signatures are consistent: all four dedicated providers receive api_key=, model=, max_retries=.

Verdict: Excellent API consistency. The new branches are indistinguishable in structure from the existing ones.

Naming Conventions ✅

• Class names follow the established {Provider}ChatProvider convention: OpenAIChatProvider, AnthropicChatProvider, GoogleChatProvider, OpenRouterChatProvider.
• The __init__.py exports are in alphabetical order.
• Step definition function names follow the step_impl_* convention consistently.
• Feature scenario names are descriptive and follow the existing naming style.
• The name attribute passed to each provider constructor matches the ProviderType enum value (e.g., "openai", "anthropic"), maintaining consistency.

Verdict: All naming conventions are properly followed.

Code Patterns ✅ (with minor observation)

• The dispatch pattern in create_ai_provider() is consistent: each provider type gets an if provider_type == ProviderType.X: block with identical structure.
• The fallback to LangChainChatProvider for non-dedicated providers (e.g., Groq, Together) is preserved correctly at the end of the method.
• The llm/__init__.py properly uses __all__ to declare public exports.

Minor observation (non-blocking): The create_ai_provider() method now has 4 nearly identical blocks for the dedicated providers (OpenAI, Anthropic, Google, OpenRouter), each repeating the API key lookup and validation logic verbatim. This is a pre-existing pattern that this PR correctly extends, but a future refactoring to extract the common key-lookup/validation into a private helper (e.g., _resolve_api_key(provider_type)) would reduce duplication and make adding future dedicated providers easier. This is not a blocker for this PR.

Standard Criteria

Specification Alignment ✅

• The change aligns with ADR-008 (Provider Plugin Architecture) referenced in the module docstring.
• The registry now correctly dispatches to dedicated provider classes for all providers that have them, eliminating the dead-code inconsistency.

Commit Message Format ✅

• First line: fix(providers): wire OpenAIChatProvider and AnthropicChatProvider into ProviderRegistry — correct Conventional Changelog format.
• Footer: Closes #3427 — proper issue linking.
• Single atomic commit with detailed body.

Test Quality ✅

• 3 new scenarios added covering: Anthropic dispatch, OpenAI missing-key error, Anthropic missing-key error.
• 3 existing scenarios updated to reflect the new dispatch behavior.
• Tests verify meaningful behavior: isinstance checks, name attribute, model_id attribute, and ValueError with specific env var names.
• Step definitions are well-structured with proper type annotations.

Code Correctness ✅

• The key_attr lookup from PROVIDER_KEY_ATTRS is safe for both ProviderType.OPENAI and ProviderType.ANTHROPIC (both have entries).
• The api_key retrieval via getattr(self._settings, key_attr, None) handles missing attributes gracefully.
• The model fallback chain (model_id or self.DEFAULT_MODELS.get(provider_type, "gpt-4o")) is correct.
• No new # type: ignore suppressions introduced.

Good Aspects

• Clean, focused change that does exactly what the issue asks for
• Excellent consistency with existing patterns
• Thorough test coverage including both happy path and error paths
• Well-written commit message with detailed explanation
• The __init__.py update properly exports all four dedicated provider classes

Decision: REQUEST CHANGES 🔄

The code changes themselves are excellent and ready to merge. The only blockers are the missing milestone and Type/ label on the PR, which are required by CONTRIBUTING.md for all pull requests.

---

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## Code Review — PR #3464 **Review Focus**: api-consistency, naming-conventions, code-patterns **Review Type**: initial-review **Recommendation**: REQUEST CHANGES (process issues only — code is ready) --- This PR correctly wires `OpenAIChatProvider` and `AnthropicChatProvider` into `ProviderRegistry.create_ai_provider()`, resolving the dead-code issue described in #3427. The implementation follows the established pattern used by `GoogleChatProvider` and `OpenRouterChatProvider`, and the test coverage is thorough. The code itself is well-written. However, there are **process compliance issues** that must be addressed per CONTRIBUTING.md before merge. ### Required Changes 1. **[PROCESS] Missing Milestone on PR** - Location: PR metadata - Issue: CONTRIBUTING.md requires every PR to be assigned to a milestone. This PR has `milestone: null`. - Required: Assign this PR to the appropriate milestone (the issue is tagged `Priority/Backlog`, so assign to the relevant backlog or current milestone). 2. **[PROCESS] Missing `Type/` Label on PR** - Location: PR metadata - Issue: CONTRIBUTING.md requires every PR to have a `Type/` label (e.g., `Type/Bug`, `Type/Feature`). This PR has no labels. - Required: Add the `Type/Bug` label to match the linked issue #3427. ### Deep Dive Results — Focus Areas #### API Consistency ✅ Given special attention to API consistency across the provider dispatch branches in `create_ai_provider()`: - The new OpenAI and Anthropic branches follow the **exact same pattern** as the existing Google and OpenRouter branches: import → key lookup → API key validation → provider instantiation with `api_key`, `model`, and `max_retries`. - Error messages use the same format string: `"Provider {provider_type.value} is not configured. Please set the {missing_env} environment variable."` - The `missing_env` computation logic (`key_attr.upper() if key_attr else provider_type.value.upper()`) is identical across all four branches. - Constructor call signatures are consistent: all four dedicated providers receive `api_key=`, `model=`, `max_retries=`. **Verdict**: Excellent API consistency. The new branches are indistinguishable in structure from the existing ones. #### Naming Conventions ✅ - Class names follow the established `{Provider}ChatProvider` convention: `OpenAIChatProvider`, `AnthropicChatProvider`, `GoogleChatProvider`, `OpenRouterChatProvider`. - The `__init__.py` exports are in alphabetical order. - Step definition function names follow the `step_impl_*` convention consistently. - Feature scenario names are descriptive and follow the existing naming style. - The `name` attribute passed to each provider constructor matches the `ProviderType` enum value (e.g., `"openai"`, `"anthropic"`), maintaining consistency. **Verdict**: All naming conventions are properly followed. #### Code Patterns ✅ (with minor observation) - The dispatch pattern in `create_ai_provider()` is consistent: each provider type gets an `if provider_type == ProviderType.X:` block with identical structure. - The fallback to `LangChainChatProvider` for non-dedicated providers (e.g., Groq, Together) is preserved correctly at the end of the method. - The `llm/__init__.py` properly uses `__all__` to declare public exports. **Minor observation (non-blocking)**: The `create_ai_provider()` method now has 4 nearly identical blocks for the dedicated providers (OpenAI, Anthropic, Google, OpenRouter), each repeating the API key lookup and validation logic verbatim. This is a pre-existing pattern that this PR correctly extends, but a future refactoring to extract the common key-lookup/validation into a private helper (e.g., `_resolve_api_key(provider_type)`) would reduce duplication and make adding future dedicated providers easier. This is not a blocker for this PR. ### Standard Criteria #### Specification Alignment ✅ - The change aligns with ADR-008 (Provider Plugin Architecture) referenced in the module docstring. - The registry now correctly dispatches to dedicated provider classes for all providers that have them, eliminating the dead-code inconsistency. #### Commit Message Format ✅ - First line: `fix(providers): wire OpenAIChatProvider and AnthropicChatProvider into ProviderRegistry` — correct Conventional Changelog format. - Footer: `Closes #3427` — proper issue linking. - Single atomic commit with detailed body. #### Test Quality ✅ - 3 new scenarios added covering: Anthropic dispatch, OpenAI missing-key error, Anthropic missing-key error. - 3 existing scenarios updated to reflect the new dispatch behavior. - Tests verify meaningful behavior: `isinstance` checks, `name` attribute, `model_id` attribute, and `ValueError` with specific env var names. - Step definitions are well-structured with proper type annotations. #### Code Correctness ✅ - The `key_attr` lookup from `PROVIDER_KEY_ATTRS` is safe for both `ProviderType.OPENAI` and `ProviderType.ANTHROPIC` (both have entries). - The `api_key` retrieval via `getattr(self._settings, key_attr, None)` handles missing attributes gracefully. - The `model` fallback chain (`model_id or self.DEFAULT_MODELS.get(provider_type, "gpt-4o")`) is correct. - No new `# type: ignore` suppressions introduced. ### Good Aspects - Clean, focused change that does exactly what the issue asks for - Excellent consistency with existing patterns - Thorough test coverage including both happy path and error paths - Well-written commit message with detailed explanation - The `__init__.py` update properly exports all four dedicated provider classes **Decision: REQUEST CHANGES** 🔄 The code changes themselves are excellent and ready to merge. The only blockers are the missing milestone and `Type/` label on the PR, which are required by CONTRIBUTING.md for all pull requests. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer

freemo referenced this pull request 2026-04-05 19:39:43 +00:00

[Automated] CleverAgents Build Session - 2026-04-05 #3377

freemo referenced this pull request 2026-04-05 19:48:58 +00:00

[Automated] CleverAgents Build Session - 2026-04-05 #3377

freemo referenced this pull request 2026-04-05 20:01:26 +00:00

[Automated] CleverAgents Build Session - 2026-04-05 #3572

freemo referenced this pull request 2026-04-05 20:02:57 +00:00

[Automated] CleverAgents Build Session - 2026-04-05 #3572

freemo referenced this pull request 2026-04-05 20:07:13 +00:00

[Automated] CleverAgents Build Session - 2026-04-05 #3572

freemo referenced this pull request 2026-04-05 20:07:24 +00:00

[Automated] CleverAgents Build Session - 2026-04-05 #3572

freemo referenced this pull request 2026-04-05 20:13:35 +00:00

[Automated] CleverAgents Build Session - 2026-04-05 #3572

freemo added this to the v3.2.0 milestone 2026-04-05 20:48:53 +00:00

freemo referenced this pull request 2026-04-05 20:49:07 +00:00

[Automated] CleverAgents Build Session - 2026-04-05 #3572

freemo referenced this pull request 2026-04-05 20:52:58 +00:00

[Automated] CleverAgents Build Session - 2026-04-05 #3377

freemo referenced this pull request 2026-04-05 20:54:57 +00:00

[Automated] CleverAgents Build Session - 2026-04-05 #3377

freemo referenced this pull request 2026-04-05 20:59:02 +00:00

[Automated] CleverAgents Build Session - 2026-04-05 #3377

freemo referenced this pull request 2026-04-05 20:59:05 +00:00

UAT: Dedicated OpenAIChatProvider and AnthropicChatProvider classes exist but are never used by the provider registry #3427

freemo referenced this pull request 2026-04-05 21:00:52 +00:00

[Automated] CleverAgents Build Session - 2026-04-05 #3377

freemo referenced this pull request 2026-04-05 21:05:04 +00:00

[Automated] CleverAgents Build Session - 2026-04-05 #3377

freemo merged commit 2a48c508d6 into master 2026-04-05 21:07:03 +00:00

freemo referenced this pull request 2026-04-05 21:09:58 +00:00

docs: update session export panels and plan executor subplan wiring #3657

freemo referenced this pull request 2026-04-05 21:10:13 +00:00

[Automated] CleverAgents Build Session - 2026-04-05 #3572

freemo referenced this pull request 2026-04-05 21:11:36 +00:00

UAT: Dedicated OpenAIChatProvider and AnthropicChatProvider classes exist but are never used by the provider registry #3427

freemo removed this from the v3.2.0 milestone 2026-04-06 20:51:12 +00:00

HAL9000 referenced this pull request 2026-04-08 19:31:39 +00:00

Proposal: update specification — agents diagnostics to document all 9 supported providers #4806

HAL9000 referenced this pull request 2026-04-08 19:32:37 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4799

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

auto/needs-reevaluation

Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  

controller-managed

Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  

auto/blocked-by-deps

PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  

auto/ci-timeout

Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  

auto/claimed-implementer

Currently being processed by an implementer worker.

  

auto/claimed-merge

Currently being processed by the merge driver.

  

auto/claimed-reviewer

Currently being processed by a reviewer worker.

  

auto/driver-down

Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  

auto/invariant-violation

Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  

auto/last-attempt-tier-0

In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-1

In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-2

In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  

auto/last-attempt-tier-min

In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  

Automation Tracking

Tracking issues used by the AI Automation system for agents to communicate and report.

  

auto/needs-conflict-resolution

Rebase conflict needs LLM conflict-resolver.

  

auto/needs-implementer

Failing CI needs implementer attention.

  

auto/postmortem

Documenting a driver incident or rollback.

  

auto/ready-to-merge

Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  

auto/restart-throttled

Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  

auto/revert

Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  

auto/sentinel

Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  

auto/stale-inactivity

No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  

auto/unstable

Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  

Blocked

A ticket in a blocked state and unable to complete until some other task is completed first.

  

Bounty

$100

A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$1000

A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$10000

A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$20

A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$2000

A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$250

A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$50

A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$500

A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$5000

A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$750

A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  

MoSCoW

Could have

Could have feature in order to satisfy the epic/legendary.

  

MoSCoW

Must have

Must have feature in order to satisfy the epic/legendary.

  

MoSCoW

Should have

Should have feature in order to satisfy the epic/legendary.

  

Needs Feedback

There are questions in the ticket that can not be completed until the project owner provides clarity.

  

Points

1

1 man-hours worth of work for an expert with no learning curve.

  

Points

13

13 man-hours worth of work for an expert with no learning curve.

  

Points

2

2 man-hours worth of work for an expert with no learning curve.

  

Points

21

21 man-hours worth of work for an expert with no learning curve.

  

Points

3

3 man-hours worth of work for an expert with no learning curve.

  

Points

34

34 man-hours worth of work for an expert with no learning curve.

  

Points

5

5 man-hours worth of work for an expert with no learning curve.

  

Points

55

55 man-hours worth of work for an expert with no learning curve.

  

Points

8

8 man-hours worth of work for an expert with no learning curve.

  

Points

88

88 man-hours worth of work for an expert with no learning curve.

  

Priority

Backlog

This ticket has backlogged priority and is not to be worked on yet

  

Priority

CI Blocker

Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Signed-off: Owner

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Scrum Master

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Tech Lead

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Spike

A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  

State

Completed

The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  

State

Duplicate

A ticket that represents the same content as an existing ticket.

  

State

In Progress

A ticket that is actively being developed.

  

State

In Review

A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  

State

Paused

This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  

State

Unverified

All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  

State

Verified

The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  

State

Wont Do

This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  

Type

Automation

Any edits or discussion about the AI automated coding system.

  

Type

Bug

Something that doesnt work as intended.

  

Type

Discussion

Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  

Type

Documentation

An error or improvement needed in the documentation.

  

Type

Epic

Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  

Type

Feature

Some new functionality not present.

  

Type

Legendary

A type of Epic which will contain other Epics.

  

Type

Refactor

A code change that restructures existing code without changing its external behavior.

  

Type

Support

Someone needs help using the project.

  

Type

Task

A generic task that doesnt fit into the other type categories.

  

Type

Testing

Work exclusively focusing on fixing or expanding testing.

No labels

auto/needs-reevaluation

controller-managed

auto/blocked-by-deps

auto/ci-timeout

auto/claimed-implementer

auto/claimed-merge

auto/claimed-reviewer

auto/driver-down

auto/invariant-violation

auto/last-attempt-tier-0

auto/last-attempt-tier-1

auto/last-attempt-tier-2

auto/last-attempt-tier-min

Automation Tracking

auto/needs-conflict-resolution

auto/needs-implementer

auto/postmortem

auto/ready-to-merge

auto/restart-throttled

auto/revert

auto/sentinel

auto/stale-inactivity

auto/unstable

Blocked

Bounty

$100

Bounty

$1000

Bounty

$10000

Bounty

$20

Bounty

$2000

Bounty

$250

Bounty

$50

Bounty

$500

Bounty

$5000

Bounty

$750

MoSCoW

Could have

MoSCoW

Must have

MoSCoW

Should have

Needs Feedback

Points

1

Points

13

Points

2

Points

21

Points

3

Points

34

Points

5

Points

55

Points

8

Points

88

Priority

Backlog

Priority

CI Blocker

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Signed-off: Owner

Signed-off: Scrum Master

Signed-off: Tech Lead

Spike

State

Completed

State

Duplicate

State

In Progress

State

In Review

State

Paused

State

Unverified

State

Verified

State

Wont Do

Type

Automation

Type

Bug

Type

Discussion

Type

Documentation

Type

Epic

Type

Feature

Type

Legendary

Type

Refactor

Type

Support

Type

Task

Type

Testing

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

cleveragents/cleveragents-core!3464

No description provided.