cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

fix(validation): enforce type discriminator in attach_validation to reject plain tools #3317

Closed
freemo wants to merge 1 commits from fix/tool-registry-validation-type-discriminator into master
pull from: fix/tool-registry-validation-type-discriminator
merge into: cleveragents:master
Conversation 20 Commits 1 Files Changed 5
+90 -2

1 Commits

Author SHA1 Message Date
freemo 94f780e82d fix(validation): enforce type discriminator in attach_validation to reject plain tools
CI / lint (pull_request) Successful in 27s
Details
CI / typecheck (pull_request) Successful in 49s
Details
CI / quality (pull_request) Successful in 34s
Details
CI / security (pull_request) Successful in 57s
Details
CI / build (pull_request) Successful in 17s
Details
CI / helm (pull_request) Successful in 23s
Details
CI / unit_tests (pull_request) Successful in 7m1s
Details
CI / e2e_tests (pull_request) Successful in 18m48s
Details
CI / integration_tests (pull_request) Successful in 22m41s
Details
CI / docker (pull_request) Successful in 1m22s
Details
CI / coverage (pull_request) Successful in 10m51s
Details
CI / status-check (pull_request) Successful in 1s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / benchmark-regression (pull_request) Failing after 14m11s
Details 
Add tool_type discriminator check in ToolRegistryService.attach_validation()
to enforce the spec requirement that only entries tagged as 'validation' may
be attached. Passing a plain tool (tool_type='tool') now raises ValidationError
instead of silently succeeding.

Changes:
- src/cleveragents/application/services/tool_registry_service.py: Add
  tool_type discriminator check after existence check; raise ValidationError
  when tool_type != 'validation'; update docstring to document enforcement
- features/consolidated_tool.feature: Add TDD scenario for plain tool rejection
- features/steps/tool_registry_service_coverage_steps.py: Add Given step for
  plain tool entry and Then step for ValidationError assertion
- robot/tool_cli.robot: Add integration test 'Validation Attach Rejects Plain Tool'
- robot/helper_tool_cli.py: Add validation_attach_plain_tool() helper function

ISSUES CLOSED: #2912
 2026-04-05 09:35:20 +00:00