cleveragents/cleveragents-core
cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.1k Pull requests 489 Projects Releases Packages Wiki Activity Actions

fix(resource-type): require letter-start for namespace/name in _NAMESPACED_RE #3290

Merged
freemo merged 1 commit from fix/resource-type-namespaced-re-digit-start into master 2026-04-05 21:12:25 +00:00
Conversation 3 Commits 1 Files changed 4 +141 -3
freemo commented 2026-04-05 09:11:52 +00:00
Owner
Copy link

Summary

Fixes _NAMESPACED_RE in resource_type.py and _resource_type_validation.py to require both namespace and name components to start with a letter, consistent with the spec requirement and _BUILTIN_NAME_RE.

Problem

The _NAMESPACED_RE pattern used [a-zA-Z0-9] as the first character class, allowing digit-starting names like 123abc/my-type and local/456-type. This was inconsistent with:

  • _BUILTIN_NAME_RE which correctly uses [a-zA-Z]
  • The spec requirement that names start with a letter
  • _SERVER_NS_NAME_RE in project.py

Changes

src/cleveragents/domain/models/core/resource_type.py

  • Changed _NAMESPACED_RE from ^[a-zA-Z0-9][a-zA-Z0-9_-]*/[a-zA-Z0-9][a-zA-Z0-9_-]*$ to ^[a-zA-Z][a-zA-Z0-9_-]*/[a-zA-Z][a-zA-Z0-9_-]*$
  • Updated docstring comment to reflect the letter-start requirement

src/cleveragents/domain/models/core/_resource_type_validation.py

  • Changed _NAMESPACED_RE from ^[a-zA-Z0-9_-]+/[a-zA-Z0-9_-]+$ to ^[a-zA-Z][a-zA-Z0-9_-]*/[a-zA-Z][a-zA-Z0-9_-]*$

features/resource_type_digit_start_validation.feature (new)

  • Added 8 Behave scenarios covering:
    • Rejection of digit-starting namespace (123abc/my-type)
    • Rejection of digit-starting name component (local/456-type)
    • Rejection of digit-starting both components (1ns/2name)
    • Acceptance of valid letter-starting names (local/my-type, myorg/custom-db, my_org/my_type)
    • Rejection of digit-starting inherits field values

features/steps/resource_type_digit_start_validation_steps.py (new)

  • Step definitions for the new feature file

Verification

  • ResourceTypeSpec(name="123abc/my-type", ...) now raises ValidationError ✓
  • ResourceTypeSpec(name="local/456-type", ...) now raises ValidationError ✓
  • ResourceTypeSpec(name="local/my-type", ...) still succeeds ✓
  • ResourceTypeSpec(name="myorg/custom-db", ...) still succeeds ✓
  • nox -e lint passes ✓
  • nox -e typecheck passes (0 errors, 0 warnings) ✓

Closes #2983

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: ca-issue-worker

## Summary Fixes `_NAMESPACED_RE` in `resource_type.py` and `_resource_type_validation.py` to require both namespace and name components to start with a letter, consistent with the spec requirement and `_BUILTIN_NAME_RE`. ## Problem The `_NAMESPACED_RE` pattern used `[a-zA-Z0-9]` as the first character class, allowing digit-starting names like `123abc/my-type` and `local/456-type`. This was inconsistent with: - `_BUILTIN_NAME_RE` which correctly uses `[a-zA-Z]` - The spec requirement that names start with a letter - `_SERVER_NS_NAME_RE` in `project.py` ## Changes ### `src/cleveragents/domain/models/core/resource_type.py` - Changed `_NAMESPACED_RE` from `^[a-zA-Z0-9][a-zA-Z0-9_-]*/[a-zA-Z0-9][a-zA-Z0-9_-]*$` to `^[a-zA-Z][a-zA-Z0-9_-]*/[a-zA-Z][a-zA-Z0-9_-]*$` - Updated docstring comment to reflect the letter-start requirement ### `src/cleveragents/domain/models/core/_resource_type_validation.py` - Changed `_NAMESPACED_RE` from `^[a-zA-Z0-9_-]+/[a-zA-Z0-9_-]+$` to `^[a-zA-Z][a-zA-Z0-9_-]*/[a-zA-Z][a-zA-Z0-9_-]*$` ### `features/resource_type_digit_start_validation.feature` (new) - Added 8 Behave scenarios covering: - Rejection of digit-starting namespace (`123abc/my-type`) - Rejection of digit-starting name component (`local/456-type`) - Rejection of digit-starting both components (`1ns/2name`) - Acceptance of valid letter-starting names (`local/my-type`, `myorg/custom-db`, `my_org/my_type`) - Rejection of digit-starting `inherits` field values ### `features/steps/resource_type_digit_start_validation_steps.py` (new) - Step definitions for the new feature file ## Verification - `ResourceTypeSpec(name="123abc/my-type", ...)` now raises `ValidationError` ✓ - `ResourceTypeSpec(name="local/456-type", ...)` now raises `ValidationError` ✓ - `ResourceTypeSpec(name="local/my-type", ...)` still succeeds ✓ - `ResourceTypeSpec(name="myorg/custom-db", ...)` still succeeds ✓ - `nox -e lint` passes ✓ - `nox -e typecheck` passes (0 errors, 0 warnings) ✓ Closes #2983 --- **Automated by CleverAgents Bot** Supervisor: Implementation | Agent: ca-issue-worker
fix(resource-type): require letter-start for namespace/name in _NAMESPACED_RE
All checks were successful
CI / lint (pull_request) Successful in 21s
Details
CI / typecheck (pull_request) Successful in 47s
Details
CI / quality (pull_request) Successful in 35s
Details
CI / security (pull_request) Successful in 1m3s
Details
CI / build (pull_request) Successful in 18s
Details
CI / helm (pull_request) Successful in 23s
Details
CI / unit_tests (pull_request) Successful in 6m41s
Details
CI / e2e_tests (pull_request) Successful in 18m1s
Details
CI / integration_tests (pull_request) Successful in 22m59s
Details
CI / docker (pull_request) Successful in 1m22s
Details
CI / coverage (pull_request) Successful in 11m29s
Details
CI / status-check (pull_request) Successful in 1s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / benchmark-regression (pull_request) Successful in 58m55s
Details
c1dca80bf2 
Update _NAMESPACED_RE in resource_type.py and _resource_type_validation.py
to require both namespace and name components to start with a letter, consistent
with _BUILTIN_NAME_RE and the spec requirement that names start with a letter.

Previously, _NAMESPACED_RE used [a-zA-Z0-9] as the first character class,
allowing digit-starting names like '123abc/my-type'. Now uses [a-zA-Z] to
enforce letter-start for both components.

Also adds Behave scenarios covering rejection of digit-starting custom resource
type names and valid letter-starting names.

ISSUES CLOSED: #2983
freemo added this to the v3.7.0 milestone 2026-04-05 09:14:20 +00:00
freemo reviewed 2026-04-05 16:28:35 +00:00
freemo left a comment
Copy link

Review Summary

Reviewed PR #3290 with focus on api-consistency, naming-conventions, and code-patterns.

This is a clean, well-scoped bug fix that corrects _NAMESPACED_RE regex patterns in two files to require letter-start for both namespace and name components, aligning with the spec requirement and the existing _BUILTIN_NAME_RE / _SERVER_NS_NAME_RE patterns.

Verdict: This PR is ready for approval.

✅ Specification Compliance

  • The spec defines the name format as [[server:]namespace/]name and the glossary entry for "Namespace" confirms letter-start convention
  • _SERVER_NS_NAME_RE in project.py (line 32-36) already uses [a-zA-Z] for first character — this PR brings _NAMESPACED_RE into alignment
  • _BUILTIN_NAME_RE already uses [a-zA-Z] — consistency is now restored

✅ API Consistency (Focus Area)

  • Both _NAMESPACED_RE definitions (in resource_type.py and _resource_type_validation.py) are now identical: ^[a-zA-Z][a-zA-Z0-9_-]*/[a-zA-Z][a-zA-Z0-9_-]*$
  • Cross-module consistency: The pattern now matches the structure used in _SERVER_NS_NAME_RE in project.py and _BUILTIN_NAME_RE in both files
  • Validation behavior: Both validate_name() and validate_inherits() validators correctly use the updated pattern through the module-level _NAMESPACED_RE

✅ Naming Conventions (Focus Area)

  • Variable names follow existing project conventions (_NAMESPACED_RE, _BUILTIN_NAME_RE)
  • Feature file name resource_type_digit_start_validation.feature follows project naming patterns
  • Step file name resource_type_digit_start_validation_steps.py follows the <feature>_steps.py convention
  • Helper function _make_custom_physical_spec() follows the _ prefix convention for internal helpers

✅ Code Patterns (Focus Area)

  • The regex fix is minimal and targeted — only the character class for the first character was changed
  • Step definitions follow the established pattern: try/except capturing ValidationError into context.rt_error
  • Background step correctly reuses the existing given step from resource_type_model_coverage_steps.py
  • The then step for "invalid inherits type name" is correctly reused from resource_type_model_coverage_steps.py (noted in the step file docstring)

✅ CONTRIBUTING.md Compliance

  • Commit message: fix(resource-type): require letter-start for namespace/name in _NAMESPACED_RE — correct Conventional Changelog format ✓
  • Issue footer: ISSUES CLOSED: #2983 ✓
  • PR metadata: Closes #2983, milestone v3.7.0 (matches issue), Type/Bug label ✓
  • Single atomic commit with implementation + tests ✓
  • No forbidden patterns: No # type: ignore, imports at top of file ✓

✅ Test Quality

  • 8 Behave scenarios covering:
    • 3 rejection cases (digit-starting namespace, name, both)
    • 3 acceptance cases (letter-starting with various valid characters)
    • 2 inherits field rejection cases
  • Assertions check both that errors are raised AND that error messages contain expected text
  • Step definitions are clean, well-documented, and properly typed

✅ Code Correctness

  • The regex change from [a-zA-Z0-9] → [a-zA-Z] is correct for the stated requirement
  • Bonus fix in _resource_type_validation.py: The old pattern ^[a-zA-Z0-9_-]+/[a-zA-Z0-9_-]+$ was even more permissive — it allowed names starting with hyphens or underscores (e.g., _ns/name, -ns/name). The new pattern correctly prevents this too.

Minor Suggestions (Non-blocking)

  1. DRY concern — duplicate _NAMESPACED_RE definitions: Both resource_type.py and _resource_type_validation.py define their own _NAMESPACED_RE (and _BUILTIN_NAME_RE). If someone changes one but not the other in the future, the inconsistency bug could recur. Consider a follow-up issue to consolidate these into a single shared location (e.g., the validation module exports them, and resource_type.py imports). This is a pre-existing design issue, not introduced by this PR.

  2. Additional edge case tests: Since the _resource_type_validation.py fix also prevents names starting with hyphens or underscores (which the old [a-zA-Z0-9_-]+ pattern allowed), consider adding scenarios for _ns/name and -ns/name rejection in a follow-up. Again, not blocking for this PR since the issue scope was specifically digit-starting names.

Decision: APPROVED ✅

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## Review Summary Reviewed PR #3290 with focus on **api-consistency**, **naming-conventions**, and **code-patterns**. This is a clean, well-scoped bug fix that corrects `_NAMESPACED_RE` regex patterns in two files to require letter-start for both namespace and name components, aligning with the spec requirement and the existing `_BUILTIN_NAME_RE` / `_SERVER_NS_NAME_RE` patterns. **Verdict: This PR is ready for approval.** ### ✅ Specification Compliance - The spec defines the name format as `[[server:]namespace/]name` and the glossary entry for "Namespace" confirms letter-start convention - `_SERVER_NS_NAME_RE` in `project.py` (line 32-36) already uses `[a-zA-Z]` for first character — this PR brings `_NAMESPACED_RE` into alignment - `_BUILTIN_NAME_RE` already uses `[a-zA-Z]` — consistency is now restored ### ✅ API Consistency (Focus Area) - **Both `_NAMESPACED_RE` definitions** (in `resource_type.py` and `_resource_type_validation.py`) are now identical: `^[a-zA-Z][a-zA-Z0-9_-]*/[a-zA-Z][a-zA-Z0-9_-]*$` - **Cross-module consistency**: The pattern now matches the structure used in `_SERVER_NS_NAME_RE` in `project.py` and `_BUILTIN_NAME_RE` in both files - **Validation behavior**: Both `validate_name()` and `validate_inherits()` validators correctly use the updated pattern through the module-level `_NAMESPACED_RE` ### ✅ Naming Conventions (Focus Area) - Variable names follow existing project conventions (`_NAMESPACED_RE`, `_BUILTIN_NAME_RE`) - Feature file name `resource_type_digit_start_validation.feature` follows project naming patterns - Step file name `resource_type_digit_start_validation_steps.py` follows the `<feature>_steps.py` convention - Helper function `_make_custom_physical_spec()` follows the `_` prefix convention for internal helpers ### ✅ Code Patterns (Focus Area) - The regex fix is minimal and targeted — only the character class for the first character was changed - Step definitions follow the established pattern: try/except capturing `ValidationError` into `context.rt_error` - Background step correctly reuses the existing `given` step from `resource_type_model_coverage_steps.py` - The `then` step for "invalid inherits type name" is correctly reused from `resource_type_model_coverage_steps.py` (noted in the step file docstring) ### ✅ CONTRIBUTING.md Compliance - **Commit message**: `fix(resource-type): require letter-start for namespace/name in _NAMESPACED_RE` — correct Conventional Changelog format ✓ - **Issue footer**: `ISSUES CLOSED: #2983` ✓ - **PR metadata**: `Closes #2983`, milestone v3.7.0 (matches issue), `Type/Bug` label ✓ - **Single atomic commit** with implementation + tests ✓ - **No forbidden patterns**: No `# type: ignore`, imports at top of file ✓ ### ✅ Test Quality - 8 Behave scenarios covering: - 3 rejection cases (digit-starting namespace, name, both) - 3 acceptance cases (letter-starting with various valid characters) - 2 `inherits` field rejection cases - Assertions check both that errors are raised AND that error messages contain expected text - Step definitions are clean, well-documented, and properly typed ### ✅ Code Correctness - The regex change from `[a-zA-Z0-9]` → `[a-zA-Z]` is correct for the stated requirement - **Bonus fix in `_resource_type_validation.py`**: The old pattern `^[a-zA-Z0-9_-]+/[a-zA-Z0-9_-]+$` was even more permissive — it allowed names starting with hyphens or underscores (e.g., `_ns/name`, `-ns/name`). The new pattern correctly prevents this too. ### Minor Suggestions (Non-blocking) 1. **DRY concern — duplicate `_NAMESPACED_RE` definitions**: Both `resource_type.py` and `_resource_type_validation.py` define their own `_NAMESPACED_RE` (and `_BUILTIN_NAME_RE`). If someone changes one but not the other in the future, the inconsistency bug could recur. Consider a follow-up issue to consolidate these into a single shared location (e.g., the validation module exports them, and `resource_type.py` imports). This is a pre-existing design issue, not introduced by this PR. 2. **Additional edge case tests**: Since the `_resource_type_validation.py` fix also prevents names starting with hyphens or underscores (which the old `[a-zA-Z0-9_-]+` pattern allowed), consider adding scenarios for `_ns/name` and `-ns/name` rejection in a follow-up. Again, not blocking for this PR since the issue scope was specifically digit-starting names. **Decision: APPROVED** ✅ --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
freemo requested reviews from khird, drew 2026-04-05 17:59:24 +00:00
freemo commented 2026-04-05 17:59:37 +00:00
Author
Owner
Copy link

PR Status Update — Awaiting Review

This PR is ready for review. Here is the current status:

✅ CI Checks

All critical CI checks are passing:

  • lint ✅ | typecheck ✅ | unit_tests ✅ | coverage ✅
  • integration_tests ✅ | e2e_tests ✅ | docker ✅ | helm ✅
  • security ✅ | quality ✅ | build ✅ | status-check ✅

The benchmark-regression and benchmark-publish checks are pending (these are non-blocking performance checks that run asynchronously).

✅ Merge Readiness

  • No merge conflicts with master
  • Correct dependency direction: PR #3290 blocks issue #2983 ✅
  • Issue #2983 is in State/In Review ✅
  • Milestone: v3.7.0 ✅
  • Type label: Type/Bug ✅

❌ Blocking: Needs 2 Approving Reviews

Per CONTRIBUTING.md, this PR requires 2 approving reviews from non-author contributors. Currently there are 0 official approvals.

Review requests have been sent to @khird and @drew.

What This PR Does

Fixes _NAMESPACED_RE in resource_type.py and _resource_type_validation.py to require both namespace and name components to start with a letter (changing [a-zA-Z0-9] → [a-zA-Z] for the first character class). This aligns with the spec requirement, _BUILTIN_NAME_RE, and _SERVER_NS_NAME_RE in project.py.

The fix is minimal, targeted, and includes 8 Behave scenarios covering rejection and acceptance cases.

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: ca-issue-worker

## PR Status Update — Awaiting Review This PR is **ready for review**. Here is the current status: ### ✅ CI Checks All critical CI checks are passing: - lint ✅ | typecheck ✅ | unit_tests ✅ | coverage ✅ - integration_tests ✅ | e2e_tests ✅ | docker ✅ | helm ✅ - security ✅ | quality ✅ | build ✅ | status-check ✅ The `benchmark-regression` and `benchmark-publish` checks are pending (these are non-blocking performance checks that run asynchronously). ### ✅ Merge Readiness - No merge conflicts with master - Correct dependency direction: PR #3290 blocks issue #2983 ✅ - Issue #2983 is in `State/In Review` ✅ - Milestone: v3.7.0 ✅ - Type label: `Type/Bug` ✅ ### ❌ Blocking: Needs 2 Approving Reviews Per CONTRIBUTING.md, this PR requires **2 approving reviews from non-author contributors**. Currently there are 0 official approvals. Review requests have been sent to @khird and @drew. ### What This PR Does Fixes `_NAMESPACED_RE` in `resource_type.py` and `_resource_type_validation.py` to require both namespace and name components to start with a letter (changing `[a-zA-Z0-9]` → `[a-zA-Z]` for the first character class). This aligns with the spec requirement, `_BUILTIN_NAME_RE`, and `_SERVER_NS_NAME_RE` in `project.py`. The fix is minimal, targeted, and includes 8 Behave scenarios covering rejection and acceptance cases. --- **Automated by CleverAgents Bot** Supervisor: Implementation | Agent: ca-issue-worker
freemo reviewed 2026-04-05 19:43:51 +00:00
freemo left a comment
Copy link

Independent Code Review — PR #3290

Reviewed PR #3290 with focus on api-consistency, naming-conventions, and code-patterns.

This is a clean, well-scoped bug fix that corrects _NAMESPACED_RE regex patterns in two files to require letter-start for both namespace and name components, aligning with the spec requirement and the existing _BUILTIN_NAME_RE pattern.

Verdict: No issues found. This PR is ready for human reviewer approval.

✅ Specification Compliance

  • The spec defines the name format as [[server:]namespace/]name with letter-start requirement
  • _BUILTIN_NAME_RE already uses [a-zA-Z] — consistency is now restored across both modules
  • _SERVER_NS_NAME_RE in project.py already enforces letter-start — this PR brings _NAMESPACED_RE into alignment

✅ API Consistency (Focus Area — Deep Dive)

  • Both _NAMESPACED_RE definitions (in resource_type.py and _resource_type_validation.py) are now identical: ^[a-zA-Z][a-zA-Z0-9_-]*/[a-zA-Z][a-zA-Z0-9_-]*$
  • Cross-module consistency: The pattern now matches the structure used in _BUILTIN_NAME_RE in both files
  • Validation behavior: Both validate_name() and validate_inherits() validators correctly use the updated pattern through the module-level _NAMESPACED_RE
  • Bonus fix in _resource_type_validation.py: The old pattern ^[a-zA-Z0-9_-]+/[a-zA-Z0-9_-]+$ was even more permissive than the one in resource_type.py — it allowed names starting with hyphens or underscores (e.g., _ns/name, -ns/name). The new pattern correctly prevents this too, bringing both files into perfect alignment.

✅ Naming Conventions (Focus Area — Deep Dive)

  • Variable names follow existing project conventions (_NAMESPACED_RE, _BUILTIN_NAME_RE)
  • Feature file name resource_type_digit_start_validation.feature follows project naming patterns
  • Step file name resource_type_digit_start_validation_steps.py follows the <feature>_steps.py convention
  • Helper function _make_custom_physical_spec() follows the _ prefix convention for internal helpers
  • Step function names are descriptive and follow the step_<action> pattern

✅ Code Patterns (Focus Area — Deep Dive)

  • The regex fix is minimal and targeted — only the character class for the first character was changed
  • Step definitions follow the established pattern: try/except capturing ValidationError into context.rt_error
  • Background step correctly reuses the existing given step from resource_type_model_coverage_steps.py
  • The then step for "invalid inherits type name" is correctly reused from resource_type_model_coverage_steps.py (noted in the step file docstring)
  • Error message assertions check both error type AND message content — consistent with project patterns

✅ CONTRIBUTING.md Compliance

  • Commit message: fix(resource-type): require letter-start for namespace/name in _NAMESPACED_RE — correct Conventional Changelog format ✓
  • Issue footer: ISSUES CLOSED: #2983 ✓
  • PR body: Closes #2983 ✓
  • Milestone: v3.7.0 (matches issue) ✓
  • Label: Type/Bug ✓
  • Single atomic commit with implementation + tests ✓
  • No forbidden patterns: No # type: ignore, imports at top of file ✓

✅ Test Quality

  • 8 Behave scenarios covering:
    • 3 rejection cases (digit-starting namespace, name, both components)
    • 3 acceptance cases (letter-starting with hyphens, org-style, underscores)
    • 2 inherits field rejection cases (digit-starting namespace and name)
  • Assertions check both that errors are raised AND that error messages contain expected text
  • Step definitions are clean, well-documented, and properly typed with return annotations
  • CI confirms all nox sessions pass (lint, typecheck, unit_tests, coverage, integration_tests)

✅ Code Correctness

  • The regex change from [a-zA-Z0-9] → [a-zA-Z] is correct for the stated requirement
  • The * quantifier after the first character class is correct (first char already matched by [a-zA-Z])
  • No regressions — valid names like local/my-type, myorg/custom-db, my_org/my_type still pass

Minor Suggestions (Non-blocking)

  1. DRY concern — duplicate _NAMESPACED_RE definitions: Both resource_type.py and _resource_type_validation.py define their own _NAMESPACED_RE (and _BUILTIN_NAME_RE). If someone changes one but not the other in the future, the inconsistency bug could recur. Consider a follow-up issue to consolidate these into a single shared location (e.g., the validation module exports them, and resource_type.py imports). This is a pre-existing design issue, not introduced by this PR.

  2. Additional edge case tests: Since the _resource_type_validation.py fix also prevents names starting with hyphens or underscores (which the old [a-zA-Z0-9_-]+ pattern allowed), consider adding scenarios for _ns/name and -ns/name rejection in a follow-up. Not blocking since the issue scope was specifically digit-starting names.

Decision: APPROVED ✅

(Note: Posted as COMMENT because the Forgejo API user matches the PR author. Human reviewers @khird and @drew — this PR is ready for your approval.)

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## Independent Code Review — PR #3290 Reviewed PR #3290 with focus on **api-consistency**, **naming-conventions**, and **code-patterns**. This is a clean, well-scoped bug fix that corrects `_NAMESPACED_RE` regex patterns in two files to require letter-start for both namespace and name components, aligning with the spec requirement and the existing `_BUILTIN_NAME_RE` pattern. **Verdict: No issues found. This PR is ready for human reviewer approval.** ### ✅ Specification Compliance - The spec defines the name format as `[[server:]namespace/]name` with letter-start requirement - `_BUILTIN_NAME_RE` already uses `[a-zA-Z]` — consistency is now restored across both modules - `_SERVER_NS_NAME_RE` in `project.py` already enforces letter-start — this PR brings `_NAMESPACED_RE` into alignment ### ✅ API Consistency (Focus Area — Deep Dive) - **Both `_NAMESPACED_RE` definitions** (in `resource_type.py` and `_resource_type_validation.py`) are now identical: `^[a-zA-Z][a-zA-Z0-9_-]*/[a-zA-Z][a-zA-Z0-9_-]*$` - **Cross-module consistency**: The pattern now matches the structure used in `_BUILTIN_NAME_RE` in both files - **Validation behavior**: Both `validate_name()` and `validate_inherits()` validators correctly use the updated pattern through the module-level `_NAMESPACED_RE` - **Bonus fix in `_resource_type_validation.py`**: The old pattern `^[a-zA-Z0-9_-]+/[a-zA-Z0-9_-]+$` was even more permissive than the one in `resource_type.py` — it allowed names starting with hyphens or underscores (e.g., `_ns/name`, `-ns/name`). The new pattern correctly prevents this too, bringing both files into perfect alignment. ### ✅ Naming Conventions (Focus Area — Deep Dive) - Variable names follow existing project conventions (`_NAMESPACED_RE`, `_BUILTIN_NAME_RE`) - Feature file name `resource_type_digit_start_validation.feature` follows project naming patterns - Step file name `resource_type_digit_start_validation_steps.py` follows the `<feature>_steps.py` convention - Helper function `_make_custom_physical_spec()` follows the `_` prefix convention for internal helpers - Step function names are descriptive and follow the `step_<action>` pattern ### ✅ Code Patterns (Focus Area — Deep Dive) - The regex fix is minimal and targeted — only the character class for the first character was changed - Step definitions follow the established pattern: try/except capturing `ValidationError` into `context.rt_error` - Background step correctly reuses the existing `given` step from `resource_type_model_coverage_steps.py` - The `then` step for "invalid inherits type name" is correctly reused from `resource_type_model_coverage_steps.py` (noted in the step file docstring) - Error message assertions check both error type AND message content — consistent with project patterns ### ✅ CONTRIBUTING.md Compliance - **Commit message**: `fix(resource-type): require letter-start for namespace/name in _NAMESPACED_RE` — correct Conventional Changelog format ✓ - **Issue footer**: `ISSUES CLOSED: #2983` ✓ - **PR body**: `Closes #2983` ✓ - **Milestone**: v3.7.0 (matches issue) ✓ - **Label**: `Type/Bug` ✓ - **Single atomic commit** with implementation + tests ✓ - **No forbidden patterns**: No `# type: ignore`, imports at top of file ✓ ### ✅ Test Quality - 8 Behave scenarios covering: - 3 rejection cases (digit-starting namespace, name, both components) - 3 acceptance cases (letter-starting with hyphens, org-style, underscores) - 2 `inherits` field rejection cases (digit-starting namespace and name) - Assertions check both that errors are raised AND that error messages contain expected text - Step definitions are clean, well-documented, and properly typed with return annotations - CI confirms all nox sessions pass (lint, typecheck, unit_tests, coverage, integration_tests) ### ✅ Code Correctness - The regex change from `[a-zA-Z0-9]` → `[a-zA-Z]` is correct for the stated requirement - The `*` quantifier after the first character class is correct (first char already matched by `[a-zA-Z]`) - No regressions — valid names like `local/my-type`, `myorg/custom-db`, `my_org/my_type` still pass ### Minor Suggestions (Non-blocking) 1. **DRY concern — duplicate `_NAMESPACED_RE` definitions**: Both `resource_type.py` and `_resource_type_validation.py` define their own `_NAMESPACED_RE` (and `_BUILTIN_NAME_RE`). If someone changes one but not the other in the future, the inconsistency bug could recur. Consider a follow-up issue to consolidate these into a single shared location (e.g., the validation module exports them, and `resource_type.py` imports). This is a pre-existing design issue, not introduced by this PR. 2. **Additional edge case tests**: Since the `_resource_type_validation.py` fix also prevents names starting with hyphens or underscores (which the old `[a-zA-Z0-9_-]+` pattern allowed), consider adding scenarios for `_ns/name` and `-ns/name` rejection in a follow-up. Not blocking since the issue scope was specifically digit-starting names. **Decision: APPROVED** ✅ _(Note: Posted as COMMENT because the Forgejo API user matches the PR author. Human reviewers @khird and @drew — this PR is ready for your approval.)_ --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
freemo merged commit 8f43352723 into master 2026-04-05 21:12:18 +00:00
freemo removed this from the v3.7.0 milestone 2026-04-07 00:10:23 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
drew
khird
Labels
Clear labels   
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  
controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  
auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  
auto/claimed-implementer
Currently being processed by an implementer worker.

  
auto/claimed-merge
Currently being processed by the merge driver.

  
auto/claimed-reviewer
Currently being processed by a reviewer worker.

  
auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  
auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  
auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  
auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  
Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.

  
auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.

  
auto/needs-implementer
Failing CI needs implementer attention.

  
auto/postmortem
Documenting a driver incident or rollback.

  
auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  
auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  
auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  
auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  
auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  
auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  
Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.

  
Bounty
$100
 A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$1000
 A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$10000
 A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$20
 A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$2000
 A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$250
 A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$50
 A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$500
 A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$5000
 A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$750
 A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  
MoSCoW
Could have
 Could have feature in order to satisfy the epic/legendary.

  
MoSCoW
Must have
 Must have feature in order to satisfy the epic/legendary.

  
MoSCoW
Should have
 Should have feature in order to satisfy the epic/legendary.

  
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.

  
Points
1
 1 man-hours worth of work for an expert with no learning curve.

  
Points
13
 13 man-hours worth of work for an expert with no learning curve.

  
Points
2
 2 man-hours worth of work for an expert with no learning curve.

  
Points
21
 21 man-hours worth of work for an expert with no learning curve.

  
Points
3
 3 man-hours worth of work for an expert with no learning curve.

  
Points
34
 34 man-hours worth of work for an expert with no learning curve.

  
Points
5
 5 man-hours worth of work for an expert with no learning curve.

  
Points
55
 55 man-hours worth of work for an expert with no learning curve.

  
Points
8
 8 man-hours worth of work for an expert with no learning curve.

  
Points
88
 88 man-hours worth of work for an expert with no learning curve.

  
Priority
Backlog
 This ticket has backlogged priority and is not to be worked on yet

  
Priority
CI Blocker
 Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  
State
Completed
 The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  
State
Duplicate
 A ticket that represents the same content as an existing ticket.

  
State
In Progress
 A ticket that is actively being developed.

  
State
In Review
 A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  
State
Paused
 This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  
State
Unverified
 All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  
State
Verified
 The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  
State
Wont Do
 This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  
Type
Automation
 Any edits or discussion about the AI automated coding system.

  
Type
Bug
 Something that doesnt work as intended.

  
Type
Discussion
 Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  
Type
Documentation
 An error or improvement needed in the documentation.

  
Type
Epic
 Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  
Type
Feature
 Some new functionality not present.

  
Type
Legendary
 A type of Epic which will contain other Epics.

  
Type
Refactor
 A code change that restructures existing code without changing its external behavior.

  
Type
Support
 Someone needs help using the project.

  
Type
Task
 A generic task that doesnt fit into the other type categories.

  
Type
Testing
 Work exclusively focusing on fixing or expanding testing.

No labels
auto/needs-reevaluation
controller-managed
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks
#2983 UAT: _NAMESPACED_RE in resource_type.py and _resource_type_validation.py allows custom resource type names/namespaces starting with digits — spec requires names to start with a letter
cleveragents/cleveragents-core
Reference
cleveragents/cleveragents-core!3290
No description provided.