fix(skills): replace get_tool() calls with get() in SkillRegistry validation methods #3283

Merged
freemo merged 1 commits from fix/skill-registry-get-tool-attribute-error into master 2026-04-05 21:08:39 +00:00

1 Commits

Author SHA1 Message Date
freemo 9f62f9c9c8 fix(skills): replace get_tool() calls with get() in SkillRegistry validation methods
CI / lint (pull_request) Failing after 20s
CI / quality (pull_request) Successful in 34s
CI / typecheck (pull_request) Successful in 46s
CI / security (pull_request) Successful in 55s
CI / coverage (pull_request) Has been skipped
CI / build (pull_request) Successful in 17s
CI / helm (pull_request) Successful in 24s
CI / unit_tests (pull_request) Failing after 6m45s
CI / docker (pull_request) Has been skipped
CI / e2e_tests (pull_request) Successful in 17m43s
CI / integration_tests (pull_request) Successful in 22m51s
CI / status-check (pull_request) Failing after 1s
CI / benchmark-publish (pull_request) Has been skipped
CI / benchmark-regression (pull_request) Has been skipped
SkillRegistry.validate_plan() and validate_skill() called the non-existent
ToolRegistry.get_tool() method, causing AttributeError at runtime. The correct
method is ToolRegistry.get(), which is already used by SkillRegistry.refresh().

Changes:
- Replace self._tool_registry.get_tool(entry.name) with self._tool_registry.get(entry.name)
  in validate_plan()
- Replace self._tool_registry.get_tool(ref) with self._tool_registry.get(ref)
  in validate_skill()
- Update Behave BDD tests to use mock.get instead of mock.get_tool
- Add new BDD scenarios covering validate_skill() happy path, not-found path,
  unregistered include path, and no-tool-registry path
- Remove stale get_tool mock setup from test helpers

ISSUES CLOSED: #2914
2026-04-05 08:59:59 +00:00