cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

fix(tests): add missing Behave feature file for coverage_threshold #3237

Merged
freemo merged 1 commits from fix/coverage-threshold-feature-file into master 2026-04-05 21:09:22 +00:00
Conversation 2 Commits 1 Files Changed 1
+57
freemo commented 2026-04-05 08:15:37 +00:00
Owner
Copy Link
Copy Source

Summary

Creates features/coverage_threshold_config.feature, the missing Gherkin feature file that exercises all 15 step functions in features/steps/coverage_threshold_config_steps.py. Prior to this PR, every step in that module was dead code — no scenario invoked any of them — meaning the coverage threshold configuration was entirely untested by Behave. This PR resolves the gap introduced by PR #2629 and ensures the --coverage-min pattern support added to step_nightly_fail_under is actually exercised.

Changes

  • Added features/coverage_threshold_config.feature — a new Gherkin feature file containing 11 BDD scenarios organized into four logical groups:
    • pyproject.toml coverage configuration (7 scenarios): validates the [tool.coverage.run] section exists, that src is listed as a coverage source, that branch tracking is enabled (branch = true), that the data file is build/.coverage, that the HTML output directory is build/htmlcov, that the XML output is build/coverage.xml, and that the omit patterns include */tests/*.
    • noxfile.py coverage session (2 scenarios): asserts that a coverage_report session is defined and that the fail-under threshold is at least 97 (matching the COVERAGE_THRESHOLD = 97 constant).
    • CI workflow (1 scenario): confirms the CI workflow invokes nox -s coverage_report.
    • Nightly quality workflow (1 scenario): confirms the nightly workflow enforces a --coverage-min threshold of at least 85 (matching the actual --coverage-min 85 value in nightly-quality.yml).
  • No Python code added or modified. The step implementations in coverage_threshold_config_steps.py were already complete; only the driving feature file was absent.
  • All 15 step functions are now reachable — none remain as dead code.

Design Decisions

  • Exact step text matching: All Gherkin step lines were copied verbatim from the @given/@then decorator strings in coverage_threshold_config_steps.py to guarantee correct Behave step resolution without any ambiguity.
  • Threshold values sourced from actual project files: The noxfile threshold (97) was taken from the COVERAGE_THRESHOLD = 97 constant; the nightly workflow threshold (85) was taken from the literal --coverage-min 85 argument in .forgejo/workflows/nightly-quality.yml.
  • Scenario grouping with inline comments: Scenarios are organized into four named groups with Gherkin comments to make the intent of each block immediately clear.

Testing

  • Behave: 11 scenarios — all pass against actual project configuration values
  • Ruff lint (ruff check features/): All checks passed
  • No new Python code introduced

Modules Affected

  • features/coverage_threshold_config.feature (new file)

Closes #2767

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: ca-pr-api-creator

## Summary Creates `features/coverage_threshold_config.feature`, the missing Gherkin feature file that exercises all 15 step functions in `features/steps/coverage_threshold_config_steps.py`. Prior to this PR, every step in that module was dead code — no scenario invoked any of them — meaning the coverage threshold configuration was entirely untested by Behave. This PR resolves the gap introduced by PR #2629 and ensures the `--coverage-min` pattern support added to `step_nightly_fail_under` is actually exercised. ## Changes - **Added `features/coverage_threshold_config.feature`** — a new Gherkin feature file containing 11 BDD scenarios organized into four logical groups: - **`pyproject.toml` coverage configuration** (7 scenarios): validates the `[tool.coverage.run]` section exists, that `src` is listed as a coverage source, that branch tracking is enabled (`branch = true`), that the data file is `build/.coverage`, that the HTML output directory is `build/htmlcov`, that the XML output is `build/coverage.xml`, and that the omit patterns include `*/tests/*`. - **`noxfile.py` coverage session** (2 scenarios): asserts that a `coverage_report` session is defined and that the fail-under threshold is at least 97 (matching the `COVERAGE_THRESHOLD = 97` constant). - **CI workflow** (1 scenario): confirms the CI workflow invokes `nox -s coverage_report`. - **Nightly quality workflow** (1 scenario): confirms the nightly workflow enforces a `--coverage-min` threshold of at least 85 (matching the actual `--coverage-min 85` value in `nightly-quality.yml`). - **No Python code added or modified.** The step implementations in `coverage_threshold_config_steps.py` were already complete; only the driving feature file was absent. - **All 15 step functions are now reachable** — none remain as dead code. ## Design Decisions - **Exact step text matching**: All Gherkin step lines were copied verbatim from the `@given`/`@then` decorator strings in `coverage_threshold_config_steps.py` to guarantee correct Behave step resolution without any ambiguity. - **Threshold values sourced from actual project files**: The noxfile threshold (97) was taken from the `COVERAGE_THRESHOLD = 97` constant; the nightly workflow threshold (85) was taken from the literal `--coverage-min 85` argument in `.forgejo/workflows/nightly-quality.yml`. - **Scenario grouping with inline comments**: Scenarios are organized into four named groups with Gherkin comments to make the intent of each block immediately clear. ## Testing - Behave: **11 scenarios — all pass** against actual project configuration values - Ruff lint (`ruff check features/`): **All checks passed** - No new Python code introduced ## Modules Affected - `features/coverage_threshold_config.feature` *(new file)* Closes #2767 --- **Automated by CleverAgents Bot** Supervisor: Implementation | Agent: ca-pr-api-creator
freemo added 1 commit 2026-04-05 08:15:37 +00:00
fix(tests): add missing Behave feature file for coverage_threshold
CI / lint (pull_request) Successful in 26s
Details
CI / typecheck (pull_request) Successful in 47s
Details
CI / security (pull_request) Successful in 55s
Details
CI / quality (pull_request) Successful in 40s
Details
CI / build (pull_request) Successful in 17s
Details
CI / helm (pull_request) Successful in 23s
Details
CI / unit_tests (pull_request) Successful in 6m55s
Details
CI / e2e_tests (pull_request) Successful in 17m13s
Details
CI / integration_tests (pull_request) Successful in 23m21s
Details
CI / coverage (pull_request) Successful in 11m3s
Details
CI / docker (pull_request) Successful in 21s
Details
CI / status-check (pull_request) Successful in 1s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / benchmark-regression (pull_request) Successful in 57m1s
Details
2eaf9362a3 
- What was implemented
  - Created features/coverage_threshold_config.feature containing 11 BDD scenarios to exercise coverage threshold configurations.
  - All 15 step functions in features/steps/coverage_threshold_config_steps.py are now exercised by the new scenarios.
  - Scenarios cover:
    - pyproject.toml coverage config (7 scenarios)
    - noxfile.py coverage session (2 scenarios)
    - CI workflow (1 scenario)
    - nightly quality workflow (1 scenario)
  - All 11 scenarios verified to pass against actual project configuration values.

- Key design decisions
  - Used the exact step text from the step file to ensure proper Gherkin-to-step matching.
  - Nightly workflow threshold set to 85 (matching the actual --coverage-min 85 value in nightly-quality.yml).
  - Noxfile threshold set to 97 (matching COVERAGE_THRESHOLD = 97 constant).
  - Organized scenarios into logical groups with comments for readability.

- Modules/components affected
  - features/coverage_threshold_config.feature (new feature file)
  - features/steps/coverage_threshold_config_steps.py (all steps now exercised)

ISSUES CLOSED: #2767
freemo added this to the v3.2.0 milestone 2026-04-05 08:23:26 +00:00
freemo commented 2026-04-05 08:24:24 +00:00
Author
Owner
Copy Link
Copy Source

🔒 Review claimed by reviewer-pool-1 [claim-token: reviewer-pool-1-3237-1775372600]

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-continuous-pr-reviewer

🔒 Review claimed by reviewer-pool-1 [claim-token: reviewer-pool-1-3237-1775372600] --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-continuous-pr-reviewer
freemo reviewed 2026-04-05 08:58:02 +00:00
freemo left a comment
Author
Owner
Copy Link
Copy Source

Review: APPROVED ✅

PR Metadata

  • Title: Follows Conventional Changelog format (fix(tests): ...) ✅
  • Body: Includes Closes #2767 ✅
  • Milestone: v3.2.0 ✅
  • Label: Type/Bug ✅
  • Commit footer: ISSUES CLOSED: #2767 ✅

Code Review

Step-to-Scenario Matching: All 11 Gherkin scenarios were verified against the 15 step functions in coverage_threshold_config_steps.py. Every @given and @then decorator string matches its corresponding feature file step text exactly. All 15 step functions are now reachable — zero dead code remains.

Threshold Values:

  • Noxfile threshold of 97 correctly matches the COVERAGE_THRESHOLD = 97 constant in noxfile.py ✅
  • Nightly workflow threshold of 85 correctly matches the actual --coverage-min 85 argument in nightly-quality.yml ✅
  • Note: The original issue #2767 suggested 97 for the nightly threshold, but the PR correctly uses 85 to match the actual configuration. This is the right call — the test should validate what the config actually says, not an aspirational value.

Scenario Organization: Four logical groups (pyproject.toml config, noxfile session, CI workflow, nightly workflow) with clear Gherkin comments. Well-structured and readable.

Risk Assessment: Minimal — this PR adds only a .feature file with no Python code changes. The step implementations were already reviewed in PR #2629.

No issues found. Clean, focused PR that resolves a real testing gap.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## Review: APPROVED ✅ ### PR Metadata - **Title**: Follows Conventional Changelog format (`fix(tests): ...`) ✅ - **Body**: Includes `Closes #2767` ✅ - **Milestone**: v3.2.0 ✅ - **Label**: Type/Bug ✅ - **Commit footer**: `ISSUES CLOSED: #2767` ✅ ### Code Review **Step-to-Scenario Matching**: All 11 Gherkin scenarios were verified against the 15 step functions in `coverage_threshold_config_steps.py`. Every `@given` and `@then` decorator string matches its corresponding feature file step text exactly. All 15 step functions are now reachable — zero dead code remains. **Threshold Values**: - Noxfile threshold of 97 correctly matches the `COVERAGE_THRESHOLD = 97` constant in `noxfile.py` ✅ - Nightly workflow threshold of 85 correctly matches the actual `--coverage-min 85` argument in `nightly-quality.yml` ✅ - Note: The original issue #2767 suggested 97 for the nightly threshold, but the PR correctly uses 85 to match the actual configuration. This is the right call — the test should validate what the config actually says, not an aspirational value. **Scenario Organization**: Four logical groups (pyproject.toml config, noxfile session, CI workflow, nightly workflow) with clear Gherkin comments. Well-structured and readable. **Risk Assessment**: Minimal — this PR adds only a `.feature` file with no Python code changes. The step implementations were already reviewed in PR #2629. **No issues found.** Clean, focused PR that resolves a real testing gap. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
freemo scheduled this pull request to auto merge when all checks succeed 2026-04-05 08:59:57 +00:00
freemo merged commit 2e2202e52f into master 2026-04-05 21:09:18 +00:00
freemo removed this from the v3.2.0 milestone 2026-04-06 20:50:49 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
freemo
Labels
Clear labels
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
 controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
 overdue
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
 auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
 auto/claimed-implementer
Currently being processed by an implementer worker.
 auto/claimed-merge
Currently being processed by the merge driver.
 auto/claimed-reviewer
Currently being processed by a reviewer worker.
 auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
 auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
 auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
 auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
 Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.
 auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.
 auto/needs-implementer
Failing CI needs implementer attention.
 auto/postmortem
Documenting a driver incident or rollback.
 auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
 auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
 auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
 auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
 auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
 auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
 Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aditya (Aditya Chhabra) aleenaumair (Aleena Umair) brent.edwards (Brent Edwards) CoreRasurae (Luis Mendes) drew (Drew Morris) eugen.thaci (Eugen Thaci) freemo (Jeffrey Phillips Freeman) HAL9000 (HAL 9000) HAL9001 (HAL9001) hamza.khyari (Hamza Khyari) hurui200320 (Rui Hu) justin.morris khird (Kyle Hird) org.cleveragents
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Blocks
#2767 UAT: PR #2629 — Missing feature file for coverage_threshold_config_steps.py (steps are dead code)
cleveragents/cleveragents-core
Reference: cleveragents/cleveragents-core#3237
Delete Branch "fix/coverage-threshold-feature-file"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?