cleveragents/cleveragents-core
cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.1k Pull requests 489 Projects Releases Packages Wiki Activity Actions

fix(sandbox): remove type: ignore in SandboxManager strategy assignment #3058

Merged
freemo merged 1 commit from fix/sandbox-manager-type-ignore into master 2026-04-05 21:13:25 +00:00
Conversation 9 Commits 1 Files changed 3 +185 -1
freemo commented 2026-04-05 04:39:49 +00:00
Owner
Copy link

Summary

Removes a # type: ignore[assignment] comment from SandboxManager.get_or_create_sandbox_for_resource that violated the project's strict no-type-suppression coding standards, replacing it with a semantically correct and statically verifiable cast() call from the typing module.

Changes

  • Removed # type: ignore[assignment] from manager.py line 618: The suppression comment was masking a type mismatch between SandboxStrategy (a StrEnum) and SandboxStrategyStr (a Literal[...] type alias). While the two types are structurally compatible at runtime, Pyright could not verify this statically, leading to the suppression. The comment has been fully removed.

  • Added from typing import cast import to manager.py: The cast function from the standard library typing module is now imported to enable the type-safe assignment.

  • Replaced suppressed assignment with cast("SandboxStrategyStr", boundary_resource.sandbox_strategy): The previously suppressed line:

    strategy = boundary_resource.sandbox_strategy  # type: ignore[assignment]

    is now:

    strategy = cast("SandboxStrategyStr", boundary_resource.sandbox_strategy)

    This is semantically correct because SandboxStrategy (StrEnum) and SandboxStrategyStr (Literal) share exactly the same string value set, making the cast safe at both the type-checker and runtime levels.

  • Added features/sandbox_manager_strategy_cast.feature: A new Behave feature file with 2 scenarios that exercise the get_or_create_sandbox_for_resource method with a non-None sandbox_strategy, ensuring the cast conversion path is covered by the test suite.

  • Added features/steps/sandbox_manager_strategy_cast_steps.py: Step definitions for the new feature file, following the established mocking pattern from sandbox_manager_coverage_r3_steps.py to avoid DAG traversal by mocking the boundary cache.

Design Decisions

  • cast() over SandboxStrategyStr(...) constructor call: SandboxStrategyStr is a Literal type alias, not a callable class. Attempting to call it as a constructor would raise a TypeError at runtime. cast() is the correct tool here — it is a no-op at runtime (returns its second argument unchanged) and serves purely as a static type annotation hint for Pyright.

  • String form "SandboxStrategyStr" in the cast() call: The file uses from __future__ import annotations, which defers evaluation of all annotations. Using the string form "SandboxStrategyStr" in the cast() call ensures consistency with the file's annotation style and avoids any forward-reference issues.

  • No dedicated conversion/validation helper function: The issue suggested a possible helper function to map SandboxStrategy → SandboxStrategyStr. This was evaluated and rejected for this fix: the two types are guaranteed by design to share the same string values (they represent the same domain concept), so a runtime validation step would add complexity without safety benefit. A cast() is the idiomatic, minimal, and correct solution.

  • Boundary cache mocking in tests: The new Behave step definitions mock the boundary cache to avoid triggering DAG traversal, following the established pattern in sandbox_manager_coverage_r3_steps.py. This keeps the tests fast, isolated, and focused on the specific code path under test.

Testing

  • Unit tests (Behave): ✅ 2/2 new scenarios passed; 63/63 sandbox manager coverage scenarios passed
  • Integration tests (Robot): Not applicable — this is a type-safety fix with no behavioural change
  • Type checking (nox -e typecheck): ✅ 0 errors, 0 warnings
  • Coverage: ≥ 97% (no regression)
  • Benchmarks: Not needed — no performance-sensitive code paths modified

Modules Affected

  • src/cleveragents/infrastructure/sandbox/manager.py — removed # type: ignore[assignment], added cast import, replaced suppressed assignment with cast() call
  • features/sandbox_manager_strategy_cast.feature — new Behave feature file (2 scenarios)
  • features/steps/sandbox_manager_strategy_cast_steps.py — new Behave step definitions

Related Issues

Closes #2828

Checklist

  • All nox stages pass (lint, typecheck, unit_tests, integration_tests, coverage_report)
  • Coverage >= 97%
  • No # type: ignore directives
  • Commit message follows Conventional Changelog format
  • Implementation aligns with docs/specification.md

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: ca-pr-api-creator

## Summary Removes a `# type: ignore[assignment]` comment from `SandboxManager.get_or_create_sandbox_for_resource` that violated the project's strict no-type-suppression coding standards, replacing it with a semantically correct and statically verifiable `cast()` call from the `typing` module. ## Changes - **Removed `# type: ignore[assignment]` from `manager.py` line 618**: The suppression comment was masking a type mismatch between `SandboxStrategy` (a `StrEnum`) and `SandboxStrategyStr` (a `Literal[...]` type alias). While the two types are structurally compatible at runtime, Pyright could not verify this statically, leading to the suppression. The comment has been fully removed. - **Added `from typing import cast` import to `manager.py`**: The `cast` function from the standard library `typing` module is now imported to enable the type-safe assignment. - **Replaced suppressed assignment with `cast("SandboxStrategyStr", boundary_resource.sandbox_strategy)`**: The previously suppressed line: ```python strategy = boundary_resource.sandbox_strategy # type: ignore[assignment] ``` is now: ```python strategy = cast("SandboxStrategyStr", boundary_resource.sandbox_strategy) ``` This is semantically correct because `SandboxStrategy` (StrEnum) and `SandboxStrategyStr` (Literal) share exactly the same string value set, making the cast safe at both the type-checker and runtime levels. - **Added `features/sandbox_manager_strategy_cast.feature`**: A new Behave feature file with 2 scenarios that exercise the `get_or_create_sandbox_for_resource` method with a non-`None` `sandbox_strategy`, ensuring the cast conversion path is covered by the test suite. - **Added `features/steps/sandbox_manager_strategy_cast_steps.py`**: Step definitions for the new feature file, following the established mocking pattern from `sandbox_manager_coverage_r3_steps.py` to avoid DAG traversal by mocking the boundary cache. ## Design Decisions - **`cast()` over `SandboxStrategyStr(...)` constructor call**: `SandboxStrategyStr` is a `Literal` type alias, not a callable class. Attempting to call it as a constructor would raise a `TypeError` at runtime. `cast()` is the correct tool here — it is a no-op at runtime (returns its second argument unchanged) and serves purely as a static type annotation hint for Pyright. - **String form `"SandboxStrategyStr"` in the `cast()` call**: The file uses `from __future__ import annotations`, which defers evaluation of all annotations. Using the string form `"SandboxStrategyStr"` in the `cast()` call ensures consistency with the file's annotation style and avoids any forward-reference issues. - **No dedicated conversion/validation helper function**: The issue suggested a possible helper function to map `SandboxStrategy → SandboxStrategyStr`. This was evaluated and rejected for this fix: the two types are guaranteed by design to share the same string values (they represent the same domain concept), so a runtime validation step would add complexity without safety benefit. A `cast()` is the idiomatic, minimal, and correct solution. - **Boundary cache mocking in tests**: The new Behave step definitions mock the boundary cache to avoid triggering DAG traversal, following the established pattern in `sandbox_manager_coverage_r3_steps.py`. This keeps the tests fast, isolated, and focused on the specific code path under test. ## Testing - **Unit tests (Behave)**: ✅ 2/2 new scenarios passed; 63/63 sandbox manager coverage scenarios passed - **Integration tests (Robot)**: Not applicable — this is a type-safety fix with no behavioural change - **Type checking (`nox -e typecheck`)**: ✅ 0 errors, 0 warnings - **Coverage**: ≥ 97% (no regression) - **Benchmarks**: Not needed — no performance-sensitive code paths modified ## Modules Affected - `src/cleveragents/infrastructure/sandbox/manager.py` — removed `# type: ignore[assignment]`, added `cast` import, replaced suppressed assignment with `cast()` call - `features/sandbox_manager_strategy_cast.feature` — new Behave feature file (2 scenarios) - `features/steps/sandbox_manager_strategy_cast_steps.py` — new Behave step definitions ## Related Issues Closes #2828 ## Checklist - [ ] All nox stages pass (lint, typecheck, unit_tests, integration_tests, coverage_report) - [ ] Coverage >= 97% - [ ] No `# type: ignore` directives - [ ] Commit message follows Conventional Changelog format - [ ] Implementation aligns with docs/specification.md --- **Automated by CleverAgents Bot** Supervisor: Implementation | Agent: ca-pr-api-creator
fix(sandbox): remove type: ignore in SandboxManager strategy assignment
All checks were successful
CI / lint (pull_request) Successful in 32s
Details
CI / typecheck (pull_request) Successful in 55s
Details
CI / quality (pull_request) Successful in 48s
Details
CI / security (pull_request) Successful in 1m2s
Details
CI / build (pull_request) Successful in 23s
Details
CI / helm (pull_request) Successful in 22s
Details
CI / unit_tests (pull_request) Successful in 6m43s
Details
CI / docker (pull_request) Successful in 1m28s
Details
CI / e2e_tests (pull_request) Successful in 17m13s
Details
CI / integration_tests (pull_request) Successful in 22m17s
Details
CI / coverage (pull_request) Successful in 10m27s
Details
CI / status-check (pull_request) Successful in 1s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / benchmark-regression (pull_request) Successful in 56m1s
Details
68a3cc40ca 
Implemented removal of the type: ignore in SandboxManager strategy assignment by introducing a proper typing.cast usage and added tests to cover the new path.

- What was implemented
  - Added from typing import cast to src/cleveragents/infrastructure/sandbox/manager.py.
  - Replaced strategy = boundary_resource.sandbox_strategy  # type: ignore[assignment] with strategy = cast("SandboxStrategyStr", boundary_resource.sandbox_strategy) at line 618 in get_or_create_sandbox_for_resource.
  - The cast is semantically correct: SandboxStrategy (StrEnum) values are exactly the same string set as SandboxStrategyStr (Literal), so the cast is a truthful type assertion with zero runtime overhead.
  - Added features/sandbox_manager_strategy_cast.feature with 2 Behave scenarios exercising the cast conversion path.
  - Added features/steps/sandbox_manager_strategy_cast_steps.py with step definitions.

- Key design decisions
  - Used cast() from typing rather than SandboxStrategyStr(...) constructor call, because SandboxStrategyStr is a Literal type alias (not a callable), so calling it as a constructor would fail at runtime.
  - Used string form "SandboxStrategyStr" in the cast call because the file uses from __future__ import annotations.
  - Mocked the boundary cache in tests to avoid DAG traversal, following the pattern established in sandbox_manager_coverage_r3_steps.py.

- Affected modules/components
  - src/cleveragents/infrastructure/sandbox/manager.py
  - features/sandbox_manager_strategy_cast.feature
  - features/steps/sandbox_manager_strategy_cast_steps.py

- Testing considerations
  - The new Behave scenarios exercise the cast path in isolation, reducing DAG traversal concerns and aligning with existing testing patterns.

ISSUES CLOSED: #2828
freemo commented 2026-04-05 06:11:22 +00:00
Author
Owner
Copy link

🔒 Review claimed by reviewer-pool-1 [claim-token: reviewer-pool-1-3058-1775369400]

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-continuous-pr-reviewer

🔒 Review claimed by reviewer-pool-1 [claim-token: reviewer-pool-1-3058-1775369400] --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-continuous-pr-reviewer
freemo added this to the v3.7.0 milestone 2026-04-05 06:14:52 +00:00
freemo reviewed 2026-04-05 06:15:15 +00:00
freemo left a comment
Copy link

Review: APPROVED ✅

(Posted as COMMENT because the Forgejo API token belongs to the PR author and self-approval is not permitted. The review assessment is APPROVE.)

Summary

This PR correctly removes a # type: ignore[assignment] suppression from SandboxManager.get_or_create_sandbox_for_resource and replaces it with an idiomatic typing.cast() call. The change is minimal, correct, and well-tested.

Review Findings

Specification Alignment ✅

  • The sandbox module's runtime behavior is unchanged — cast() is a no-op at runtime.
  • The fix aligns with CONTRIBUTING.md's strict no-type-suppression policy.

Correctness ✅

  • Type safety verified: SandboxStrategy (StrEnum) has exactly the same 6 string values (git_worktree, copy_on_write, transaction_rollback, snapshot, overlay, none) as SandboxStrategyStr (Literal). The cast is truthful.
  • cast() over constructor: Correct decision — SandboxStrategyStr is a Literal type alias, not callable. Attempting SandboxStrategyStr(...) would raise TypeError at runtime.
  • String form "SandboxStrategyStr": Correct — the file uses from __future__ import annotations, so string-form is consistent.

Code Quality ✅

  • Import placed correctly at top of file alongside other standard library imports.
  • Single-line change in production code — minimal blast radius.
  • manager.py is 655 lines (exceeds 500-line guideline), but this is pre-existing and not introduced by this PR.

Test Quality ✅

  • Two Behave scenarios exercise the cast() path via get_or_create_sandbox_for_resource with a non-None sandbox_strategy.
  • Step definitions follow the established boundary-cache mocking pattern from sandbox_manager_coverage_r3_steps.py.
  • Minor note: both scenarios use SandboxStrategy.NONE — testing with a second strategy value (e.g., GIT_WORKTREE) would add diversity, but since cast() is a no-op regardless of value, this is not a blocking concern.

Security ✅

  • No secrets, credentials, or injection risks.

CI Status ✅

All required checks passing: lint, typecheck, security, quality, unit_tests, integration_tests, e2e_tests, coverage, build, status-check.

Commit Message ✅

  • Follows Conventional Changelog format: fix(sandbox): remove type: ignore in SandboxManager strategy assignment
  • Includes ISSUES CLOSED: #2828 footer.

Metadata Fix Applied

  • Assigned milestone v3.7.0 to match the linked issue.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## Review: APPROVED ✅ (Posted as COMMENT because the Forgejo API token belongs to the PR author and self-approval is not permitted. The review assessment is APPROVE.) ### Summary This PR correctly removes a `# type: ignore[assignment]` suppression from `SandboxManager.get_or_create_sandbox_for_resource` and replaces it with an idiomatic `typing.cast()` call. The change is minimal, correct, and well-tested. ### Review Findings #### Specification Alignment ✅ - The sandbox module's runtime behavior is unchanged — `cast()` is a no-op at runtime. - The fix aligns with CONTRIBUTING.md's strict no-type-suppression policy. #### Correctness ✅ - **Type safety verified**: `SandboxStrategy` (StrEnum) has exactly the same 6 string values (`git_worktree`, `copy_on_write`, `transaction_rollback`, `snapshot`, `overlay`, `none`) as `SandboxStrategyStr` (Literal). The cast is truthful. - **`cast()` over constructor**: Correct decision — `SandboxStrategyStr` is a `Literal` type alias, not callable. Attempting `SandboxStrategyStr(...)` would raise `TypeError` at runtime. - **String form `"SandboxStrategyStr"`**: Correct — the file uses `from __future__ import annotations`, so string-form is consistent. #### Code Quality ✅ - Import placed correctly at top of file alongside other standard library imports. - Single-line change in production code — minimal blast radius. - `manager.py` is 655 lines (exceeds 500-line guideline), but this is pre-existing and not introduced by this PR. #### Test Quality ✅ - Two Behave scenarios exercise the `cast()` path via `get_or_create_sandbox_for_resource` with a non-`None` `sandbox_strategy`. - Step definitions follow the established boundary-cache mocking pattern from `sandbox_manager_coverage_r3_steps.py`. - Minor note: both scenarios use `SandboxStrategy.NONE` — testing with a second strategy value (e.g., `GIT_WORKTREE`) would add diversity, but since `cast()` is a no-op regardless of value, this is not a blocking concern. #### Security ✅ - No secrets, credentials, or injection risks. #### CI Status ✅ All required checks passing: lint, typecheck, security, quality, unit_tests, integration_tests, e2e_tests, coverage, build, status-check. #### Commit Message ✅ - Follows Conventional Changelog format: `fix(sandbox): remove type: ignore in SandboxManager strategy assignment` - Includes `ISSUES CLOSED: #2828` footer. ### Metadata Fix Applied - Assigned milestone v3.7.0 to match the linked issue. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
freemo commented 2026-04-05 06:41:03 +00:00
Author
Owner
Copy link

🔒 Review claimed by reviewer-pool-1 [claim-token: reviewer-pool-1-3058-1775371200]

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-continuous-pr-reviewer

🔒 Review claimed by reviewer-pool-1 [claim-token: reviewer-pool-1-3058-1775371200] --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-continuous-pr-reviewer
freemo reviewed 2026-04-05 06:51:51 +00:00
freemo left a comment
Copy link

Independent Review: APPROVED ✅

(Posted as COMMENT because the Forgejo API token belongs to the PR author and self-approval is not permitted. The independent review assessment is APPROVE.)

Independent Review Summary

Thorough review of all 3 changed files against the specification, CONTRIBUTING.md, and codebase conventions. This is a second, independent review providing a different perspective from the initial self-review.

Specification Alignment ✅

  • The sandbox module's runtime behavior is completely unchanged — cast() is a no-op at runtime.
  • The fix directly addresses the CONTRIBUTING.md strict no-type-suppression policy: "The use of # type: ignore or any other mechanism to suppress type-checking errors is strictly forbidden."
  • Module boundaries respected — the change is confined to the sandbox infrastructure layer.

Correctness ✅

  • Type safety verified: SandboxStrategy (StrEnum) has exactly the same 6 string values (git_worktree, copy_on_write, transaction_rollback, snapshot, overlay, none) as SandboxStrategyStr (Literal). The cast is truthful.
  • cast() is the correct tool: SandboxStrategyStr is a Literal type alias, not a callable class. Attempting SandboxStrategyStr(...) would raise TypeError at runtime. The issue's suggestion of a constructor call was correctly evaluated and rejected.
  • String form "SandboxStrategyStr": Correct — the file uses from __future__ import annotations, so string-form is consistent.
  • Established pattern: cast(SandboxStrategyStr, ...) is already used in _base.py (lines 132, 306) and resource_handler_service.py (line 394). This PR follows the existing codebase convention.

Code Quality ✅

  • Import from typing import cast placed correctly at top of file alongside other standard library imports.
  • Single-line change in production code — minimal blast radius.
  • No unnecessary complexity introduced.

Test Quality ✅

  • Two Behave scenarios exercise the cast() path via get_or_create_sandbox_for_resource with a non-None sandbox_strategy.
  • Step definitions follow the established boundary-cache mocking pattern from sandbox_manager_coverage_r3_steps.py.
  • _STRATEGY_MAP includes all 6 strategies for future test expansion.
  • Minor observation: both scenarios use SandboxStrategy.NONE — testing with a second strategy value (e.g., GIT_WORKTREE) would add diversity, but since cast() is a no-op regardless of value, this is not a blocking concern.

Security ✅

  • No secrets, credentials, or injection risks.

Commit Message ✅

  • Follows Conventional Changelog format: fix(sandbox): remove type: ignore in SandboxManager strategy assignment
  • Includes ISSUES CLOSED: #2828 footer.

PR Metadata ✅

  • Type/Bug label present
  • Milestone v3.7.0 assigned (matches issue)
  • Body contains Closes #2828

CI Status ✅

All required checks passing: lint, typecheck, security, quality, unit_tests, integration_tests, e2e_tests, coverage, build, status-check.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## Independent Review: APPROVED ✅ (Posted as COMMENT because the Forgejo API token belongs to the PR author and self-approval is not permitted. The independent review assessment is **APPROVE**.) ### Independent Review Summary Thorough review of all 3 changed files against the specification, CONTRIBUTING.md, and codebase conventions. This is a **second, independent review** providing a different perspective from the initial self-review. ### Specification Alignment ✅ - The sandbox module's runtime behavior is completely unchanged — `cast()` is a no-op at runtime. - The fix directly addresses the CONTRIBUTING.md strict no-type-suppression policy: *"The use of `# type: ignore` or any other mechanism to suppress type-checking errors is strictly forbidden."* - Module boundaries respected — the change is confined to the sandbox infrastructure layer. ### Correctness ✅ - **Type safety verified**: `SandboxStrategy` (StrEnum) has exactly the same 6 string values (`git_worktree`, `copy_on_write`, `transaction_rollback`, `snapshot`, `overlay`, `none`) as `SandboxStrategyStr` (Literal). The cast is truthful. - **`cast()` is the correct tool**: `SandboxStrategyStr` is a `Literal` type alias, not a callable class. Attempting `SandboxStrategyStr(...)` would raise `TypeError` at runtime. The issue's suggestion of a constructor call was correctly evaluated and rejected. - **String form `"SandboxStrategyStr"`**: Correct — the file uses `from __future__ import annotations`, so string-form is consistent. - **Established pattern**: `cast(SandboxStrategyStr, ...)` is already used in `_base.py` (lines 132, 306) and `resource_handler_service.py` (line 394). This PR follows the existing codebase convention. ### Code Quality ✅ - Import `from typing import cast` placed correctly at top of file alongside other standard library imports. - Single-line change in production code — minimal blast radius. - No unnecessary complexity introduced. ### Test Quality ✅ - Two Behave scenarios exercise the `cast()` path via `get_or_create_sandbox_for_resource` with a non-`None` `sandbox_strategy`. - Step definitions follow the established boundary-cache mocking pattern from `sandbox_manager_coverage_r3_steps.py`. - `_STRATEGY_MAP` includes all 6 strategies for future test expansion. - Minor observation: both scenarios use `SandboxStrategy.NONE` — testing with a second strategy value (e.g., `GIT_WORKTREE`) would add diversity, but since `cast()` is a no-op regardless of value, this is not a blocking concern. ### Security ✅ - No secrets, credentials, or injection risks. ### Commit Message ✅ - Follows Conventional Changelog format: `fix(sandbox): remove type: ignore in SandboxManager strategy assignment` - Includes `ISSUES CLOSED: #2828` footer. ### PR Metadata ✅ - Type/Bug label present - Milestone v3.7.0 assigned (matches issue) - Body contains `Closes #2828` ### CI Status ✅ All required checks passing: lint, typecheck, security, quality, unit_tests, integration_tests, e2e_tests, coverage, build, status-check. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
freemo commented 2026-04-05 07:18:29 +00:00
Author
Owner
Copy link

🔒 Review claimed by reviewer-pool-1 [claim-token: reviewer-pool-1-3058-1775372600]

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-continuous-pr-reviewer

🔒 Review claimed by reviewer-pool-1 [claim-token: reviewer-pool-1-3058-1775372600] --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-continuous-pr-reviewer
freemo reviewed 2026-04-05 08:15:18 +00:00
freemo left a comment
Copy link

Independent Review: APPROVED ✅

(Posted as COMMENT because the Forgejo API token belongs to the PR author and self-approval is not permitted. The independent review assessment is APPROVE.)

Review Summary

Thorough independent review of all 3 changed files against the specification, CONTRIBUTING.md, and codebase conventions. This PR correctly removes a # type: ignore[assignment] suppression and replaces it with an idiomatic typing.cast() call.

Specification Alignment ✅

  • Runtime behavior is completely unchanged — cast() is a no-op at runtime
  • Directly addresses CONTRIBUTING.md's strict no-type-suppression policy
  • Module boundaries respected — change is confined to the sandbox infrastructure layer

Correctness ✅

  • Type safety verified: SandboxStrategy (StrEnum) and SandboxStrategyStr (Literal) share exactly the same 6 string values (git_worktree, copy_on_write, transaction_rollback, snapshot, overlay, none). The cast is truthful.
  • cast() is the correct tool: SandboxStrategyStr is a Literal type alias, not callable. A constructor call would raise TypeError at runtime.
  • String form "SandboxStrategyStr": Correct — file uses from __future__ import annotations.
  • Established pattern: cast(SandboxStrategyStr, ...) is already used in _base.py (lines 132, 306) and resource_handler_service.py (line 394). This PR follows existing codebase convention.

Test Quality ✅

  • 2 Behave scenarios exercise the cast() path via get_or_create_sandbox_for_resource with a non-None sandbox_strategy
  • Step definitions follow the established boundary-cache mocking pattern from sandbox_manager_coverage_r3_steps.py
  • _STRATEGY_MAP includes all 6 strategies for future test expansion
  • Minor observation: both scenarios use SandboxStrategy.NONE — testing with a second strategy value would add diversity, but since cast() is a no-op regardless of value, this is not blocking

Code Quality ✅

  • from typing import cast import placed correctly at top of file with standard library imports
  • Single-line production code change — minimal blast radius
  • No unnecessary complexity introduced

Security ✅

  • No secrets, credentials, or injection risks

Commit Message ✅

  • Follows Conventional Changelog format: fix(sandbox): remove type: ignore in SandboxManager strategy assignment
  • Includes ISSUES CLOSED: #2828 footer

PR Metadata ✅

  • Type/Bug label present
  • Milestone v3.7.0 assigned (matches issue)
  • Body contains Closes #2828

CI Status ✅

All required checks passing: lint, typecheck, security, quality, unit_tests, integration_tests, e2e_tests, coverage, build, status-check.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## Independent Review: APPROVED ✅ (Posted as COMMENT because the Forgejo API token belongs to the PR author and self-approval is not permitted. The independent review assessment is **APPROVE**.) ### Review Summary Thorough independent review of all 3 changed files against the specification, CONTRIBUTING.md, and codebase conventions. This PR correctly removes a `# type: ignore[assignment]` suppression and replaces it with an idiomatic `typing.cast()` call. ### Specification Alignment ✅ - Runtime behavior is completely unchanged — `cast()` is a no-op at runtime - Directly addresses CONTRIBUTING.md's strict no-type-suppression policy - Module boundaries respected — change is confined to the sandbox infrastructure layer ### Correctness ✅ - **Type safety verified**: `SandboxStrategy` (StrEnum) and `SandboxStrategyStr` (Literal) share exactly the same 6 string values (`git_worktree`, `copy_on_write`, `transaction_rollback`, `snapshot`, `overlay`, `none`). The cast is truthful. - **`cast()` is the correct tool**: `SandboxStrategyStr` is a `Literal` type alias, not callable. A constructor call would raise `TypeError` at runtime. - **String form `"SandboxStrategyStr"`**: Correct — file uses `from __future__ import annotations`. - **Established pattern**: `cast(SandboxStrategyStr, ...)` is already used in `_base.py` (lines 132, 306) and `resource_handler_service.py` (line 394). This PR follows existing codebase convention. ### Test Quality ✅ - 2 Behave scenarios exercise the `cast()` path via `get_or_create_sandbox_for_resource` with a non-`None` `sandbox_strategy` - Step definitions follow the established boundary-cache mocking pattern from `sandbox_manager_coverage_r3_steps.py` - `_STRATEGY_MAP` includes all 6 strategies for future test expansion - Minor observation: both scenarios use `SandboxStrategy.NONE` — testing with a second strategy value would add diversity, but since `cast()` is a no-op regardless of value, this is not blocking ### Code Quality ✅ - `from typing import cast` import placed correctly at top of file with standard library imports - Single-line production code change — minimal blast radius - No unnecessary complexity introduced ### Security ✅ - No secrets, credentials, or injection risks ### Commit Message ✅ - Follows Conventional Changelog format: `fix(sandbox): remove type: ignore in SandboxManager strategy assignment` - Includes `ISSUES CLOSED: #2828` footer ### PR Metadata ✅ - Type/Bug label present - Milestone v3.7.0 assigned (matches issue) - Body contains `Closes #2828` ### CI Status ✅ All required checks passing: lint, typecheck, security, quality, unit_tests, integration_tests, e2e_tests, coverage, build, status-check. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
freemo commented 2026-04-05 08:54:55 +00:00
Author
Owner
Copy link

🔒 Review claimed by reviewer-pool-1 [claim-token: reviewer-pool-1-3058-1743898800]

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-continuous-pr-reviewer

🔒 Review claimed by reviewer-pool-1 [claim-token: reviewer-pool-1-3058-1743898800] --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-continuous-pr-reviewer
freemo reviewed 2026-04-05 09:01:27 +00:00
freemo left a comment
Copy link

Code Review — LGTM ✅

PR: fix(sandbox): remove type: ignore in SandboxManager strategy assignment

Review Checklist

✅ Correctness: Replaces # type: ignore[assignment] with a semantically correct cast() call. This is the correct approach — cast() is a type-safe way to assert a type without suppressing the checker.

✅ Type Safety: Removes a type suppression violation. No # type: ignore directives remain. Pyright passes.

✅ Commit Format: fix(sandbox): follows Conventional Changelog format.

✅ Labels/Milestone: Priority/Medium, Type/Bug, milestone v3.7.0 — correctly assigned.

Decision: LGTM — Proceeding to merge when CI passes.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-continuous-pr-reviewer

## Code Review — LGTM ✅ **PR:** fix(sandbox): remove type: ignore in SandboxManager strategy assignment ### Review Checklist **✅ Correctness:** Replaces `# type: ignore[assignment]` with a semantically correct `cast()` call. This is the correct approach — `cast()` is a type-safe way to assert a type without suppressing the checker. **✅ Type Safety:** Removes a type suppression violation. No `# type: ignore` directives remain. Pyright passes. **✅ Commit Format:** `fix(sandbox):` follows Conventional Changelog format. **✅ Labels/Milestone:** `Priority/Medium`, `Type/Bug`, milestone `v3.7.0` — correctly assigned. ### Decision: **LGTM** — Proceeding to merge when CI passes. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-continuous-pr-reviewer
freemo scheduled this pull request to auto merge when all checks succeed 2026-04-05 09:06:05 +00:00
freemo commented 2026-04-05 16:24:51 +00:00
Author
Owner
Copy link

Issue triaged by project owner:

  • State: Verified
  • Priority: Medium — Removes a # type: ignore in SandboxManager strategy assignment. Per project rules, type suppression is strictly forbidden.
  • Milestone: v3.7.0 (already set)
  • Story Points: 2 — S — Straightforward type annotation fix. Estimated 1-4 hours.
  • MoSCoW: Should Have — Violates a strict project rule (no type suppression), but is not blocking functionality.
  • Parent Epic: #2810 (CI Quality Gates Restoration)

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: ca-project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: Medium — Removes a `# type: ignore` in SandboxManager strategy assignment. Per project rules, type suppression is strictly forbidden. - **Milestone**: v3.7.0 (already set) - **Story Points**: 2 — S — Straightforward type annotation fix. Estimated 1-4 hours. - **MoSCoW**: Should Have — Violates a strict project rule (no type suppression), but is not blocking functionality. - **Parent Epic**: #2810 (CI Quality Gates Restoration) --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: ca-project-owner
freemo merged commit c3b2f59772 into master 2026-04-05 21:13:08 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  
controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  
auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  
auto/claimed-implementer
Currently being processed by an implementer worker.

  
auto/claimed-merge
Currently being processed by the merge driver.

  
auto/claimed-reviewer
Currently being processed by a reviewer worker.

  
auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  
auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  
auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  
auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  
Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.

  
auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.

  
auto/needs-implementer
Failing CI needs implementer attention.

  
auto/postmortem
Documenting a driver incident or rollback.

  
auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  
auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  
auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  
auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  
auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  
auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  
Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.

  
Bounty
$100
 A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$1000
 A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$10000
 A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$20
 A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$2000
 A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$250
 A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$50
 A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$500
 A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$5000
 A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$750
 A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  
MoSCoW
Could have
 Could have feature in order to satisfy the epic/legendary.

  
MoSCoW
Must have
 Must have feature in order to satisfy the epic/legendary.

  
MoSCoW
Should have
 Should have feature in order to satisfy the epic/legendary.

  
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.

  
Points
1
 1 man-hours worth of work for an expert with no learning curve.

  
Points
13
 13 man-hours worth of work for an expert with no learning curve.

  
Points
2
 2 man-hours worth of work for an expert with no learning curve.

  
Points
21
 21 man-hours worth of work for an expert with no learning curve.

  
Points
3
 3 man-hours worth of work for an expert with no learning curve.

  
Points
34
 34 man-hours worth of work for an expert with no learning curve.

  
Points
5
 5 man-hours worth of work for an expert with no learning curve.

  
Points
55
 55 man-hours worth of work for an expert with no learning curve.

  
Points
8
 8 man-hours worth of work for an expert with no learning curve.

  
Points
88
 88 man-hours worth of work for an expert with no learning curve.

  
Priority
Backlog
 This ticket has backlogged priority and is not to be worked on yet

  
Priority
CI Blocker
 Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  
State
Completed
 The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  
State
Duplicate
 A ticket that represents the same content as an existing ticket.

  
State
In Progress
 A ticket that is actively being developed.

  
State
In Review
 A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  
State
Paused
 This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  
State
Unverified
 All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  
State
Verified
 The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  
State
Wont Do
 This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  
Type
Automation
 Any edits or discussion about the AI automated coding system.

  
Type
Bug
 Something that doesnt work as intended.

  
Type
Discussion
 Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  
Type
Documentation
 An error or improvement needed in the documentation.

  
Type
Epic
 Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  
Type
Feature
 Some new functionality not present.

  
Type
Legendary
 A type of Epic which will contain other Epics.

  
Type
Refactor
 A code change that restructures existing code without changing its external behavior.

  
Type
Support
 Someone needs help using the project.

  
Type
Task
 A generic task that doesnt fit into the other type categories.

  
Type
Testing
 Work exclusively focusing on fixing or expanding testing.

No labels
auto/needs-reevaluation
controller-managed
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
Milestone
Clear milestone
No items
No milestone
v3.7.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core!3058
No description provided.