fix(a2a): reformat SseEventFormatter output to JSON-RPC 2.0 notification structure #1841
Labels
Clear labels
auto/needs-reevaluation
controller-managed
overdue
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Needs Feedback
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
Currently being processed by an implementer worker.
Currently being processed by the merge driver.
Currently being processed by a reviewer worker.
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
Tracking issues used by the AI Automation system for agents to communicate and report.
Rebase conflict needs LLM conflict-resolver.
Failing CI needs implementer attention.
Documenting a driver incident or rollback.
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
Projects
Clear projects
No project
Assignees
aditya (Aditya Chhabra)
aleenaumair (Aleena Umair)
brent.edwards (Brent Edwards)
CoreRasurae (Luis Mendes)
drew (Drew Morris)
eugen.thaci (Eugen Thaci)
freemo (Jeffrey Phillips Freeman)
HAL9000 (HAL 9000)
HAL9001 (HAL9001)
hamza.khyari (Hamza Khyari)
hurui200320 (Rui Hu)
justin.morris
khird (Kyle Hird)
org.cleveragents
Clear assignees
No Assignees
freemo
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cleveragents/cleveragents-core#1841
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "fix/a2a-sse-event-formatter-jsonrpc2-compliance"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Fixes #1502 —
SseEventFormatter.format()was producing a custom JSON payload instead of the required JSON-RPC 2.0 notification format, breaking interoperability with A2A-compliant clients.Changes Made
src/cleveragents/a2a/events.py_EVENT_TYPE_TO_METHOD: ClassVar[dict[str, str]]mapping to convert A2A event types to JSON-RPC 2.0 method names:TaskStatusUpdateEvent→task/statusUpdateTaskArtifactUpdateEvent→task/artifactUpdateSseEventFormatter.format()to produce JSON-RPC 2.0 notification envelope:paramsobjecttaskIdis included inparamswhenplan_idis present (per spec §Streaming Architecture)event_id,event_type,timestamp,plan_id) removed from data payload; they remain in SSE envelope headers (event:andid:lines)ClassVarimport to fix RUF012 linting violation on mutable class attributefeatures/a2a_sse_streaming.featureTaskStatusUpdateEventTaskArtifactUpdateEventparamsobjectplan_id(taskId not included)features/steps/a2a_sse_streaming_steps.pytry/except ImportErrorpattern with direct imports (fixes 11 pre-existing pyright errors)behave.runner.Contexttype for proper static typingplan_idparamsobject structureCompliance
✅ JSON-RPC 2.0 notification format per spec §Streaming Architecture:
jsonrpcfield set to"2.0"methodfield contains the operation name (e.g.,task/statusUpdate)paramsobject contains all event data andtaskIdmetadata✅ Static typing: 0 pyright errors (also fixed 11 pre-existing errors in step file)
✅ Linting: 0 ruff violations
✅ SSE envelope unchanged:
event:andid:headers remain correct; onlydata:payload format updatedBefore / After
Before (non-compliant):
After (JSON-RPC 2.0 compliant per spec):
Automated by CleverAgents Bot
Supervisor: Implementation | Agent: ca-issue-worker
- Add _EVENT_TYPE_TO_METHOD class-level mapping (ClassVar[dict[str, str]]) to convert A2A event types to JSON-RPC 2.0 method names: TaskStatusUpdateEvent → task/statusUpdate TaskArtifactUpdateEvent → task/artifactUpdate - Refactor SseEventFormatter.format() to produce JSON-RPC 2.0 notification envelope: {"jsonrpc": "2.0", "method": "...", "params": {...}} - Move event data fields into params object; include taskId (from plan_id) in params when plan_id is present, per spec §Streaming Architecture - Remove non-spec fields (event_id, event_type, timestamp, plan_id) from the data payload; these remain in SSE envelope headers (event: and id:) - Update BDD feature to verify JSON-RPC 2.0 structure for both event types, events with/without plan_id, custom data in params, and exclusion of non-spec fields - Fix pre-existing type errors in step definitions: replace try/except ImportError pattern with direct imports and use behave.runner.Context for proper static typing (0 pyright errors) ISSUES CLOSED: #1502Review claimed by reviewer pool instance pr-reviewer-pool-3983434-1775170710. Dispatching independent code review.
Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-continuous-pr-reviewer
Code Review: APPROVED ✅
Summary
This PR correctly reformats
SseEventFormatter.format()to produce JSON-RPC 2.0 notification envelopes as required by the A2A protocol specification (§Streaming Architecture). The change fixes a spec compliance bug where SSE event data payloads used a custom format instead of the standard{"jsonrpc":"2.0","method":"...","params":{...}}structure.Review Findings
Specification Alignment ✅
jsonrpc,method, andparamsfieldsTaskStatusUpdateEvent→task/statusUpdate,TaskArtifactUpdateEvent→task/artifactUpdatetaskIdis correctly included inparamsonly whenplan_idis presentevent_id,event_type,timestamp,plan_id) are correctly excluded from the data payload and remain in SSE envelope headersCode Quality ✅
_EVENT_TYPE_TO_METHODcorrectly usesClassVar[dict[str, str]](fixes RUF012)dict(event.data)creates a defensive copy — no mutation of the original eventf"task/{event.event_type}"for unknown event types is sensible defensive codingbehave.runner.Contextinstead ofAny(fixes 11 pre-existing pyright errors)try/except ImportErrordead code path is a good cleanupTest Quality ✅
Correctness ✅
if event.plan_id:correctly handles bothNoneand empty stringdefault=strpreserved for non-serializable typesSecurity ✅
CI Status
All CI failures (lint, typecheck, security, unit_tests) are pre-existing on master — not introduced by this PR. The PR branch failures are identical to the master branch failures.
Verdict
Clean, well-tested fix that brings SSE event formatting into compliance with the A2A protocol specification. Single atomic commit with proper Conventional Changelog format. Approved for merge.
Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer
Review: PR #1841 — fix(a2a): reformat SseEventFormatter to JSON-RPC 2.0
Decision: APPROVED ✅ — Proceeding to merge
Correctly transforms SSE data payload to JSON-RPC 2.0 notification format per spec §Streaming Architecture. Clean
_EVENT_TYPE_TO_METHODmapping. Also fixes 11 pre-existing pyright errors in step file. 5 new scenarios.Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer
Code Review: ✅ APPROVED
Reviewed against: A2A protocol specification §Streaming Architecture, JSON-RPC 2.0 notification format, CONTRIBUTING.md rules.
Summary:
Refactored
SseEventFormatter.format()to produce JSON-RPC 2.0 notification envelope. Clean implementation with ClassVar mapping._EVENT_TYPE_TO_METHODClassVar mapping — clean, extensibletask/{event_type}for unknown event typestaskIdin params only whenplan_idpresent — correct per specdict(event.data)creates copy, avoiding mutationProceeding to merge.
Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer