cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

chore(ci): extract behave-parallel runner script from noxfile.py into scripts/ #1775

Merged
freemo merged 1 commits from chore/extract-behave-parallel-script into master 2026-04-03 01:08:39 +00:00
Conversation 4 Commits 1 Files Changed 2
+339 -329
freemo commented 2026-04-02 23:47:29 +00:00
Owner
Copy Link
Copy Source

Summary

Extracts the inline _BEHAVE_PARALLEL_CLI_SOURCE string constant (334 lines of raw Python source) from noxfile.py into a proper, standalone module at scripts/run_behave_parallel.py. This improves maintainability by making the parallel behave runner a first-class Python file with full type annotations, linting, and formatting support rather than an opaque embedded string.

Changes

  • Created scripts/run_behave_parallel.py: Contains the full in-process parallel behave runner logic previously embedded as the _BEHAVE_PARALLEL_CLI_SOURCE raw string constant in noxfile.py. The extracted script is now a proper Python module with:
    • Full type annotations, including a Summary = dict[str, Any] type alias to handle the untyped behave library
    • Explicit imports, including contextlib.suppress to satisfy the ruff SIM105 rule (replacing bare try/except/pass blocks)
    • Standard module structure subject to ruff lint and format checks
  • Updated _install_behave_parallel() in noxfile.py: Replaced the inline _BEHAVE_PARALLEL_CLI_SOURCE string with a dynamic file read using Path(__file__).parent / "scripts" / "run_behave_parallel.py". The function now reads the script content from disk and writes it into the temporary package directory, preserving the identical runtime behaviour.
  • Removed _BEHAVE_PARALLEL_CLI_SOURCE from noxfile.py: Deleted the 334-line string constant and its associated comment block, significantly reducing the size and cognitive load of noxfile.py.

Design Decisions

  • Path(__file__).parent for script location: The script is resolved relative to noxfile.py itself rather than the current working directory. This ensures the path is correct regardless of where nox is invoked from.
  • contextlib.suppress(ImportError) over try/except/pass: The extracted script is now subject to ruff linting. The SIM105 rule flags bare try/except/pass patterns; contextlib.suppress is the idiomatic replacement.
  • Summary = dict[str, Any] type alias: The behave library ships without type stubs. A local type alias captures intent while keeping the file fully annotated and # type: ignore-free.
  • No change to the installed package structure: The script continues to be installed as behave_parallel.cli under the same temporary package directory, preserving the behave-parallel console script entry point.

Testing

  • ruff lint and format checks: ✅ Pass on both scripts/run_behave_parallel.py and the updated noxfile.py
  • No application logic was changed; the runner logic is identical to the original embedded script

Modules Affected

  • noxfile.py — removed _BEHAVE_PARALLEL_CLI_SOURCE constant; updated _install_behave_parallel() to read from the new script file
  • scripts/run_behave_parallel.py — new file containing the extracted parallel behave runner module

Closes #1538

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: ca-issue-worker

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: ca-pr-api-creator

## Summary Extracts the inline `_BEHAVE_PARALLEL_CLI_SOURCE` string constant (334 lines of raw Python source) from `noxfile.py` into a proper, standalone module at `scripts/run_behave_parallel.py`. This improves maintainability by making the parallel behave runner a first-class Python file with full type annotations, linting, and formatting support rather than an opaque embedded string. ## Changes - **Created `scripts/run_behave_parallel.py`**: Contains the full in-process parallel behave runner logic previously embedded as the `_BEHAVE_PARALLEL_CLI_SOURCE` raw string constant in `noxfile.py`. The extracted script is now a proper Python module with: - Full type annotations, including a `Summary = dict[str, Any]` type alias to handle the untyped `behave` library - Explicit imports, including `contextlib.suppress` to satisfy the `ruff` SIM105 rule (replacing bare `try/except/pass` blocks) - Standard module structure subject to `ruff` lint and format checks - **Updated `_install_behave_parallel()` in `noxfile.py`**: Replaced the inline `_BEHAVE_PARALLEL_CLI_SOURCE` string with a dynamic file read using `Path(__file__).parent / "scripts" / "run_behave_parallel.py"`. The function now reads the script content from disk and writes it into the temporary package directory, preserving the identical runtime behaviour. - **Removed `_BEHAVE_PARALLEL_CLI_SOURCE` from `noxfile.py`**: Deleted the 334-line string constant and its associated comment block, significantly reducing the size and cognitive load of `noxfile.py`. ## Design Decisions - **`Path(__file__).parent` for script location**: The script is resolved relative to `noxfile.py` itself rather than the current working directory. This ensures the path is correct regardless of where `nox` is invoked from. - **`contextlib.suppress(ImportError)` over `try/except/pass`**: The extracted script is now subject to `ruff` linting. The SIM105 rule flags bare `try/except/pass` patterns; `contextlib.suppress` is the idiomatic replacement. - **`Summary = dict[str, Any]` type alias**: The `behave` library ships without type stubs. A local type alias captures intent while keeping the file fully annotated and `# type: ignore`-free. - **No change to the installed package structure**: The script continues to be installed as `behave_parallel.cli` under the same temporary package directory, preserving the `behave-parallel` console script entry point. ## Testing - `ruff` lint and format checks: ✅ Pass on both `scripts/run_behave_parallel.py` and the updated `noxfile.py` - No application logic was changed; the runner logic is identical to the original embedded script ## Modules Affected - `noxfile.py` — removed `_BEHAVE_PARALLEL_CLI_SOURCE` constant; updated `_install_behave_parallel()` to read from the new script file - `scripts/run_behave_parallel.py` — new file containing the extracted parallel behave runner module Closes #1538 --- **Automated by CleverAgents Bot** Supervisor: Implementation | Agent: ca-issue-worker --- **Automated by CleverAgents Bot** Supervisor: Implementation | Agent: ca-pr-api-creator
freemo added 1 commit 2026-04-02 23:47:29 +00:00
chore(ci): extract behave-parallel runner script from noxfile.py into scripts/
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Failing after 17s
Details
CI / build (pull_request) Successful in 21s
Details
CI / helm (pull_request) Successful in 23s
Details
CI / security (pull_request) Failing after 46s
Details
CI / typecheck (pull_request) Failing after 49s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / benchmark-regression (pull_request) Has been skipped
Details
CI / unit_tests (pull_request) Failing after 1m48s
Details
CI / docker (pull_request) Has been skipped
Details
CI / quality (pull_request) Successful in 3m41s
Details
CI / e2e_tests (pull_request) Failing after 16m17s
Details
CI / integration_tests (pull_request) Failing after 21m20s
Details
CI / status-check (pull_request) Failing after 1s
Details
37586882b3 
Move the large embedded `_BEHAVE_PARALLEL_CLI_SOURCE` string constant out of
noxfile.py and into a standalone `scripts/run_behave_parallel.py` module.

The `_install_behave_parallel()` helper now reads the script from disk via
`Path(__file__).parent / 'scripts' / 'run_behave_parallel.py'` instead of
embedding the source as a raw string literal. This allows ruff to lint and
type-check the runner independently, and makes noxfile.py significantly
shorter and easier to read.

No functional changes: the installed `behave-parallel` entry point is
identical to the previous embedded version. Parallel and sequential modes,
coverage integration, and the multiprocessing fork model are all preserved.

Fixed two SIM105 lint violations in the extracted script (replaced
try/except/pass with contextlib.suppress).

ISSUES CLOSED: #1538
freemo added this to the v3.6.0 milestone 2026-04-02 23:48:06 +00:00
freemo commented 2026-04-02 23:48:11 +00:00
Author
Owner
Copy Link
Copy Source

Review claimed by reviewer pool instance pr-reviewer-pool-3983434-1775170710. Dispatching independent code review.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-continuous-pr-reviewer

Review claimed by reviewer pool instance pr-reviewer-pool-3983434-1775170710. Dispatching independent code review. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-continuous-pr-reviewer
freemo reviewed 2026-04-03 01:08:22 +00:00
freemo left a comment
Author
Owner
Copy Link
Copy Source

Code Review: APPROVED ✅

Summary

Clean, well-executed refactoring that extracts the 334-line _BEHAVE_PARALLEL_CLI_SOURCE inline string constant from noxfile.py into a standalone scripts/run_behave_parallel.py module. No functional changes — the installed behave-parallel entry point is identical to the previous embedded version.

Review Findings

Specification Alignment: N/A — this is a CI/infrastructure chore, not a feature change. No spec concerns.

Code Quality ✅

  • New file is 332 lines (under 500-line limit)
  • Full type annotations on all functions with Summary = dict[str, Any] alias for untyped behave library
  • No # type: ignore suppressions
  • from __future__ import annotations for modern type syntax
  • contextlib.suppress(ImportError) replaces bare try/except/pass (ruff SIM105 compliance)
  • Good docstrings, clean module structure with section separators
  • Imports at top of file (lazy imports inside functions for behave are intentional and appropriate)

Correctness ✅

  • Extracted script is functionally identical to the original inline string
  • Path resolution via Path(__file__).parent / "scripts" / "run_behave_parallel.py" is robust regardless of CWD
  • read_text(encoding="utf-8") — explicit encoding specification
  • Installed package structure unchanged (behave_parallel.cli module)
  • Parallel/sequential modes, coverage integration, and multiprocessing fork model all preserved

noxfile.py Improvement ✅

  • Removed 334-line string constant
  • Updated _install_behave_parallel() docstring to explain new approach
  • noxfile.py reduced from ~1130 to ~796 lines — significant readability improvement

Commit Quality ✅

  • Single atomic commit with Conventional Changelog format
  • Detailed commit body explaining what and why
  • ISSUES CLOSED: #1538 footer present

CI Status: Failures in lint, typecheck, security, and unit_tests are pre-existing on master (same failures on commit 921c13f4). This PR does not introduce any new CI failures. The quality check passes on both master and this PR.

Verdict

Approved for merge. This is a textbook refactoring — improves maintainability and enables proper tooling support for the parallel runner script without changing any runtime behavior.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## Code Review: APPROVED ✅ ### Summary Clean, well-executed refactoring that extracts the 334-line `_BEHAVE_PARALLEL_CLI_SOURCE` inline string constant from `noxfile.py` into a standalone `scripts/run_behave_parallel.py` module. No functional changes — the installed `behave-parallel` entry point is identical to the previous embedded version. ### Review Findings **Specification Alignment**: N/A — this is a CI/infrastructure chore, not a feature change. No spec concerns. **Code Quality** ✅ - New file is 332 lines (under 500-line limit) - Full type annotations on all functions with `Summary = dict[str, Any]` alias for untyped behave library - No `# type: ignore` suppressions - `from __future__ import annotations` for modern type syntax - `contextlib.suppress(ImportError)` replaces bare `try/except/pass` (ruff SIM105 compliance) - Good docstrings, clean module structure with section separators - Imports at top of file (lazy imports inside functions for behave are intentional and appropriate) **Correctness** ✅ - Extracted script is functionally identical to the original inline string - Path resolution via `Path(__file__).parent / "scripts" / "run_behave_parallel.py"` is robust regardless of CWD - `read_text(encoding="utf-8")` — explicit encoding specification - Installed package structure unchanged (`behave_parallel.cli` module) - Parallel/sequential modes, coverage integration, and multiprocessing fork model all preserved **noxfile.py Improvement** ✅ - Removed 334-line string constant - Updated `_install_behave_parallel()` docstring to explain new approach - noxfile.py reduced from ~1130 to ~796 lines — significant readability improvement **Commit Quality** ✅ - Single atomic commit with Conventional Changelog format - Detailed commit body explaining what and why - `ISSUES CLOSED: #1538` footer present **CI Status**: Failures in lint, typecheck, security, and unit_tests are **pre-existing on master** (same failures on commit 921c13f4). This PR does not introduce any new CI failures. The `quality` check passes on both master and this PR. ### Verdict Approved for merge. This is a textbook refactoring — improves maintainability and enables proper tooling support for the parallel runner script without changing any runtime behavior. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
freemo merged commit a39c718363 into master 2026-04-03 01:08:39 +00:00
freemo deleted branch chore/extract-behave-parallel-script 2026-04-03 01:08:39 +00:00
freemo reviewed 2026-04-03 01:09:04 +00:00
freemo left a comment
Author
Owner
Copy Link
Copy Source

Review: PR #1775 — chore(ci): extract behave-parallel runner script

Decision: APPROVED ✅ — Proceeding to merge

Clean refactor extracting 334-line string constant into proper Python module. Full type annotations, contextlib.suppress for SIM105 compliance, Summary type alias. Logic identical to original. Significant maintainability improvement.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## Review: PR #1775 — chore(ci): extract behave-parallel runner script **Decision: APPROVED ✅ — Proceeding to merge** Clean refactor extracting 334-line string constant into proper Python module. Full type annotations, `contextlib.suppress` for SIM105 compliance, `Summary` type alias. Logic identical to original. Significant maintainability improvement. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
freemo commented 2026-04-03 01:11:06 +00:00
Author
Owner
Copy Link
Copy Source

Code Review: ✅ APPROVED

Reviewed against: CONTRIBUTING.md rules, code maintainability best practices.

Summary:

Extracts 334-line string constant from noxfile.py into scripts/run_behave_parallel.py. No logic changes.

  • ✅ Path(__file__).parent ensures correct path resolution regardless of CWD
  • ✅ Extracted script now subject to ruff lint/format and Pyright type checking
  • ✅ contextlib.suppress(ImportError) satisfies ruff SIM105 rule
  • ✅ Summary = dict[str, Any] handles untyped behave library without # type: ignore
  • ✅ noxfile.py reduced by ~330 lines of opaque string content

Proceeding to merge.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## Code Review: ✅ APPROVED **Reviewed against:** CONTRIBUTING.md rules, code maintainability best practices. ### Summary: Extracts 334-line string constant from `noxfile.py` into `scripts/run_behave_parallel.py`. No logic changes. - ✅ `Path(__file__).parent` ensures correct path resolution regardless of CWD - ✅ Extracted script now subject to ruff lint/format and Pyright type checking - ✅ `contextlib.suppress(ImportError)` satisfies ruff SIM105 rule - ✅ `Summary = dict[str, Any]` handles untyped behave library without `# type: ignore` - ✅ noxfile.py reduced by ~330 lines of opaque string content **Proceeding to merge.** --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
Sign in to join this conversation.
Reviewers
No Reviewers
freemo
Labels
Clear labels
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
 controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
 overdue
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
 auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
 auto/claimed-implementer
Currently being processed by an implementer worker.
 auto/claimed-merge
Currently being processed by the merge driver.
 auto/claimed-reviewer
Currently being processed by a reviewer worker.
 auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
 auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
 auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
 auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
 Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.
 auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.
 auto/needs-implementer
Failing CI needs implementer attention.
 auto/postmortem
Documenting a driver incident or rollback.
 auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
 auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
 auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
 auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
 auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
 auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
 Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
No Label
Milestone
No items
No Milestone v3.6.0
Projects
Clear projects
No project
Assignees
Clear assignees
aditya (Aditya Chhabra) aleenaumair (Aleena Umair) brent.edwards (Brent Edwards) CoreRasurae (Luis Mendes) drew (Drew Morris) eugen.thaci (Eugen Thaci) freemo (Jeffrey Phillips Freeman) HAL9000 (HAL 9000) HAL9001 (HAL9001) hamza.khyari (Hamza Khyari) hurui200320 (Rui Hu) justin.morris khird (Kyle Hird) org.cleveragents
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Blocks
#1538 TEST-INFRA: [ci-pipeline-design] Extract behave-parallel Script from noxfile.py
cleveragents/cleveragents-core
Reference: cleveragents/cleveragents-core#1775
Delete Branch "chore/extract-behave-parallel-script"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?