fix(provider): make LangChainChatProvider name and model_id mutable properties (#1553) #1558

Merged

freemo merged 1 commit from fix/provider-immutable-properties into master

2026-04-02 21:13:37 +00:00

freemo commented

2026-04-02 21:12:22 +00:00

Owner

Summary

Fixes #1553 - Resolves AttributeError when agents build tries to set provider name and model_id.

Problem

The LangChainChatProvider class defined name and model_id as read-only properties (no setters), causing an AttributeError when PlanService._resolve_ai_provider_for_actor() attempted to mutate these properties.

Error: AttributeError: property 'name' of 'LangChainChatProvider' object has no setter

Location: src/cleveragents/application/services/plan_service.py:411 and 413

Root Cause

# In LangChainChatProvider - read-only properties
@property
def name(self) -> str:
    return self._name
# No setter!

# In PlanService - attempts mutation
provider_instance_mutable.name = provider_name  # ← AttributeError
provider_instance_mutable.model_id = model_name  # ← AttributeError

Solution

Added property setters for both name and model_id:

@name.setter
def name(self, value: str) -> None:
    self._name = value

@model_id.setter
def model_id(self, value: str) -> None:
    self._model_id = value

Impact

✅ Fixes agents build command crash
✅ Allows proper provider name/model resolution
✅ No regression in existing functionality
✅ Type-safe (str → str)
✅ Minimal change (8 lines added)

Testing

The fix enables the end-to-end workflow:

agents tell -n "name" "description" (creates plan)
agents build (now works without AttributeError)

Closes #1553

Automated by CleverAgents Bot
Supervisor: Product Builder | Agent: product-builder

## Summary Fixes #1553 - Resolves AttributeError when `agents build` tries to set provider name and model_id. ## Problem The `LangChainChatProvider` class defined `name` and `model_id` as read-only properties (no setters), causing an AttributeError when `PlanService._resolve_ai_provider_for_actor()` attempted to mutate these properties. **Error**: `AttributeError: property 'name' of 'LangChainChatProvider' object has no setter` **Location**: `src/cleveragents/application/services/plan_service.py:411` and `413` ## Root Cause ```python # In LangChainChatProvider - read-only properties @property def name(self) -> str: return self._name # No setter! # In PlanService - attempts mutation provider_instance_mutable.name = provider_name # ← AttributeError provider_instance_mutable.model_id = model_name # ← AttributeError ``` ## Solution Added property setters for both `name` and `model_id`: ```python @name.setter def name(self, value: str) -> None: self._name = value @model_id.setter def model_id(self, value: str) -> None: self._model_id = value ``` ## Impact - ✅ Fixes `agents build` command crash - ✅ Allows proper provider name/model resolution - ✅ No regression in existing functionality - ✅ Type-safe (str → str) - ✅ Minimal change (8 lines added) ## Testing The fix enables the end-to-end workflow: 1. `agents tell -n "name" "description"` (creates plan) 2. `agents build` (now works without AttributeError) Closes #1553 --- **Automated by CleverAgents Bot** Supervisor: Product Builder | Agent: product-builder

Rows
Columns