feat(decision): add decision persistence layer #131

Merged

hamza.khyari merged 2 commits from feature/m4-decision-persistence into master 2026-02-26 14:25:27 +00:00

Conversation 4 Commits 2 Files changed 12 +2362 -1

hamza.khyari commented 2026-02-20 15:33:05 +00:00

Member

Copy link

Metadata

• Commit Message: feat(decision): add decision persistence layer
• Branch: feature/m4-decision-persistence

Background

This PR implements the decision persistence layer for Milestone 3 (v3.2.0). It adds the ability to persist decision records to the SQLite database, enabling decision trees to be recorded during strategize and queried via CLI commands.

Related issue: #171

Expected Behavior

Decision records are persisted to SQLite with full context snapshots. The decision persistence layer supports CRUD operations and integrates with the plan execution lifecycle.

Acceptance Criteria

• Decision model persists to SQLite via repository pattern
• Decision records include context snapshots
• CRUD operations work for decision lifecycle
• Existing tests pass with no regressions
• Coverage remains >=97%

Definition of Done

This PR is complete when:

• All acceptance criteria above are met.
• Code review is approved.
• CI passes (nox full suite, coverage >=97%).
• PR is merged to master.

## Metadata - **Commit Message**: `feat(decision): add decision persistence layer` - **Branch**: `feature/m4-decision-persistence` ## Background This PR implements the decision persistence layer for Milestone 3 (v3.2.0). It adds the ability to persist decision records to the SQLite database, enabling decision trees to be recorded during strategize and queried via CLI commands. Related issue: #171 ## Expected Behavior Decision records are persisted to SQLite with full context snapshots. The decision persistence layer supports CRUD operations and integrates with the plan execution lifecycle. ## Acceptance Criteria - [x] Decision model persists to SQLite via repository pattern - [x] Decision records include context snapshots - [x] CRUD operations work for decision lifecycle - [x] Existing tests pass with no regressions - [x] Coverage remains >=97% ## Definition of Done This PR is complete when: - All acceptance criteria above are met. - Code review is approved. - CI passes (nox full suite, coverage >=97%). - PR is merged to master.

hamza.khyari changed title from feat(db): add decision tables and repositories [H-19/H-20, D5.db/D5.repo] to WIP: feat(db): add decision tables and repositories [H-19/H-20, D5.db/D5.repo] 2026-02-20 15:34:18 +00:00

hamza.khyari changed title from WIP: feat(db): add decision tables and repositories [H-19/H-20, D5.db/D5.repo] to feat(decision): add decision persistence layer [H-19, M3.2] 2026-02-23 15:54:56 +00:00

freemo added this to the v3.2.0 milestone 2026-02-23 17:26:17 +00:00

freemo commented 2026-02-23 17:27:08 +00:00

Owner

Copy link

Relates to #171

Relates to #171

hamza.khyari changed target branch from develop-hamza-2 to master 2026-02-23 22:56:04 +00:00

freemo commented 2026-02-24 03:28:08 +00:00

Owner

Copy link

Note: This PR (feature/m4-decision-persistence) is a duplicate tracking path. The properly scoped issue for this work is #171 (feat(decision): add decision persistence). This PR's branch exists on the remote and appears to contain Hamza's active work. The PR should be retargeted and associated with issue #171 once ready for review.

Note: This PR (`feature/m4-decision-persistence`) is a duplicate tracking path. The properly scoped issue for this work is #171 (feat(decision): add decision persistence). This PR's branch exists on the remote and appears to contain Hamza's active work. The PR should be retargeted and associated with issue #171 once ready for review.

freemo added the

MoSCoW

Must have

Points

8

Priority

High

State

In Review

Type

Feature

labels 2026-02-24 03:36:43 +00:00

hamza.khyari was assigned by freemo 2026-02-24 03:37:54 +00:00

hamza.khyari force-pushed feature/m4-decision-persistence from 89a374a296 to d0feda432a 2026-02-24 17:39:09 +00:00 Compare

hamza.khyari force-pushed feature/m4-decision-persistence from 9f36e8f848 to 78c3e5dc01 2026-02-24 17:46:56 +00:00 Compare

hamza.khyari force-pushed feature/m4-decision-persistence from 78c3e5dc01 to 42c9ee85d4 2026-02-24 20:09:33 +00:00 Compare

freemo force-pushed feature/m4-decision-persistence from 42c9ee85d4 to f88a4a1290 2026-02-24 20:50:24 +00:00 Compare

freemo requested changes 2026-02-24 22:27:54 +00:00

Dismissed

freemo left a comment

Copy link

Code Review: PR #131 — feat(decision): add decision persistence layer [H-19, M3.2]

This PR implements a well-scoped decision persistence subsystem with proper repository pattern architecture. The branch name matches issue #171's metadata, and the overall structure (models, repository, migration, tests, docs, benchmarks) is thorough. However, several process and code quality issues need attention.

Process Issues

1. Commit message mismatch with issue metadata
Issue #171 specifies the commit message first line as: feat(decision): add decision persistence
The actual commit message is: feat(decision): add decision persistence layer
Per the issue's Definition of Done: "the first line of the commit message matches the Commit Message in Metadata exactly."

2. No issue references in commit footers (CONTRIBUTING.md §4)
Neither commit (feat(decision): add decision persistence layer nor fix(decision): use setattr for ORM attribute write to satisfy pyright) has a footer referencing issue #171. Per guidelines, every commit must reference its associated issue (e.g., ISSUES CLOSED: #171 or Refs: #171).

3. No CHANGELOG update (CONTRIBUTING.md §6)
A +2,349 line PR adding a new persistence subsystem requires a CHANGELOG entry describing the change from the user's perspective.

4. No CONTRIBUTORS.md update (CONTRIBUTING.md §8)
Hamza Khyari should be added to CONTRIBUTORS.md if not already listed.

5. Improper labels on PR (CONTRIBUTING.md §12)
This PR carries MoSCoW/Must have, Points/8, and enhancement labels. Per guidelines: "No other label scopes (State/, Priority/, MoSCoW/) are applied to Pull Requests." The PR should have only Type/Feature. Remove MoSCoW/Must have, Points/8, and enhancement.

Code Quality Issues

6. Overuse of Any types (CONTRIBUTING.md — Type Safety)
DecisionRepository uses Any extensively where the concrete Decision type should be specified:

• create(self, decision: Any) -> Any
• get(self, decision_id: str) -> Any | None
• get_by_plan(self, plan_id: str) -> list[Any]
• get_tree(self, root_decision_id: str) -> list[Any]
• to_domain(self) -> Any
• from_domain(cls, decision: Any) -> DecisionModel

Per CONTRIBUTING.md: "every function signature, variable declaration, and return type should be annotated with explicit types." If this is to avoid circular imports, use TYPE_CHECKING:

from __future__ import annotations
from typing import TYPE_CHECKING
if TYPE_CHECKING:
    from cleveragents.domain.decisions import Decision

7. Missing type annotations in Robot helper
robot/helper_decision_persistence.py has 12 functions all lacking type annotations (parameter types and return types). While these are module-private, the project standard requires full annotations.

8. BFS uses list.pop(0) — O(n) per operation
In DecisionRepository.get_tree():

queue = [root_decision_id]
while queue:
    parent_id = queue.pop(0)  # O(n) operation

This should use collections.deque for O(1) popleft. For large decision trees this becomes a performance concern:

from collections import deque
queue = deque([root_decision_id])
while queue:
    parent_id = queue.popleft()  # O(1) operation

What's Good

• Single feature scope (decision persistence only) — properly scoped PR
• Correct branch name matching issue #171 metadata
• Proper milestone assignment (v3.2.0)
• Repository pattern with proper separation of concerns
• Complete test coverage (Behave scenarios, Robot tests, ASV benchmarks)
• Alembic migration included
• Documentation updated (database_schema.md)
• Existing maintainer comments acknowledged (#171 linkage)

Action Items

1. Fix commit message to match issue metadata exactly.
2. Add issue references to commit footers.
3. Add CHANGELOG entry.
4. Add CONTRIBUTORS.md entry.
5. Replace Any types with concrete Decision type using TYPE_CHECKING.
6. Add type annotations to Robot helper functions.
7. Replace list.pop(0) with deque.popleft() in get_tree().
8. Fix PR labels to only Type/Feature.

## Code Review: PR #131 — `feat(decision): add decision persistence layer [H-19, M3.2]` This PR implements a well-scoped decision persistence subsystem with proper repository pattern architecture. The branch name matches issue #171's metadata, and the overall structure (models, repository, migration, tests, docs, benchmarks) is thorough. However, several process and code quality issues need attention. ### Process Issues **1. Commit message mismatch with issue metadata** Issue #171 specifies the commit message first line as: `feat(decision): add decision persistence` The actual commit message is: `feat(decision): add decision persistence layer` Per the issue's Definition of Done: "the first line of the commit message matches the Commit Message in Metadata exactly." **2. No issue references in commit footers (CONTRIBUTING.md §4)** Neither commit (`feat(decision): add decision persistence layer` nor `fix(decision): use setattr for ORM attribute write to satisfy pyright`) has a footer referencing issue #171. Per guidelines, every commit must reference its associated issue (e.g., `ISSUES CLOSED: #171` or `Refs: #171`). **3. No CHANGELOG update (CONTRIBUTING.md §6)** A +2,349 line PR adding a new persistence subsystem requires a CHANGELOG entry describing the change from the user's perspective. **4. No CONTRIBUTORS.md update (CONTRIBUTING.md §8)** Hamza Khyari should be added to CONTRIBUTORS.md if not already listed. **5. Improper labels on PR (CONTRIBUTING.md §12)** This PR carries `MoSCoW/Must have`, `Points/8`, and `enhancement` labels. Per guidelines: "No other label scopes (`State/`, `Priority/`, `MoSCoW/`) are applied to Pull Requests." The PR should have only `Type/Feature`. Remove `MoSCoW/Must have`, `Points/8`, and `enhancement`. ### Code Quality Issues **6. Overuse of `Any` types (CONTRIBUTING.md — Type Safety)** `DecisionRepository` uses `Any` extensively where the concrete `Decision` type should be specified: - `create(self, decision: Any) -> Any` - `get(self, decision_id: str) -> Any | None` - `get_by_plan(self, plan_id: str) -> list[Any]` - `get_tree(self, root_decision_id: str) -> list[Any]` - `to_domain(self) -> Any` - `from_domain(cls, decision: Any) -> DecisionModel` Per CONTRIBUTING.md: "every function signature, variable declaration, and return type should be annotated with explicit types." If this is to avoid circular imports, use `TYPE_CHECKING`: ```python from __future__ import annotations from typing import TYPE_CHECKING if TYPE_CHECKING: from cleveragents.domain.decisions import Decision ``` **7. Missing type annotations in Robot helper** `robot/helper_decision_persistence.py` has 12 functions all lacking type annotations (parameter types and return types). While these are module-private, the project standard requires full annotations. **8. BFS uses `list.pop(0)` — O(n) per operation** In `DecisionRepository.get_tree()`: ```python queue = [root_decision_id] while queue: parent_id = queue.pop(0) # O(n) operation ``` This should use `collections.deque` for O(1) popleft. For large decision trees this becomes a performance concern: ```python from collections import deque queue = deque([root_decision_id]) while queue: parent_id = queue.popleft() # O(1) operation ``` ### What's Good - Single feature scope (decision persistence only) — properly scoped PR - Correct branch name matching issue #171 metadata - Proper milestone assignment (v3.2.0) - Repository pattern with proper separation of concerns - Complete test coverage (Behave scenarios, Robot tests, ASV benchmarks) - Alembic migration included - Documentation updated (database_schema.md) - Existing maintainer comments acknowledged (#171 linkage) ### Action Items 1. Fix commit message to match issue metadata exactly. 2. Add issue references to commit footers. 3. Add CHANGELOG entry. 4. Add CONTRIBUTORS.md entry. 5. Replace `Any` types with concrete `Decision` type using `TYPE_CHECKING`. 6. Add type annotations to Robot helper functions. 7. Replace `list.pop(0)` with `deque.popleft()` in `get_tree()`. 8. Fix PR labels to only `Type/Feature`.

freemo dismissed freemo's review 2026-02-24 22:44:50 +00:00

Reason:

dont want hard block

hamza.khyari referenced this pull request 2026-02-25 13:12:31 +00:00

feat(service): add decision recording and snapshot store #433

hamza.khyari removed the

Priority

High

Points

8

MoSCoW

Must have

labels 2026-02-25 15:05:54 +00:00

hamza.khyari force-pushed feature/m4-decision-persistence from f88a4a1290 to 8e56067dbb 2026-02-25 15:25:23 +00:00 Compare

freemo added a new dependency 2026-02-25 18:17:50 +00:00

#171 feat(decision): add decision persistence

hamza.khyari requested review from brent.edwards 2026-02-26 00:37:19 +00:00

brent.edwards approved these changes 2026-02-26 00:52:35 +00:00

Dismissed

brent.edwards left a comment

Copy link

Looks good to me!

Looks good to me!

hamza.khyari force-pushed feature/m4-decision-persistence from 8e56067dbb to 6083747cb8 2026-02-26 01:02:23 +00:00 Compare

hamza.khyari dismissed brent.edwards's review 2026-02-26 01:02:24 +00:00

Reason:

New commits pushed, approval review dismissed automatically according to repository settings

hamza.khyari changed title from feat(decision): add decision persistence layer [H-19, M3.2] to feat(decision): add decision persistence layer 2026-02-26 01:29:49 +00:00

hamza.khyari force-pushed feature/m4-decision-persistence from 6083747cb8 to f29e485f71 2026-02-26 01:38:38 +00:00 Compare

hamza.khyari scheduled this pull request to auto merge when all checks succeed 2026-02-26 02:22:00 +00:00

hamza.khyari force-pushed feature/m4-decision-persistence from f29e485f71 to 38fa95a70c 2026-02-26 12:35:27 +00:00 Compare

hamza.khyari force-pushed feature/m4-decision-persistence from 5d3a0f48ec to 7f2b1c61fc 2026-02-26 13:40:47 +00:00 Compare

hamza.khyari merged commit db58a3bb62 into master 2026-02-26 14:25:27 +00:00

hamza.khyari referenced this pull request from a commit 2026-02-26 14:25:28 +00:00

Merge pull request 'feat(decision): add decision persistence layer' (#131) from feature/m4-decision-persistence into master

hamza.khyari removed the

State

In Review

label 2026-02-26 15:35:49 +00:00

freemo added the

State

Completed

label 2026-03-04 00:59:16 +00:00

HAL9000 referenced this pull request 2026-04-12 18:21:54 +00:00

[AUTO-ARCH] Status: Architecture Review (Cycle 1) #7983

HAL9000 referenced this pull request 2026-04-12 19:40:51 +00:00

docs: architecture — add v3.8.0 Server Implementation milestone plan section #8014

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

auto/needs-reevaluation

Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  

controller-managed

Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  

auto/blocked-by-deps

PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  

auto/ci-timeout

Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  

auto/claimed-implementer

Currently being processed by an implementer worker.

  

auto/claimed-merge

Currently being processed by the merge driver.

  

auto/claimed-reviewer

Currently being processed by a reviewer worker.

  

auto/driver-down

Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  

auto/invariant-violation

Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  

auto/last-attempt-tier-0

In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-1

In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-2

In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  

auto/last-attempt-tier-min

In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  

Automation Tracking

Tracking issues used by the AI Automation system for agents to communicate and report.

  

auto/needs-conflict-resolution

Rebase conflict needs LLM conflict-resolver.

  

auto/needs-implementer

Failing CI needs implementer attention.

  

auto/postmortem

Documenting a driver incident or rollback.

  

auto/ready-to-merge

Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  

auto/restart-throttled

Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  

auto/revert

Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  

auto/sentinel

Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  

auto/stale-inactivity

No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  

auto/unstable

Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  

Blocked

A ticket in a blocked state and unable to complete until some other task is completed first.

  

Bounty

$100

A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$1000

A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$10000

A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$20

A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$2000

A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$250

A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$50

A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$500

A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$5000

A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$750

A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  

MoSCoW

Could have

Could have feature in order to satisfy the epic/legendary.

  

MoSCoW

Must have

Must have feature in order to satisfy the epic/legendary.

  

MoSCoW

Should have

Should have feature in order to satisfy the epic/legendary.

  

Needs Feedback

There are questions in the ticket that can not be completed until the project owner provides clarity.

  

Points

1

1 man-hours worth of work for an expert with no learning curve.

  

Points

13

13 man-hours worth of work for an expert with no learning curve.

  

Points

2

2 man-hours worth of work for an expert with no learning curve.

  

Points

21

21 man-hours worth of work for an expert with no learning curve.

  

Points

3

3 man-hours worth of work for an expert with no learning curve.

  

Points

34

34 man-hours worth of work for an expert with no learning curve.

  

Points

5

5 man-hours worth of work for an expert with no learning curve.

  

Points

55

55 man-hours worth of work for an expert with no learning curve.

  

Points

8

8 man-hours worth of work for an expert with no learning curve.

  

Points

88

88 man-hours worth of work for an expert with no learning curve.

  

Priority

Backlog

This ticket has backlogged priority and is not to be worked on yet

  

Priority

CI Blocker

Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Signed-off: Owner

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Scrum Master

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Tech Lead

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Spike

A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  

State

Completed

The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  

State

Duplicate

A ticket that represents the same content as an existing ticket.

  

State

In Progress

A ticket that is actively being developed.

  

State

In Review

A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  

State

Paused

This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  

State

Unverified

All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  

State

Verified

The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  

State

Wont Do

This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  

Type

Automation

Any edits or discussion about the AI automated coding system.

  

Type

Bug

Something that doesnt work as intended.

  

Type

Discussion

Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  

Type

Documentation

An error or improvement needed in the documentation.

  

Type

Epic

Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  

Type

Feature

Some new functionality not present.

  

Type

Legendary

A type of Epic which will contain other Epics.

  

Type

Refactor

A code change that restructures existing code without changing its external behavior.

  

Type

Support

Someone needs help using the project.

  

Type

Task

A generic task that doesnt fit into the other type categories.

  

Type

Testing

Work exclusively focusing on fixing or expanding testing.

No labels

auto/needs-reevaluation

controller-managed

auto/blocked-by-deps

auto/ci-timeout

auto/claimed-implementer

auto/claimed-merge

auto/claimed-reviewer

auto/driver-down

auto/invariant-violation

auto/last-attempt-tier-0

auto/last-attempt-tier-1

auto/last-attempt-tier-2

auto/last-attempt-tier-min

Automation Tracking

auto/needs-conflict-resolution

auto/needs-implementer

auto/postmortem

auto/ready-to-merge

auto/restart-throttled

auto/revert

auto/sentinel

auto/stale-inactivity

auto/unstable

Blocked

Bounty

$100

Bounty

$1000

Bounty

$10000

Bounty

$20

Bounty

$2000

Bounty

$250

Bounty

$50

Bounty

$500

Bounty

$5000

Bounty

$750

MoSCoW

Could have

MoSCoW

Must have

MoSCoW

Should have

Needs Feedback

Points

1

Points

13

Points

2

Points

21

Points

3

Points

34

Points

5

Points

55

Points

8

Points

88

Priority

Backlog

Priority

CI Blocker

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Signed-off: Owner

Signed-off: Scrum Master

Signed-off: Tech Lead

Spike

State

Completed

State

Duplicate

State

In Progress

State

In Review

State

Paused

State

Unverified

State

Verified

State

Wont Do

Type

Automation

Type

Bug

Type

Discussion

Type

Documentation

Type

Epic

Type

Feature

Type

Legendary

Type

Refactor

Type

Support

Type

Task

Type

Testing

Milestone

Clear milestone

No items

No milestone

v3.2.0

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

hamza.khyari

3 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks

#171 feat(decision): add decision persistence

cleveragents/cleveragents-core

Reference

cleveragents/cleveragents-core!131

No description provided.