cleveragents/cleveragents-core

Fork 3

refactor(cleanup): remove or implement empty stub packages #1266

Merged

freemo merged 1 commit from refactor/m7-remove-empty-stub-packages into master

2026-04-02 16:58:37 +00:00

brent.edwards commented

2026-04-02 06:30:14 +00:00

Member

No description provided.

brent.edwards added 1 commit

2026-04-02 06:30:14 +00:00

refactor(cleanup): remove or implement empty stub packages

CI / lint (pull_request) Successful in 3m20s

Details

CI / build (pull_request) Successful in 15s

Details

CI / quality (pull_request) Successful in 3m47s

Details

CI / helm (pull_request) Successful in 22s

Details

CI / typecheck (pull_request) Successful in 4m5s

Details

CI / security (pull_request) Successful in 4m12s

Details

CI / unit_tests (pull_request) Successful in 6m1s

Details

CI / docker (pull_request) Successful in 1m18s

Details

CI / coverage (pull_request) Successful in 12m25s

Details

CI / e2e_tests (pull_request) Successful in 16m48s

Details

CI / integration_tests (pull_request) Successful in 24m15s

Details

CI / status-check (pull_request) Successful in 3s

Details

CI / benchmark-publish (pull_request) Has been skipped

Details

CI / benchmark-regression (pull_request) Successful in 55m15s

Details

99ac4403b9

Remove four empty stub packages that contained only __init__.py with
__all__ = [] and no functional code, violating CONTRIBUTING.md §Commit
Completeness. All four were audited against docs/specification.md:

- src/cleveragents/runtime/ — Spec defines four layers (Domain,
  Application, Infrastructure, Presentation) with no Runtime Layer.
  Runtime concepts (LSP Runtime, actor runtime) belong in Infrastructure.
- src/cleveragents/domain/repositories/ — Spec mentions repository
  interfaces in Domain but mandates no separate subpackage. Empty with
  no protocols defined; existing models cover the domain.
- src/cleveragents/domain/plans/ — Plan domain models already exist in
  domain/models/planconfig, planfiles, and plansettings. Empty duplicate.
- src/cleveragents/application/workflows/ — Application logic already
  served by application/services/. Empty stub added no value.

Updated test references in features/steps/module_coverage_steps.py,
features/steps/coverage_extras_steps.py, features/architecture.feature,
and robot/architecture.robot to remove the deleted packages from import
verification and architecture validation lists.

ISSUES CLOSED: #948

brent.edwards added this to the v3.2.0 milestone

2026-04-02 06:30:19 +00:00

brent.edwards added the

Type

Task

label

2026-04-02 06:30:20 +00:00

freemo commented

2026-04-02 08:03:09 +00:00

Owner

🔒 Claimed by pr-reviewer-1. Starting independent code review.

freemo self-assigned this

2026-04-02 08:06:06 +00:00

freemo approved these changes

2026-04-02 08:12:17 +00:00

Dismissed

freemo left a comment

Code Review — APPROVED ✅

Summary

This PR cleanly removes four empty stub packages (runtime/, domain/repositories/, domain/plans/, application/workflows/) that contained only __init__.py with __all__ = [] and no functional code. Each removal is well-justified against the specification.

Review Findings

Specification Alignment ✅

The spec defines four architectural layers (Domain, Application, Infrastructure, Presentation/CLI) — no "Runtime" layer exists. Removing runtime/ is correct.
domain/repositories/ was empty with no protocols defined; existing domain models cover the domain layer adequately.
domain/plans/ duplicated namespace already served by domain/models/planconfig, planfiles, and plansettings.
application/workflows/ was empty; application/services/ already serves the application layer.

Correctness ✅

Verified via grep that no source code, test code, or configuration files import from any of the four deleted packages (outside the files modified by this PR).
All four directories confirmed to contain only __init__.py (plus cached .pyc) — truly empty stubs.

Test Updates ✅

features/architecture.feature — runtime removed from main packages table.
features/steps/coverage_extras_steps.py — 4 module references removed from import test list.
features/steps/module_coverage_steps.py — 4 module references removed from import test list.
robot/architecture.robot — Directory Should Exist ${SRC_DIR}/runtime removed.
All test changes are consistent and complete.

Commit Quality ✅

Single atomic commit following Conventional Changelog format.
Detailed commit body with per-package spec justification.
ISSUES CLOSED: #948 footer present.

Security ✅ — No concerns; purely removing dead code.

No issues found. Approving for merge.

## Code Review — APPROVED ✅ ### Summary This PR cleanly removes four empty stub packages (`runtime/`, `domain/repositories/`, `domain/plans/`, `application/workflows/`) that contained only `__init__.py` with `__all__ = []` and no functional code. Each removal is well-justified against the specification. ### Review Findings **Specification Alignment** ✅ - The spec defines four architectural layers (Domain, Application, Infrastructure, Presentation/CLI) — no "Runtime" layer exists. Removing `runtime/` is correct. - `domain/repositories/` was empty with no protocols defined; existing domain models cover the domain layer adequately. - `domain/plans/` duplicated namespace already served by `domain/models/planconfig`, `planfiles`, and `plansettings`. - `application/workflows/` was empty; `application/services/` already serves the application layer. **Correctness** ✅ - Verified via grep that no source code, test code, or configuration files import from any of the four deleted packages (outside the files modified by this PR). - All four directories confirmed to contain only `__init__.py` (plus cached `.pyc`) — truly empty stubs. **Test Updates** ✅ - `features/architecture.feature` — `runtime` removed from main packages table. - `features/steps/coverage_extras_steps.py` — 4 module references removed from import test list. - `features/steps/module_coverage_steps.py` — 4 module references removed from import test list. - `robot/architecture.robot` — `Directory Should Exist ${SRC_DIR}/runtime` removed. - All test changes are consistent and complete. **Commit Quality** ✅ - Single atomic commit following Conventional Changelog format. - Detailed commit body with per-package spec justification. - `ISSUES CLOSED: #948` footer present. **Security** ✅ — No concerns; purely removing dead code. No issues found. Approving for merge.

freemo referenced this pull request

2026-04-02 08:12:48 +00:00

refactor(cleanup): remove or implement empty stub packages (runtime, repositories, plans, workflows) #948

freemo referenced this pull request

2026-04-02 16:51:03 +00:00

refactor(cleanup): remove or implement empty stub packages (runtime, repositories, plans, workflows) #948

freemo referenced this pull request

2026-04-02 16:53:37 +00:00

[Automated] Product Build Session State #1314

freemo commented

2026-04-02 16:55:00 +00:00

Owner

Review claimed by reviewer pool instance reviewer-pool-1. Dispatching independent code review.

freemo approved these changes

2026-04-02 16:58:24 +00:00

freemo left a comment

Independent Code Review — APPROVED ✅

Review Scope

Independently reviewed the full diff (8 files changed: 4 source deletions, 4 test file updates) against the specification, CONTRIBUTING.md, and linked issue #948.

Findings

Specification Alignment ✅

The spec defines four architectural layers (Domain, Application, Infrastructure, Presentation/CLI). There is no "Runtime" layer — removing runtime/ is correct.
domain/repositories/ was empty with no protocols defined; the spec does not mandate a separate subpackage for repository interfaces.
domain/plans/ duplicated namespace already served by domain/models/planconfig, planfiles, and plansettings.
application/workflows/ was empty; application/services/ already serves the application layer.

Correctness ✅

Verified via grep that zero source files, test files, or configuration files import from any of the four deleted packages (runtime, domain.repositories, domain.plans, application.workflows).
All four directories confirmed to contain only __init__.py with __all__ = [] — truly empty stubs with no functional code.

Test Updates ✅

features/architecture.feature — runtime row removed from main packages table.
features/steps/coverage_extras_steps.py — 4 module references removed from import test list.
features/steps/module_coverage_steps.py — 4 module references removed from import test list.
robot/architecture.robot — Directory Should Exist ${SRC_DIR}/runtime removed.
All test changes are consistent and complete — no orphaned references remain.

Commit Quality ✅

Single atomic commit following Conventional Changelog format.
Detailed commit body with per-package spec justification.
ISSUES CLOSED: #948 footer present.
Commit message matches the issue's prescribed format exactly.

Security ✅ — No concerns; purely removing dead code.

Minor Note (non-blocking): The PR body/description is empty. Per CONTRIBUTING.md, PRs should include a description with closing keywords. The commit message compensates with excellent detail, so this is not blocking.

Approving for merge.

## Independent Code Review — APPROVED ✅ ### Review Scope Independently reviewed the full diff (8 files changed: 4 source deletions, 4 test file updates) against the specification, CONTRIBUTING.md, and linked issue #948. ### Findings **Specification Alignment** ✅ - The spec defines four architectural layers (Domain, Application, Infrastructure, Presentation/CLI). There is no "Runtime" layer — removing `runtime/` is correct. - `domain/repositories/` was empty with no protocols defined; the spec does not mandate a separate subpackage for repository interfaces. - `domain/plans/` duplicated namespace already served by `domain/models/planconfig`, `planfiles`, and `plansettings`. - `application/workflows/` was empty; `application/services/` already serves the application layer. **Correctness** ✅ - Verified via grep that **zero** source files, test files, or configuration files import from any of the four deleted packages (`runtime`, `domain.repositories`, `domain.plans`, `application.workflows`). - All four directories confirmed to contain only `__init__.py` with `__all__ = []` — truly empty stubs with no functional code. **Test Updates** ✅ - `features/architecture.feature` — `runtime` row removed from main packages table. - `features/steps/coverage_extras_steps.py` — 4 module references removed from import test list. - `features/steps/module_coverage_steps.py` — 4 module references removed from import test list. - `robot/architecture.robot` — `Directory Should Exist ${SRC_DIR}/runtime` removed. - All test changes are consistent and complete — no orphaned references remain. **Commit Quality** ✅ - Single atomic commit following Conventional Changelog format. - Detailed commit body with per-package spec justification. - `ISSUES CLOSED: #948` footer present. - Commit message matches the issue's prescribed format exactly. **Security** ✅ — No concerns; purely removing dead code. **Minor Note** (non-blocking): The PR body/description is empty. Per CONTRIBUTING.md, PRs should include a description with closing keywords. The commit message compensates with excellent detail, so this is not blocking. Approving for merge.

freemo merged commit f4432c2759 into master

2026-04-02 16:58:37 +00:00

freemo deleted branch refactor/m7-remove-empty-stub-packages

2026-04-02 16:58:38 +00:00

freemo referenced this pull request

2026-04-02 16:58:44 +00:00

refactor(cleanup): remove or implement empty stub packages (runtime, repositories, plans, workflows) #948

freemo referenced this pull request

2026-04-02 16:59:00 +00:00

[Automated] Product Build Session State #1314

freemo referenced this pull request

2026-04-02 17:11:30 +00:00