develop-aditya #126

Merged
brent.edwards merged 15 commits from develop-aditya into master 2026-02-21 00:02:59 +00:00

15 Commits

Author SHA1 Message Date
brent.edwards 37018341e3 Merge remote-tracking branch 'origin/master' into develop-aditya
CI / lint (pull_request) Successful in 16s
CI / benchmark-publish (pull_request) Has been skipped
CI / quality (pull_request) Successful in 32s
CI / typecheck (pull_request) Successful in 38s
CI / security (pull_request) Successful in 44s
CI / build (pull_request) Successful in 31s
CI / integration_tests (pull_request) Successful in 3m41s
CI / unit_tests (pull_request) Successful in 5m18s
CI / docker (pull_request) Successful in 38s
CI / benchmark-regression (pull_request) Successful in 16m0s
CI / coverage (pull_request) Successful in 27m37s
2026-02-20 23:02:06 +00:00
brent.edwards aefcc74d76 fix(test): resolve AmbiguousStep collision after master merge
CI / benchmark-publish (pull_request) Has been skipped
CI / lint (pull_request) Successful in 15s
CI / quality (pull_request) Successful in 18s
CI / build (pull_request) Successful in 16s
CI / security (pull_request) Successful in 42s
CI / typecheck (pull_request) Successful in 44s
CI / integration_tests (pull_request) Successful in 2m57s
CI / unit_tests (pull_request) Successful in 5m9s
CI / docker (pull_request) Successful in 43s
CI / benchmark-regression (pull_request) Successful in 14m0s
CI / coverage (pull_request) Successful in 14m9s
Renamed 'listing actors with namespace' step in actor_loading_steps.py
to 'listing loaded actors with namespace' to avoid collision with
actor_registry_persistence_steps.py from master. Updated
actor_loading.feature to use renamed step.
2026-02-20 20:24:10 +00:00
brent.edwards 85dc638093 Merge branch 'master' into develop-aditya
# Conflicts:
#	implementation_plan.md
2026-02-20 18:58:05 +00:00
aditya 436a4af6d7 docs(plan): mark C2.loader complete
CI / benchmark-publish (pull_request) Has been skipped
CI / lint (pull_request) Successful in 13s
CI / build (pull_request) Successful in 14s
CI / quality (pull_request) Successful in 17s
CI / typecheck (pull_request) Successful in 28s
CI / security (pull_request) Successful in 39s
CI / integration_tests (pull_request) Successful in 3m15s
CI / unit_tests (pull_request) Successful in 4m24s
CI / docker (pull_request) Successful in 58s
CI / benchmark-regression (pull_request) Failing after 11m13s
CI / coverage (pull_request) Successful in 11m17s
2026-02-19 12:46:18 +00:00
aditya ef4ba36779 feat(actor): add actor registry and loader 2026-02-19 11:29:34 +00:00
aditya 3ea2413b43 Merge branch 'master' into feature/m3-actor-schema-examples
CI / lint (pull_request) Successful in 14s
CI / build (pull_request) Successful in 16s
CI / quality (pull_request) Successful in 16s
CI / security (pull_request) Successful in 26s
CI / typecheck (pull_request) Successful in 27s
CI / integration_tests (pull_request) Successful in 3m16s
CI / unit_tests (pull_request) Successful in 4m7s
CI / docker (pull_request) Successful in 37s
CI / benchmark-regression (pull_request) Successful in 8m45s
CI / coverage (pull_request) Successful in 10m42s
CI / benchmark-publish (pull_request) Has been skipped
# Conflicts:
#	implementation_plan.md
2026-02-19 05:58:08 +00:00
aditya 7a670feed2 docs(plan): update implementation_plan for completed C1.examples task
CI / lint (pull_request) Successful in 15s
CI / typecheck (pull_request) Successful in 31s
CI / security (pull_request) Successful in 25s
CI / quality (pull_request) Successful in 16s
CI / integration_tests (pull_request) Successful in 4m6s
CI / build (pull_request) Successful in 16s
CI / unit_tests (pull_request) Successful in 18m21s
CI / docker (pull_request) Successful in 39s
CI / coverage (pull_request) Successful in 1h11m30s
- Mark all C1.examples checklist items as complete with actual line counts
- Add comprehensive implementation notes section for C1.examples
- Document key decisions: pattern-based organization, test reuse strategy, parallel execution detection, error compatibility
- Add development log entry with commit list and test results
- Document bug fixes: max_context_tokens, missing descriptions, step conflicts

Checklist: 22/22 items complete (docs, tests, benchmarks, quality, git, PR)
Test Results: Behave 25/25, Robot 16/16, ASV 7/7 all passing
2026-02-18 12:46:46 +00:00
aditya 4ae7f2d6fe test(actor): fix actor examples test suite issues
- Add missing node descriptions in Behave test scenarios
- Fix context_view and parallel execution step definitions
- Update llm_with_tools.yaml max_context_tokens (10000 → 16000)
- Add context.error compatibility for error assertions

Results: Behave 25/25, Robot 16/16, ASV 7/7 all newly added tests passing.
2026-02-18 12:18:37 +00:00
aditya a5fd451a3b fix(actor): resolve Behave test conflicts and add missing step definitions
- Fix ActorType import error in actor_schema_steps.py
- Simplify actor_examples_steps.py to remove duplicate steps
- Add missing Background step and actor validation steps
- Add llm_with_tools.yaml documentation section
- Rename conflicting Given step patterns with 'examples' suffix
- Add comprehensive Then steps for actor config validation
- Fix step patterns to include trailing colons for docstring steps

Test Results:
- 8 scenarios passing (up from 0)
- 138 steps passing (critical path tests working)
- 5 undefined steps remaining (minor edge cases)
- Basic actor example validation fully functional
2026-02-18 11:41:05 +00:00
aditya d144c4e5c4 test(actor): add ASV benchmarks for actor examples loading
- Measure file loading throughput for all 5 example YAML files
- Benchmark complex hierarchical graph parsing performance
2026-02-18 10:49:26 +00:00
aditya ef43947297 test(actor): add Robot Framework tests for actor examples
Create robot/actor_examples.robot with 17 integration test cases:
- Validate all 5 example YAML files load successfully
- Verify actor patterns (strategist, tool-only, graph, hierarchical)
- Check documentation completeness and pattern coverage
- Test invalid example rejection scenarios

Create robot/helper_actor_examples.py with validation commands.
Uses ${PYTHON} and ${CURDIR} per Robot Framework standards.
2026-02-18 10:45:49 +00:00
aditya c6157745e7 test(actor): add step definitions for actor examples validation
Create features/steps/actor_examples_steps.py with step implementations:
- Given steps for actor patterns (strategist/executor/reviewer/validator)
- When steps for schema validation from string and file
- Then steps for field validation and pattern verification
- Graph/route validation (nodes, edges, conditionals, subgraphs)
- Error assertions and documentation completeness checks

All steps use unique patterns to avoid AmbiguousStep conflicts.
2026-02-18 09:36:14 +00:00
aditya 02466864ef test(actor): add comprehensive Behave scenarios for actor examples
Create features/actor_examples.feature with 30+ test scenarios covering:
- All 5 example YAML files load and validate successfully
- Strategist actor pattern (planning, large context, read-only tools)
- Executor actor pattern (write-capable tools, implementation focus)
- Reviewer actor pattern (quality gates, linting tools)
- Tool-only actors (no LLM, pure tool collections)
- Validation-node actors (stateless validators, security scanning)
- Linear graph workflows (sequential 3-step pipelines)
- Complex graphs (conditionals, retry logic, tool nodes)
- Hierarchical graphs (subgraph invocation, parallel execution)
- Multi-level patterns (strategic → tactical → execution)
- Invalid example rejection (missing fields, cycles, bad names)
- Documentation completeness verification

Each scenario validates schema correctness, required fields, and
actor-specific patterns aligned with CleverAgents specification.
2026-02-18 08:52:08 +00:00
aditya 2b56b7f38b docs(actor): add comprehensive actor YAML examples documentation
Create docs/reference/actors_examples.md with detailed examples covering:
- Simple LLM actors (code reviewers, assistants)
- Strategist actors (planning, decomposition)
- Executor actors (implementation, file operations)
- Reviewer actors (quality gates, standards compliance)
- Tool-only actors (reusable tool collections)
- Validation-node actors (linting, security scanning)
- Linear graph workflows (3-step review pipeline)
- Complex graph workflows (TDD with conditionals, retry logic)
- Hierarchical actor graphs (multi-level planning, subgraph composition)

Each example includes purpose, use cases, key features, and alignment
with CleverAgents specification. Documentation references existing
YAML files in examples/actors/ directory.
2026-02-18 08:44:56 +00:00
aditya af38a6bf75 docs(plan): mark actor YAML examples as complete in C1.examples checklist
Update implementation_plan.md to reflect that 5 actor YAML example files
have been created under examples/actors/ during C1.schema implementation.

These examples were completed as part of C1.schema task.
Remaining work: documentation, test scenarios, integration tests, and benchmarks.
2026-02-18 06:41:18 +00:00