feat(events): add user_identity field to DomainEvent and propagate through event pipeline #1257
Labels
Clear labels
auto/needs-reevaluation
controller-managed
overdue
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Needs Feedback
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
Currently being processed by an implementer worker.
Currently being processed by the merge driver.
Currently being processed by a reviewer worker.
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
Tracking issues used by the AI Automation system for agents to communicate and report.
Rebase conflict needs LLM conflict-resolver.
Failing CI needs implementer attention.
Documenting a driver incident or rollback.
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
No Label
Type
Feature
Projects
Clear projects
No project
Assignees
aditya (Aditya Chhabra)
aleenaumair (Aleena Umair)
brent.edwards (Brent Edwards)
CoreRasurae (Luis Mendes)
drew (Drew Morris)
eugen.thaci (Eugen Thaci)
freemo (Jeffrey Phillips Freeman)
HAL9000 (HAL 9000)
HAL9001 (HAL9001)
hamza.khyari (Hamza Khyari)
hurui200320 (Rui Hu)
justin.morris
khird (Kyle Hird)
org.cleveragents
Clear assignees
No Assignees
freemo
Notifications
Due Date
No due date set.
Blocks
#715 feat(events): add user_identity field to DomainEvent and propagate through event pipeline
cleveragents/cleveragents-core
Reference: cleveragents/cleveragents-core#1257
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "feature/domain-event-user-identity"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
user_identity: str | Nonefield toDomainEventfrozen Pydantic model, enabling authenticated user identity to be carried as a first-class event attributeAuditEventSubscriberto preferevent.user_identityover legacy details-dict extraction with backward-compatible fallbackresource_cli_flags_904.feature(clone-into expected "container types" but error message reads "container resource types")Motivation
AuditService.record()accepts auser_identityparameter, butAuditEventSubscriberalways passedNonebecauseDomainEventhad nouser_identityfield. Audit entries lacked identity context, which is critical for security audit trails per spec §Audit Logging (SEC7).Approach
Added the field directly to
DomainEventas an optional string (None in local/unauthenticated mode). Updated the subscriber to check the field first, falling back to details extraction for backward compatibility. No changes to emission sites were needed — they can now optionally populate the field when auth context is available.Quality
nox -s lint— passednox -s typecheck— 0 errors, 0 warningsnox -s unit_tests— 556 features, 13789 scenarios, 0 failuresnox -s integration_tests— new identity tests pass (9/9)nox -s coverage_report— passed (>=97%)Closes #715
Review: PR #1257 — feat(events): add user_identity field to DomainEvent and propagate through event pipeline
Checklist
AuditService.record()accepteduser_identitybut always receivedNonebecauseDomainEventhad no dedicated field. Aligns with §Audit Logging and §Event-Driven Architecture in the specification.feat(events): add user_identity field to DomainEvent and propagate through event pipeline— valid Conventional Changelog withISSUES CLOSED: #715footerDomainEvent.user_identity: str | None = Field(default=None)— properly typed, well-documented, placed logically betweenproject_nameanddetailsAuditEventSubscribercorrectly prefersevent.user_identityover details dict fallback withoroperator, and always pops from details to prevent duplication in stored JSONLoggingEventBusincludesuser_identityin structured log outputNone)redact_value()before audit persistence — prevents accidental secret leakage from tokens embedded in identity stringsneeds feedbacklabelDesign Notes
oroperator inevent.user_identity or details_identitytreats empty strings as falsy — this is appropriate since an empty identity string is semantically meaningless.Nonesince server-mode auth is not yet implemented (M9).Note on Related PR
PR #1258 (fix(audit): forward DomainEvent.timestamp) also modifies
audit_event_subscriber.py. After this merge, PR #1258 will need rebasing to incorporate the user_identity field changes.APPROVED — merging.
dbd97eb9c6tob039b28309🔒 Claimed by pr-reviewer-5. Starting independent code review.
Independent Code Review — PR #1257
Summary
Reviewed all 9 changed files (3 source, 4 Behave test files, 2 Robot test files) against the specification and project conventions.
Source Code Review
DomainEvent(models.py):user_identity: str | None = Field(default=None)— correctly typed, well-placed betweenproject_nameanddetails, fully documented in class docstring with spec reference (§Audit Logging). Backward compatible.AuditEventSubscriber(audit_event_subscriber.py):user_identityfrom details dict to prevent duplication, then prefersevent.user_identityover the popped value viaoroperator. Theorfallback correctly treats empty strings as "no identity" — semantically appropriate.redact_value()applied to identity before persistence — good security practice.LoggingEventBus(logging_bus.py):user_identity=event.user_identityto structured log output — consistent with existing field logging pattern.ReactiveEventBus(reactive.py): Correctly NOT modified — it doesn't do per-field structured logging, so no change needed.Test Review
Compliance
ISSUES CLOSED: #715footer# type: ignoresuppressionsneeds feedbacklabelAPPROVED — no issues found.
b039b28309to6a31f376acNew commits pushed, approval review dismissed automatically according to repository settings
Review claimed by reviewer pool instance reviewer-pool-1. Dispatching independent code review.
Independent Code Review — PR #1257 (reviewer-pool-1)
Summary
Reviewed all 9 changed files against the specification (§Audit Logging SEC7, §Event-Driven Architecture), CONTRIBUTING.md conventions, and project coding standards.
Source Code Review
DomainEvent(models.py):user_identity: str | None = Field(default=None, ...)— correctly typed, well-placed betweenproject_nameanddetails, fully documented in class docstring with spec reference. Backward compatible (defaults toNone). Frozen model ensures immutability.AuditEventSubscriber(audit_event_subscriber.py):if/elsebranching:event.user_identity is not None: uses field value, pops from details to prevent duplicationevent.user_identity is None: falls back toraw_details.pop("user_identity", None)for backward compatoroperator approach (from earlier revisions) because it correctly handles the case whereevent.user_identityis an empty string — theis Nonecheck is semantically precise.redact_value()applied to identity before persistence — good security practice.LoggingEventBus(logging_bus.py):emit()method does NOT includeuser_identityin its structured log output. This is a minor gap (non-blocking) — the critical audit path throughAuditEventSubscribercorrectly handles the field. A follow-up could adduser_identity=event.user_identityto the_logger.info()call for completeness.ReactiveEventBus(reactive.py): Correctly NOT modified — it doesn't do per-field structured logging.Test Review
user_identityis stripped from details after field wins — thorough.Incidental Fix
resource_cli_flags_904.feature: Changed expected string from "container types" to "container resource types" — fixes a pre-existing test mismatch. Verified this aligns with the actual error message.Compliance Checklist
feat(events): ...withISSUES CLOSED: #715footer# type: ignoresuppressions in new codeCloses #715in PR bodyneeds feedbacklabelMinor Non-Blocking Observation
LoggingEventBus.emit()does not includeuser_identityin its structured log output. Consider adding it in a follow-up for parity with the field set onDomainEvent.APPROVED — merging via squash.