cleveragents/cleveragents-core

Fork 3

fix(cleanup): remove ghost acp/ package and orphaned .pyc files #1256

Merged

freemo merged 1 commit from fix/m7-remove-acp-ghost-package into master

2026-04-02 04:16:22 +00:00

brent.edwards commented

2026-04-02 02:44:19 +00:00

Member

Summary

Closes #947

Adds an explicit .gitignore entry for the deprecated src/cleveragents/acp/ package path to prevent accidental re-introduction and document the deprecation per ADR-047 (ACP → A2A Standard Adoption).

Background

The ACP module was properly renamed to src/cleveragents/a2a/ in commit ec0b7631 (closing #688), but the deprecated acp/ path was not explicitly excluded. While __pycache__/ and *.py[cod] are already gitignored globally, the ghost acp/ directory with stale .pyc files persists on developer machines as untracked build artifacts.

Changes

.gitignore: Added explicit exclusion for src/cleveragents/acp/ with a comment referencing ADR-047

Verification

Confirmed src/cleveragents/acp/ does not exist in version control (renamed to a2a/ in ec0b7631)
Confirmed zero tracked .pyc files across the entire repository
Confirmed zero imports referencing cleveragents.acp in source, test, and configuration files
Confirmed no orphaned .pyc files exist without corresponding .py sources
Remaining "acp" references in docs/specification.md, docs/timeline.md, and mkdocs.yml are historical documentation — appropriate to keep

Quality Gates

All nox sessions pass:

Session	Result
`lint`	✅ Pass
`format`	✅ Pass
`typecheck`	✅ Pass
`security_scan`	✅ Pass
`dead_code`	✅ Pass
`unit_tests-3.13`	✅ Pass
`integration_tests-3.13`	✅ Pass
`docs`	✅ Pass
`build-3.13`	✅ Pass
`benchmark`	✅ Pass (1905 benchmarks)
`coverage_report`	✅ Pass — 98.7% (threshold: 97%)

## Summary Closes #947 Adds an explicit `.gitignore` entry for the deprecated `src/cleveragents/acp/` package path to prevent accidental re-introduction and document the deprecation per ADR-047 (ACP → A2A Standard Adoption). ## Background The ACP module was properly renamed to `src/cleveragents/a2a/` in commit `ec0b7631` (closing #688), but the deprecated `acp/` path was not explicitly excluded. While `__pycache__/` and `*.py[cod]` are already gitignored globally, the ghost `acp/` directory with stale `.pyc` files persists on developer machines as untracked build artifacts. ## Changes - **`.gitignore`**: Added explicit exclusion for `src/cleveragents/acp/` with a comment referencing ADR-047 ## Verification - Confirmed `src/cleveragents/acp/` does not exist in version control (renamed to `a2a/` in ec0b7631) - Confirmed zero tracked `.pyc` files across the entire repository - Confirmed zero imports referencing `cleveragents.acp` in source, test, and configuration files - Confirmed no orphaned `.pyc` files exist without corresponding `.py` sources - Remaining "acp" references in `docs/specification.md`, `docs/timeline.md`, and `mkdocs.yml` are historical documentation — appropriate to keep ## Quality Gates All nox sessions pass: | Session | Result | |---------|--------| | `lint` | ✅ Pass | | `format` | ✅ Pass | | `typecheck` | ✅ Pass | | `security_scan` | ✅ Pass | | `dead_code` | ✅ Pass | | `unit_tests-3.13` | ✅ Pass | | `integration_tests-3.13` | ✅ Pass | | `docs` | ✅ Pass | | `build-3.13` | ✅ Pass | | `benchmark` | ✅ Pass (1905 benchmarks) | | `coverage_report` | ✅ Pass — **98.7%** (threshold: 97%) |

brent.edwards added 1 commit

2026-04-02 02:44:19 +00:00

fix(cleanup): remove ghost acp/ package and orphaned .pyc files

CI / benchmark-publish (pull_request) Has been skipped

Details

CI / build (pull_request) Successful in 21s

Details

CI / helm (pull_request) Successful in 23s

Details

CI / lint (pull_request) Successful in 3m20s

Details

CI / quality (pull_request) Successful in 3m43s

Details

CI / typecheck (pull_request) Successful in 3m58s

Details

CI / security (pull_request) Successful in 4m8s

Details

CI / unit_tests (pull_request) Successful in 5m48s

Details

CI / docker (pull_request) Successful in 11s

Details

CI / coverage (pull_request) Successful in 13m1s

Details

CI / e2e_tests (pull_request) Successful in 19m50s

Details

CI / integration_tests (pull_request) Successful in 22m2s

Details

CI / status-check (pull_request) Successful in 1s

Details

CI / benchmark-regression (pull_request) Successful in 55m19s

Details

f653c58ebd

The ACP module was properly renamed to A2A in commit ec0b7631 (closing #688),
but the deprecated src/cleveragents/acp/ path was not explicitly excluded from
version control. While __pycache__/ and *.py[cod] are already gitignored
globally, add an explicit .gitignore entry for the deprecated acp/ package path
to prevent accidental re-introduction and document the deprecation per ADR-047.

Verification performed:
- Confirmed src/cleveragents/acp/ does not exist in git (only __pycache__
  artifacts remain on developer machines as untracked build artifacts)
- Confirmed zero tracked .pyc files across the entire repository
- Confirmed zero imports referencing cleveragents.acp in source, test, and
  configuration files
- Confirmed no orphaned .pyc files exist without corresponding .py sources
- All nox sessions pass (coverage: 98.7%)

ISSUES CLOSED: #947

brent.edwards added this to the v3.2.0 milestone

2026-04-02 02:44:24 +00:00

brent.edwards added the

Type

Task

label

2026-04-02 02:44:25 +00:00

freemo approved these changes

2026-04-02 04:16:18 +00:00

freemo left a comment

Review: PR #1256 — fix(cleanup): remove ghost acp/ package and orphaned .pyc files

Checklist

✅ Spec alignment: Correctly addresses the ACP→A2A migration cleanup per ADR-047
✅ Commit format: fix(cleanup): remove ghost acp/ package and orphaned .pyc files — valid Conventional Changelog format with ISSUES CLOSED: #947 footer
✅ Change scope: Minimal — adds a single .gitignore entry for src/cleveragents/acp/ with a comment referencing ADR-047
✅ Verification: PR author confirmed zero tracked .pyc files, zero cleveragents.acp imports, and no orphaned .pyc files exist
✅ Quality gates: All 11 nox sessions pass, coverage at 98.7% (≥97% threshold)
✅ No needs feedback label
✅ Mergeable: No conflicts with master
✅ Labels: Type/Task ✓
✅ Milestone: v3.2.0 ✓

Assessment

This is a safe, minimal cleanup change. The deprecated acp/ directory was already removed from version control in commit ec0b7631; this PR adds an explicit .gitignore exclusion to prevent accidental re-introduction. The remaining "acp" references in docs are historical documentation and appropriate to keep.

APPROVED — merging.

## Review: PR #1256 — fix(cleanup): remove ghost acp/ package and orphaned .pyc files ### Checklist - ✅ **Spec alignment**: Correctly addresses the ACP→A2A migration cleanup per ADR-047 - ✅ **Commit format**: `fix(cleanup): remove ghost acp/ package and orphaned .pyc files` — valid Conventional Changelog format with `ISSUES CLOSED: #947` footer - ✅ **Change scope**: Minimal — adds a single `.gitignore` entry for `src/cleveragents/acp/` with a comment referencing ADR-047 - ✅ **Verification**: PR author confirmed zero tracked `.pyc` files, zero `cleveragents.acp` imports, and no orphaned `.pyc` files exist - ✅ **Quality gates**: All 11 nox sessions pass, coverage at 98.7% (≥97% threshold) - ✅ **No `needs feedback` label** - ✅ **Mergeable**: No conflicts with master - ✅ **Labels**: Type/Task ✓ - ✅ **Milestone**: v3.2.0 ✓ ### Assessment This is a safe, minimal cleanup change. The deprecated `acp/` directory was already removed from version control in commit `ec0b7631`; this PR adds an explicit `.gitignore` exclusion to prevent accidental re-introduction. The remaining "acp" references in docs are historical documentation and appropriate to keep. **APPROVED** — merging.

freemo merged commit ce026cafc2 into master

2026-04-02 04:16:22 +00:00

freemo deleted branch fix/m7-remove-acp-ghost-package

2026-04-02 04:16:23 +00:00

freemo referenced this pull request from a commit

2026-04-02 04:16:24 +00:00

Merge pull request 'fix(cleanup): remove ghost acp/ package and orphaned .pyc files' (#1256) from fix/m7-remove-acp-ghost-package into master

freemo referenced this pull request

2026-04-02 04:16:27 +00:00

fix(cleanup): remove ghost acp/ package and orphaned .pyc files #947

freemo referenced this pull request

2026-04-02 04:25:14 +00:00