fix(test): remove lingering @tdd_expected_fail tags for closed bugs #821 and #932 #1229

Merged
freemo merged 1 commit from feature/m3-tdd-tag-cleanup-821-932 into master 2026-04-02 16:51:16 +00:00
Member

Summary

Removes stale @tdd_expected_fail references from TDD test files for fixed bugs #821 (ACMS context tier runtime) and #932 (plan apply --yes flag). Both bugs are closed on Forgejo and the @tdd_expected_fail tags were already absent from the tag lines, but the feature description and step-definition docstring for bug #821 still referenced the tag and described the bug as unfixed.

Changes

features/tdd_context_tier_runtime.feature (bug #821)

  • Updated feature description to reflect that bug #821 is fixed and ContextTierService now has working runtime promotion/demotion/eviction logic.
  • Removed stale references to @tdd_expected_fail tag and "will FAIL until the bug is fixed" language.
  • Permanent tags @tdd_issue @tdd_issue_821 @mock_only remain in place per CONTRIBUTING.md.

features/steps/tdd_context_tier_runtime_steps.py (bug #821)

  • Updated module docstring to reflect that the bug is fixed and these tests serve as permanent regression guards.
  • Removed stale references to @tdd_expected_fail tag.

features/tdd_plan_apply_yes_flag.feature (bug #932)

  • No changes needed — the @tdd_expected_fail tag was already absent and no stale descriptions existed.
  • Permanent tags @tdd_issue @tdd_issue_932 remain in place per CONTRIBUTING.md.

Tag Naming Convention Note

The issue acceptance criteria reference @tdd_bug / @tdd_bug_<N> as permanent tags. Per CONTRIBUTING.md (TDD Issue Test Tags section), the correct permanent tag naming is @tdd_issue / @tdd_issue_<N>. Both files already use the correct convention. No tag rename is needed.

Quality Gates

All nox sessions pass:

Session Result
lint PASS
format PASS
typecheck PASS
security_scan PASS
dead_code PASS
unit_tests-3.13 PASS (508 features, 12985 scenarios, 0 failures)
integration_tests-3.13 PASS
docs PASS
build-3.13 PASS
benchmark PASS
coverage_report PASS (97%, meets ≥97% threshold)

Closes #1206

## Summary Removes stale `@tdd_expected_fail` references from TDD test files for fixed bugs #821 (ACMS context tier runtime) and #932 (plan apply --yes flag). Both bugs are closed on Forgejo and the `@tdd_expected_fail` tags were already absent from the tag lines, but the feature description and step-definition docstring for bug #821 still referenced the tag and described the bug as unfixed. ## Changes ### `features/tdd_context_tier_runtime.feature` (bug #821) - Updated feature description to reflect that bug #821 is fixed and ContextTierService now has working runtime promotion/demotion/eviction logic. - Removed stale references to `@tdd_expected_fail` tag and "will FAIL until the bug is fixed" language. - Permanent tags `@tdd_issue @tdd_issue_821 @mock_only` remain in place per CONTRIBUTING.md. ### `features/steps/tdd_context_tier_runtime_steps.py` (bug #821) - Updated module docstring to reflect that the bug is fixed and these tests serve as permanent regression guards. - Removed stale references to `@tdd_expected_fail` tag. ### `features/tdd_plan_apply_yes_flag.feature` (bug #932) - No changes needed — the `@tdd_expected_fail` tag was already absent and no stale descriptions existed. - Permanent tags `@tdd_issue @tdd_issue_932` remain in place per CONTRIBUTING.md. ## Tag Naming Convention Note The issue acceptance criteria reference `@tdd_bug` / `@tdd_bug_<N>` as permanent tags. Per CONTRIBUTING.md (TDD Issue Test Tags section), the correct permanent tag naming is `@tdd_issue` / `@tdd_issue_<N>`. Both files already use the correct convention. No tag rename is needed. ## Quality Gates All nox sessions pass: | Session | Result | |---------|--------| | `lint` | ✅ PASS | | `format` | ✅ PASS | | `typecheck` | ✅ PASS | | `security_scan` | ✅ PASS | | `dead_code` | ✅ PASS | | `unit_tests-3.13` | ✅ PASS (508 features, 12985 scenarios, 0 failures) | | `integration_tests-3.13` | ✅ PASS | | `docs` | ✅ PASS | | `build-3.13` | ✅ PASS | | `benchmark` | ✅ PASS | | `coverage_report` | ✅ PASS (97%, meets ≥97% threshold) | Closes #1206
fix(test): remove lingering @tdd_expected_fail tags for closed bugs #821 and #932
All checks were successful
CI / helm (pull_request) Successful in 28s
CI / build (pull_request) Successful in 44s
CI / lint (pull_request) Successful in 3m25s
CI / quality (pull_request) Successful in 3m43s
CI / typecheck (pull_request) Successful in 4m4s
CI / security (pull_request) Successful in 4m10s
CI / integration_tests (pull_request) Successful in 7m4s
CI / unit_tests (pull_request) Successful in 7m16s
CI / docker (pull_request) Successful in 1m39s
CI / coverage (pull_request) Successful in 12m22s
CI / e2e_tests (pull_request) Successful in 20m58s
CI / status-check (pull_request) Successful in 5s
CI / benchmark-publish (pull_request) Has been skipped
CI / benchmark-regression (pull_request) Successful in 55m12s
2fc6fe83c0
The @tdd_expected_fail tag was already absent from the tag lines of both
features/tdd_context_tier_runtime.feature (bug #821) and
features/tdd_plan_apply_yes_flag.feature (bug #932). However, the feature
description and step-definition docstring for bug #821 still referenced the
@tdd_expected_fail tag and described the bug as unfixed.

Updated the feature description in tdd_context_tier_runtime.feature and the
module docstring in tdd_context_tier_runtime_steps.py to reflect that bug #821
has been fixed and these tests now serve as permanent regression guards. No
changes were needed for bug #932 as its files had no stale references.

Permanent tags @tdd_issue / @tdd_issue_821 and @tdd_issue / @tdd_issue_932
remain in place per the CONTRIBUTING.md TDD Issue Test Tags convention.

All nox sessions pass: lint, format, typecheck, security_scan, dead_code,
unit_tests (508 features, 12985 scenarios, 0 failures), integration_tests,
docs, build, benchmark, coverage_report (97%).

ISSUES CLOSED: #1206
brent.edwards added this to the v3.2.0 milestone 2026-03-31 11:33:10 +00:00
freemo approved these changes 2026-04-02 04:20:47 +00:00
Dismissed
freemo left a comment

Review: APPROVED

PR #1229 — fix(test): remove lingering @tdd_expected_fail tags for closed bugs #821 and #932

What was reviewed

  • features/tdd_context_tier_runtime.feature — Updated feature description to reflect bug #821 is fixed
  • features/steps/tdd_context_tier_runtime_steps.py — Updated module docstring to reflect fix status

Assessment

  • Spec alignment: Correctly follows CONTRIBUTING.md TDD Issue Test Tags convention (@tdd_issue / @tdd_issue_<N> permanent tags retained)
  • Code quality: Pure documentation cleanup — no functional code changes
  • Test coverage: No test logic changed; descriptions now accurately reflect that tests serve as regression guards
  • Risk: Very low — only feature descriptions and docstrings updated
  • Quality gates: All 11 nox sessions pass (508 features, 12985 scenarios, 97% coverage)

Clean, minimal change. No concerns.

## Review: APPROVED ✅ **PR #1229 — fix(test): remove lingering @tdd_expected_fail tags for closed bugs #821 and #932** ### What was reviewed - `features/tdd_context_tier_runtime.feature` — Updated feature description to reflect bug #821 is fixed - `features/steps/tdd_context_tier_runtime_steps.py` — Updated module docstring to reflect fix status ### Assessment - **Spec alignment**: ✅ Correctly follows CONTRIBUTING.md TDD Issue Test Tags convention (`@tdd_issue` / `@tdd_issue_<N>` permanent tags retained) - **Code quality**: ✅ Pure documentation cleanup — no functional code changes - **Test coverage**: ✅ No test logic changed; descriptions now accurately reflect that tests serve as regression guards - **Risk**: Very low — only feature descriptions and docstrings updated - **Quality gates**: All 11 nox sessions pass (508 features, 12985 scenarios, 97% coverage) Clean, minimal change. No concerns.
freemo self-assigned this 2026-04-02 06:15:12 +00:00
Owner

🔒 Claimed by pr-reviewer-1. Starting independent code review.

🔒 Claimed by pr-reviewer-1. Starting independent code review.
freemo approved these changes 2026-04-02 08:06:08 +00:00
Dismissed
freemo left a comment

Independent Review: APPROVED

PR #1229 — fix(test): remove lingering @tdd_expected_fail tags for closed bugs #821 and #932

Review Summary

Verified that both bugs #821 (ACMS context tier runtime) and #932 (plan apply --yes flag) are closed on Forgejo. The @tdd_expected_fail tag was already absent from the actual Behave tag lines in both feature files — this PR correctly cleans up stale descriptive text that still referenced the tag and described the bugs as unfixed.

Files Reviewed

File Change Verdict
features/tdd_context_tier_runtime.feature Feature description updated to reflect bug #821 is fixed; removed "will FAIL until the bug is fixed" and @tdd_expected_fail references Correct
features/steps/tdd_context_tier_runtime_steps.py Module docstring updated to reflect fix status; removed stale "before the fix" language Correct
features/tdd_plan_apply_yes_flag.feature No changes (confirmed identical SHA on master and branch) Correct — no stale references existed

Verification Checklist

  • Spec alignment: Follows CONTRIBUTING.md TDD Issue Test Tags convention — permanent @tdd_issue / @tdd_issue_<N> tags retained, @tdd_expected_fail references removed from descriptions
  • Tag integrity: @tdd_issue @tdd_issue_821 @mock_only and @tdd_issue @tdd_issue_932 remain on tag lines
  • No functional changes: Only feature descriptions and docstrings updated — test logic untouched
  • Commit format: Conventional Changelog format with ISSUES CLOSED: #1206
  • PR metadata: Milestone v3.2.0, Type/Task label, Closes #1206 in body
  • Quality gates: All nox sessions reported passing (508 features, 12985 scenarios, 97% coverage)
  • No merge conflicts: PR is mergeable

Pre-existing Note (out of scope)

features/steps/tdd_context_tier_runtime_steps.py line 48 contains a pre-existing # type: ignore[arg-type] suppression that violates project rules. This was NOT introduced by this PR and should be tracked separately.

Clean, minimal, well-documented change. Approving for merge.

## Independent Review: APPROVED ✅ **PR #1229 — fix(test): remove lingering @tdd_expected_fail tags for closed bugs #821 and #932** ### Review Summary Verified that both bugs #821 (ACMS context tier runtime) and #932 (plan apply --yes flag) are **closed** on Forgejo. The `@tdd_expected_fail` tag was already absent from the actual Behave tag lines in both feature files — this PR correctly cleans up stale descriptive text that still referenced the tag and described the bugs as unfixed. ### Files Reviewed | File | Change | Verdict | |------|--------|---------| | `features/tdd_context_tier_runtime.feature` | Feature description updated to reflect bug #821 is fixed; removed "will FAIL until the bug is fixed" and `@tdd_expected_fail` references | ✅ Correct | | `features/steps/tdd_context_tier_runtime_steps.py` | Module docstring updated to reflect fix status; removed stale "before the fix" language | ✅ Correct | | `features/tdd_plan_apply_yes_flag.feature` | No changes (confirmed identical SHA on master and branch) | ✅ Correct — no stale references existed | ### Verification Checklist - ✅ **Spec alignment**: Follows CONTRIBUTING.md TDD Issue Test Tags convention — permanent `@tdd_issue` / `@tdd_issue_<N>` tags retained, `@tdd_expected_fail` references removed from descriptions - ✅ **Tag integrity**: `@tdd_issue @tdd_issue_821 @mock_only` and `@tdd_issue @tdd_issue_932` remain on tag lines - ✅ **No functional changes**: Only feature descriptions and docstrings updated — test logic untouched - ✅ **Commit format**: Conventional Changelog format with `ISSUES CLOSED: #1206` - ✅ **PR metadata**: Milestone v3.2.0, Type/Task label, `Closes #1206` in body - ✅ **Quality gates**: All nox sessions reported passing (508 features, 12985 scenarios, 97% coverage) - ✅ **No merge conflicts**: PR is mergeable ### Pre-existing Note (out of scope) `features/steps/tdd_context_tier_runtime_steps.py` line 48 contains a pre-existing `# type: ignore[arg-type]` suppression that violates project rules. This was NOT introduced by this PR and should be tracked separately. Clean, minimal, well-documented change. Approving for merge.
Owner

Review claimed by reviewer pool instance reviewer-pool-1. Dispatching independent code review.

Review claimed by reviewer pool instance reviewer-pool-1. Dispatching independent code review.
freemo approved these changes 2026-04-02 16:51:03 +00:00
freemo left a comment

Independent Review: APPROVED

PR #1229 — fix(test): remove lingering @tdd_expected_fail tags for closed bugs #821 and #932

Review Methodology

Performed a full content comparison of all three files referenced in the PR across both master and the feature branch using the Forgejo file content API. Verified the linked issue (#1206) acceptance criteria against the actual changes.

Files Reviewed

File Master SHA Branch SHA Change Summary
features/tdd_context_tier_runtime.feature 091bcc1f 3038defb Feature description updated: removed "will FAIL until the bug is fixed" and @tdd_expected_fail references; added "The bug has been fixed" language and regression guard framing
features/steps/tdd_context_tier_runtime_steps.py 3c2bfb76 518532fc Module docstring updated: removed "before the fix" / "will fail until the bug is fixed" / @tdd_expected_fail references; added "The bug has been fixed" regression guard language
features/tdd_plan_apply_yes_flag.feature 1ad55715 1ad55715 Identical — correctly no changes needed (no stale references existed)

Verification Checklist

  • Spec alignment: Follows CONTRIBUTING.md TDD Issue Test Tags convention — permanent @tdd_issue / @tdd_issue_<N> tags retained on tag lines
  • Tag integrity: @tdd_issue @tdd_issue_821 @mock_only and @tdd_issue @tdd_issue_932 remain on their respective tag lines, untouched
  • No functional changes: Only feature descriptions and module docstrings updated — all test logic, step definitions, and assertions are identical
  • Commit format: fix(test): remove lingering @tdd_expected_fail tags for closed bugs #821 and #932 — valid Conventional Changelog format
  • Commit footer: ISSUES CLOSED: #1206 present
  • PR metadata: Milestone v3.2.0 , Type/Task label , Closes #1206 in body
  • Single atomic commit: One commit, one logical change
  • No merge conflicts: PR is mergeable
  • Quality gates: All 11 nox sessions reported passing (508 features, 12985 scenarios, 97% coverage)
  • No needs feedback label: Safe to merge

Pre-existing Note (out of scope)

features/steps/tdd_context_tier_runtime_steps.py line 48 contains a pre-existing # type: ignore[arg-type] suppression that violates project rules. This was not introduced by this PR and should be tracked as a separate issue.

Clean, minimal, well-documented change. Approving for merge.

## Independent Review: APPROVED ✅ **PR #1229 — fix(test): remove lingering @tdd_expected_fail tags for closed bugs #821 and #932** ### Review Methodology Performed a full content comparison of all three files referenced in the PR across both `master` and the feature branch using the Forgejo file content API. Verified the linked issue (#1206) acceptance criteria against the actual changes. ### Files Reviewed | File | Master SHA | Branch SHA | Change Summary | |------|-----------|------------|----------------| | `features/tdd_context_tier_runtime.feature` | `091bcc1f` | `3038defb` | Feature description updated: removed "will FAIL until the bug is fixed" and `@tdd_expected_fail` references; added "The bug has been fixed" language and regression guard framing | | `features/steps/tdd_context_tier_runtime_steps.py` | `3c2bfb76` | `518532fc` | Module docstring updated: removed "before the fix" / "will **fail** until the bug is fixed" / `@tdd_expected_fail` references; added "The bug has been fixed" regression guard language | | `features/tdd_plan_apply_yes_flag.feature` | `1ad55715` | `1ad55715` | **Identical** — correctly no changes needed (no stale references existed) | ### Verification Checklist - ✅ **Spec alignment**: Follows CONTRIBUTING.md TDD Issue Test Tags convention — permanent `@tdd_issue` / `@tdd_issue_<N>` tags retained on tag lines - ✅ **Tag integrity**: `@tdd_issue @tdd_issue_821 @mock_only` and `@tdd_issue @tdd_issue_932` remain on their respective tag lines, untouched - ✅ **No functional changes**: Only feature descriptions and module docstrings updated — all test logic, step definitions, and assertions are identical - ✅ **Commit format**: `fix(test): remove lingering @tdd_expected_fail tags for closed bugs #821 and #932` — valid Conventional Changelog format - ✅ **Commit footer**: `ISSUES CLOSED: #1206` present - ✅ **PR metadata**: Milestone v3.2.0 ✅, `Type/Task` label ✅, `Closes #1206` in body ✅ - ✅ **Single atomic commit**: One commit, one logical change - ✅ **No merge conflicts**: PR is mergeable - ✅ **Quality gates**: All 11 nox sessions reported passing (508 features, 12985 scenarios, 97% coverage) - ✅ **No `needs feedback` label**: Safe to merge ### Pre-existing Note (out of scope) `features/steps/tdd_context_tier_runtime_steps.py` line 48 contains a pre-existing `# type: ignore[arg-type]` suppression that violates project rules. This was **not introduced** by this PR and should be tracked as a separate issue. Clean, minimal, well-documented change. Approving for merge.
freemo merged commit f324575a3b into master 2026-04-02 16:51:15 +00:00
freemo deleted branch feature/m3-tdd-tag-cleanup-821-932 2026-04-02 16:51:16 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core!1229
No description provided.