No reviewers
Labels
No labels
auto/needs-reevaluation
controller-managed
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
cleveragents/cleveragents-core!1229
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "feature/m3-tdd-tag-cleanup-821-932"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Removes stale
@tdd_expected_failreferences from TDD test files for fixed bugs #821 (ACMS context tier runtime) and #932 (plan apply --yes flag). Both bugs are closed on Forgejo and the@tdd_expected_failtags were already absent from the tag lines, but the feature description and step-definition docstring for bug #821 still referenced the tag and described the bug as unfixed.Changes
features/tdd_context_tier_runtime.feature(bug #821)@tdd_expected_failtag and "will FAIL until the bug is fixed" language.@tdd_issue @tdd_issue_821 @mock_onlyremain in place per CONTRIBUTING.md.features/steps/tdd_context_tier_runtime_steps.py(bug #821)@tdd_expected_failtag.features/tdd_plan_apply_yes_flag.feature(bug #932)@tdd_expected_failtag was already absent and no stale descriptions existed.@tdd_issue @tdd_issue_932remain in place per CONTRIBUTING.md.Tag Naming Convention Note
The issue acceptance criteria reference
@tdd_bug/@tdd_bug_<N>as permanent tags. Per CONTRIBUTING.md (TDD Issue Test Tags section), the correct permanent tag naming is@tdd_issue/@tdd_issue_<N>. Both files already use the correct convention. No tag rename is needed.Quality Gates
All nox sessions pass:
lintformattypechecksecurity_scandead_codeunit_tests-3.13integration_tests-3.13docsbuild-3.13benchmarkcoverage_reportCloses #1206
Review: APPROVED ✅
PR #1229 — fix(test): remove lingering @tdd_expected_fail tags for closed bugs #821 and #932
What was reviewed
features/tdd_context_tier_runtime.feature— Updated feature description to reflect bug #821 is fixedfeatures/steps/tdd_context_tier_runtime_steps.py— Updated module docstring to reflect fix statusAssessment
@tdd_issue/@tdd_issue_<N>permanent tags retained)Clean, minimal change. No concerns.
🔒 Claimed by pr-reviewer-1. Starting independent code review.
Independent Review: APPROVED ✅
PR #1229 — fix(test): remove lingering @tdd_expected_fail tags for closed bugs #821 and #932
Review Summary
Verified that both bugs #821 (ACMS context tier runtime) and #932 (plan apply --yes flag) are closed on Forgejo. The
@tdd_expected_failtag was already absent from the actual Behave tag lines in both feature files — this PR correctly cleans up stale descriptive text that still referenced the tag and described the bugs as unfixed.Files Reviewed
features/tdd_context_tier_runtime.feature@tdd_expected_failreferencesfeatures/steps/tdd_context_tier_runtime_steps.pyfeatures/tdd_plan_apply_yes_flag.featureVerification Checklist
@tdd_issue/@tdd_issue_<N>tags retained,@tdd_expected_failreferences removed from descriptions@tdd_issue @tdd_issue_821 @mock_onlyand@tdd_issue @tdd_issue_932remain on tag linesISSUES CLOSED: #1206Closes #1206in bodyPre-existing Note (out of scope)
features/steps/tdd_context_tier_runtime_steps.pyline 48 contains a pre-existing# type: ignore[arg-type]suppression that violates project rules. This was NOT introduced by this PR and should be tracked separately.Clean, minimal, well-documented change. Approving for merge.
Review claimed by reviewer pool instance reviewer-pool-1. Dispatching independent code review.
Independent Review: APPROVED ✅
PR #1229 — fix(test): remove lingering @tdd_expected_fail tags for closed bugs #821 and #932
Review Methodology
Performed a full content comparison of all three files referenced in the PR across both
masterand the feature branch using the Forgejo file content API. Verified the linked issue (#1206) acceptance criteria against the actual changes.Files Reviewed
features/tdd_context_tier_runtime.feature091bcc1f3038defb@tdd_expected_failreferences; added "The bug has been fixed" language and regression guard framingfeatures/steps/tdd_context_tier_runtime_steps.py3c2bfb76518532fc@tdd_expected_failreferences; added "The bug has been fixed" regression guard languagefeatures/tdd_plan_apply_yes_flag.feature1ad557151ad55715Verification Checklist
@tdd_issue/@tdd_issue_<N>tags retained on tag lines@tdd_issue @tdd_issue_821 @mock_onlyand@tdd_issue @tdd_issue_932remain on their respective tag lines, untouchedfix(test): remove lingering @tdd_expected_fail tags for closed bugs #821 and #932— valid Conventional Changelog formatISSUES CLOSED: #1206presentType/Tasklabel ✅,Closes #1206in body ✅needs feedbacklabel: Safe to mergePre-existing Note (out of scope)
features/steps/tdd_context_tier_runtime_steps.pyline 48 contains a pre-existing# type: ignore[arg-type]suppression that violates project rules. This was not introduced by this PR and should be tracked as a separate issue.Clean, minimal, well-documented change. Approving for merge.